32347 2009-12-09 14:35:08 -0800 Chromium: Context menu launched by menu key has funky behavior 2009-12-14 14:45:47 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 estade webkit-unassigned commit-queue evan webkit.review.bot oldest_to_newest 170182 0 estade 2009-12-09 14:35:08 -0800 sometimes it fails to show up at all, pressing it multiple times in a row will make it show up in different locations, etc. 170186 1 44565 estade 2009-12-09 14:38:46 -0800 Created attachment 44565 patch 170191 2 webkit.review.bot 2009-12-09 14:43:14 -0800 style-queue ran check-webkit-style on attachment 44565 without any errors. 170431 3 evan 2009-12-10 08:31:17 -0800 I think you should get James Su to take a look. As I understand it we shouldn't need Win/Lin differences in key handling at this layer. 170471 4 estade 2009-12-10 11:19:14 -0800 @3: there is a behavioral difference. Windows on key up, Linux on key down. 171594 5 44565 commit-queue 2009-12-14 14:45:43 -0800 Comment on attachment 44565 patch Clearing flags on attachment: 44565 Committed r52124: <http://trac.webkit.org/changeset/52124> 171595 6 commit-queue 2009-12-14 14:45:47 -0800 All reviewed patches have been landed. Closing bug. 44565 2009-12-09 14:38:46 -0800 2009-12-14 14:45:42 -0800 patch context.diff text/plain 2662 estade SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTE5MjMpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMTItMDkgIEV2YW4g U3RhZGUgIDxlc3RhZGVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMjM0NworICAgICAgICBDaHJvbWl1bTogQ29udGV4dCBtZW51IGxhdW5jaGVkIGJ5IG1l bnUga2V5IGhhcyBmdW5reSBiZWhhdmlvcgorCisgICAgICAgIE1ha2UgdGhlIGNvbnRleHQgbWVu dSdzIHBvc2l0aW9uIGRlcGVuZCBvbiB0aGUgc2VsZWN0aW9uIG9ubHkgd2hlbiBhbgorICAgICAg ICBlZGl0YWJsZSBmaWVsZCBoYXMgZm9jdXMuIEFsc28sIGRvbid0IHNlbmQgbXVsdGlwbGUgY29u dGV4dCBtZW51IGV2ZW50cworICAgICAgICBmb3IgYSBzaW5nbGUga2V5cHJlc3MuCisKKyAgICAg ICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6 a2V5RXZlbnQpOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6c2VuZENvbnRleHRNZW51 RXZlbnQpOgorCiAyMDA5LTEyLTA5ICBEYXJpbiBGaXNoZXIgIDxkYXJpbkBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJLaXQvY2hyb21p dW0vc3JjL1dlYlZpZXdJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlZpZXdJbXBsLmNwcAkocmV2aXNpb24gNTE5MjMpCisrKyBXZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlZpZXdJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDUyLDggKzQ1MiwxNiBAQCBib29s IFdlYlZpZXdJbXBsOjprZXlFdmVudChjb25zdCBXZWJLZXliCiAgICAgICAgIHJldHVybiBrZXlF dmVudERlZmF1bHQoZXZlbnQpOwogCiAjaWYgUExBVEZPUk0oV0lOX09TKSB8fCBQTEFURk9STShM SU5VWCkKLSAgICBpZiAoKCFldmVudC5tb2RpZmllcnMgJiYgKGV2ZW50LndpbmRvd3NLZXlDb2Rl ID09IFZLRVlfQVBQUykpCi0gICAgICAgIHx8ICgoZXZlbnQubW9kaWZpZXJzID09IFdlYklucHV0 RXZlbnQ6OlNoaWZ0S2V5KSAmJiAoZXZlbnQud2luZG93c0tleUNvZGUgPT0gVktFWV9GMTApKSkg eworICAgIGNvbnN0IFdlYklucHV0RXZlbnQ6OlR5cGUgY29udGV4dE1lbnVUcmlnZ2VyaW5nRXZl bnRUeXBlID0KKyNpZiBQTEFURk9STShXSU5fT1MpCisgICAgICAgIFdlYklucHV0RXZlbnQ6Oktl eVVwOworI2VsaWYgUExBVEZPUk0oTElOVVgpCisgICAgICAgIFdlYklucHV0RXZlbnQ6OlJhd0tl eURvd247CisjZW5kaWYKKworICAgIGlmICgoKCFldmVudC5tb2RpZmllcnMgJiYgKGV2ZW50Lndp bmRvd3NLZXlDb2RlID09IFZLRVlfQVBQUykpCisgICAgICAgIHx8ICgoZXZlbnQubW9kaWZpZXJz ID09IFdlYklucHV0RXZlbnQ6OlNoaWZ0S2V5KSAmJiAoZXZlbnQud2luZG93c0tleUNvZGUgPT0g VktFWV9GMTApKSkKKyAgICAgICAgJiYgZXZlbnQudHlwZSA9PSBjb250ZXh0TWVudVRyaWdnZXJp bmdFdmVudFR5cGUpIHsKICAgICAgICAgc2VuZENvbnRleHRNZW51RXZlbnQoZXZlbnQpOwogICAg ICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CkBAIC01OTEsMTUgKzU5OSwxMiBAQCBib29sIFdlYlZp ZXdJbXBsOjpzZW5kQ29udGV4dE1lbnVFdmVudChjCiAjZW5kaWYKICAgICBJbnRQb2ludCBsb2Nh dGlvbjsKIAotICAgIC8vIFRoZSBjb250ZXh0IG1lbnUgZXZlbnQgd2FzIGdlbmVyYXRlZCBmcm9t IHRoZSBrZXlib2FyZCwgc28gc2hvdyB0aGUKLSAgICAvLyBjb250ZXh0IG1lbnUgYnkgdGhlIGN1 cnJlbnQgc2VsZWN0aW9uLgotICAgIFBvc2l0aW9uIHN0YXJ0ID0gbWFpbkZyYW1lSW1wbC0+c2Vs ZWN0aW9uKCktPnNlbGVjdGlvbigpLnN0YXJ0KCk7Ci0gICAgUG9zaXRpb24gZW5kID0gbWFpbkZy YW1lSW1wbC0+c2VsZWN0aW9uKCktPnNlbGVjdGlvbigpLmVuZCgpOwogCiAgICAgRnJhbWUqIGZv Y3VzZWRGcmFtZSA9IHBhZ2UoKS0+Zm9jdXNDb250cm9sbGVyKCktPmZvY3VzZWRPck1haW5GcmFt ZSgpOwogICAgIE5vZGUqIGZvY3VzZWROb2RlID0gZm9jdXNlZEZyYW1lLT5kb2N1bWVudCgpLT5m b2N1c2VkTm9kZSgpOworICAgIFBvc2l0aW9uIHN0YXJ0ID0gbWFpbkZyYW1lSW1wbC0+c2VsZWN0 aW9uKCktPnNlbGVjdGlvbigpLnN0YXJ0KCk7CiAKLSAgICBpZiAoc3RhcnQubm9kZSgpICYmIGVu ZC5ub2RlKCkpIHsKKyAgICBpZiAoZm9jdXNlZEZyYW1lLT5lZGl0b3IoKSAmJiBmb2N1c2VkRnJh bWUtPmVkaXRvcigpLT5jYW5FZGl0KCkgJiYgc3RhcnQubm9kZSgpKSB7CiAgICAgICAgIFJlbmRl ck9iamVjdCogcmVuZGVyZXIgPSBzdGFydC5ub2RlKCktPnJlbmRlcmVyKCk7CiAgICAgICAgIGlm ICghcmVuZGVyZXIpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Cg==