32344 2009-12-09 13:21:56 -0800 exception thrown when running apply-patches 2009-12-09 22:05:20 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue oldest_to_newest 170128 0 eric 2009-12-09 13:21:56 -0800 > bugzilla-tool apply-patches 32313 Cleaning working directory Updating working directory Traceback (most recent call last): File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 104, in <module> BugzillaTool().main() File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/multicommandtool.py", line 253, in main return command.check_arguments_and_execute(args_after_command_name, self) File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/multicommandtool.py", line 99, in check_arguments_and_execute return self.execute(command_options, command_args, tool) or 0 File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/commands/download.py", line 86, in execute WebKitApplyingScripts.setup_for_patch_apply(tool, options) File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/commands/download.py", line 105, in setup_for_patch_apply update_step.run() File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/buildsteps.py", line 115, in run self._tool.executive.run_and_throw_if_fail(self.port().update_webkit_command()) File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/buildsteps.py", line 67, in port self._port = WebKitPort.port(self._options.port) AttributeError: Values instance has no attribute 'port' This is fallout from Adam's recent restructuring. 170131 1 abarth 2009-12-09 13:23:46 -0800 Hum... There may be more examples of this. Patch forthcoming. 170138 2 44558 abarth 2009-12-09 13:29:10 -0800 Created attachment 44558 Patch 170144 3 44558 eric 2009-12-09 13:33:04 -0800 Comment on attachment 44558 Patch OK. Seems port shoudl just be a global option, no? 170172 4 44558 commit-queue 2009-12-09 14:25:43 -0800 Comment on attachment 44558 Patch Clearing flags on attachment: 44558 Committed r51923: <http://trac.webkit.org/changeset/51923> 170173 5 commit-queue 2009-12-09 14:25:48 -0800 All reviewed patches have been landed. Closing bug. 170315 6 abarth 2009-12-09 22:05:20 -0800 > OK. Seems port shoudl just be a global option, no? Yes. We need global options to not suck though. :) 44558 2009-12-09 13:29:10 -0800 2009-12-09 14:25:43 -0800 Patch bug-32344-20091209132907.patch text/plain 2014 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0YThlMzMwLi5jNzM2MWZiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMDktMTIt MDkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBleGNlcHRpb24gdGhyb3duIHdoZW4gcnVubmlu ZyBhcHBseS1wYXRjaGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zMjM0NAorCisgICAgICAgIFRoZSB1cGRhdGUgc3RlcCBub3cgdGFrZXMgYSBwb3J0 IG9wdGlvbi4gIE9uY2Ugd2UgZmluaXNoIHRoZSBTdGVwcworICAgICAgICByZWZhY3RvcmluZywg d2Ugd29uJ3QgaGF2ZSB0byB3b3JyeSBhYm91dCB0aGlzIGtpbmQgb2YgYnVnIGFnYWluLgorCisg ICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL2Rvd25sb2FkLnB5OgorCisyMDA5LTEy LTA5ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKICAgICAgICAgVW5yZXZpZXdl ZC4gIEZpeCBTY3JpcHRFcnJvciBpbmNsdWRlcy4gIEkgZG9uJ3QgdW5kZXJzdGFuZCB3aHkgdGhl c2UKICAgICAgICAgZGlkbid0IHRocm93IGR1cmluZyB1bml0IHRlc3RpbmcuLi4KIApkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL2Rvd25sb2FkLnB5IGIv V2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL2Rvd25sb2FkLnB5CmluZGV4IDAz MTBkNmIuLjU1OWMwY2UgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9j b21tYW5kcy9kb3dubG9hZC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29t bWFuZHMvZG93bmxvYWQucHkKQEAgLTMzLDcgKzMzLDcgQEAgaW1wb3J0IG9zCiBmcm9tIG9wdHBh cnNlIGltcG9ydCBtYWtlX29wdGlvbgogCiBmcm9tIG1vZHVsZXMuYnVnemlsbGEgaW1wb3J0IHBh cnNlX2J1Z19pZAotZnJvbSBtb2R1bGVzLmJ1aWxkc3RlcHMgaW1wb3J0IEJ1aWxkU3RlcHMsIEVu c3VyZUJ1aWxkZXJzQXJlR3JlZW5TdGVwLCBDbGVhbldvcmtpbmdEaXJlY3RvcnlTdGVwLCBVcGRh dGVTdGVwLCBCdWlsZFN0ZXAsIENoZWNrU3R5bGVTdGVwLCBQcmVwYXJlQ2hhbmdlbG9nU3RlcAor ZnJvbSBtb2R1bGVzLmJ1aWxkc3RlcHMgaW1wb3J0IENvbW1hbmRPcHRpb25zLCBCdWlsZFN0ZXBz LCBFbnN1cmVCdWlsZGVyc0FyZUdyZWVuU3RlcCwgQ2xlYW5Xb3JraW5nRGlyZWN0b3J5U3RlcCwg VXBkYXRlU3RlcCwgQnVpbGRTdGVwLCBDaGVja1N0eWxlU3RlcCwgUHJlcGFyZUNoYW5nZWxvZ1N0 ZXAKIGZyb20gbW9kdWxlcy5jaGFuZ2Vsb2dzIGltcG9ydCBDaGFuZ2VMb2cKIGZyb20gbW9kdWxl cy5jb21tZW50cyBpbXBvcnQgYnVnX2NvbW1lbnRfZnJvbV9jb21taXRfdGV4dAogZnJvbSBtb2R1 bGVzLmV4ZWN1dGl2ZSBpbXBvcnQgU2NyaXB0RXJyb3IKQEAgLTk1LDYgKzk1LDcgQEAgY2xhc3Mg V2ViS2l0QXBwbHlpbmdTY3JpcHRzOgogICAgICAgICByZXR1cm4gWwogICAgICAgICAgICAgbWFr ZV9vcHRpb24oIi0tbm8tdXBkYXRlIiwgYWN0aW9uPSJzdG9yZV9mYWxzZSIsIGRlc3Q9InVwZGF0 ZSIsIGRlZmF1bHQ9VHJ1ZSwgaGVscD0iRG9uJ3QgdXBkYXRlIHRoZSB3b3JraW5nIGRpcmVjdG9y eSBiZWZvcmUgYXBwbHlpbmcgcGF0Y2hlcyIpLAogICAgICAgICAgICAgbWFrZV9vcHRpb24oIi0t bG9jYWwtY29tbWl0IiwgYWN0aW9uPSJzdG9yZV90cnVlIiwgZGVzdD0ibG9jYWxfY29tbWl0Iiwg ZGVmYXVsdD1GYWxzZSwgaGVscD0iTWFrZSBhIGxvY2FsIGNvbW1pdCBmb3IgZWFjaCBhcHBsaWVk IHBhdGNoIiksCisgICAgICAgICAgICBDb21tYW5kT3B0aW9ucy5wb3J0LAogICAgICAgICBdCiAK ICAgICBAc3RhdGljbWV0aG9kCg==