<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>32343</bug_id>
          
          <creation_ts>2009-12-09 13:19:22 -0800</creation_ts>
          <short_desc>commit-queue should reject/handle patches missing Reviewed by line</short_desc>
          <delta_ts>2009-12-27 19:02:22 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>26927</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>170127</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-12-09 13:19:22 -0800</bug_when>
    <thetext>commit-queue should reject/handle patches missing Reviewed by line

If contributors delete the &quot;Reviewed by&quot; line then the commit-queue will happily land a patch w/o listing the reviewer in the ChangeLog.  This is bad. :(
http://trac.webkit.org/changeset/51910</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>175130</commentid>
    <comment_count>1</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-12-27 19:02:22 -0800</bug_when>
    <thetext>Bug 32940 is another example of where this would be useful.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>