32338 2009-12-09 12:15:44 -0800 [Chromium] webkit.org Chromium builder by missing GeolocationServiceChromium 2009-12-09 14:36:44 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 joth joth commit-queue steveblock webkit.review.bot oldest_to_newest 170102 0 joth 2009-12-09 12:15:44 -0800 There is currently a build error in the Chromium Mac Release build bot. http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/481/steps/compile-webkit/logs/stdio Undefined symbols: "WebCore::GeolocationService::s_factoryFunction", referenced from: __ZN7WebCore18GeolocationService17s_factoryFunctionE$non_lazy_ptr in libwebcore.a(GeolocationService.o) ld: symbol(s) not found collect2: ld returned 1 exit status PhaseScriptExecution /Users/joth/dev/chromium_git/src/third_party/WebKit/WebKit/chromium/./xcodebuild/WebKit.build/Debug/webkit.build/Script-676D4CE01E3365CE0B035461.sh cd /Users/joth/dev/chromium_git/src/third_party/WebKit/WebKit/chromium /bin/sh -c /Users/joth/dev/chromium_git/src/third_party/WebKit/WebKit/chromium/./xcodebuild/WebKit.build/Debug/webkit.build/Script-676D4CE01E3365CE0B035461.sh ** BUILD FAILED ** The following build 170103 1 44553 joth 2009-12-09 12:17:18 -0800 Created attachment 44553 Patch 1 170105 2 webkit.review.bot 2009-12-09 12:19:09 -0800 style-queue ran check-webkit-style on attachment 44553 without any errors. 170112 3 44556 joth 2009-12-09 12:27:52 -0800 Created attachment 44556 Patch 2. Include ChangeLog this time 170114 4 webkit.review.bot 2009-12-09 12:30:08 -0800 style-queue ran check-webkit-style on attachment 44556 without any errors. 170115 5 44556 dglazkov 2009-12-09 12:31:58 -0800 Comment on attachment 44556 Patch 2. Include ChangeLog this time ok 170118 6 44556 commit-queue 2009-12-09 12:44:46 -0800 Comment on attachment 44556 Patch 2. Include ChangeLog this time Rejecting patch 44556 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: .. M WebCore/ChangeLog M WebCore/WebCore.gypi A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following files contain tab characters: trunk/WebCore/ChangeLog Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. at /usr/local/git/libexec/git-core/git-svn line 558 170183 7 steveblock 2009-12-09 14:36:44 -0800 (In reply to comment #6) > (From update of attachment 44556 [details]) > Rejecting patch 44556 from commit-queue. Fixed tab and landed manually as http://trac.webkit.org/changeset/51925 44553 2009-12-09 12:17:18 -0800 2009-12-09 12:27:52 -0800 Patch 1 bug32338_patch.txt text/plain 572 joth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvV2ViQ29yZS5neXBpIGIvV2ViQ29yZS9XZWJDb3JlLmd5cGkK aW5kZXggMmEwMjBlZC4uMDI1MDcyOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9XZWJDb3JlLmd5cGkK KysrIGIvV2ViQ29yZS9XZWJDb3JlLmd5cGkKQEAgLTE4NjcsNiArMTg2Nyw3IEBACiAgICAgICAg ICAgICAncGxhdGZvcm0vY2hyb21pdW0vRnJhbWVsZXNzU2Nyb2xsVmlldy5jcHAnLAogICAgICAg ICAgICAgJ3BsYXRmb3JtL2Nocm9taXVtL0ZyYW1lbGVzc1Njcm9sbFZpZXcuaCcsCiAgICAgICAg ICAgICAncGxhdGZvcm0vY2hyb21pdW0vRnJhbWVsZXNzU2Nyb2xsVmlld0NsaWVudC5oJywKKyAg ICAgICAgICAgICdwbGF0Zm9ybS9jaHJvbWl1bS9HZW9sb2NhdGlvblNlcnZpY2VDaHJvbWl1bS5j cHAnLAogICAgICAgICAgICAgJ3BsYXRmb3JtL2Nocm9taXVtL0tleUNvZGVDb252ZXJzaW9uLmgn LAogICAgICAgICAgICAgJ3BsYXRmb3JtL2Nocm9taXVtL0tleUNvZGVDb252ZXJzaW9uR3RrLmNw cCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vY2hyb21pdW0vS2V5Ym9hcmRDb2Rlc1Bvc2l4Lmgn LAo= 44556 2009-12-09 12:27:52 -0800 2009-12-09 12:44:46 -0800 Patch 2. Include ChangeLog this time bug32338_patch.txt text/plain 1237 joth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzkyNTc4MC4uZGQ1M2MzMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMi0wOSAgSm9uYXRoYW4gRGl4 b24gIDxqb3RoQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBCdWcgMzIzMzggLSBbQ2hyb21pdW1dIHdlYmtpdC5vcmcgQ2hyb21p dW0gYnVpbGRlciBieSBtaXNzaW5nIEdlb2xvY2F0aW9uU2VydmljZUNocm9taXVtCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjMzOAorCisgICAgICAg IEZpeCBidWlsZCBicmVhazogcmUtaW5jbHVkZSBmaWxlIGRyb3BwZWQgb3V0IGJ5IG1lcmdlIGlu IGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzUxNjgxL3RydW5rL1dlYkNvcmUvV2Vi Q29yZS5neXBpCisKKyAgICAgICAgKiBXZWJDb3JlLmd5cGk6CisJQWRkIG1pc3NpbmcgR2VvbG9j YXRpb25TZXJ2aWNlQ2hyb21pdW0uY3BwCisKKwogMjAwOS0xMi0wOSAgT2xpdmVyIEh1bnQgIDxv bGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeApkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9XZWJDb3JlLmd5cGkgYi9XZWJDb3JlL1dlYkNvcmUuZ3lwaQppbmRleCAyYTAyMGVkLi4wMjUw NzI4IDEwMDY0NAotLS0gYS9XZWJDb3JlL1dlYkNvcmUuZ3lwaQorKysgYi9XZWJDb3JlL1dlYkNv cmUuZ3lwaQpAQCAtMTg2Nyw2ICsxODY3LDcgQEAKICAgICAgICAgICAgICdwbGF0Zm9ybS9jaHJv bWl1bS9GcmFtZWxlc3NTY3JvbGxWaWV3LmNwcCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vY2hy b21pdW0vRnJhbWVsZXNzU2Nyb2xsVmlldy5oJywKICAgICAgICAgICAgICdwbGF0Zm9ybS9jaHJv bWl1bS9GcmFtZWxlc3NTY3JvbGxWaWV3Q2xpZW50LmgnLAorICAgICAgICAgICAgJ3BsYXRmb3Jt L2Nocm9taXVtL0dlb2xvY2F0aW9uU2VydmljZUNocm9taXVtLmNwcCcsCiAgICAgICAgICAgICAn cGxhdGZvcm0vY2hyb21pdW0vS2V5Q29kZUNvbnZlcnNpb24uaCcsCiAgICAgICAgICAgICAncGxh dGZvcm0vY2hyb21pdW0vS2V5Q29kZUNvbnZlcnNpb25HdGsuY3BwJywKICAgICAgICAgICAgICdw bGF0Zm9ybS9jaHJvbWl1bS9LZXlib2FyZENvZGVzUG9zaXguaCcsCg==