32333 2009-12-09 11:29:59 -0800 Layout test for video element on HTTP 2010-01-04 13:20:38 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hclam hclam eric.carlson eric oldest_to_newest 170071 0 hclam 2009-12-09 11:29:59 -0800 Add a new layout test that can test the user agent's ability to handle caching of video resources. To start with a simple case, this test will do the following: 1. Load the resource, until we receive canplaythrough event 2. Remove the element 3. Load the resource the second time, until we receive canplaythrough event If the user agent performs caching of video resource, the first load will have the resource goes into cache and the second load will work fine too. If the user agent doesn't do any caching, both load will always work fine. 170185 1 44564 hclam 2009-12-09 14:38:12 -0800 Created attachment 44564 new test + expectation 170270 2 44564 eric.carlson 2009-12-09 17:49:46 -0800 Comment on attachment 44564 new test + expectation As we discussed in irc, the patch looks good but it would be helpful to have more information in the ChangeLog about why it is necessary to copy the test movies instead of using the originals like the other http media tests do. r=me with some extra comments 170271 3 hclam 2009-12-09 17:58:11 -0800 Thanks for the review, will fix the change log before I commit. 175415 4 eric 2009-12-28 22:40:44 -0800 Attachment 44564 was posted by a committer and has review+, assigning to Hin-Chung Lam for commit. 175441 5 eric 2009-12-28 23:27:57 -0800 Looks like this has been r+'d for a little over two weeks. I assume things are just a bit slow due to the holiday season. Or maybe this was already landed? 176835 6 hclam 2010-01-04 13:20:38 -0800 (In reply to comment #5) > Looks like this has been r+'d for a little over two weeks. I assume things are > just a bit slow due to the holiday season. Or maybe this was already landed? Sorry for late response. This has been submitted as http://trac.webkit.org/changeset/51966. I'm closing it, thanks for reminding me. 44564 2009-12-09 14:38:12 -0800 2009-12-09 17:49:46 -0800 new test + expectation webkit-http-test.patch text/plain 3141 hclam ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyMzNiMGEzLi4zMmUyMjAzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDktMTIt MDkgIEFscGhhIExhbSAgPGhjbGFtQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMYXlvdXQgdGVzdCBmb3IgdmlkZW8gZWxlbWVu dCBvbiBIVFRQCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zMjMzMworCisgICAgICAgIEFkZGVkIGEgbmV3IGxheW91dCB0ZXN0IHRoYXQgdGVzdHMgdmlk ZW8gZWxlbWVudCBvbiBIVFRQIHByb3RvY29sLgorICAgICAgICBUaGlzIHRlc3QgbG9hZCB0aGUg c2FtZSB2aWRlbyBmaWxlIHR3aWNlLiBUaGUgZmlyc3QgbG9hZCB3aWxsIGNhY2hlCisgICAgICAg IHRoZSB2aWRlbyBmaWxlIGlmIGNhY2hpbmcgaXMgc3VwcG9ydGVkLiBUaGUgc2Vjb25kIGxvYWQg ZW5zdXJlCisgICAgICAgIHRoZSBjYWNoZSB3b3JrcyBjb3JyZWN0bHkuCisKKyAgICAgICAgKiBo dHRwL3Rlc3RzL21lZGlhL3Jlc291cmNlcy90ZXN0Lm1wNDogQ29waWVkIGZyb20gTGF5b3V0VGVz dHMvbWVkaWEvY29udGVudC90ZXN0Lm1wNC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL21lZGlhL3Jl c291cmNlcy90ZXN0Lm9ndjogQ29waWVkIGZyb20gTGF5b3V0VGVzdHMvbWVkaWEvY29udGVudC90 ZXN0Lm9ndi4KKyAgICAgICAgKiBodHRwL3Rlc3RzL21lZGlhL3ZpZGVvLWxvYWQtdHdpY2UtZXhw ZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL21lZGlhL3ZpZGVvLWxvYWQt dHdpY2UuaHRtbDogQWRkZWQuCisKIDIwMDktMTItMDggIEFkYW0gTGFuZ2xleSAgPGFnbEBnb29n bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9tZWRpYS9yZXNvdXJjZXMvdGVzdC5tcDQgYi9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL21lZGlhL3Jlc291cmNlcy90ZXN0Lm1wNApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwLi5kMjc4YzhhCkJpbmFyeSBmaWxlcyAvZGV2L251bGwgYW5kIGIv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9tZWRpYS9yZXNvdXJjZXMvdGVzdC5tcDQgZGlmZmVyCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3Jlc291cmNlcy90ZXN0Lm9n diBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVkaWEvcmVzb3VyY2VzL3Rlc3Qub2d2Cm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmM5ZWU5MTAKQmluYXJ5IGZpbGVzIC9kZXYv bnVsbCBhbmQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3Jlc291cmNlcy90ZXN0Lm9n diBkaWZmZXIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVkaWEvdmlkZW8t bG9hZC10d2ljZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3Zp ZGVvLWxvYWQtdHdpY2UtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAuLjlkMDhlZmIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L21lZGlhL3ZpZGVvLWxvYWQtdHdpY2UtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTIgQEAKK1JV Tih2aWRlby5zcmMgPSBmaWxlKQorRVZFTlQobG9hZGVkbWV0YWRhdGEpCitFVkVOVChsb2FkZWRk YXRhKQorRVZFTlQoY2FucGxheSkKK0VWRU5UKGNhbnBsYXl0aHJvdWdoKQorUlVOKHZpZGVvLnNy YyA9IGZpbGUpCitFVkVOVChsb2FkZWRtZXRhZGF0YSkKK0VWRU5UKGxvYWRlZGRhdGEpCitFVkVO VChjYW5wbGF5KQorRVZFTlQoY2FucGxheXRocm91Z2gpCitFTkQgT0YgVEVTVAorCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3ZpZGVvLWxvYWQtdHdpY2UuaHRtbCBi L0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVkaWEvdmlkZW8tbG9hZC10d2ljZS5odG1sCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjhhMDU0MmYKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3ZpZGVvLWxvYWQtdHdpY2UuaHRtbApAQCAt MCwwICsxLDMzIEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Li4vLi4vLi4vbWVkaWEv bWVkaWEtZmlsZS5qcz48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPS4uLy4uLy4uL21lZGlhL3ZpZGVv LXRlc3QuanM+PC9zY3JpcHQ+Cis8c2NyaXB0PgorICAgIHZhciBmaWxlID0gZmluZE1lZGlhRmls ZSgidmlkZW8iLCAiaHR0cDovLzEyNy4wLjAuMTo4MDAwL21lZGlhL3Jlc291cmNlcy90ZXN0Iik7 CisKKyAgICBmdW5jdGlvbiBjcmVhdGVWaWRlbygpIHsKKyAgICAgICAgdmFyIHZpZGVvID0gZG9j dW1lbnQuY3JlYXRlRWxlbWVudCgidmlkZW8iKTsKKyAgICAgICAgZG9jdW1lbnQuYm9keS5hcHBl bmRDaGlsZCh2aWRlbyk7CisgICAgICAgIGZpbmRNZWRpYUVsZW1lbnQoKTsKKyAgICAgICAgd2Fp dEZvckV2ZW50KCdsb2FkZWRtZXRhZGF0YScpOworICAgICAgICB3YWl0Rm9yRXZlbnQoJ2xvYWRl ZGRhdGEnKTsKKyAgICAgICAgd2FpdEZvckV2ZW50KCdjYW5wbGF5Jyk7CisgICAgfQorCisgICAg ZnVuY3Rpb24gZmlyc3RDYW5QbGF5VGhyb3VnaCgpIHsKKyAgICAgICAgZG9jdW1lbnQuYm9keS5y ZW1vdmVDaGlsZCh2aWRlbyk7CisgICAgICAgIGNyZWF0ZVZpZGVvKCk7CisgICAgICAgIHdhaXRG b3JFdmVudCgnY2FucGxheXRocm91Z2gnLCBlbmRUZXN0KTsKKyAgICAgICAgcnVuKCJ2aWRlby5z cmMgPSBmaWxlIik7CisgICAgfQorCisgICAgZnVuY3Rpb24gaW5pdCgpIHsKKyAgICAgICAgY3Jl YXRlVmlkZW8oKTsKKyAgICAgICAgd2FpdEZvckV2ZW50KCdjYW5wbGF5dGhyb3VnaCcsIGZpcnN0 Q2FuUGxheVRocm91Z2gpOworICAgICAgICBydW4oInZpZGVvLnNyYyA9IGZpbGUiKTsKKyAgICB9 Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0iaW5pdCgpIj4KKzwvYm9keT4KKzwv aHRtbD4K