32330 2009-12-09 10:45:58 -0800 V8 ScriptState is missing include for DEFINE_STATIC_LOCAL 2009-12-09 15:32:48 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 steveblock steveblock commit-queue webkit.review.bot oldest_to_newest 170047 0 steveblock 2009-12-09 10:45:58 -0800 V8 ScriptState is missing include for DEFINE_STATIC_LOCAL. This is defined in wtf/StdLibExtras.h. This causes a build break on Android. It seems that Chromium picks up the include via other feature-dependent header includes. 170051 1 44546 steveblock 2009-12-09 10:52:53 -0800 Created attachment 44546 Patch 1 for Bug 32330 170054 2 webkit.review.bot 2009-12-09 10:56:17 -0800 style-queue ran check-webkit-style on attachment 44546 without any errors. 170133 3 44546 eric 2009-12-09 13:25:05 -0800 Comment on attachment 44546 Patch 1 for Bug 32330 LGTM too. 170224 4 44546 commit-queue 2009-12-09 15:32:43 -0800 Comment on attachment 44546 Patch 1 for Bug 32330 Clearing flags on attachment: 44546 Committed r51930: <http://trac.webkit.org/changeset/51930> 170225 5 commit-queue 2009-12-09 15:32:48 -0800 All reviewed patches have been landed. Closing bug. 44546 2009-12-09 10:52:53 -0800 2009-12-09 15:32:43 -0800 Patch 1 for Bug 32330 defineStaticLocal.txt text/plain 985 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTkwNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMTItMDkgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZHMgd3RmL1N0ZExpYkV4dHJhcy5oIGluY2x1ZGUgZm9yIERFRklORV9TVEFUSUNfTE9DQUwg aW4gVjggU2NyaXB0U3RhdGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zMjMzMAorCisgICAgICAgIEJ1aWxkIGZpeCBvbmx5LCBubyBuZXcgdGVzdHMu CisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TY3JpcHRTdGF0ZS5jcHA6IE1vZGlmaWVkLiBBZGRz IHd0Zi9TdGRMaWJFeHRyYXMuaCBpbmNsdWRlLgorCiAyMDA5LTEyLTA5ICBDaHJpcyBNYXJyaW4g IDxjbWFycmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJ bmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRTdGF0ZS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRTdGF0ZS5jcHAJKHJldmlzaW9uIDUxOTA0KQorKysg V2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRTdGF0ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3 LDYgKzM3LDcgQEAKICNpbmNsdWRlICJTY3JpcHRDb250cm9sbGVyLmgiCiAKICNpbmNsdWRlIDx3 dGYvQXNzZXJ0aW9ucy5oPgorI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KIAogbmFtZXNw YWNlIFdlYkNvcmUgewogCg==