32328 2009-12-09 10:38:56 -0800 Some script binding methods lack INSPECTOR guards 2009-12-09 14:54:29 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 steveblock steveblock commit-queue webkit.review.bot oldest_to_newest 170044 0 steveblock 2009-12-09 10:38:56 -0800 ScriptValue::quarantineValue and some overloads of ScriptGlobalObject::set use types which are only defined when INSPECTOR is enabled. These methods should be guarded with ENABLE(INSPECTOR). 170049 1 44545 steveblock 2009-12-09 10:48:21 -0800 Created attachment 44545 Patch 1 for Bug 32328 170050 2 webkit.review.bot 2009-12-09 10:50:50 -0800 style-queue ran check-webkit-style on attachment 44545 without any errors. 170200 3 44545 commit-queue 2009-12-09 14:54:24 -0800 Comment on attachment 44545 Patch 1 for Bug 32328 Clearing flags on attachment: 44545 Committed r51927: <http://trac.webkit.org/changeset/51927> 170201 4 commit-queue 2009-12-09 14:54:29 -0800 All reviewed patches have been landed. Closing bug. 44545 2009-12-09 10:48:21 -0800 2009-12-09 14:54:24 -0800 Patch 1 for Bug 32328 addInspectorGuards.txt text/plain 2271 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTkwNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTItMDkgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZHMgRU5BQkxFKElOU1BFQ1RPUikgZ3VhcmRzIGFyb3VuZCBzY3JpcHQgYmluZGluZyBtZXRo b2RzIHRoYXQgdXNlIHR5cGVzCisgICAgICAgIGRlZmluZWQgb25seSB3aGVuIElOU1BFQ1RPUiBp cyBlbmFibGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzIzMjgKKworICAgICAgICBCdWlsZCBmaXggb25seSwgbm8gbmV3IHRlc3RzLgorCisgICAg ICAgICogYmluZGluZ3MvanMvU2NyaXB0VmFsdWUuY3BwOiBNb2RpZmllZC4gQWRkZWQgRU5BQkxF KElOU1BFQ1RPUikgZ3VhcmQgdG8gU2NyaXB0VmFsdWU6OnF1YXJhbnRpbmVWYWx1ZS4KKyAgICAg ICAgKiBiaW5kaW5ncy92OC9TY3JpcHRPYmplY3QuY3BwOiBNb2RpZmllZC4gQWRkZWQgRU5BQkxF KElOU1BFQ1RPUikgZ3VhcmQgdG8gc29tZSBvdmVybG9hZHMgb2YgU2NyaXB0R2xvYmFsT2JqZWN0 OjpzZXQuCisKIDIwMDktMTItMDkgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvYmluZGlu Z3MvanMvU2NyaXB0VmFsdWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvanMv U2NyaXB0VmFsdWUuY3BwCShyZXZpc2lvbiA1MTkwNCkKKysrIFdlYkNvcmUvYmluZGluZ3MvanMv U2NyaXB0VmFsdWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MiwxMSArNDIsMTMgQEAgdXNpbmcg bmFtZXNwYWNlIEpTQzsKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCisjaWYgRU5BQkxFKElOU1BF Q1RPUikKIFNjcmlwdFZhbHVlIFNjcmlwdFZhbHVlOjpxdWFyYW50aW5lVmFsdWUoU2NyaXB0U3Rh dGUqIHNjcmlwdFN0YXRlLCBjb25zdCBTY3JpcHRWYWx1ZSYgdmFsdWUpCiB7CiAgICAgSlNMb2Nr IGxvY2soU2lsZW5jZUFzc2VydGlvbnNPbmx5KTsKICAgICByZXR1cm4gU2NyaXB0VmFsdWUoSlNJ bnNwZWN0ZWRPYmplY3RXcmFwcGVyOjp3cmFwKHNjcmlwdFN0YXRlLCB2YWx1ZS5qc1ZhbHVlKCkp KTsKIH0KKyNlbmRpZgogCiBib29sIFNjcmlwdFZhbHVlOjpnZXRTdHJpbmcoU2NyaXB0U3RhdGUq IHNjcmlwdFN0YXRlLCBTdHJpbmcmIHJlc3VsdCkgY29uc3QKIHsKSW5kZXg6IFdlYkNvcmUvYmlu ZGluZ3MvdjgvU2NyaXB0T2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdz L3Y4L1NjcmlwdE9iamVjdC5jcHAJKHJldmlzaW9uIDUxOTA0KQorKysgV2ViQ29yZS9iaW5kaW5n cy92OC9TY3JpcHRPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDAsNiArMTQwLDcgQEAg Ym9vbCBTY3JpcHRHbG9iYWxPYmplY3Q6OnNldChTY3JpcHRTdGF0ZQogICAgIHJldHVybiBzY29w ZS5zdWNjZXNzKCk7CiB9CiAKKyNpZiBFTkFCTEUoSU5TUEVDVE9SKQogYm9vbCBTY3JpcHRHbG9i YWxPYmplY3Q6OnNldChTY3JpcHRTdGF0ZSogc2NyaXB0U3RhdGUsIGNvbnN0IGNoYXIqIG5hbWUs IEluc3BlY3RvckJhY2tlbmQqIHZhbHVlKQogewogICAgIFNjcmlwdFNjb3BlIHNjb3BlKHNjcmlw dFN0YXRlKTsKQEAgLTE2MCw2ICsxNjEsNyBAQCBib29sIFNjcmlwdEdsb2JhbE9iamVjdDo6c2V0 KFNjcmlwdFN0YXRlCiAgICAgc2NvcGUuZ2xvYmFsKCktPlNldCh2ODo6U3RyaW5nOjpOZXcobmFt ZSksIFY4RE9NV3JhcHBlcjo6Y29udmVydFRvVjhPYmplY3QoVjhDbGFzc0luZGV4OjpJTkpFQ1RF RFNDUklQVEhPU1QsIHZhbHVlKSk7CiAgICAgcmV0dXJuIHNjb3BlLnN1Y2Nlc3MoKTsKIH0KKyNl bmRpZgogCiBib29sIFNjcmlwdEdsb2JhbE9iamVjdDo6Z2V0KFNjcmlwdFN0YXRlKiBzY3JpcHRT dGF0ZSwgY29uc3QgY2hhciogbmFtZSwgU2NyaXB0T2JqZWN0JiB2YWx1ZSkKIHsK