32321 2009-12-09 07:05:28 -0800 ENABLE_ORIENTATION_EVENTS does not compile 2009-12-09 13:17:48 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 phanna webkit-unassigned android-webkit-unforking commit-queue eric oldest_to_newest 169991 0 44535 phanna 2009-12-09 07:05:28 -0800 Created attachment 44535 Patch to fix build. Frame.cpp does not compile due to a change in dispatchWindowEvent. Attached is a patch to fix the build. 169995 1 44535 fishd 2009-12-09 07:46:22 -0800 Comment on attachment 44535 Patch to fix build. > Index: WebCore/ChangeLog ... > + Fix the build with ENABLE_ORIENTATION_EVENTS > + > + * page/Frame.cpp: > + (WebCore::Frame::sendOrientationChangeEvent): the change is good, but please revise the patch to include a bug link in the ChangeLog. 169997 2 44537 phanna 2009-12-09 07:51:17 -0800 Created attachment 44537 Update changelog with bug url. 170007 3 44537 commit-queue 2009-12-09 08:35:53 -0800 Comment on attachment 44537 Update changelog with bug url. Rejecting patch 44537 from commit-queue. Unexpected failure when landing patch! Please file a bug against bugzilla-tool. Failed to run "['WebKitTools/Scripts/bugzilla-tool', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '44537']" exit_code: 1 Last 500 characters of output: nd_handle_errors self.run() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 54, in run self.clean() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 81, in clean step.run() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/buildsteps.py", line 101, in run os.chdir(self._tool._scm.checkout_root) AttributeError: 'NoneType' object has no attribute 'checkout_root' 170008 4 phanna 2009-12-09 08:38:13 -0800 Oops, cq failed. Can someone landed this patch manually? 170077 5 44537 eric 2009-12-09 11:36:41 -0800 Comment on attachment 44537 Update changelog with bug url. Sorry for the noise. Adam believes to have fixed the issue. I've restarted the commit bot. 170089 6 44537 commit-queue 2009-12-09 11:59:59 -0800 Comment on attachment 44537 Update changelog with bug url. Clearing flags on attachment: 44537 Committed r51910: <http://trac.webkit.org/changeset/51910> 170090 7 commit-queue 2009-12-09 12:00:04 -0800 All reviewed patches have been landed. Closing bug. 170125 8 eric 2009-12-09 13:17:48 -0800 Please be sure to leave the "Reviewed by NOBODY (OOPS!)." line in your ChangeLogs so that the scripts can correctly mark a reviewer when landing. 44535 2009-12-09 07:05:28 -0800 2009-12-09 07:51:17 -0800 Patch to fix build. orientation.patch text/plain 1023 phanna PyAgICAgIG9yaWVudGF0aW9uLnBhdGNoCkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNTE4OTgpCisrKyBXZWJDb3JlL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEwIEBACisyMDA5LTEyLTA5ICBQYXRy aWNrIFNjb3R0ICA8cGhhbm5hQGVtYWlsLnVuYy5lZHU+CisKKyAgICAgICAgRml4IHRoZSBidWls ZCB3aXRoIEVOQUJMRV9PUklFTlRBVElPTl9FVkVOVFMKKworICAgICAgICAqIHBhZ2UvRnJhbWUu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWU6OnNlbmRPcmllbnRhdGlvbkNoYW5nZUV2ZW50 KToKKwogMjAwOS0xMi0wOSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIEJ1aWxkIGZpeApJbmRleDogV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCShyZXZpc2lvbiA1MTg5OCkKKysrIFdlYkNvcmUvcGFn ZS9GcmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI5Niw3ICsyOTYsNyBAQCB2b2lkIEZyYW1l OjpzZW5kT3JpZW50YXRpb25DaGFuZ2VFdmVudChpCiB7CiAgICAgbV9vcmllbnRhdGlvbiA9IG9y aWVudGF0aW9uOwogICAgIGlmIChEb2N1bWVudCogZG9jID0gZG9jdW1lbnQoKSkKLSAgICAgICAg ZG9jLT5kaXNwYXRjaFdpbmRvd0V2ZW50KGV2ZW50TmFtZXMoKS5vcmllbnRhdGlvbmNoYW5nZUV2 ZW50LCBmYWxzZSwgZmFsc2UpOworICAgICAgICBkb2MtPmRpc3BhdGNoV2luZG93RXZlbnQoRXZl bnQ6OmNyZWF0ZShldmVudE5hbWVzKCkub3JpZW50YXRpb25jaGFuZ2VFdmVudCwgZmFsc2UsIGZh bHNlKSk7CiB9CiAjZW5kaWYgLy8gRU5BQkxFKE9SSUVOVEFUSU9OX0VWRU5UUykKICAgICAK 44537 2009-12-09 07:51:17 -0800 2009-12-09 11:59:59 -0800 Update changelog with bug url. orientation.patch text/plain 1078 phanna PyAgICAgIG9yaWVudGF0aW9uLnBhdGNoCkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNTE4OTgpCisrKyBXZWJDb3JlL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDExIEBACisyMDA5LTEyLTA5ICBQYXRy aWNrIFNjb3R0ICA8cGhhbm5hQGVtYWlsLnVuYy5lZHU+CisKKyAgICAgICAgRml4IHRoZSBidWls ZCB3aXRoIEVOQUJMRV9PUklFTlRBVElPTl9FVkVOVFMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMzIxCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lOjpzZW5kT3JpZW50YXRpb25DaGFuZ2VFdmVudCk6 CisKIDIwMDktMTItMDkgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAg ICBCdWlsZCBmaXgKSW5kZXg6IFdlYkNvcmUvcGFnZS9GcmFtZS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAkocmV2aXNpb24gNTE4OTgpCisrKyBXZWJDb3JlL3BhZ2Uv RnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOTYsNyArMjk2LDcgQEAgdm9pZCBGcmFtZTo6 c2VuZE9yaWVudGF0aW9uQ2hhbmdlRXZlbnQoaQogewogICAgIG1fb3JpZW50YXRpb24gPSBvcmll bnRhdGlvbjsKICAgICBpZiAoRG9jdW1lbnQqIGRvYyA9IGRvY3VtZW50KCkpCi0gICAgICAgIGRv Yy0+ZGlzcGF0Y2hXaW5kb3dFdmVudChldmVudE5hbWVzKCkub3JpZW50YXRpb25jaGFuZ2VFdmVu dCwgZmFsc2UsIGZhbHNlKTsKKyAgICAgICAgZG9jLT5kaXNwYXRjaFdpbmRvd0V2ZW50KEV2ZW50 OjpjcmVhdGUoZXZlbnROYW1lcygpLm9yaWVudGF0aW9uY2hhbmdlRXZlbnQsIGZhbHNlLCBmYWxz ZSkpOwogfQogI2VuZGlmIC8vIEVOQUJMRShPUklFTlRBVElPTl9FVkVOVFMpCiAgICAgCg==