32320 2009-12-09 07:00:34 -0800 [Chromium] Remove obsolete message handling methods from WebDevTools* interfaces 2009-12-11 07:09:54 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys pfeldman webkit.review.bot oldest_to_newest 169990 0 yurys 2009-12-09 07:00:34 -0800 Remove message sending/dispatching methods from WebDevTools* interfaces that don't use WebDevToolMessageData for passing parameters. 170742 1 44686 yurys 2009-12-11 06:49:27 -0800 Created attachment 44686 patch 170745 2 webkit.review.bot 2009-12-11 06:54:12 -0800 style-queue ran check-webkit-style on attachment 44686 without any errors. 170747 3 yurys 2009-12-11 07:09:54 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/chromium/ChangeLog M WebKit/chromium/public/WebDevToolsAgent.h M WebKit/chromium/public/WebDevToolsAgentClient.h M WebKit/chromium/public/WebDevToolsFrontend.h M WebKit/chromium/public/WebDevToolsFrontendClient.h Committed r51984 44686 2009-12-11 06:49:27 -0800 2009-12-11 06:55:25 -0800 patch remove-obsolete.patch text/plain 5582 yurys ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGQ1NTU0OGIuLjQzN2RiYzcgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDA5LTEyLTExICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92 ZSBvYnNvbGV0ZSBtZXNzYWdlIGhhbmRsaW5nIG1ldGhvZHMgZnJvbSBXZWJEZXZUb29scyogaW50 ZXJmYWNlcworCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zMjMyMAorCisgICAgICAgICogcHVibGljL1dlYkRldlRvb2xzQWdlbnQuaDoKKyAgICAgICAg KiBwdWJsaWMvV2ViRGV2VG9vbHNBZ2VudENsaWVudC5oOgorICAgICAgICAqIHB1YmxpYy9XZWJE ZXZUb29sc0Zyb250ZW5kLmg6CisgICAgICAgICogcHVibGljL1dlYkRldlRvb2xzRnJvbnRlbmRD bGllbnQuaDoKKwogMjAwOS0xMi0xMCAgTWlrZSBCZWxzaGUgIDxtaWtlQGJlbHNoZS5jb20+CiAK ICAgICAgICAgVW5yZXZpZXdlZCwgYnVpbGQgZml4IGZvciBjaHJvbWl1bS4KZGlmZiAtLWdpdCBh L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRGV2VG9vbHNBZ2VudC5oIGIvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJEZXZUb29sc0FnZW50LmgKaW5kZXggOWMyNzYyOC4uZTNiNTE4NiAxMDA2 NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEZXZUb29sc0FnZW50LmgKKysrIGIv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEZXZUb29sc0FnZW50LmgKQEAgLTU1LDEyICs1NSw2 IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCBkaWROYXZpZ2F0ZSgpID0gMDsKIAotICAg IC8vIFRPRE8oMzIzMjApOiByZW1vdmUgdGhpcyBtZXRob2QgZnJvbSBBUEkuCi0gICAgdmlydHVh bCB2b2lkIGRpc3BhdGNoTWVzc2FnZUZyb21Gcm9udGVuZChjb25zdCBXZWJTdHJpbmcmIGNsYXNz TmFtZSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0 IFdlYlN0cmluZyYgbWV0aG9kTmFtZSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGNvbnN0IFdlYlN0cmluZyYgcGFyYW0xLAotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgV2ViU3RyaW5nJiBwYXJhbTIsCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBXZWJTdHJpbmcm IHBhcmFtMykgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBkaXNwYXRjaE1lc3NhZ2VGcm9tRnJvbnRl bmQoY29uc3QgV2ViRGV2VG9vbHNNZXNzYWdlRGF0YSYpID0gMDsKIAogICAgIHZpcnR1YWwgdm9p ZCBpbnNwZWN0RWxlbWVudEF0KGNvbnN0IFdlYlBvaW50JikgPSAwOwpAQCAtNzksMTIgKzczLDYg QEAgcHVibGljOgogICAgIC8vIEFzeW5jaHJvbm91c2x5IHJlcXVlc3QgZGVidWdnZXIgdG8gcGF1 c2UgaW1tZWRpYXRlbHkuCiAgICAgV0VCS0lUX0FQSSBzdGF0aWMgdm9pZCBkZWJ1Z2dlclBhdXNl U2NyaXB0KCk7CiAKLSAgICAvLyBUT0RPKDMyMzIwKTogcmVtb3ZlIHRoaXMgbWV0aG9kIGZyb20g QVBJLgotICAgIFdFQktJVF9BUEkgc3RhdGljIGJvb2wgZGlzcGF0Y2hNZXNzYWdlRnJvbUZyb250 ZW5kT25JT1RocmVhZChjb25zdCBXZWJTdHJpbmcmIGNsYXNzTmFtZSwKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qg V2ViU3RyaW5nJiBtZXRob2ROYW1lLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBXZWJTdHJpbmcmIHBhcmFtMSwK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgY29uc3QgV2ViU3RyaW5nJiBwYXJhbTIsCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IFdlYlN0cmlu ZyYgcGFyYW0zKTsKICAgICBXRUJLSVRfQVBJIHN0YXRpYyBib29sIGRpc3BhdGNoTWVzc2FnZUZy b21Gcm9udGVuZE9uSU9UaHJlYWQoY29uc3QgV2ViRGV2VG9vbHNNZXNzYWdlRGF0YSYpOwogCiAg ICAgdHlwZWRlZiB2b2lkICgqTWVzc2FnZUxvb3BEaXNwYXRjaEhhbmRsZXIpKCk7CmRpZmYgLS1n aXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRldlRvb2xzQWdlbnRDbGllbnQuaCBiL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRGV2VG9vbHNBZ2VudENsaWVudC5oCmluZGV4IGVjNTE2 NTQuLjdjMThkYzQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRGV2VG9v bHNBZ2VudENsaWVudC5oCisrKyBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRGV2VG9vbHNB Z2VudENsaWVudC5oCkBAIC0zOSwxMiArMzksNiBAQCBzdHJ1Y3QgV2ViRGV2VG9vbHNNZXNzYWdl RGF0YTsKIAogY2xhc3MgV2ViRGV2VG9vbHNBZ2VudENsaWVudCB7CiBwdWJsaWM6Ci0gICAgLy8g VE9ETygzMjMyMCk6IHJlbW92ZSB0aGlzIG1ldGhvZCBmcm9tIEFQSS4KLSAgICB2aXJ0dWFsIHZv aWQgc2VuZE1lc3NhZ2VUb0Zyb250ZW5kKGNvbnN0IFdlYlN0cmluZyYgY2xhc3NOYW1lLAotICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgV2ViU3RyaW5nJiBtZXRo b2ROYW1lLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgV2Vi U3RyaW5nJiBwYXJhbTEsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBj b25zdCBXZWJTdHJpbmcmIHBhcmFtMiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGNvbnN0IFdlYlN0cmluZyYgcGFyYW0zKSB7fQogICAgIHZpcnR1YWwgdm9pZCBzZW5k TWVzc2FnZVRvRnJvbnRlbmQoY29uc3QgV2ViRGV2VG9vbHNNZXNzYWdlRGF0YSYpIHsgfQogCiAg ICAgLy8gSW52YWxpZGF0ZXMgd2lkZ2V0IHdoaWNoIGxlYWRzIHRvIHRoZSByZXBhaW50LgpAQCAt NTYsMTIgKzUwLDYgQEAgcHVibGljOgogICAgIC8vIE5vdGlmaWVzIGhvc3QgdXBvbiBydW50aW1l IGZlYXR1cmUgYmVpbmcgZW5hYmxlZC9kaXNhYmxlZC4KICAgICB2aXJ0dWFsIHZvaWQgcnVudGlt ZUZlYXR1cmVTdGF0ZUNoYW5nZWQoY29uc3QgV2ViU3RyaW5nJiBmZWF0dXJlLCBib29sIGVuYWJs ZWQpIHsgfQogCi0gICAgLy8gVE9ETygzMjMyMCk6IHJlbW92ZSB0aGlzIG1ldGhvZCBmcm9tIEFQ SS4KLSAgICBXRUJLSVRfQVBJIHN0YXRpYyB2b2lkIHNlbmRNZXNzYWdlVG9Gcm9udGVuZE9uSU9U aHJlYWQoY29uc3QgV2ViU3RyaW5nJiBjbGFzc05hbWUsCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IFdlYlN0cmluZyYgbWV0 aG9kTmFtZSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgY29uc3QgV2ViU3RyaW5nJiBwYXJhbTEsCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IFdlYlN0cmluZyYg cGFyYW0yLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBjb25zdCBXZWJTdHJpbmcmIHBhcmFtMyk7CiAgICAgV0VCS0lUX0FQSSBzdGF0 aWMgdm9pZCBzZW5kTWVzc2FnZVRvRnJvbnRlbmRPbklPVGhyZWFkKGNvbnN0IFdlYkRldlRvb2xz TWVzc2FnZURhdGEmKTsKIAogcHJvdGVjdGVkOgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJEZXZUb29sc0Zyb250ZW5kLmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YkRldlRvb2xzRnJvbnRlbmQuaAppbmRleCBiN2Q3MTg5Li5kOTVmMzVhIDEwMDY0NAotLS0gYS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRldlRvb2xzRnJvbnRlbmQuaAorKysgYi9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkRldlRvb2xzRnJvbnRlbmQuaApAQCAtNTAsMTEgKzUwLDYgQEAg cHVibGljOgogCiAgICAgdmlydHVhbCB+V2ViRGV2VG9vbHNGcm9udGVuZCgpIHt9CiAKLSAgICB2 aXJ0dWFsIHZvaWQgZGlzcGF0Y2hNZXNzYWdlRnJvbUFnZW50KGNvbnN0IFdlYlN0cmluZyYgY2xh c3NOYW1lLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qg V2ViU3RyaW5nJiBtZXRob2ROYW1lLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgY29uc3QgV2ViU3RyaW5nJiBwYXJhbTEsCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBjb25zdCBXZWJTdHJpbmcmIHBhcmFtMiwKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IFdlYlN0cmluZyYgcGFyYW0zKSA9 IDA7CiAgICAgdmlydHVhbCB2b2lkIGRpc3BhdGNoTWVzc2FnZUZyb21BZ2VudChjb25zdCBXZWJE ZXZUb29sc01lc3NhZ2VEYXRhJikgPSAwOwogfTsKIApkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJEZXZUb29sc0Zyb250ZW5kQ2xpZW50LmggYi9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYkRldlRvb2xzRnJvbnRlbmRDbGllbnQuaAppbmRleCAyZjc0YThjLi42MjAwNzA5 IDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRldlRvb2xzRnJvbnRlbmRD bGllbnQuaAorKysgYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRldlRvb2xzRnJvbnRlbmRD bGllbnQuaApAQCAtNDAsMTEgKzQwLDYgQEAgY2xhc3MgV2ViRGV2VG9vbHNGcm9udGVuZENsaWVu dCB7CiBwdWJsaWM6CiAgICAgV2ViRGV2VG9vbHNGcm9udGVuZENsaWVudCgpIHt9CiAKLSAgICB2 aXJ0dWFsIHZvaWQgc2VuZE1lc3NhZ2VUb0FnZW50KGNvbnN0IFdlYlN0cmluZyYgY2xhc3NOYW1l LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgV2ViU3RyaW5nJiBt ZXRob2ROYW1lLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgV2Vi U3RyaW5nJiBwYXJhbTEsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25z dCBXZWJTdHJpbmcmIHBhcmFtMiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGNvbnN0IFdlYlN0cmluZyYgcGFyYW0zKSB7fTsKICAgICB2aXJ0dWFsIHZvaWQgc2VuZE1lc3Nh Z2VUb0FnZW50KGNvbnN0IFdlYkRldlRvb2xzTWVzc2FnZURhdGEmKSB7fTsKICAgICB2aXJ0dWFs IHZvaWQgc2VuZERlYnVnZ2VyQ29tbWFuZFRvQWdlbnQoY29uc3QgV2ViU3RyaW5nJiBjb21tYW5k KSB7fTsKICAgICB2aXJ0dWFsIHZvaWQgc2VuZERlYnVnZ2VyUGF1c2VTY3JpcHQoKSB7fQo=