32319 2009-12-09 05:26:12 -0800 Make changing-frame-hierarchy-in-onload.html non-flaky and platform-independent 2009-12-14 14:16:44 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Minor --- 0 kinuko webkit-unassigned commit-queue oldest_to_newest 169976 0 kinuko 2009-12-09 05:26:12 -0800 The layout test changing-frame-hierarchy-in-onload.html can be flaky or can yield different results across different platforms. The potential flakiness comes from the timing issue around setTimer and iframe loading. If I understand correctly, the test expects stop() is called: 1) after all the HTML elements in the main page are loaded 2) before body's onload() is called, and 3) before any iframe contents are shown (i.e. expects empty iframe content). 1) and 2) are almost always met, but 3) can cause some problems especially on other platforms than Mac/WebKit. On Mac/Webkit loading resources/slow-resource.pl doesn't render anything until all the data from the script is loaded due to buffering in NSURLConnection. The script returns one line text first, sleeps 5 sec and returns another line, therefore on Mac/Webkit it's safe to assume iframe content is empty for 5 sec or so. However this does not apply on some other platforms - for example on {Mac,Linux,Win}/Chrome this test always (on Mac,Linux) or often (on Windows) fails because they render the iframe contents as soon as they receive any data. (corresponding bug: http://code.google.com/p/chromium/issues/detail?id=24206) 169977 1 44531 kinuko 2009-12-09 05:39:03 -0800 Created attachment 44531 Make changing-frame-hierarchy-in-onload.html less flaky 169978 2 kinuko 2009-12-09 05:41:56 -0800 Attached a proposing patch. I've tested the test crashes without the fix made for the original issue 16102. 170015 3 44531 fishd 2009-12-09 09:14:27 -0800 Comment on attachment 44531 Make changing-frame-hierarchy-in-onload.html less flaky I guess a more direct solution would have been to use a variant of slow-resource.pl that doesn't print out anything until after the 5 second timeout has elapsed. I assume you made the other changes in an effort to speed up the test. Is that right? R=me 170307 4 kinuko 2009-12-09 20:53:23 -0800 (In reply to comment #3) > (From update of attachment 44531 [details]) > I guess a more direct solution would have been to use a variant of > slow-resource.pl > that doesn't print out anything until after the 5 second timeout has elapsed. > > I assume you made the other changes in an effort to speed up the test. Is that > right? > > R=me Thanks for reviewing, the patch also includes the part replacing slow-resource.pl with its variant, slow-resource-1-sec.pl, which doesn't print out anything until after the 1 sec timeout has elapsed. 171579 5 44531 commit-queue 2009-12-14 14:16:40 -0800 Comment on attachment 44531 Make changing-frame-hierarchy-in-onload.html less flaky Clearing flags on attachment: 44531 Committed r52119: <http://trac.webkit.org/changeset/52119> 171580 6 commit-queue 2009-12-14 14:16:44 -0800 All reviewed patches have been landed. Closing bug. 44531 2009-12-09 05:39:03 -0800 2009-12-14 14:16:40 -0800 Make changing-frame-hierarchy-in-onload.html less flaky bug-32319-20091209223901.patch text/plain 1601 kinuko ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjM2FmYjZhLi4zZGQxZTZkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTIt MDkgIEtpbnVrbyBZYXN1ZGEgIDxraW51a29AY2hyb21pdW0uY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgY2hhbmdpbmctZnJhbWUtaGll cmFyY2h5LWluLW9ubG9hZC5odG1sIGxlc3MgZmxha3kgYW5kCisgICAgICAgIHBsYXRmb3JtLWlu ZGVwZW5kZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzIzMTkKKworICAgICAgICAqIGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9jaGFuZ2luZy1mcmFt ZS1oaWVyYXJjaHktaW4tb25sb2FkLmh0bWw6CisKIDIwMDktMTItMDcgIE5pa29sYXMgWmltbWVy bWFubiAgPG56aW1tZXJtYW5uQHJpbS5jb20+CiAKICAgICAgICAgTm90IHJldmlld2VkLiBBZGQg dHdvIHRlc3RzIGdlbmVyYXRpbmcgbmV3IHJlc3VsdHMgdG8gZ3RrcyBjb2xsZWN0aW9uIG9mIHRl c3RzIGRvaW5nIHNvLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9uYXZpZ2F0 aW9uL2NoYW5naW5nLWZyYW1lLWhpZXJhcmNoeS1pbi1vbmxvYWQuaHRtbCBiL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9jaGFuZ2luZy1mcmFtZS1oaWVyYXJjaHktaW4tb25sb2Fk Lmh0bWwKaW5kZXggYTA0MzAxZS4uNWEyYzdkMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9uYXZpZ2F0aW9uL2NoYW5naW5nLWZyYW1lLWhpZXJhcmNoeS1pbi1vbmxvYWQuaHRt bAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vY2hhbmdpbmctZnJhbWUt aGllcmFyY2h5LWluLW9ubG9hZC5odG1sCkBAIC00LDE2ICs0LDE1IEBAIGlmICh3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIpCiAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgp OwogCiAKLXNldFRpbWVvdXQoc3RvcCwgNTAwKTsKLQogd2luZG93Lm9ubG9hZCA9IGZ1bmN0aW9u ICgpIHsKICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgnZnJvbTEnKSk7CiB9CiA8L3NjcmlwdD4KLQogPGRpdj4KIFRoaXMgdGVzdHMgdGhhdCB3ZSB3 b24ndCBjcmFzaCB3aGVuIGFuIG9ubG9hZCBtZXRob2QgY2hhbmdlcyB0aGUgZnJhbWUgaGllcmFy Y2h5IHdoZW4gdGhlIG1haW4gZnJhbWUgbG9hZCBpcyBzdG9wcGVkLgogPC9kaXY+CiA8ZGl2PlNV Q0NFU1MgLSBkaWRuJ3QgY3Jhc2g8L2Rpdj4KLTxpZnJhbWUgaWQ9ImZyb20xIiBzcmM9Ii9uYXZp Z2F0aW9uL3Jlc291cmNlcy9zbG93LXJlc291cmNlLnBsIj48L2lmcmFtZT4KKzxpZnJhbWUgaWQ9 ImZyb20xIiBzcmM9Ii9uYXZpZ2F0aW9uL3Jlc291cmNlcy9zbG93LXJlc291cmNlLTEtc2VjLnBs Ij48L2lmcmFtZT4KKzxzY3JpcHQ+c2V0VGltZW91dChzdG9wLCAwKTs8L3NjcmlwdD4KIDwvaHRt bD4KKwo=