32306 2009-12-08 23:56:36 -0800 [V8] Isolated world reuse failure 2009-12-09 12:14:28 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 sgjesse sgjesse abarth ager commit-queue dglazkov eric pfeldman sgjesse webkit.review.bot oldest_to_newest 169914 0 sgjesse 2009-12-08 23:56:36 -0800 The layout test LayoutTests/http/tests/security/isolatedWorld/world-reuse.html fails with V8 bindings changes introduced in r51407 (http://trac.webkit.org/changeset/51407). See http://crbug.com/28905 for details. 169966 1 44529 sgjesse 2009-12-09 04:50:08 -0800 Created attachment 44529 Patch 169967 2 webkit.review.bot 2009-12-09 04:54:21 -0800 Attachment 44529 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/bindings/v8/V8Proxy.cpp:396: One line control clauses should not use braces. [whitespace/braces] [4] WebCore/bindings/v8/V8Proxy.cpp:398: One line control clauses should not use braces. [whitespace/braces] [4] WebCore/bindings/v8/V8Proxy.cpp:1383: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/bindings/v8/V8Proxy.cpp:1383: Use 0 instead of NULL. [readability/null] [5] WebCore/bindings/v8/V8Proxy.cpp:1384: Use 0 instead of NULL. [readability/null] [5] Total errors found: 5 169971 3 44529 pfeldman 2009-12-09 05:05:30 -0800 Comment on attachment 44529 Patch > + if (debugId == -1) { > + snprintf(buffer, sizeof(buffer), "injected"); > + } else { > + snprintf(buffer, sizeof(buffer), "injected,%d", debugId); > + } no {} for single line bodies > targetContext->SetData(v8::String::New(buffer)); > > return true; > @@ -1378,6 +1380,8 @@ int V8Proxy::contextDebugId(v8::Handle<v > return -1; > v8::String::AsciiValue ascii(context->GetData()); > char* comma = strnstr(*ascii, ",", ascii.length()); > + if (comma == NULL) > + return NULL; if (!comma) return 0; > return atoi(comma + 1); > } > 169973 4 44530 sgjesse 2009-12-09 05:13:26 -0800 Created attachment 44530 Patch fixing webkit style 169985 5 44530 commit-queue 2009-12-09 06:34:45 -0800 Comment on attachment 44530 Patch fixing webkit style Rejecting patch 44530 from commit-queue. Unexpected failure when landing patch! Please file a bug against bugzilla-tool. Failed to run "['WebKitTools/Scripts/bugzilla-tool', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '44530']" exit_code: 1 Last 500 characters of output: nd_handle_errors self.run() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 54, in run self.clean() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 81, in clean step.run() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/buildsteps.py", line 101, in run os.chdir(self._tool._scm.checkout_root) AttributeError: 'NoneType' object has no attribute 'checkout_root' 170018 6 44530 dglazkov 2009-12-09 09:35:42 -0800 Comment on attachment 44530 Patch fixing webkit style Let's try again? 170021 7 44530 commit-queue 2009-12-09 09:36:56 -0800 Comment on attachment 44530 Patch fixing webkit style Rejecting patch 44530 from commit-queue. Unexpected failure when landing patch! Please file a bug against bugzilla-tool. Failed to run "['WebKitTools/Scripts/bugzilla-tool', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '44530']" exit_code: 1 Last 500 characters of output: nd_handle_errors self.run() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 54, in run self.clean() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 81, in clean step.run() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/buildsteps.py", line 101, in run os.chdir(self._tool._scm.checkout_root) AttributeError: 'NoneType' object has no attribute 'checkout_root' 170056 8 eric 2009-12-09 11:03:29 -0800 This is from Adam's refactoring of the queues last night. I'll stop the commit-queue and we'll get a fix in shortly. 170076 9 44530 eric 2009-12-09 11:36:27 -0800 Comment on attachment 44530 Patch fixing webkit style Sorry for the noise. Adam believes to have fixed the issue. I've restarted the commit bot. 170100 10 44530 commit-queue 2009-12-09 12:14:21 -0800 Comment on attachment 44530 Patch fixing webkit style Clearing flags on attachment: 44530 Committed r51912: <http://trac.webkit.org/changeset/51912> 170101 11 commit-queue 2009-12-09 12:14:28 -0800 All reviewed patches have been landed. Closing bug. 44529 2009-12-09 04:50:08 -0800 2009-12-09 05:14:31 -0800 Patch 32306.patch text/plain 1804 sgjesse SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTg5NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMTItMDkgIFPDuHJlbiBHamVzc2UgIDxzZ2plc3NlQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbVjhdIElzb2xhdGVkIHdvcmxkIHJldXNlIGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMzA2CisKKyAgICAgICAgRml4ZWQgYnVnIGlu dHJvZHVjZWQgaW4gcjUxNDA3OiAoaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNTE0 MDcpIHdoaWNoIGNhdXNlZCBsYXlvdXQgdGVzdAorICAgICAgICBMYXlvdXRUZXN0cy9odHRwL3Rl c3RzL3NlY3VyaXR5L2lzb2xhdGVkV29ybGQvd29ybGQtcmV1c2UuaHRtbCB0byBmYWlsLgorCisg ICAgICAgICogYmluZGluZ3MvdjgvVjhQcm94eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOFBy b3h5OjpzZXRJbmplY3RlZFNjcmlwdENvbnRleHREZWJ1Z0lkKToKKyAgICAgICAgKFdlYkNvcmU6 OlY4UHJveHk6OmNvbnRleHREZWJ1Z0lkKToKKwogMjAwOS0xMi0wOSAgT2xpdmVyIEh1bnQgIDxv bGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeApJbmRleDogV2ViQ29yZS9iaW5k aW5ncy92OC9WOFByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 UHJveHkuY3BwCShyZXZpc2lvbiA1MTg5NSkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94 eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM4OSwxMSArMzg5LDEzIEBAIGJvb2wgVjhQcm94eTo6 c2V0SW5qZWN0ZWRTY3JpcHRDb250ZXh0RGUKICAgICBpZiAobV9jb250ZXh0LklzRW1wdHkoKSkK ICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIGludCBkZWJ1Z0lkID0gY29udGV4dERlYnVnSWQo bV9jb250ZXh0KTsKLSAgICBpZiAoZGVidWdJZCA9PSAtMSkKLSAgICAgICAgcmV0dXJuIGZhbHNl OwogCiAgICAgY2hhciBidWZmZXJbMzJdOwotICAgIHNucHJpbnRmKGJ1ZmZlciwgc2l6ZW9mKGJ1 ZmZlciksICJpbmplY3RlZCwlZCIsIGRlYnVnSWQpOworICAgIGlmIChkZWJ1Z0lkID09IC0xKSB7 CisgICAgICAgIHNucHJpbnRmKGJ1ZmZlciwgc2l6ZW9mKGJ1ZmZlciksICJpbmplY3RlZCIpOwor ICAgIH0gZWxzZSB7CisgICAgICAgIHNucHJpbnRmKGJ1ZmZlciwgc2l6ZW9mKGJ1ZmZlciksICJp bmplY3RlZCwlZCIsIGRlYnVnSWQpOworICAgIH0KICAgICB0YXJnZXRDb250ZXh0LT5TZXREYXRh KHY4OjpTdHJpbmc6Ok5ldyhidWZmZXIpKTsKIAogICAgIHJldHVybiB0cnVlOwpAQCAtMTM3OCw2 ICsxMzgwLDggQEAgaW50IFY4UHJveHk6OmNvbnRleHREZWJ1Z0lkKHY4OjpIYW5kbGU8dgogICAg ICAgICByZXR1cm4gLTE7CiAgICAgdjg6OlN0cmluZzo6QXNjaWlWYWx1ZSBhc2NpaShjb250ZXh0 LT5HZXREYXRhKCkpOwogICAgIGNoYXIqIGNvbW1hID0gc3RybnN0cigqYXNjaWksICIsIiwgYXNj aWkubGVuZ3RoKCkpOworICAgIGlmIChjb21tYSA9PSBOVUxMKQorICAgICAgICByZXR1cm4gTlVM TDsKICAgICByZXR1cm4gYXRvaShjb21tYSArIDEpOwogfQogCg== 44530 2009-12-09 05:13:26 -0800 2009-12-09 12:14:20 -0800 Patch fixing webkit style 32306.patch text/plain 1782 sgjesse SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTg5NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMTItMDkgIFPDuHJlbiBHamVzc2UgIDxzZ2plc3NlQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbVjhdIElzb2xhdGVkIHdvcmxkIHJldXNlIGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMzA2CisKKyAgICAgICAgRml4ZWQgYnVnIGlu dHJvZHVjZWQgaW4gcjUxNDA3OiAoaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNTE0 MDcpIHdoaWNoIGNhdXNlZCBsYXlvdXQgdGVzdAorICAgICAgICBMYXlvdXRUZXN0cy9odHRwL3Rl c3RzL3NlY3VyaXR5L2lzb2xhdGVkV29ybGQvd29ybGQtcmV1c2UuaHRtbCB0byBmYWlsLgorCisg ICAgICAgICogYmluZGluZ3MvdjgvVjhQcm94eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOFBy b3h5OjpzZXRJbmplY3RlZFNjcmlwdENvbnRleHREZWJ1Z0lkKToKKyAgICAgICAgKFdlYkNvcmU6 OlY4UHJveHk6OmNvbnRleHREZWJ1Z0lkKToKKwogMjAwOS0xMi0wOSAgT2xpdmVyIEh1bnQgIDxv bGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeApJbmRleDogV2ViQ29yZS9iaW5k aW5ncy92OC9WOFByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 UHJveHkuY3BwCShyZXZpc2lvbiA1MTg5NSkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94 eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM4OSwxMSArMzg5LDEyIEBAIGJvb2wgVjhQcm94eTo6 c2V0SW5qZWN0ZWRTY3JpcHRDb250ZXh0RGUKICAgICBpZiAobV9jb250ZXh0LklzRW1wdHkoKSkK ICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIGludCBkZWJ1Z0lkID0gY29udGV4dERlYnVnSWQo bV9jb250ZXh0KTsKLSAgICBpZiAoZGVidWdJZCA9PSAtMSkKLSAgICAgICAgcmV0dXJuIGZhbHNl OwogCiAgICAgY2hhciBidWZmZXJbMzJdOwotICAgIHNucHJpbnRmKGJ1ZmZlciwgc2l6ZW9mKGJ1 ZmZlciksICJpbmplY3RlZCwlZCIsIGRlYnVnSWQpOworICAgIGlmIChkZWJ1Z0lkID09IC0xKQor ICAgICAgICBzbnByaW50ZihidWZmZXIsIHNpemVvZihidWZmZXIpLCAiaW5qZWN0ZWQiKTsKKyAg ICBlbHNlCisgICAgICAgIHNucHJpbnRmKGJ1ZmZlciwgc2l6ZW9mKGJ1ZmZlciksICJpbmplY3Rl ZCwlZCIsIGRlYnVnSWQpOwogICAgIHRhcmdldENvbnRleHQtPlNldERhdGEodjg6OlN0cmluZzo6 TmV3KGJ1ZmZlcikpOwogCiAgICAgcmV0dXJuIHRydWU7CkBAIC0xMzc4LDYgKzEzNzksOCBAQCBp bnQgVjhQcm94eTo6Y29udGV4dERlYnVnSWQodjg6OkhhbmRsZTx2CiAgICAgICAgIHJldHVybiAt MTsKICAgICB2ODo6U3RyaW5nOjpBc2NpaVZhbHVlIGFzY2lpKGNvbnRleHQtPkdldERhdGEoKSk7 CiAgICAgY2hhciogY29tbWEgPSBzdHJuc3RyKCphc2NpaSwgIiwiLCBhc2NpaS5sZW5ndGgoKSk7 CisgICAgaWYgKCFjb21tYSkKKyAgICAgICAgcmV0dXJuIC0xOwogICAgIHJldHVybiBhdG9pKGNv bW1hICsgMSk7CiB9CiAK