32301 2009-12-08 19:40:36 -0800 Add "using std::foo" rule checked by script to coding style guidelines 2009-12-09 15:09:01 -0800 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) All All RESOLVED FIXED https://lists.webkit.org/pipermail/webkit-dev/2009-December/010906.html P4 Minor --- 0 cjerdonek webkit-unassigned cjerdonek commit-queue webkit.review.bot oldest_to_newest 169879 0 cjerdonek 2009-12-08 19:40:36 -0800 This is a bug report to make the following changes and clarifications to the coding style guidelines: (1) Add this to the guidelines: Do not use statements of the form "using std:foo" in implementation files. Use "using namespace std" instead. (The script currently enforces this rule, but for header files and not just implementation files.) (2) Clarify that the rule to put "using namespace" statements near the beginning of a file applies only to implementation files. (It currently applies also to header files.) Also, strengthen the rule so it applies to all "using" statements in implementation files and not just "using namespace" statements. (The above is excerpted from an e-mail to the webkit-dev list -- linked to by the URL for this report.) 169885 1 44509 cjerdonek 2009-12-08 20:00:36 -0800 Created attachment 44509 Proposed patch Changes made as reported. Also, all the "using" statement style guidelines now lead with "In header files" or "In implementation files," etc. so it is immediately obvious what types of files each rule applies to. 169887 2 webkit.review.bot 2009-12-08 20:05:20 -0800 style-queue ran check-webkit-style on attachment 44509 without any errors. 170016 3 44509 darin 2009-12-09 09:31:44 -0800 Comment on attachment 44509 Proposed patch > +<li>In header files in the WTF sub-library, however, it is acceptable > +to use "using" declarations at the end of the file to include one > +or more names in the WTF namespace into the global scope. I think the use of the verb "include" here is strange. I think it should be "add" or "import" instead. 170037 4 44543 cjerdonek 2009-12-09 10:16:38 -0800 Created attachment 44543 Revised patch Changed the two uses of "include" to "import" -- as suggested. 170038 5 webkit.review.bot 2009-12-09 10:19:49 -0800 style-queue ran check-webkit-style on attachment 44543 without any errors. 170216 6 44543 commit-queue 2009-12-09 15:08:55 -0800 Comment on attachment 44543 Revised patch Clearing flags on attachment: 44543 Committed r51929: <http://trac.webkit.org/changeset/51929> 170217 7 commit-queue 2009-12-09 15:09:01 -0800 All reviewed patches have been landed. Closing bug. 44509 2009-12-08 20:00:36 -0800 2009-12-09 10:16:38 -0800 Proposed patch patch.txt text/plain 3186 cjerdonek SW5kZXg6IFdlYktpdFNpdGUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFNpdGUvQ2hh bmdlTG9nCShyZXZpc2lvbiA1MTg4NSkKKysrIFdlYktpdFNpdGUvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMTItMDggIENocmlzIEplcmRvbmVrICA8Y2hy aXMuamVyZG9uZWtAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZGVkIHRoZSAidXNpbmcgc3RkOjpmb28iIHJ1bGUgdG8gdGhlIGNv ZGluZyBzdHlsZSBndWlkZWxpbmVzLgorICAgICAgICAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMzAxCisgICAgICAgIAorICAgICAgICBBZGRlZCB0 byB0aGUgY29kaW5nIHN0eWxlIGd1aWRlbGluZXMgdGhlICJ1c2luZyBzdGQ6OmZvbyIgcnVsZQor ICAgICAgICBjaGVja2VkIGJ5IHRoZSBjaGVjay13ZWJraXQtc3R5bGUgc2NyaXB0LiAgQWxzbyBj bGFyaWZpZWQgdGhlCisgICAgICAgICJ1c2luZyIgc3RhdGVtZW50IGd1aWRlbGluZXMgdGhhdCBh cHBseSB0byBpbXBsZW1lbnRhdGlvbiBmaWxlcy4KKworICAgICAgICAqIGNvZGluZy9jb2Rpbmct c3R5bGUuaHRtbDoKKwogMjAwOS0xMi0wNSAgQ2hyaXMgSmVyZG9uZWsgIDxjaHJpcy5qZXJkb25l a0BnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBX ZWJLaXRTaXRlL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRT aXRlL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRtbAkocmV2aXNpb24gNTE4ODUpCisrKyBXZWJLaXRT aXRlL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtNzA5LDggKzcw OSw4IEBAIERvbid0IGJvdGhlciB0byBvcmdhbml6ZSB0aGVtIGluIGEgbG9naWMKIAogPG9sPgog Ci08bGk+SW4gaGVhZGVyIGZpbGVzLCBkbyBub3QgdXNlICJ1c2luZyIgc3RhdGVtZW50cyBpbiBn bG9iYWwgb3IgCi0ibmFtZXNwYWNlIiBzY29wZS4KKzxsaT5JbiBoZWFkZXIgZmlsZXMsIGRvIG5v dCB1c2UgInVzaW5nIiBzdGF0ZW1lbnRzIGluIG5hbWVzcGFjZQorKG9yIGdsb2JhbCkgc2NvcGUu CiAKIDxoNCBjbGFzcz0icmlnaHQiPlJpZ2h0OjwvaDQ+CiA8cHJlIGNsYXNzPSJjb2RlIj4KQEAg LTc0MSw5ICs3NDEsOSBAQCBjbGFzcyBWZWN0b3JCdWZmZXIgewogPC9wcmU+CiA8L2xpPgogCi08 bGk+SXQgaXMgYWNjZXB0YWJsZSwgaG93ZXZlciwgdG8gdXNlICJ1c2luZyIgZGVjbGFyYXRpb25z IGF0IHRoZSBlbmQgb2YgCi1oZWFkZXIgZmlsZXMgaW4gdGhlIFdURiBzdWItbGlicmFyeSB0byBp bmNsdWRlIG9uZSBvciBtb3JlIG5hbWVzIGluIAotdGhlIFdURiBuYW1lc3BhY2UgaW50byB0aGUg Z2xvYmFsIHNjb3BlLgorPGxpPkluIGhlYWRlciBmaWxlcyBpbiB0aGUgV1RGIHN1Yi1saWJyYXJ5 LCBob3dldmVyLCBpdCBpcyBhY2NlcHRhYmxlCit0byB1c2UgInVzaW5nIiBkZWNsYXJhdGlvbnMg YXQgdGhlIGVuZCBvZiB0aGUgZmlsZSB0byBpbmNsdWRlIG9uZQorb3IgbW9yZSBuYW1lcyBpbiB0 aGUgV1RGIG5hbWVzcGFjZSBpbnRvIHRoZSBnbG9iYWwgc2NvcGUuCiAKIDxoNCBjbGFzcz0icmln aHQiPlJpZ2h0OjwvaDQ+CiA8cHJlIGNsYXNzPSJjb2RlIj4KQEAgLTc3Nyw4ICs3NzcsMzYgQEAg dXNpbmcgV1RGOjpQbGFjZW1lbnROZXdBZG9wdDsKIDwvcHJlPgogPC9saT4KIAotPGxpPkFueSAi dXNpbmcgbmFtZXNwYWNlIiBzdGF0ZW1lbnRzIGZvciBhIG5lc3RlZCBuYW1lc3BhY2Ugd2hvc2Ug cGFyZW50IG5hbWVzcGFjZSAKLWlzIGFsc28gZGVmaW5lZCBpbiBhIGZpbGUgbXVzdCBiZSBkZWNs YXJlZCB3aXRoaW4gdGhhdCBuYW1lc3BhY2UgZGVmaW5pdGlvbi4KKzxsaT5JbiBDKysgaW1wbGVt ZW50YXRpb24gZmlsZXMsIGRvIG5vdCB1c2Ugc3RhdGVtZW50cyBvZiB0aGUgZm9ybQorInVzaW5n IHN0ZDo6Zm9vIiB0byBpbmNsdWRlIG5hbWVzIGluIHRoZSBzdGFuZGFyZCB0ZW1wbGF0ZSBsaWJy YXJ5LgorVXNlICJ1c2luZyBuYW1lc3BhY2Ugc3RkIiBpbnN0ZWFkLgorCis8aDQgY2xhc3M9InJp Z2h0Ij5SaWdodDo8L2g0PgorPHByZSBjbGFzcz0iY29kZSI+CisvLyBIVE1MQmFzZUVsZW1lbnQu Y3BwCisKK3VzaW5nIG5hbWVzcGFjZSBzdGQ7CisKK25hbWVzcGFjZSBXZWJDb3JlIHsKKworfSAv LyBuYW1lc3BhY2UgV2ViQ29yZQorPC9wcmU+CisKKzxoNCBjbGFzcz0id3JvbmciPldyb25nOjwv aDQ+Cis8cHJlIGNsYXNzPSJjb2RlIj4KKy8vIEhUTUxCYXNlRWxlbWVudC5jcHAKKwordXNpbmcg c3RkOjpzd2FwOworCituYW1lc3BhY2UgV2ViQ29yZSB7CisKK30gLy8gbmFtZXNwYWNlIFdlYkNv cmUKKzwvcHJlPgorPC9saT4KKworPGxpPkluIGltcGxlbWVudGF0aW9uIGZpbGVzLCBpZiBhICJ1 c2luZyBuYW1lc3BhY2UiIHN0YXRlbWVudCBpcworZm9yIGEgbmVzdGVkIG5hbWVzcGFjZSB3aG9z ZSBwYXJlbnQgbmFtZXNwYWNlIGlzIGRlZmluZWQgaW4gdGhlIGZpbGUsCitwdXQgdGhlIHN0YXRl bWVudCBpbnNpZGUgdGhhdCBuYW1lc3BhY2UgZGVmaW5pdGlvbi4KIAogPGg0IGNsYXNzPSJyaWdo dCI+UmlnaHQ6PC9oND4KIDxwcmUgY2xhc3M9ImNvZGUiPgpAQCAtODAzLDggKzgzMSwxMCBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiA8L3ByZT4KIDwvbGk+CiAKLTxsaT5Bbnkgb3RoZXIgInVzaW5n IG5hbWVzcGFjZSIgc3RhdGVtZW50cyBtdXN0IGJlIGRlY2xhcmVkIGJlZm9yZSB0aGUgZmlyc3Qg bmFtZXNwYWNlIAotZGVmaW5pdGlvbiBpbiB0aGUgZmlsZS4KKzxsaT5JbiBpbXBsZW1lbnRhdGlv biBmaWxlcywgcHV0IGFsbCBvdGhlciAidXNpbmciIHN0YXRlbWVudHMKK2F0IHRoZSBiZWdpbm5p bmcgb2YgdGhlIGZpbGUsIGJlZm9yZSBhbnkgbmFtZXNwYWNlIGRlZmluaXRpb25zIGFuZAorYWZ0 ZXIgYW55ICJpbmNsdWRlIiBzdGF0ZW1lbnRzLgorCiA8aDQgY2xhc3M9InJpZ2h0Ij5SaWdodDo8 L2g0PgogPHByZSBjbGFzcz0iY29kZSI+CiAvLyBIVE1MU2VsZWN0RWxlbWVudC5jcHAK 44543 2009-12-09 10:16:38 -0800 2009-12-09 15:08:54 -0800 Revised patch patch2.txt text/plain 3184 cjerdonek SW5kZXg6IFdlYktpdFNpdGUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFNpdGUvQ2hh bmdlTG9nCShyZXZpc2lvbiA1MTg4NSkKKysrIFdlYktpdFNpdGUvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMTItMDggIENocmlzIEplcmRvbmVrICA8Y2hy aXMuamVyZG9uZWtAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZGVkIHRoZSAidXNpbmcgc3RkOjpmb28iIHJ1bGUgdG8gdGhlIGNv ZGluZyBzdHlsZSBndWlkZWxpbmVzLgorICAgICAgICAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMzAxCisgICAgICAgIAorICAgICAgICBBZGRlZCB0 byB0aGUgY29kaW5nIHN0eWxlIGd1aWRlbGluZXMgdGhlICJ1c2luZyBzdGQ6OmZvbyIgcnVsZQor ICAgICAgICBjaGVja2VkIGJ5IHRoZSBjaGVjay13ZWJraXQtc3R5bGUgc2NyaXB0LiAgQWxzbyBj bGFyaWZpZWQgdGhlCisgICAgICAgICJ1c2luZyIgc3RhdGVtZW50IGd1aWRlbGluZXMgdGhhdCBh cHBseSB0byBpbXBsZW1lbnRhdGlvbiBmaWxlcy4KKworICAgICAgICAqIGNvZGluZy9jb2Rpbmct c3R5bGUuaHRtbDoKKwogMjAwOS0xMi0wNSAgQ2hyaXMgSmVyZG9uZWsgIDxjaHJpcy5qZXJkb25l a0BnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBX ZWJLaXRTaXRlL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRT aXRlL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRtbAkocmV2aXNpb24gNTE4ODUpCisrKyBXZWJLaXRT aXRlL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtNzA5LDggKzcw OSw4IEBAIERvbid0IGJvdGhlciB0byBvcmdhbml6ZSB0aGVtIGluIGEgbG9naWMKIAogPG9sPgog Ci08bGk+SW4gaGVhZGVyIGZpbGVzLCBkbyBub3QgdXNlICJ1c2luZyIgc3RhdGVtZW50cyBpbiBn bG9iYWwgb3IgCi0ibmFtZXNwYWNlIiBzY29wZS4KKzxsaT5JbiBoZWFkZXIgZmlsZXMsIGRvIG5v dCB1c2UgInVzaW5nIiBzdGF0ZW1lbnRzIGluIG5hbWVzcGFjZQorKG9yIGdsb2JhbCkgc2NvcGUu CiAKIDxoNCBjbGFzcz0icmlnaHQiPlJpZ2h0OjwvaDQ+CiA8cHJlIGNsYXNzPSJjb2RlIj4KQEAg LTc0MSw5ICs3NDEsOSBAQCBjbGFzcyBWZWN0b3JCdWZmZXIgewogPC9wcmU+CiA8L2xpPgogCi08 bGk+SXQgaXMgYWNjZXB0YWJsZSwgaG93ZXZlciwgdG8gdXNlICJ1c2luZyIgZGVjbGFyYXRpb25z IGF0IHRoZSBlbmQgb2YgCi1oZWFkZXIgZmlsZXMgaW4gdGhlIFdURiBzdWItbGlicmFyeSB0byBp bmNsdWRlIG9uZSBvciBtb3JlIG5hbWVzIGluIAotdGhlIFdURiBuYW1lc3BhY2UgaW50byB0aGUg Z2xvYmFsIHNjb3BlLgorPGxpPkluIGhlYWRlciBmaWxlcyBpbiB0aGUgV1RGIHN1Yi1saWJyYXJ5 LCBob3dldmVyLCBpdCBpcyBhY2NlcHRhYmxlCit0byB1c2UgInVzaW5nIiBkZWNsYXJhdGlvbnMg YXQgdGhlIGVuZCBvZiB0aGUgZmlsZSB0byBpbXBvcnQgb25lCitvciBtb3JlIG5hbWVzIGluIHRo ZSBXVEYgbmFtZXNwYWNlIGludG8gdGhlIGdsb2JhbCBzY29wZS4KIAogPGg0IGNsYXNzPSJyaWdo dCI+UmlnaHQ6PC9oND4KIDxwcmUgY2xhc3M9ImNvZGUiPgpAQCAtNzc3LDggKzc3NywzNiBAQCB1 c2luZyBXVEY6OlBsYWNlbWVudE5ld0Fkb3B0OwogPC9wcmU+CiA8L2xpPgogCi08bGk+QW55ICJ1 c2luZyBuYW1lc3BhY2UiIHN0YXRlbWVudHMgZm9yIGEgbmVzdGVkIG5hbWVzcGFjZSB3aG9zZSBw YXJlbnQgbmFtZXNwYWNlIAotaXMgYWxzbyBkZWZpbmVkIGluIGEgZmlsZSBtdXN0IGJlIGRlY2xh cmVkIHdpdGhpbiB0aGF0IG5hbWVzcGFjZSBkZWZpbml0aW9uLgorPGxpPkluIEMrKyBpbXBsZW1l bnRhdGlvbiBmaWxlcywgZG8gbm90IHVzZSBzdGF0ZW1lbnRzIG9mIHRoZSBmb3JtCisidXNpbmcg c3RkOjpmb28iIHRvIGltcG9ydCBuYW1lcyBpbiB0aGUgc3RhbmRhcmQgdGVtcGxhdGUgbGlicmFy eS4KK1VzZSAidXNpbmcgbmFtZXNwYWNlIHN0ZCIgaW5zdGVhZC4KKworPGg0IGNsYXNzPSJyaWdo dCI+UmlnaHQ6PC9oND4KKzxwcmUgY2xhc3M9ImNvZGUiPgorLy8gSFRNTEJhc2VFbGVtZW50LmNw cAorCit1c2luZyBuYW1lc3BhY2Ugc3RkOworCituYW1lc3BhY2UgV2ViQ29yZSB7CisKK30gLy8g bmFtZXNwYWNlIFdlYkNvcmUKKzwvcHJlPgorCis8aDQgY2xhc3M9Indyb25nIj5Xcm9uZzo8L2g0 PgorPHByZSBjbGFzcz0iY29kZSI+CisvLyBIVE1MQmFzZUVsZW1lbnQuY3BwCisKK3VzaW5nIHN0 ZDo6c3dhcDsKKworbmFtZXNwYWNlIFdlYkNvcmUgeworCit9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl Cis8L3ByZT4KKzwvbGk+CisKKzxsaT5JbiBpbXBsZW1lbnRhdGlvbiBmaWxlcywgaWYgYSAidXNp bmcgbmFtZXNwYWNlIiBzdGF0ZW1lbnQgaXMKK2ZvciBhIG5lc3RlZCBuYW1lc3BhY2Ugd2hvc2Ug cGFyZW50IG5hbWVzcGFjZSBpcyBkZWZpbmVkIGluIHRoZSBmaWxlLAorcHV0IHRoZSBzdGF0ZW1l bnQgaW5zaWRlIHRoYXQgbmFtZXNwYWNlIGRlZmluaXRpb24uCiAKIDxoNCBjbGFzcz0icmlnaHQi PlJpZ2h0OjwvaDQ+CiA8cHJlIGNsYXNzPSJjb2RlIj4KQEAgLTgwMyw4ICs4MzEsMTAgQEAgbmFt ZXNwYWNlIFdlYkNvcmUgewogPC9wcmU+CiA8L2xpPgogCi08bGk+QW55IG90aGVyICJ1c2luZyBu YW1lc3BhY2UiIHN0YXRlbWVudHMgbXVzdCBiZSBkZWNsYXJlZCBiZWZvcmUgdGhlIGZpcnN0IG5h bWVzcGFjZSAKLWRlZmluaXRpb24gaW4gdGhlIGZpbGUuCis8bGk+SW4gaW1wbGVtZW50YXRpb24g ZmlsZXMsIHB1dCBhbGwgb3RoZXIgInVzaW5nIiBzdGF0ZW1lbnRzCithdCB0aGUgYmVnaW5uaW5n IG9mIHRoZSBmaWxlLCBiZWZvcmUgYW55IG5hbWVzcGFjZSBkZWZpbml0aW9ucyBhbmQKK2FmdGVy IGFueSAiaW5jbHVkZSIgc3RhdGVtZW50cy4KKwogPGg0IGNsYXNzPSJyaWdodCI+UmlnaHQ6PC9o ND4KIDxwcmUgY2xhc3M9ImNvZGUiPgogLy8gSFRNTFNlbGVjdEVsZW1lbnQuY3BwCg==