32299 2009-12-08 17:38:52 -0800 Cannot open a lot of WebSocket connections 2010-01-19 08:25:23 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac (Intel) OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ap webkit-unassigned eric ukai webkit.review.bot yuzo oldest_to_newest 169847 0 44500 ap 2009-12-08 17:38:52 -0800 Created attachment 44500 test case (to be run locally) Not sure if it's a SocketStreamHandleCFNet or pywebsocket issue, but I couldn't open more than a few dozen connections to a local WebSocket server. Please see attached test case. I'm getting results as low as 25 or as high as 89 randomly. I want to have at least some large number guaranteed to make a test verifying that WebSocket is not subject to HTTP connection limit (currently 4 or 6 in different implementations, but it would be best to set a much higher threshold in the test). 172229 1 yuzo 2009-12-16 01:56:19 -0800 A fix is under review now in the upstream. If you are in a hurry, please make the following change: http://code.google.com/p/pywebsocket/source/diff?format=side&show=review&spec=issue34&r=147&path=/branches/moreconn/src/mod_pywebsocket/standalone.py Yuzo 177105 2 45878 yuzo 2010-01-05 03:06:57 -0800 Created attachment 45878 Update pywebsocket to 0.4.6 177107 3 webkit.review.bot 2010-01-05 03:10:50 -0800 style-queue ran check-webkit-style on attachment 45878 without any errors. 177165 4 45878 ap 2010-01-05 08:34:37 -0800 Comment on attachment 45878 Update pywebsocket to 0.4.6 r=me. The patch doesn't include a test case - would be nice to land the attached one at the same time. 180875 5 eric 2010-01-14 13:04:06 -0800 Ping? This has been in the pending-commit list for 7 days w/o comment. Just checking in... 181093 6 ukai 2010-01-14 20:57:01 -0800 Committed r53317: <http://trac.webkit.org/changeset/53317> 181949 7 ap 2010-01-18 11:57:21 -0800 Test landed in bug 33804. 181980 8 ap 2010-01-18 13:52:45 -0800 This doesn't quite work on Windows: <http://build.webkit.org/results/Windows%20Debug%20(Tests)/r53421%20(8654)/websocket/tests/multiple-connections-pretty-diff.html>. 182176 9 ukai 2010-01-19 01:46:43 -0800 (In reply to comment #8) > This doesn't quite work on Windows: > <http://build.webkit.org/results/Windows%20Debug%20(Tests)/r53421%20(8654)/websocket/tests/multiple-connections-pretty-diff.html>. This is the cause? 2010-01-18 13:25:39.906 DumpRenderTree_debug.exe[2688:994] *** More than MAXIMUM_WAIT_OBJECTS (64) ports add to a port set. The last ones will be ignored. http://build.webkit.org/results/Windows%20Debug%20(Tests)/r53421%20(8654)/websocket/tests/multiple-connections-stderr.txt 182248 10 ap 2010-01-19 08:25:23 -0800 Sounds like that! 64 is enough for my purposes - changed the test to only make 50 connections. 44500 2009-12-08 17:38:52 -0800 2009-12-08 17:38:52 -0800 test case (to be run locally) multiple-connections.html text/html 758 ap PHA+VGVzdCB0aGF0IFdlYlNvY2tldCBpcyBub3Qgc3ViamVjdCB0byBIVFRQIGNvbm5lY3Rpb24g bGltaXQ8L3A+CjxwIGlkPXJlc3VsdD5SdW5uaW5nLi4uPC9wPgo8c2NyaXB0PgppZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKSB7CiAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNU ZXh0KCk7CiAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Cn0KCnZhciBz b2NrZXRDb3VudCA9IDEwMDsKdmFyIHJlc3VsdCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJy ZXN1bHQiKTsKCmZvciAoaSA9IDA7IGkgPCBzb2NrZXRDb3VudDsgKytpKSB7CiAgICB2YXIgd3Mg PSBuZXcgV2ViU29ja2V0KCJ3czovLzEyNy4wLjAuMTo4ODgwL3dlYnNvY2tldC90ZXN0cy9lY2hv Iik7CiAgICB3cy5vbm9wZW4gPSBmdW5jdGlvbigpIHsKICAgICAgICB2YXIgbnVtID0gcGFyc2VJ bnQocmVzdWx0LmlubmVySFRNTCk7CiAgICAgICAgaWYgKCFudW0pCiAgICAgICAgICAgIG51bSA9 IDA7CiAgICAgICAgaWYgKG51bSAhPSAxMDApCiAgICAgICAgICAgIHJlc3VsdC5pbm5lckhUTUwg PSBudW0gKyAxOwogICAgICAgIGVsc2UgewogICAgICAgICAgICByZXN1bHQuaW5uZXJIVE1MID0g IlBBU1MiOwogICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQogICAg ICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOwogICAgICAgIH0K ICAgIH0KfQo8L3NjcmlwdD4= 45878 2010-01-05 03:06:57 -0800 2010-01-05 08:34:36 -0800 Update pywebsocket to 0.4.6 bug-32299-20100105200655.patch text/plain 4122 yuzo ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0OTMyOTdlLi42MmQ0YmYwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDEt MDUgIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBweXdlYnNvY2tldCB0byAwLjQu NgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzIyOTkK KyAgICAgICAgVGhlIG5ld2VyIHB5d2Vic29ja2V0IGNhbiBoYW5kbGUgbW9yZSBzaW11bHRhbmVv dXMgY29ubmVjdGlvbnMuCisKKyAgICAgICAgKiBweXdlYnNvY2tldC9tb2RfcHl3ZWJzb2NrZXQv aGFuZHNoYWtlLnB5OgorICAgICAgICAqIHB5d2Vic29ja2V0L21vZF9weXdlYnNvY2tldC9zdGFu ZGFsb25lLnB5OgorICAgICAgICAqIHB5d2Vic29ja2V0L3NldHVwLnB5OgorICAgICAgICAqIHB5 d2Vic29ja2V0L3Rlc3QvdGVzdF9oYW5kc2hha2UucHk6CisKIDIwMTAtMDEtMDQgIE1hY2llaiBT dGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBG aXNoZXIuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9weXdlYnNvY2tldC9tb2RfcHl3ZWJzb2Nr ZXQvaGFuZHNoYWtlLnB5IGIvV2ViS2l0VG9vbHMvcHl3ZWJzb2NrZXQvbW9kX3B5d2Vic29ja2V0 L2hhbmRzaGFrZS5weQppbmRleCAxNGQ1YWZjLi41MGQ4YzgwIDEwMDY0NAotLS0gYS9XZWJLaXRU b29scy9weXdlYnNvY2tldC9tb2RfcHl3ZWJzb2NrZXQvaGFuZHNoYWtlLnB5CisrKyBiL1dlYktp dFRvb2xzL3B5d2Vic29ja2V0L21vZF9weXdlYnNvY2tldC9oYW5kc2hha2UucHkKQEAgLTYzLDE3 ICs2MywxNSBAQCBfRklSU1RfRklWRV9MSU5FUyA9IG1hcChyZS5jb21waWxlLCBbCiAgICAgcide T3JpZ2luOiBbXFNdK1xyXG4kJywKIF0pCiAKLSMgRklYTUU6IENvb2tpZSBoZWFkZXJzIGFsc28g YmVpbmcgaW4gcmVzdHJpY3RlZCBXZWJTb2NrZXQgc3ludGF4LgogX1NJWFRIX0FORF9MQVRFUiA9 IHJlLmNvbXBpbGUoCiAgICAgcideJwogICAgIHInKFdlYlNvY2tldC1Qcm90b2NvbDogW1x4MjAt XHg3ZV0rXHJcbik/JwotICAgIHInKFtDY11bT29dW09vXVtLa11bSWldW0VlXTpbXlxyXSpcclxu KSonCi0gICAgcicoW0NjXVtPb11bT29dW0trXVtJaV1bRWVdMjpbXlxyXSpcclxuKT8nCi0gICAg cicoW0NjXVtPb11bT29dW0trXVtJaV1bRWVdOlteXHJdKlxyXG4pKicKKyAgICByJyhDb29raWU6 IFteXHJdKlxyXG4pKicKKyAgICByJyhDb29raWUyOiBbXlxyXSpcclxuKT8nCisgICAgcicoQ29v a2llOiBbXlxyXSpcclxuKSonCiAgICAgcidcclxuJykKIAogCi0KIGRlZiBfZGVmYXVsdF9wb3J0 KGlzX3NlY3VyZSk6CiAgICAgaWYgaXNfc2VjdXJlOgogICAgICAgICByZXR1cm4gX0RFRkFVTFRf V0VCX1NPQ0tFVF9TRUNVUkVfUE9SVApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvcHl3ZWJzb2Nr ZXQvbW9kX3B5d2Vic29ja2V0L3N0YW5kYWxvbmUucHkgYi9XZWJLaXRUb29scy9weXdlYnNvY2tl dC9tb2RfcHl3ZWJzb2NrZXQvc3RhbmRhbG9uZS5weQppbmRleCAwYTE3MzZlLi45ODIyYTc1IDEw MDY0NAotLS0gYS9XZWJLaXRUb29scy9weXdlYnNvY2tldC9tb2RfcHl3ZWJzb2NrZXQvc3RhbmRh bG9uZS5weQorKysgYi9XZWJLaXRUb29scy9weXdlYnNvY2tldC9tb2RfcHl3ZWJzb2NrZXQvc3Rh bmRhbG9uZS5weQpAQCAtODksNiArODksOCBAQCBfTE9HX0xFVkVMUyA9IHsKIF9ERUZBVUxUX0xP R19NQVhfQllURVMgPSAxMDI0ICogMjU2CiBfREVGQVVMVF9MT0dfQkFDS1VQX0NPVU5UID0gNQog CitfREVGQVVMVF9SRVFVRVNUX1FVRVVFX1NJWkUgPSAxMjgKKwogIyAxMDI0IGlzIHByYWN0aWNh bGx5IGxhcmdlIGVub3VnaCB0byBjb250YWluIFdlYlNvY2tldCBoYW5kc2hha2UgbGluZXMuCiBf TUFYX01FTU9SSVpFRF9MSU5FUyA9IDEwMjQKIApAQCAtMzE0LDEyICszMTYsMTcgQEAgZGVmIF9t YWluKCk6CiAgICAgICAgICAgICAgICAgICAgICAgaGVscD0nTG9nIGJhY2t1cCBjb3VudCcpCiAg ICAgcGFyc2VyLmFkZF9vcHRpb24oJy0tc3RyaWN0JywgZGVzdD0nc3RyaWN0JywgYWN0aW9uPSdz dG9yZV90cnVlJywKICAgICAgICAgICAgICAgICAgICAgICBkZWZhdWx0PUZhbHNlLCBoZWxwPSdT dHJpY3RseSBjaGVjayBoYW5kc2hha2UgcmVxdWVzdCcpCisgICAgcGFyc2VyLmFkZF9vcHRpb24o Jy1xJywgJy0tcXVldWUnLCBkZXN0PSdyZXF1ZXN0X3F1ZXVlX3NpemUnLCB0eXBlPSdpbnQnLAor ICAgICAgICAgICAgICAgICAgICAgIGRlZmF1bHQ9X0RFRkFVTFRfUkVRVUVTVF9RVUVVRV9TSVpF LAorICAgICAgICAgICAgICAgICAgICAgIGhlbHA9J3JlcXVlc3QgcXVldWUgc2l6ZScpCiAgICAg b3B0aW9ucyA9IHBhcnNlci5wYXJzZV9hcmdzKClbMF0KIAogICAgIG9zLmNoZGlyKG9wdGlvbnMu ZG9jdW1lbnRfcm9vdCkKIAogICAgIF9jb25maWd1cmVfbG9nZ2luZyhvcHRpb25zKQogCisgICAg U29ja2V0U2VydmVyLlRDUFNlcnZlci5yZXF1ZXN0X3F1ZXVlX3NpemUgPSBvcHRpb25zLnJlcXVl c3RfcXVldWVfc2l6ZQorCiAgICAgaWYgb3B0aW9ucy51c2VfdGxzOgogICAgICAgICBpZiBub3Qg X0hBU19PUEVOX1NTTDoKICAgICAgICAgICAgIGxvZ2dpbmcuY3JpdGljYWwoJ1RvIHVzZSBUTFMs IGluc3RhbGwgcHlPcGVuU1NMLicpCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9weXdlYnNvY2tl dC9zZXR1cC5weSBiL1dlYktpdFRvb2xzL3B5d2Vic29ja2V0L3NldHVwLnB5CmluZGV4IGQ1NTJk OTEuLjZmNmFjYzYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL3B5d2Vic29ja2V0L3NldHVwLnB5 CisrKyBiL1dlYktpdFRvb2xzL3B5d2Vic29ja2V0L3NldHVwLnB5CkBAIC01Niw3ICs1Niw3IEBA IHNldHVwKGF1dGhvcj0nWXV6byBGdWppc2hpbWEnLAogICAgICAgbmFtZT1fUEFDS0FHRV9OQU1F LAogICAgICAgcGFja2FnZXM9W19QQUNLQUdFX05BTUVdLAogICAgICAgdXJsPSdodHRwOi8vY29k ZS5nb29nbGUuY29tL3AvcHl3ZWJzb2NrZXQvJywKLSAgICAgIHZlcnNpb249JzAuNC41JywKKyAg ICAgIHZlcnNpb249JzAuNC42JywKICAgICAgICkKIAogCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9weXdlYnNvY2tldC90ZXN0L3Rlc3RfaGFuZHNoYWtlLnB5IGIvV2ViS2l0VG9vbHMvcHl3ZWJz b2NrZXQvdGVzdC90ZXN0X2hhbmRzaGFrZS5weQppbmRleCBjNGM0NTkwLi4xZDY5YjJkIDEwMDY0 NAotLS0gYS9XZWJLaXRUb29scy9weXdlYnNvY2tldC90ZXN0L3Rlc3RfaGFuZHNoYWtlLnB5Cisr KyBiL1dlYktpdFRvb2xzL3B5d2Vic29ja2V0L3Rlc3QvdGVzdF9oYW5kc2hha2UucHkKQEAgLTM0 OCw2ICszNDgsMjQgQEAgX05PVF9TVFJJQ1RMWV9HT09EX1JFUVVFU1RTID0gKAogICAgICAgICAn IGRlZmdcclxuJywKICAgICAgICAgJ1xyXG4nLAogICAgICksCisgICAgKCAgIyBXcm9uZy1jYXNl IGNvb2tpZQorICAgICAgICAnR0VUIC9kZW1vIEhUVFAvMS4xXHJcbicsCisgICAgICAgICdVcGdy YWRlOiBXZWJTb2NrZXRcclxuJywKKyAgICAgICAgJ0Nvbm5lY3Rpb246IFVwZ3JhZGVcclxuJywK KyAgICAgICAgJ0hvc3Q6IGV4YW1wbGUuY29tXHJcbicsCisgICAgICAgICdPcmlnaW46IGh0dHA6 Ly9leGFtcGxlLmNvbVxyXG4nLAorICAgICAgICAnY29va2llOiBhYmMveHl6XHJcbicKKyAgICAg ICAgJ1xyXG4nLAorICAgICksCisgICAgKCAgIyBDb29raWUsIG5vIHNwYWNlIGFmdGVyIGNvbG9u CisgICAgICAgICdHRVQgL2RlbW8gSFRUUC8xLjFcclxuJywKKyAgICAgICAgJ1VwZ3JhZGU6IFdl YlNvY2tldFxyXG4nLAorICAgICAgICAnQ29ubmVjdGlvbjogVXBncmFkZVxyXG4nLAorICAgICAg ICAnSG9zdDogZXhhbXBsZS5jb21cclxuJywKKyAgICAgICAgJ09yaWdpbjogaHR0cDovL2V4YW1w bGUuY29tXHJcbicsCisgICAgICAgICdDb29raWU6YWJjL3h5elxyXG4nCisgICAgICAgICdcclxu JywKKyAgICApLAogKQogCiAK