32296 2009-12-08 16:23:47 -0800 Implement 'select all' for WebKit/win/WebFrame 2009-12-09 12:07:12 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham commit-queue webkit.review.bot oldest_to_newest 169831 0 bfulgham 2009-12-08 16:23:47 -0800 The CG Windows port of WebKit has not needed support for a "selectAll" operation on the WebFrame. Most other browsers on the Windows platform (e.g., Firefox, IE) do provide a right-click contextual "Select All" menu. This patch provides a selectAll implementation that can be used to drive a platform-specific "Select All" feature. 169833 1 44496 bfulgham 2009-12-08 16:26:26 -0800 Created attachment 44496 Provide simple selectAll implementation. 169834 2 44497 bfulgham 2009-12-08 16:28:30 -0800 Created attachment 44497 Provide simple selectAll implementation. 169835 3 44497 bfulgham 2009-12-08 16:29:02 -0800 Comment on attachment 44497 Provide simple selectAll implementation. Whitespace (tabs) corrected. 169836 4 webkit.review.bot 2009-12-08 16:29:56 -0800 style-queue ran check-webkit-style on attachment 44497 without any errors. 170019 5 44497 darin 2009-12-09 09:35:58 -0800 Comment on attachment 44497 Provide simple selectAll implementation. > + if (!coreFrame->editor()->command("SelectAll").execute()) > + return E_FAIL; I think coreFrame->selection()->selectAll() would be better here. But this seems OK. 170041 6 44497 commit-queue 2009-12-09 10:27:30 -0800 Comment on attachment 44497 Provide simple selectAll implementation. Rejecting patch 44497 from commit-queue. Unexpected failure when landing patch! Please file a bug against bugzilla-tool. Failed to run "['WebKitTools/Scripts/bugzilla-tool', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '44497']" exit_code: 1 Last 500 characters of output: nd_handle_errors self.run() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 54, in run self.clean() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 81, in clean step.run() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/buildsteps.py", line 101, in run os.chdir(self._tool._scm.checkout_root) AttributeError: 'NoneType' object has no attribute 'checkout_root' 170080 7 44497 eric 2009-12-09 11:37:36 -0800 Comment on attachment 44497 Provide simple selectAll implementation. Sorry for the noise. Adam believes to have fixed the issue. I've restarted the commit bot. 170096 8 44497 commit-queue 2009-12-09 12:07:07 -0800 Comment on attachment 44497 Provide simple selectAll implementation. Clearing flags on attachment: 44497 Committed r51911: <http://trac.webkit.org/changeset/51911> 170097 9 commit-queue 2009-12-09 12:07:12 -0800 All reviewed patches have been landed. Closing bug. 44496 2009-12-08 16:26:26 -0800 2009-12-08 16:28:42 -0800 Provide simple selectAll implementation. select-all.patch text/plain 1117 bfulgham SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiA1MTg3OCkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTItMDggIEJyZW50IEZ1bGdoYW0gIDxiZnVs Z2hhbUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFByb3ZpZGUgYW4gaW1wbGVtZW50YXRpb24gZm9yICdzZWxlY3RBbGwnCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjI5NgorCisgICAg ICAgICogV2ViRnJhbWUuY3BwOgorICAgICAgICAoV2ViRnJhbWU6OnNlbGVjdEFsbCk6IEltcGxl bWVudCAiU2VsZWN0QWxsIiBjb21tYW5kLgorCiAyMDA5LTEyLTA4ICBBZGFtIFJvYmVuICA8YXJv YmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBXaW5kb3dzIGJ1aWxkIGZpeApJbmRleDogV2ViS2l0 L3dpbi9XZWJGcmFtZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3dpbi9XZWJGcmFtZS5jcHAJ KHJldmlzaW9uIDUxODc3KQorKysgV2ViS2l0L3dpbi9XZWJGcmFtZS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTk4Niw3ICs5ODYsMTQgQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBXZWJGcmFt ZTo6c2VsZQogCiBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIFdlYkZyYW1lOjpzZWxlY3RBbGwo KQogewotICAgIHJldHVybiBFX05PVElNUEw7CisJRnJhbWUqIGNvcmVGcmFtZSA9IGNvcmUodGhp cyk7CisgICAgaWYgKCFjb3JlRnJhbWUpCisgICAgICAgIHJldHVybiBFX0ZBSUw7CisKKwlpZiAo IWNvcmVGcmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIlNlbGVjdEFsbCIpLmV4ZWN1dGUoKSkKKwkJ cmV0dXJuIEVfRkFJTDsKKworICAgIHJldHVybiBTX09LOwogfQogCiBIUkVTVUxUIFNURE1FVEhP RENBTExUWVBFIFdlYkZyYW1lOjpkZXNlbGVjdEFsbCgpCg== 44497 2009-12-08 16:28:30 -0800 2009-12-09 12:07:07 -0800 Provide simple selectAll implementation. select-all.patch text/plain 1129 bfulgham SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiA1MTg3OCkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTItMDggIEJyZW50IEZ1bGdoYW0gIDxiZnVs Z2hhbUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFByb3ZpZGUgYW4gaW1wbGVtZW50YXRpb24gZm9yICdzZWxlY3RBbGwnCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjI5NgorCisgICAg ICAgICogV2ViRnJhbWUuY3BwOgorICAgICAgICAoV2ViRnJhbWU6OnNlbGVjdEFsbCk6IEltcGxl bWVudCAiU2VsZWN0QWxsIiBjb21tYW5kLgorCiAyMDA5LTEyLTA4ICBBZGFtIFJvYmVuICA8YXJv YmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBXaW5kb3dzIGJ1aWxkIGZpeApJbmRleDogV2ViS2l0 L3dpbi9XZWJGcmFtZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3dpbi9XZWJGcmFtZS5jcHAJ KHJldmlzaW9uIDUxODc3KQorKysgV2ViS2l0L3dpbi9XZWJGcmFtZS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTk4Niw3ICs5ODYsMTQgQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBXZWJGcmFt ZTo6c2VsZQogCiBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIFdlYkZyYW1lOjpzZWxlY3RBbGwo KQogewotICAgIHJldHVybiBFX05PVElNUEw7CisgICAgRnJhbWUqIGNvcmVGcmFtZSA9IGNvcmUo dGhpcyk7CisgICAgaWYgKCFjb3JlRnJhbWUpCisgICAgICAgIHJldHVybiBFX0ZBSUw7CisKKyAg ICBpZiAoIWNvcmVGcmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIlNlbGVjdEFsbCIpLmV4ZWN1dGUo KSkKKyAgICAgICAgcmV0dXJuIEVfRkFJTDsKKworICAgIHJldHVybiBTX09LOwogfQogCiBIUkVT VUxUIFNURE1FVEhPRENBTExUWVBFIFdlYkZyYW1lOjpkZXNlbGVjdEFsbCgpCg==