32294 2009-12-08 16:08:43 -0800 http/tests/uri/escaped-entity.html affects the output of svg/W3C-SVG-1.1/filters-conv-01-f.svg 2010-01-08 14:59:19 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac (Intel) OS X 10.5 RESOLVED FIXED P2 Normal --- 33374 33230 33372 1 zimmermann ap abecsi darin eric hausmann hyatt mjs ossy webkit.review.bot oldest_to_newest 169828 0 zimmermann 2009-12-08 16:08:43 -0800 Please see the differences between: http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/8029 http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/8030 LayoutTests/svg/W3C-SVG-1.1/filters-conv-01-f.svg reported 115 as text width instead of 117. When running the test singly, it reports 115. Clearly there is a bug and it needs investigation. Anyone? 178550 1 ossy 2010-01-08 00:31:17 -0800 I can confirm it can be a DRT sideeffect bug. It occured again on all MAC testers after http://trac.webkit.org/changeset/52976 landed. This patch move http tests at the end. http://build.webkit.org/results/Tiger%20Intel%20Release/r52977%20(7547) http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r52977%20(9112) http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r52976%20(9022) http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r52977%20(4019) 178555 2 eric 2010-01-08 01:11:13 -0800 I'm investigating. 178560 3 eric 2010-01-08 01:30:36 -0800 Found the bug. http/tests/uri/escaped-entity.html changes the results of svg/W3C-SVG-1.1/filters-conv-01-f.svg when run before it. I suspect some sort of memory smasher, but I don't know yet. My recommendation is that we skip http/tests/uri/escaped-entity.html Running http/tests/uri/escaped-entity.html under --guard mode does not crash. 178570 4 eric 2010-01-08 01:59:42 -0800 How: http://trac.webkit.org/browser/trunk/LayoutTests/http/tests/uri/escaped-entity.html affects: http://trac.webkit.org/browser/trunk/LayoutTests/svg/W3C-SVG-1.1/filters-conv-01-f.svg To cause this diff: --- layout-test-results/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt 2010-01-08 00:17:01.000000000 -0800 +++ layout-test-results/svg/W3C-SVG-1.1/filters-conv-01-f-actual.txt 2010-01-08 00:17:01.000000000 -0800 @@ -39,7 +39,7 @@ RenderSVGImage {image} at (180,163) size 50x63 [filter=convolve5] RenderSVGText {text} at (10,20) size 117x18 contains 1 chunk(s) RenderSVGInlineText {#text} at (0,-14) size 117x18 - chunk 1 text run 1 at (10.00,20.00) startOffset 0 endOffset 19 width 117.00: "Vertical blur (1x3)" + chunk 1 text run 1 at (10.00,20.00) startOffset 0 endOffset 19 width 115.00: "Vertical blur (1x3)" RenderSVGContainer {g} at (330,163) size 50x63 [transform={m=((1.00,0.00)(0.00,1.00)) t=(300.00,93.00)}] RenderSVGImage {image} at (330,163) size 50x63 [filter=convolve6] RenderSVGText {text} at (10,340) size 264x46 contains 1 chunk(s) I do not know. I can only assume that it's causing some sort of font caching issue or a memory smasher of some sort. I've not tried to produce a reduced test case yet. 178572 5 46122 eric 2010-01-08 02:07:00 -0800 Created attachment 46122 Patch 178576 6 eric 2010-01-08 02:15:37 -0800 Committed r52979: <http://trac.webkit.org/changeset/52979> 178577 7 eric 2010-01-08 02:18:11 -0800 (In reply to comment #6) > Committed r52979: <http://trac.webkit.org/changeset/52979> That was meant for another bug. 178581 8 eric 2010-01-08 02:23:02 -0800 Committed r52980: <http://trac.webkit.org/changeset/52980> 178588 9 ossy 2010-01-08 03:00:54 -0800 Unfortunately "Windows Release (Tests)" bot is still wrong, it doesn't generate the correct output for svg/W3C-SVG-1.1/filters-conv-01-f.svg :S http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r52980%20%284022%29/results.html 178594 10 eric 2010-01-08 03:08:42 -0800 I wonder if svg/W3C-SVG-1.1/filters-conv-01-f.svg could be reading from uniitialized memory. Would be nice if we had a valgrind run. 178595 11 eric 2010-01-08 03:09:51 -0800 bug 33372 also seems to be the same sort of bug. We may need to roll out the run-webkit-tests change and fix all these bugs which should appear in --singly runs as well. 178810 12 46163 ap 2010-01-08 14:25:53 -0800 Created attachment 46163 proposed fix Filed bug 33400 for the real problem, masking it with changes to escaped-entity.html for now, since the test has no need to render funky characters. 178814 13 webkit.review.bot 2010-01-08 14:33:32 -0800 style-queue ran check-webkit-style on attachment 46163 without any errors. 178823 14 ap 2010-01-08 14:59:19 -0800 Committed <http://trac.webkit.org/changeset/53012>. 46122 2010-01-08 02:07:00 -0800 2010-01-08 02:16:06 -0800 Patch bug-32294-20100108020659.patch text/plain 2400 eric ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzMDJjMmMzLi5hMTU5YmVjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDEt MDggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHAvdGVzdHMvdXJpL2VzY2FwZWQtZW50aXR5 Lmh0bWwgYWZmZWN0cyB0aGUgb3V0cHV0IG9mIHN2Zy9XM0MtU1ZHLTEuMS9maWx0ZXJzLWNvbnYt MDEtZi5zdmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTMyMjk0CisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvU2tpcHBlZDogQWRkIGh0dHAvdGVzdHMv dXJpL2VzY2FwZWQtZW50aXR5Lmh0bWwgdG8gU2tpcHBlZCBsaXN0IHNpbmNlIGl0IGFmZmVjdHMg bGF0ZXIgdGVzdHMuCisgICAgICAgICogcGxhdGZvcm0vbWFjL3N2Zy9XM0MtU1ZHLTEuMS9maWx0 ZXJzLWNvbnYtMDEtZi1leHBlY3RlZC50eHQ6IENoZWNrIGluIGNvcnJlY3QgcmVzdWx0cy4KKwog MjAxMC0wMS0wNyAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZAppbmRleCAxZmVk Y2Q5Li5hNWM4MzdlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBl ZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZApAQCAtMTAzLDMgKzEwMyw3 IEBAIGZhc3Qvd2Vic29ja2V0cy93ZWJzb2NrZXQtZXZlbnQtdGFyZ2V0Lmh0bWwKICMgVGhpcyB0 ZXN0IGlzIGNhdXNpbmcgbGF0ZXIgdGVzdHMgdG8gZmFpbAogIyBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzMzMDAKIHBsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2Fy aWEtbGl2ZXJlZ2lvbnMtbm90aWZpY2F0aW9ucy5odG1sCisKKyMgVGhpcyB0ZXN0IGNoYW5nZXMg dGhlIG91dHB1dCBvZiBzdmcvVzNDLVNWRy0xLjEvZmlsdGVycy1jb252LTAxLWYuc3ZnIGZvciB1 bmtub3duIHJlYXNvbnMuCisjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zMjI5NAoraHR0cC90ZXN0cy91cmkvZXNjYXBlZC1lbnRpdHkuaHRtbApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9XM0MtU1ZHLTEuMS9maWx0ZXJzLWNvbnYtMDEt Zi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvc3ZnL1czQy1TVkctMS4x L2ZpbHRlcnMtY29udi0wMS1mLWV4cGVjdGVkLnR4dAppbmRleCA3N2ZkM2M4Li4wZjRmOTNlIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvc3ZnL1czQy1TVkctMS4xL2ZpbHRl cnMtY29udi0wMS1mLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMv c3ZnL1czQy1TVkctMS4xL2ZpbHRlcnMtY29udi0wMS1mLWV4cGVjdGVkLnR4dApAQCAtMzksNyAr MzksNyBAQCBsYXllciBhdCAoMCwwKSBzaXplIDQ4MHgzNjAKICAgICAgICAgICAgIFJlbmRlclNW R0ltYWdlIHtpbWFnZX0gYXQgKDE4MCwxNjMpIHNpemUgNTB4NjMgW2ZpbHRlcj1jb252b2x2ZTVd CiAgICAgICAgICAgUmVuZGVyU1ZHVGV4dCB7dGV4dH0gYXQgKDEwLDIwKSBzaXplIDExN3gxOCBj b250YWlucyAxIGNodW5rKHMpCiAgICAgICAgICAgICBSZW5kZXJTVkdJbmxpbmVUZXh0IHsjdGV4 dH0gYXQgKDAsLTE0KSBzaXplIDExN3gxOAotICAgICAgICAgICAgICBjaHVuayAxIHRleHQgcnVu IDEgYXQgKDEwLjAwLDIwLjAwKSBzdGFydE9mZnNldCAwIGVuZE9mZnNldCAxOSB3aWR0aCAxMTcu MDA6ICJWZXJ0aWNhbCBibHVyICgxeDMpIgorICAgICAgICAgICAgICBjaHVuayAxIHRleHQgcnVu IDEgYXQgKDEwLjAwLDIwLjAwKSBzdGFydE9mZnNldCAwIGVuZE9mZnNldCAxOSB3aWR0aCAxMTUu MDA6ICJWZXJ0aWNhbCBibHVyICgxeDMpIgogICAgICAgICAgIFJlbmRlclNWR0NvbnRhaW5lciB7 Z30gYXQgKDMzMCwxNjMpIHNpemUgNTB4NjMgW3RyYW5zZm9ybT17bT0oKDEuMDAsMC4wMCkoMC4w MCwxLjAwKSkgdD0oMzAwLjAwLDkzLjAwKX1dCiAgICAgICAgICAgICBSZW5kZXJTVkdJbWFnZSB7 aW1hZ2V9IGF0ICgzMzAsMTYzKSBzaXplIDUweDYzIFtmaWx0ZXI9Y29udm9sdmU2XQogICAgIFJl bmRlclNWR1RleHQge3RleHR9IGF0ICgxMCwzNDApIHNpemUgMjY0eDQ2IGNvbnRhaW5zIDEgY2h1 bmsocykK 46163 2010-01-08 14:25:53 -0800 2010-01-08 14:41:57 -0800 proposed fix EnableTest.txt text/plain 3143 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUzMDA4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDEtMDggIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMjk0 CisgICAgICAgIGh0dHAvdGVzdHMvdXJpL2VzY2FwZWQtZW50aXR5Lmh0bWwgYWZmZWN0cyB0aGUg b3V0cHV0IG9mIHN2Zy9XM0MtU1ZHLTEuMS9maWx0ZXJzLWNvbnYtMDEtZi5zdmcKKworICAgICAg ICBDaGFuZ2VkIHRoZSB0ZXN0IHRvIG5vdCBoYXZlIGFueSBmdW5reSBjaGFyYWN0ZXJzLiBGaWxl ZCBidWcgMzM0MDAgdG8gdHJhY2sgdGhlIHVuZGVybHlpbmcKKyAgICAgICAgcHJvYmxlbSB3aXRo IGtlcm5pbmcuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL3VyaS9lc2NhcGVkLWVudGl0eS1leHBl Y3RlZC50eHQ6CisgICAgICAgICogaHR0cC90ZXN0cy91cmkvZXNjYXBlZC1lbnRpdHkuaHRtbDoK KyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvU2tpcHBlZDoKKwogMjAxMC0wMS0wOCAgT2phbiBWYWZh aSAgPG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy91cmkvZXNjYXBlZC1lbnRpdHktZXhwZWN0 ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvdXJpL2VzY2FwZWQt ZW50aXR5LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gNTMwMDgpCisrKyBMYXlvdXRUZXN0cy9odHRw L3Rlc3RzL3VyaS9lc2NhcGVkLWVudGl0eS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAg LTEsNCArMSw0IEBACi1UZXN0IGZvciBidWcgMTUxMTk6IFVucmVwcmVzZW50YWJsZSBjaGFyYWN0 ZXJzIGluIGEgVVJMJ3MgY2hhcmFjdGVyIHNldCBzaG91bGQgYmUgY29udmVydGVkIHRvIGVzY2Fw ZWQgZW50aXRpZXMuIFdlIHVzZSB0aGUgY2hhcmFjdGVyIFUrMDZERSAo254pIHdoaWNoIGRvZXMg bm90IGV4aXN0IGluIEJpZy01LgorVGVzdCBmb3IgYnVnIDE1MTE5OiBVbnJlcHJlc2VudGFibGUg Y2hhcmFjdGVycyBpbiBhIFVSTCdzIGNoYXJhY3RlciBzZXQgc2hvdWxkIGJlIGNvbnZlcnRlZCB0 byBlc2NhcGVkIGVudGl0aWVzLiBXZSB1c2UgdGhlIGNoYXJhY3RlciBVKzA2REUgKEFSQUJJQyBT VEFSVCBPRiBSVUIgRUwgSElaQikgd2hpY2ggZG9lcyBub3QgZXhpc3QgaW4gQmlnLTUuCiAKIE5v dGUgdGhhdCB0aGlzIGV4YWN0IHBhZ2Ugd29uJ3Qgd29yayBpbiBJRSBvciBGaXJlZm94LiBGaXJl Zm94IHNlZW1zIHRvIGFsd2F5cyB1c2UgVVRGLTggZm9yIGxvY2FsIGZpbGVzLCBhbmQgSUUgYWN0 dWFsbHkgcHJlc2VydmVzIHRoZSBVbmljb2RlIGluIHRoZSBVUkwgd2hlbiB3ZSBnZXQgaXQgZnJv bSBKUywgc28gd2UgZG9uJ3Qga25vdyB3aGF0IHdvdWxkIGdldCBzZW50IG92ZXIgdGhlIHdpcmUu IEhvd2V2ZXIsIGJvdGggYnJvd3NlcnMgd2lsbCBzZW5kICUyNiUyMzE3NTglM0Igb3ZlciBIVFRQ IGZvciB0aGUgcXVlcnkuCiAKSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvdXJpL2VzY2Fw ZWQtZW50aXR5Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy91cmkv ZXNjYXBlZC1lbnRpdHkuaHRtbAkocmV2aXNpb24gNTMwMDgpCisrKyBMYXlvdXRUZXN0cy9odHRw L3Rlc3RzL3VyaS9lc2NhcGVkLWVudGl0eS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xMSw3ICsx MSw3IEBACiAKIDxwPlRlc3QgZm9yIDxhIGhyZWY9J2h0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1MTE5Jz5idWcgMTUxMTk8L2E+OgogVW5yZXByZXNlbnRhYmxlIGNoYXJh Y3RlcnMgaW4gYSBVUkwncyBjaGFyYWN0ZXIgc2V0IHNob3VsZCBiZSBjb252ZXJ0ZWQgdG8KLWVz Y2FwZWQgZW50aXRpZXMuIFdlIHVzZSB0aGUgY2hhcmFjdGVyIFUrMDZERSAoJiN4NmRlOykgd2hp Y2ggZG9lcyBub3QgZXhpc3QgaW4KK2VzY2FwZWQgZW50aXRpZXMuIFdlIHVzZSB0aGUgY2hhcmFj dGVyIFUrMDZERSAoQVJBQklDIFNUQVJUIE9GIFJVQiBFTCBISVpCKSB3aGljaCBkb2VzIG5vdCBl eGlzdCBpbgogQmlnLTUuPC9wPgogCiA8cD5Ob3RlIHRoYXQgdGhpcyBleGFjdCBwYWdlIHdvbid0 IHdvcmsgaW4gSUUgb3IgRmlyZWZveC4gRmlyZWZveCBzZWVtcyB0bwpJbmRleDogTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjL1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL1NraXBwZWQJKHJldmlzaW9uIDUzMDA4KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjL1NraXBwZWQJKHdvcmtpbmcgY29weSkKQEAgLTk5LDcgKzk5LDMgQEAgZmFzdC9ldmVudHMv YmFzaWMtdG91Y2gtZXZlbnRzLmh0bWwKICMgVGhpcyB0ZXN0IGlzIGNhdXNpbmcgYSBsb2cgbWVz c2FnZSB0byBvY2N1ciBhZnRlciB0aGUgdGVzdCwgdGh1cyBjYXVzaW5nIHRoZSBuZXh0IHRlc3Qg YWZ0ZXIgaXQgdG8gZmFpbDoKICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMzMjU2CiBmYXN0L3dlYnNvY2tldHMvd2Vic29ja2V0LWV2ZW50LXRhcmdldC5odG1sCi0K LSMgVGhpcyB0ZXN0IGNoYW5nZXMgdGhlIG91dHB1dCBvZiBzdmcvVzNDLVNWRy0xLjEvZmlsdGVy cy1jb252LTAxLWYuc3ZnIGZvciB1bmtub3duIHJlYXNvbnMuCi0jIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjI5NAotaHR0cC90ZXN0cy91cmkvZXNjYXBlZC1lbnRp dHkuaHRtbAo=