32289 2009-12-08 14:42:09 -0800 Mouse click count lost in WebMouseEventBuilder conversion 2009-12-09 11:36:55 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 stuartmorgan stuartmorgan commit-queue eric fishd webkit.review.bot oldest_to_newest 169797 0 stuartmorgan 2009-12-08 14:42:09 -0800 WebMouseEventBuilder::WebMouseEventBuilder in WebInputEventConversion.cpp fails to pull the source event's "detail" field, which is where the click count is stored in MouseEvent, so all mouse events going through it end up with a clickCount of 0. 169807 1 44490 stuartmorgan 2009-12-08 15:06:26 -0800 Created attachment 44490 Add clickCount to conversion 169809 2 webkit.review.bot 2009-12-08 15:08:15 -0800 style-queue ran check-webkit-style on attachment 44490 without any errors. 170009 3 44490 commit-queue 2009-12-09 08:41:06 -0800 Comment on attachment 44490 Add clickCount to conversion Rejecting patch 44490 from commit-queue. Unexpected failure when landing patch! Please file a bug against bugzilla-tool. Failed to run "['WebKitTools/Scripts/bugzilla-tool', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', '--quiet', '44490']" exit_code: 1 Last 500 characters of output: nd_handle_errors self.run() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 54, in run self.clean() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/landingsequence.py", line 81, in clean step.run() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/modules/buildsteps.py", line 101, in run os.chdir(self._tool._scm.checkout_root) AttributeError: 'NoneType' object has no attribute 'checkout_root' 170040 4 fishd 2009-12-09 10:22:36 -0800 Landed as http://trac.webkit.org/changeset/51904 170078 5 eric 2009-12-09 11:36:55 -0800 Sorry for the noise. Adam believes to have fixed the issue. I've restarted the commit bot. 44490 2009-12-08 15:06:26 -0800 2009-12-09 08:41:06 -0800 Add clickCount to conversion 32289.patch text/plain 1179 stuartmorgan SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTE4NzQpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTItMDggIFN0dWFy dCBNb3JnYW4gIDxzdHVhcnRtb3JnYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluY2x1ZGUgY2xpY2tDb3VudCB3aGVuIGRv aW5nIE1vdXNlRXZlbnQgLT4gV2ViTW91c2VFdmVudCBjb252ZXJzaW9uCisgICAgICAgIGluIENo cm9taXVtIEFQSS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzIyODkKKworICAgICAgICAqIHNyYy9XZWJJbnB1dEV2ZW50Q29udmVyc2lvbi5jcHA6 CisgICAgICAgIChXZWJLaXQ6OldlYk1vdXNlRXZlbnRCdWlsZGVyOjpXZWJNb3VzZUV2ZW50QnVp bGRlcik6CisKIDIwMDktMTItMDggIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpJbmRleDogV2ViS2l0L2No cm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50Q29udmVyc2lvbi5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50Q29udmVyc2lvbi5jcHAJKHJldmlzaW9uIDUx ODcyKQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50Q29udmVyc2lvbi5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTIyOSw2ICsyMjksNyBAQCBXZWJNb3VzZUV2ZW50QnVpbGRlcjo6 V2ViTW91c2VFdmVudEJ1aWxkCiAgICAgd2luZG93WSA9IHAueSgpOwogICAgIHggPSBldmVudC5v ZmZzZXRYKCk7CiAgICAgeSA9IGV2ZW50Lm9mZnNldFkoKTsKKyAgICBjbGlja0NvdW50ID0gZXZl bnQuZGV0YWlsKCk7CiB9CiAKIFdlYktleWJvYXJkRXZlbnRCdWlsZGVyOjpXZWJLZXlib2FyZEV2 ZW50QnVpbGRlcihjb25zdCBLZXlib2FyZEV2ZW50JiBldmVudCkK