32279 2009-12-08 11:20:37 -0800 composited layers are sometimes clipped 2010-01-18 10:50:47 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 cmarrin cmarrin aroben webkit.review.bot oldest_to_newest 169734 0 cmarrin 2009-12-08 11:20:37 -0800 If you open a page with a composited layer taller than the current window and scroll, the layer will be clipped. 181444 1 46720 cmarrin 2010-01-15 17:26:58 -0800 Created attachment 46720 Patch 181446 2 webkit.review.bot 2010-01-15 17:32:19 -0800 Attachment 46720 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp:231: Should have a space between // and comment [whitespace/comments] [4] WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp:232: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 2 181532 3 46720 darin 2010-01-16 11:08:10 -0800 Comment on attachment 46720 Patch > + //m_rootLayer->setAnchorPoint(CGPointMake(0, 1)); > + //CGPoint pos = m_rootLayer->position(); You should remove this commented-out code. Unless it's needed. While I'm not as familiar with this code as some, and there's no regression testing here, the patch looks fine otherwise. Please remove the commented-out code. And if you think someone else (Simon) should review this, feel free to change back from review+ to review?. 181926 4 cmarrin 2010-01-18 10:50:47 -0800 Got rid of comments as per Darin's comment. Landed in http://trac.webkit.org/changeset/53415 46720 2010-01-15 17:26:58 -0800 2010-01-16 11:08:10 -0800 Patch 32279.patch text/plain 5952 cmarrin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzM1MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMDEtMTUgIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1h ZGUgcm9vdCBjb21wb3NpdGluZyBsYXllciBzY3JvbGwgcmF0aGVyIHRoYW4gc2Nyb2xsIHBhcmVu dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMjc5 CisgICAgICAgIAorICAgICAgICBUaGVyZSdzIHNvbWUgZ2VuZXJhbCBjbGVhbnVwIGhlcmUgc28g dGhlIGZyYW1lcywgYm91bmRzIGFuZAorICAgICAgICBwb3NpdGlvbnMgb2YgYWxsIHRoZSBhc3Nv Y2lhdGVkIGxheWVycyBhcmUgY29ycmVjdC4KKyAgICAgICAgSSBhbHNvIGNoYW5nZWQgQVBJIG9m IHNldFNjcm9sbEZyYW1lIHRvIHVzZSBhbiBJbnRSZWN0LgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3Mvd2luL1dLQ0FDRkxheWVyUmVuZGVyZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 V0tDQUNGTGF5ZXJSZW5kZXJlcjo6V0tDQUNGTGF5ZXJSZW5kZXJlcik6CisgICAgICAgIChXZWJD b3JlOjpXS0NBQ0ZMYXllclJlbmRlcmVyOjpzZXRTY3JvbGxGcmFtZSk6CisgICAgICAgIChXZWJD b3JlOjpXS0NBQ0ZMYXllclJlbmRlcmVyOjpzZXRSb290Q2hpbGRMYXllcik6CisgICAgICAgIChX ZWJDb3JlOjpXS0NBQ0ZMYXllclJlbmRlcmVyOjpjcmVhdGVSZW5kZXJlcik6CisgICAgICAgIChX ZWJDb3JlOjpXS0NBQ0ZMYXllclJlbmRlcmVyOjpyZXNpemUpOgorICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL3dpbi9XS0NBQ0ZMYXllclJlbmRlcmVyLmg6CisKIDIwMTAtMDEtMTUgIEFsZWph bmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg WGFuIExvcGV6LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vV0tDQUNGTGF5 ZXJSZW5kZXJlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93 aW4vV0tDQUNGTGF5ZXJSZW5kZXJlci5jcHAJKHJldmlzaW9uIDUzMjk3KQorKysgV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy93aW4vV0tDQUNGTGF5ZXJSZW5kZXJlci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTEzNiw4ICsxMzYsNyBAQCBXS0NBQ0ZMYXllclJlbmRlcmVyOjpXS0NBQ0ZMYXllclJl bmRlcmVyCiAgICAgLCBtX3JlbmRlcmVyKDApCiAgICAgLCBtX2hvc3RXaW5kb3coMCkKICAgICAs IG1fcmVuZGVyVGltZXIodGhpcywgJldLQ0FDRkxheWVyUmVuZGVyZXI6OnJlbmRlclRpbWVyRmly ZWQpCi0gICAgLCBtX3Njcm9sbEZyYW1lV2lkdGgoMSkgLy8gRGVmYXVsdCB0byAxIHRvIGF2b2lk IDAgc2l6ZSBmcmFtZXMKLSAgICAsIG1fc2Nyb2xsRnJhbWVIZWlnaHQoMSkgLy8gRGVmYXVsdCB0 byAxIHRvIGF2b2lkIDAgc2l6ZSBmcmFtZXMKKyAgICAsIG1fc2Nyb2xsRnJhbWUoMCwgMCwgMSwg MSkgLy8gRGVmYXVsdCB0byAxIHRvIGF2b2lkIDAgc2l6ZSBmcmFtZXMKIHsKIH0KIApAQCAtMTQ2 LDE5ICsxNDUsMTUgQEAgV0tDQUNGTGF5ZXJSZW5kZXJlcjo6fldLQ0FDRkxheWVyUmVuZGVyZQog ICAgIGRlc3Ryb3lSZW5kZXJlcigpOwogfQogCi12b2lkIFdLQ0FDRkxheWVyUmVuZGVyZXI6OnNl dFNjcm9sbEZyYW1lKGludCB3aWR0aCwgaW50IGhlaWdodCwgaW50IHNjcm9sbFgsIGludCBzY3Jv bGxZKQordm9pZCBXS0NBQ0ZMYXllclJlbmRlcmVyOjpzZXRTY3JvbGxGcmFtZShjb25zdCBJbnRS ZWN0JiBzY3JvbGxGcmFtZSkKIHsKLSAgICBtX3Njcm9sbEZyYW1lV2lkdGggPSB3aWR0aDsKLSAg ICBtX3Njcm9sbEZyYW1lSGVpZ2h0ID0gaGVpZ2h0OworICAgIG1fc2Nyb2xsRnJhbWUgPSBzY3Jv bGxGcmFtZTsKIAotICAgIENHUmVjdCBjb250ZW50c1JlY3QgPSBDR1JlY3RNYWtlKHNjcm9sbFgs IHNjcm9sbFksIHdpZHRoLCBoZWlnaHQpOwotICAgIG1fc2Nyb2xsTGF5ZXItPnNldEZyYW1lKGNv bnRlbnRzUmVjdCk7CisgICAgbV9zY3JvbGxMYXllci0+c2V0Qm91bmRzKENHUmVjdE1ha2UoMCwg MCwgbV9zY3JvbGxGcmFtZS53aWR0aCgpLCBtX3Njcm9sbEZyYW1lLmhlaWdodCgpKSk7CisgICAg bV9zY3JvbGxMYXllci0+c2V0UG9zaXRpb24oQ0dQb2ludE1ha2UoMCwgbV9zY3JvbGxGcmFtZS5o ZWlnaHQoKSkpOwogCi0gICAgaWYgKG1fcm9vdENoaWxkTGF5ZXIpIHsKLSAgICAgICAgY29udGVu dHNSZWN0Lm9yaWdpbi54ID0gMDsKLSAgICAgICAgY29udGVudHNSZWN0Lm9yaWdpbi55ID0gMDsK LSAgICAgICAgbV9yb290Q2hpbGRMYXllci0+c2V0RnJhbWUoY29udGVudHNSZWN0KTsKLSAgICB9 CisgICAgaWYgKG1fcm9vdENoaWxkTGF5ZXIpCisgICAgICAgIG1fcm9vdENoaWxkTGF5ZXItPnNl dFBvc2l0aW9uKENHUG9pbnRNYWtlKG1fc2Nyb2xsRnJhbWUueCgpLCBtX3Njcm9sbEZyYW1lLmhl aWdodCgpICsgbV9zY3JvbGxGcmFtZS55KCkpKTsKIH0KIAogdm9pZCBXS0NBQ0ZMYXllclJlbmRl cmVyOjpzZXRSb290Q29udGVudHMoQ0dJbWFnZVJlZiBpbWFnZSkKQEAgLTE3OCw3ICsxNzMsOCBA QCB2b2lkIFdLQ0FDRkxheWVyUmVuZGVyZXI6OnNldFJvb3RDaGlsZExhCiAgICAgICAgIG1fc2Ny b2xsTGF5ZXItPmFkZFN1YmxheWVyKGxheWVyKTsKIAogICAgICAgICAvLyBTZXQgdGhlIGZyYW1l Ci0gICAgICAgIGxheWVyLT5zZXRGcmFtZShDR1JlY3RNYWtlKDAsIDAsIG1fc2Nyb2xsRnJhbWVX aWR0aCwgbV9zY3JvbGxGcmFtZUhlaWdodCkpOworICAgICAgICBsYXllci0+c2V0QW5jaG9yUG9p bnQoQ0dQb2ludE1ha2UoMCwgMSkpOworICAgICAgICBzZXRTY3JvbGxGcmFtZShtX3Njcm9sbEZy YW1lKTsKICAgICB9CiAKICAgICBtX3Jvb3RDaGlsZExheWVyID0gbGF5ZXI7CkBAIC0yMzIsOCAr MjI4LDExIEBAIHZvaWQgV0tDQUNGTGF5ZXJSZW5kZXJlcjo6Y3JlYXRlUmVuZGVyZXIKICAgICBt X3Jvb3RMYXllciA9IFdLQ0FDRkxheWVyOjpjcmVhdGUoV0tDQUNGTGF5ZXI6OkxheWVyKTsKICAg ICBtX3Njcm9sbExheWVyID0gV0tDQUNGTGF5ZXI6OmNyZWF0ZShXS0NBQ0ZMYXllcjo6TGF5ZXIp OwogCisgICAgLy9tX3Jvb3RMYXllci0+c2V0QW5jaG9yUG9pbnQoQ0dQb2ludE1ha2UoMCwgMSkp OworICAgIC8vQ0dQb2ludCBwb3MgPSBtX3Jvb3RMYXllci0+cG9zaXRpb24oKTsKICAgICBtX3Jv b3RMYXllci0+YWRkU3VibGF5ZXIobV9zY3JvbGxMYXllcik7CiAgICAgbV9zY3JvbGxMYXllci0+ c2V0TWFza3NUb0JvdW5kcyh0cnVlKTsKKyAgICBtX3Njcm9sbExheWVyLT5zZXRBbmNob3JQb2lu dChDR1BvaW50TWFrZSgwLCAxKSk7CiAKICNpZm5kZWYgTkRFQlVHCiAgICAgQ0dDb2xvclJlZiBk ZWJ1Z0NvbG9yID0gY3JlYXRlQ0dDb2xvcihDb2xvcigyNTUsIDAsIDAsIDIwNCkpOwpAQCAtMjg1 LDYgKzI4NCw3IEBAIHZvaWQgV0tDQUNGTGF5ZXJSZW5kZXJlcjo6cmVzaXplKCkKICAgICBpZiAo bV9yb290TGF5ZXIpIHsKICAgICAgICAgbV9yb290TGF5ZXItPnNldEZyYW1lKGJvdW5kcygpKTsK ICAgICAgICAgV0tDQUNGQ29udGV4dEZsdXNoZXI6OnNoYXJlZCgpLmZsdXNoQWxsQ29udGV4dHMo KTsKKyAgICAgICAgc2V0U2Nyb2xsRnJhbWUobV9zY3JvbGxGcmFtZSk7CiAgICAgfQogfQogCklu ZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9XS0NBQ0ZMYXllclJlbmRlcmVyLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vV0tDQUNGTGF5ZXJS ZW5kZXJlci5oCShyZXZpc2lvbiA1MzI5NykKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv d2luL1dLQ0FDRkxheWVyUmVuZGVyZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNTgsNyArNTgsNyBA QCBwdWJsaWM6CiAgICAgc3RhdGljIGJvb2wgYWNjZWxlcmF0ZWRDb21wb3NpdGluZ0F2YWlsYWJs ZSgpOwogICAgIHN0YXRpYyB2b2lkIGRpZEZsdXNoQ29udGV4dChDQUNGQ29udGV4dFJlZik7CiAK LSAgICB2b2lkIHNldFNjcm9sbEZyYW1lKGludCB3aWR0aCwgaW50IGhlaWdodCwgaW50IHNjcm9s bFgsIGludCBzY3JvbGxZKTsKKyAgICB2b2lkIHNldFNjcm9sbEZyYW1lKGNvbnN0IEludFJlY3Qm KTsKICAgICB2b2lkIHNldFJvb3RDb250ZW50cyhDR0ltYWdlUmVmKTsKICAgICB2b2lkIHNldFJv b3RDaGlsZExheWVyKFdlYkNvcmU6OlBsYXRmb3JtTGF5ZXIqIGxheWVyKTsKICAgICB2b2lkIHNl dE5lZWRzRGlzcGxheSgpOwpAQCAtOTYsNyArOTYsNyBAQCBwcml2YXRlOgogICAgIENBUmVuZGVy T0dMQ29udGV4dCogbV9yZW5kZXJlcjsKICAgICBIV05EIG1faG9zdFdpbmRvdzsKICAgICBUaW1l cjxXS0NBQ0ZMYXllclJlbmRlcmVyPiBtX3JlbmRlclRpbWVyOwotICAgIGludCBtX3Njcm9sbEZy YW1lV2lkdGgsIG1fc2Nyb2xsRnJhbWVIZWlnaHQ7CisgICAgSW50UmVjdCBtX3Njcm9sbEZyYW1l OwogfTsKIAogfQpJbmRleDogV2ViS2l0L3dpbi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDUzMzUyKQorKysgV2ViS2l0L3dpbi9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMS0xNSAgQ2hyaXMgTWFy cmluICA8Y21hcnJpbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVXNlIG5ldyBzZXRTY3JvbGxGcmFtZSBBUEkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMjc5CisKKyAgICAgICAgKiBX ZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYlZpZXc6OnVwZGF0ZVJvb3RMYXllckNvbnRlbnRzKToK KwogMjAxMC0wMS0xMiAgSm9uIEhvbmV5Y3V0dCAgPGpob25leWN1dHRAYXBwbGUuY29tPgogCiAg ICAgICAgIE1TQUE6IHNlbGVjdGVkLCBzZWxlY3RhYmxlLCBleHRlbmRlZCBzZWxlY3RhYmxlLCBh bmQgbXVsdGlwbGUKSW5kZXg6IFdlYktpdC93aW4vV2ViVmlldy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkocmV2aXNpb24gNTMyOTcpCisrKyBXZWJLaXQvd2luL1dl YlZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01OTg5LDggKzU5ODksNyBAQCB2b2lkIFdlYlZp ZXc6OnVwZGF0ZVJvb3RMYXllckNvbnRlbnRzKCkKICAgICAgICAgcmV0dXJuOwogICAgIEZyYW1l VmlldyogZnJhbWVWaWV3ID0gY29yZUZyYW1lLT52aWV3KCk7CiAKLSAgICBtX2xheWVyUmVuZGVy ZXItPnNldFNjcm9sbEZyYW1lKGZyYW1lVmlldy0+bGF5b3V0V2lkdGgoKSwgZnJhbWVWaWV3LT5s YXlvdXRIZWlnaHQoKSwgCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmcmFtZVZp ZXctPnNjcm9sbFgoKSwgZnJhbWVWaWV3LT5zY3JvbGxZKCkpOworICAgIG1fbGF5ZXJSZW5kZXJl ci0+c2V0U2Nyb2xsRnJhbWUoSW50UmVjdChmcmFtZVZpZXctPnNjcm9sbFgoKSwgZnJhbWVWaWV3 LT5zY3JvbGxZKCksIGZyYW1lVmlldy0+bGF5b3V0V2lkdGgoKSwgZnJhbWVWaWV3LT5sYXlvdXRI ZWlnaHQoKSkpOwogfQogI2VuZGlmCiAK