32273 2009-12-08 05:08:06 -0800 add ANDROID to STORE_FONT_CUSTOM_PLATFORM_DATA 2010-07-12 08:06:51 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 0 mikerreed webkit-unassigned android-webkit-unforking commit-queue jorlow steveblock webkit.review.bot oldest_to_newest 169648 0 mikerreed 2009-12-08 05:08:06 -0800 ANDROID can support STORE_FONT_CUSTOM_PLATFORM_DATA, so I am adding its platform to the list at the head of CachedFont.cpp 170761 1 44689 mikerreed 2009-12-11 07:54:03 -0800 Created attachment 44689 this fixes the issue, by adding PLATFORM(ANDROID) to the check in CachedFont.cpp 170762 2 webkit.review.bot 2009-12-11 07:56:02 -0800 style-queue ran check-webkit-style on attachment 44689 without any errors. 170767 3 44689 darin 2009-12-11 08:12:58 -0800 Comment on attachment 44689 this fixes the issue, by adding PLATFORM(ANDROID) to the check in CachedFont.cpp Change is fine. Can't land without a change log, though, so review-. 170789 4 44692 mikerreed 2009-12-11 09:37:54 -0800 Created attachment 44692 add PLATFORM(ANDROID) same as previous patch, but this one includes the ChangeLog 237359 5 ap 2010-06-12 15:51:39 -0700 This patch has been overlooked, because it isn't marked for review. Please see <http://webkit.org/coding/contributing.html> for more information. 248114 6 60860 steveblock 2010-07-08 02:54:19 -0700 Created attachment 60860 Patch 248116 7 steveblock 2010-07-08 02:55:21 -0700 Taking over this patch from Mike. 249835 8 60860 jorlow 2010-07-12 07:47:25 -0700 Comment on attachment 60860 Patch r=me 249844 9 60860 commit-queue 2010-07-12 08:06:46 -0700 Comment on attachment 60860 Patch Clearing flags on attachment: 60860 Committed r63088: <http://trac.webkit.org/changeset/63088> 249845 10 commit-queue 2010-07-12 08:06:51 -0700 All reviewed patches have been landed. Closing bug. 44689 2009-12-11 07:54:03 -0800 2010-07-08 02:54:08 -0700 this fixes the issue, by adding PLATFORM(ANDROID) to the check in CachedFont.cpp androidfontpatch.txt text/plain 651 mikerreed SW5kZXg6IFdlYkNvcmUvbG9hZGVyL0NhY2hlZEZvbnQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvbG9hZGVyL0NhY2hlZEZvbnQuY3BwCShyZXZpc2lvbiA1MTc4OSkKKysrIFdlYkNvcmUvbG9h ZGVyL0NhY2hlZEZvbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNyw3ICsyNyw3IEBACiAjaW5j bHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiQ2FjaGVkRm9udC5oIgogCi0jaWYgUExBVEZPUk0o Q0cpIHx8IFBMQVRGT1JNKFFUKSB8fCBQTEFURk9STShHVEspIHx8IChQTEFURk9STShDSFJPTUlV TSkgJiYgKFBMQVRGT1JNKFdJTl9PUykgfHwgUExBVEZPUk0oTElOVVgpKSkgfHwgUExBVEZPUk0o SEFJS1UpIHx8IFBMQVRGT1JNKFdJTkNFKQorI2lmIFBMQVRGT1JNKEFORFJPSUQpIHx8IFBMQVRG T1JNKENHKSB8fCBQTEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RLKSB8fCAoUExBVEZPUk0oQ0hS T01JVU0pICYmIChQTEFURk9STShXSU5fT1MpIHx8IFBMQVRGT1JNKExJTlVYKSkpIHx8IFBMQVRG T1JNKEhBSUtVKSB8fCBQTEFURk9STShXSU5DRSkKICNkZWZpbmUgU1RPUkVfRk9OVF9DVVNUT01f UExBVEZPUk1fREFUQQogI2VuZGlmCiAK 44692 2009-12-11 09:37:54 -0800 2010-07-08 02:54:13 -0700 add PLATFORM(ANDROID) cachedfont_patch.txt text/plain 1300 mikerreed SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTk5OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTItMTEgIE1pa2UgUmVlZCAgPG1pa2VycmVlZEBnbWFpbC5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgYWRk IFBMQVRGT1JNKEFORFJPSUQpIHRvIHRoZSBsaXN0IGlmIHBsYXRmb3JtcyB0aGF0IHN1cHBvcnQK KyAgICAgICAgU1RPUkVfRk9OVF9DVVNUT01fUExBVEZPUk1fREFUQQorICAgICAgICAKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMjczCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpIFRlc3RpbmcgaXMgZG9uZSBpbnNpZGUgdGhlIGFuZHJv aWQgZW52aXJvbm1lbnQKKworICAgICAgICAqIGxvYWRlci9DYWNoZWRGb250LmNwcDoKKwogMjAw OS0xMi0xMSAgYW50b24gbXVoaW4gIDxhbnRvbm1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBXZWJDb3JlL2xvYWRlci9DYWNoZWRGb250LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2xvYWRlci9DYWNoZWRGb250LmNwcAkocmV2aXNpb24g NTE3ODkpCisrKyBXZWJDb3JlL2xvYWRlci9DYWNoZWRGb250LmNwcAkod29ya2luZyBjb3B5KQpA QCAtMjcsNyArMjcsNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkNhY2hlZEZv bnQuaCIKIAotI2lmIFBMQVRGT1JNKENHKSB8fCBQTEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RL KSB8fCAoUExBVEZPUk0oQ0hST01JVU0pICYmIChQTEFURk9STShXSU5fT1MpIHx8IFBMQVRGT1JN KExJTlVYKSkpIHx8IFBMQVRGT1JNKEhBSUtVKSB8fCBQTEFURk9STShXSU5DRSkKKyNpZiBQTEFU Rk9STShBTkRST0lEKSB8fCBQTEFURk9STShDRykgfHwgUExBVEZPUk0oUVQpIHx8IFBMQVRGT1JN KEdUSykgfHwgKFBMQVRGT1JNKENIUk9NSVVNKSAmJiAoUExBVEZPUk0oV0lOX09TKSB8fCBQTEFU Rk9STShMSU5VWCkpKSB8fCBQTEFURk9STShIQUlLVSkgfHwgUExBVEZPUk0oV0lOQ0UpCiAjZGVm aW5lIFNUT1JFX0ZPTlRfQ1VTVE9NX1BMQVRGT1JNX0RBVEEKICNlbmRpZgogCg== 60860 2010-07-08 02:54:19 -0700 2010-07-12 08:06:46 -0700 Patch bug-32273-20100708105417.patch text/plain 1239 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Mjc3NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDctMDggIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGFkZCBBTkRST0lEIHRvIFNUT1JFX0ZPTlRfQ1VTVE9NX1BMQVRGT1JNX0RBVEEKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMjczCisKKyAgICAgICAg VGVzdGVkIGJ5IGV4aXN0aW5nIHRlc3RzLCBqdXN0IGFkZGluZyBBTkRST0lEIHRvIHRoZSBsaXN0 IG9mIHBsYXRmb3JtcyB0aGF0IHVzZSB0aGlzIGZlYXR1cmUuCisKKyAgICAgICAgKiBsb2FkZXIv Q2FjaGVkRm9udC5jcHA6CisKIDIwMTAtMDctMDcgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCkluZGV4 OiBXZWJDb3JlL2xvYWRlci9DYWNoZWRGb250LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2xv YWRlci9DYWNoZWRGb250LmNwcAkocmV2aXNpb24gNjI3NzQpCisrKyBXZWJDb3JlL2xvYWRlci9D YWNoZWRGb250LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjcsNyArMjcsNyBAQAogI2luY2x1ZGUg ImNvbmZpZy5oIgogI2luY2x1ZGUgIkNhY2hlZEZvbnQuaCIKIAotI2lmIFBMQVRGT1JNKENHKSB8 fCBQTEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RLKSB8fCAoUExBVEZPUk0oQ0hST01JVU0pICYm IChPUyhXSU5ET1dTKSB8fCBPUyhMSU5VWCkpKSB8fCBQTEFURk9STShIQUlLVSkgfHwgT1MoV0lO Q0UpCisjaWYgUExBVEZPUk0oQ0cpIHx8IFBMQVRGT1JNKFFUKSB8fCBQTEFURk9STShHVEspIHx8 IChQTEFURk9STShDSFJPTUlVTSkgJiYgKE9TKFdJTkRPV1MpIHx8IE9TKExJTlVYKSkpIHx8IFBM QVRGT1JNKEhBSUtVKSB8fCBPUyhXSU5DRSkgfHwgUExBVEZPUk0oQU5EUk9JRCkKICNkZWZpbmUg U1RPUkVfRk9OVF9DVVNUT01fUExBVEZPUk1fREFUQQogI2VuZGlmCiAK