32260 2009-12-07 17:40:24 -0800 DOMHTMLInputElement needs getter to match setAutofilled 2009-12-08 07:51:40 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sullivan sullivan webkit.review.bot oldest_to_newest 169558 0 sullivan 2009-12-07 17:40:24 -0800 DOMHTMLInputElement includes a setter, setAutofilled, for which there is no corresponding getter. This getter would be convenient in some code I'm working on. 169561 1 44453 sullivan 2009-12-07 17:41:31 -0800 Created attachment 44453 Patch to add isAutofilled to Mac and Windows WebKit 169563 2 44453 sullivan 2009-12-07 17:43:35 -0800 Comment on attachment 44453 Patch to add isAutofilled to Mac and Windows WebKit D'oh! That was the wrong patch. Please ignore. 169565 3 44454 sullivan 2009-12-07 17:46:00 -0800 Created attachment 44454 Patch to add isAutofilled to Mac and Windows WebKit 169566 4 webkit.review.bot 2009-12-07 17:50:35 -0800 style-queue ran check-webkit-style on attachment 44454 without any errors. 169567 5 44454 adachan 2009-12-07 17:57:07 -0800 Comment on attachment 44454 Patch to add isAutofilled to Mac and Windows WebKit > +HRESULT STDMETHODCALLTYPE DOMHTMLInputElement::isAutofilled( > + /* [retval][out] */ BOOL* result) > +{ > + ASSERT(m_element && m_element->hasTagName(inputTag)); Maybe separate the ASSERT into two lines? > + HTMLInputElement* inputElement = static_cast<HTMLInputElement*>(m_element); > + *result = inputElement->isAutofilled() ? TRUE : FALSE; > + return S_OK; > +} > + r=me 169663 6 sullivan 2009-12-08 07:09:02 -0800 Fixed in r51850. 169675 7 sullivan 2009-12-08 07:51:40 -0800 Oops, I forgot to split apart the assertion as suggested in the review. I'll do that as a separate patch. 44453 2009-12-07 17:41:31 -0800 2009-12-07 17:45:05 -0800 Patch to add isAutofilled to Mac and Windows WebKit isAutoFilledPatchInternal.txt text/plain 1659 sullivan SW5kZXg6IFNhZmFyaS9QbGF0Zm9ybS9TRE9NSFRNTElucHV0RWxlbWVudC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNhZmFyaS9QbGF0Zm9ybS9TRE9NSFRNTElucHV0RWxlbWVudC5oCShyZXZpc2lvbiAyNjcy MCkKKysrIFNhZmFyaS9QbGF0Zm9ybS9TRE9NSFRNTElucHV0RWxlbWVudC5oCSh3b3JraW5nIGNv cHkpCkBAIC00Miw2ICs0Miw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgc2VsZWN0KCk7CiAgICAg dm9pZCBzZXRBdXRvRmlsbGVkKGJvb2wpOworICAgIGJvb2wgaXNBdXRvRmlsbGVkKCkgY29uc3Q7 CiAKICAgICBTU3RyaW5nIHZhbHVlKCkgY29uc3Q7CiAgICAgdm9pZCBzZXRWYWx1ZShjb25zdCBT U3RyaW5nJik7CkluZGV4OiBTYWZhcmkvUGxhdGZvcm0vU0RPTUhUTUxJbnB1dEVsZW1lbnRNYWMu bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU2FmYXJpL1BsYXRmb3JtL1NET01IVE1MSW5wdXRFbGVtZW50TWFj Lm1tCShyZXZpc2lvbiAyNjcyMCkKKysrIFNhZmFyaS9QbGF0Zm9ybS9TRE9NSFRNTElucHV0RWxl bWVudE1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtOTIsNiArOTIsMTQgQEAgdm9pZCBTRE9NSFRN TElucHV0RWxlbWVudDo6c2V0QXV0b0ZpbGxlZAogICAgIFtlbGVtZW50IF9zZXRBdXRvZmlsbGVk Om5ld1ZhbHVlXTsKIH0KIAorYm9vbCBTRE9NSFRNTElucHV0RWxlbWVudDo6aXNBdXRvRmlsbGVk KCkgY29uc3QKK3sKKyAgICBpZiAoaXNOdWxsKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAg ICAKKyAgICByZXR1cm4gW2tpdCgpIF9pc0F1dG9maWxsZWRdOworfQorCiB2b2lkIFNET01IVE1M SW5wdXRFbGVtZW50OjpzZXRWYWx1ZShjb25zdCBTU3RyaW5nJiBuZXdWYWx1ZSkKIHsKICAgICBE T01IVE1MSW5wdXRFbGVtZW50ICplbGVtZW50ID0ga2l0KCk7CkluZGV4OiBTYWZhcmkvUGxhdGZv cm0vd2luL1NET01IVE1MSW5wdXRFbGVtZW50V2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTYWZhcmkv UGxhdGZvcm0vd2luL1NET01IVE1MSW5wdXRFbGVtZW50V2luLmNwcAkocmV2aXNpb24gMjY3MjAp CisrKyBTYWZhcmkvUGxhdGZvcm0vd2luL1NET01IVE1MSW5wdXRFbGVtZW50V2luLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNjksNiArNjksMTEgQEAgdm9pZCBTRE9NSFRNTElucHV0RWxlbWVudDo6 c2V0QXV0b0ZpbGxlZAogICAgIGNhbGwoa2l0KCksICZJRm9ybXNBdXRvRmlsbFRyYW5zaXRpb246 OnNldEF1dG9maWxsZWQsIG5ld1ZhbHVlKTsKIH0KIAorYm9vbCBTRE9NSFRNTElucHV0RWxlbWVu dDo6aXNBdXRvRmlsbGVkKCkgY29uc3QKK3sKKyAgICByZXR1cm4gY2FsbEdldHRlcihraXQoKSwg JklGb3Jtc0F1dG9GaWxsVHJhbnNpdGlvbjo6aXNBdXRvZmlsbGVkKTsKK30KKyAgICAKIHZvaWQg U0RPTUhUTUxJbnB1dEVsZW1lbnQ6OnNldFZhbHVlKGNvbnN0IFNTdHJpbmcmIG5ld1ZhbHVlKQog ewogICAgIGNhbGwoa2l0KCksICZJRE9NSFRNTElucHV0RWxlbWVudDo6c2V0VmFsdWUsIG5ld1Zh bHVlKTsK 44454 2009-12-07 17:46:00 -0800 2009-12-07 17:57:06 -0800 Patch to add isAutofilled to Mac and Windows WebKit isAutoFilledPatchOpenSource.txt text/plain 4093 sullivan SW5kZXg6IFdlYkNvcmUvYmluZGluZ3Mvb2JqYy9ET01IVE1MLm1tCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvYmluZGluZ3Mvb2JqYy9ET01IVE1MLm1tCShyZXZpc2lvbiA1MTY5NykKKysrIFdlYkNv cmUvYmluZGluZ3Mvb2JqYy9ET01IVE1MLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xNDAsNyArMTQw LDEyIEBACiAgICAgICAgIHJldHVybiBOU01ha2VSYW5nZShzdGFydCwgZW5kIC0gc3RhcnQpOyAK ICAgICB9CiAgICAgcmV0dXJuIE5TTWFrZVJhbmdlKE5TTm90Rm91bmQsIDApOwotfSAgICAKK30K KworLSAoQk9PTClfaXNBdXRvZmlsbGVkCit7CisgICAgcmV0dXJuIGNvcmUoc2VsZiktPmlzQXV0 b2ZpbGxlZCgpOworfQogCiAtICh2b2lkKV9zZXRBdXRvZmlsbGVkOihCT09MKWZpbGxlZAogewpJ bmRleDogV2ViQ29yZS9iaW5kaW5ncy9vYmpjL0RPTVByaXZhdGUuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL2JpbmRpbmdzL29iamMvRE9NUHJpdmF0ZS5oCShyZXZpc2lvbiA1MTY5NykKKysrIFdl YkNvcmUvYmluZGluZ3Mvb2JqYy9ET01Qcml2YXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTY3LDEw ICs2NywxMCBAQAogQGVuZAogCiAvLyBBbGwgdGhlIG1ldGhvZHMgaW4gdGhpcyBjYXRlZ29yeSBh cmUgdXNlZCBieSBTYWZhcmkgZm9ybXMgYXV0b2ZpbGwgYW5kIHNob3VsZCBub3QgYmUgdXNlZCBm b3IgYW55IG90aGVyIHB1cnBvc2UuCi0vLyBUaGV5IGFyZSBzdG9wZ2FwIG1lYXN1cmVzIHVudGls IHdlIGZpbmlzaCB0cmFuc2l0aW9uaW5nIGZvcm0gY29udHJvbHMgdG8gbm90IHVzZSBOU1ZpZXcu IEVhY2ggb25lIHNob3VsZCBiZWNvbWUKLS8vIHJlcGxhY2VhYmxlIGJ5IHB1YmxpYyBET00gQVBJ LCBhbmQgd2hlbiB0aGF0IGhhcHBlbnMgU2FmYXJpIHdpbGwgc3dpdGNoIHRvIGltcGxlbWVudGF0 aW9ucyB1c2luZyB0aGF0IHB1YmxpYyBBUEksCi0vLyBhbmQgdGhlc2Ugd2lsbCBiZSBkZWxldGVk LgorLy8gRWFjaCBvbmUgc2hvdWxkIGV2ZW50dWFsbHkgYmUgcmVwbGFjZWQgYnkgcHVibGljIERP TSBBUEksIGFuZCB3aGVuIHRoYXQgaGFwcGVucyBTYWZhcmkgd2lsbCBzd2l0Y2ggdG8gaW1wbGVt ZW50YXRpb25zIAorLy8gdXNpbmcgdGhhdCBwdWJsaWMgQVBJLCBhbmQgdGhlc2Ugd2lsbCBiZSBk ZWxldGVkLgogQGludGVyZmFjZSBET01IVE1MSW5wdXRFbGVtZW50IChGb3Jtc0F1dG9GaWxsVHJh bnNpdGlvbikKKy0gKEJPT0wpX2lzQXV0b2ZpbGxlZDsKIC0gKEJPT0wpX2lzVGV4dEZpZWxkOwog LSAoTlNSZWN0KV9yZWN0T25TY3JlZW47IC8vIGJvdW5kaW5nIGJveCBvZiB0aGUgdGV4dCBmaWVs ZCwgaW4gc2NyZWVuIGNvb3JkaW5hdGVzCiAtICh2b2lkKV9yZXBsYWNlQ2hhcmFjdGVyc0luUmFu Z2U6KE5TUmFuZ2UpdGFyZ2V0UmFuZ2Ugd2l0aFN0cmluZzooTlNTdHJpbmcgKilyZXBsYWNlbWVu dFN0cmluZyBzZWxlY3RpbmdGcm9tSW5kZXg6KGludClpbmRleDsKSW5kZXg6IFdlYktpdC93aW4v RE9NSFRNTENsYXNzZXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vRE9NSFRNTENsYXNz ZXMuY3BwCShyZXZpc2lvbiA1MTY5NykKKysrIFdlYktpdC93aW4vRE9NSFRNTENsYXNzZXMuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xMzU3LDYgKzEzNTcsMTUgQEAgSFJFU1VMVCBTVERNRVRIT0RD QUxMVFlQRSBET01IVE1MSW5wdXRFbAogICAgIHJldHVybiBTX09LOwogfQogCitIUkVTVUxUIFNU RE1FVEhPRENBTExUWVBFIERPTUhUTUxJbnB1dEVsZW1lbnQ6OmlzQXV0b2ZpbGxlZCgKKyAgICAv KiBbcmV0dmFsXVtvdXRdICovIEJPT0wqIHJlc3VsdCkKK3sKKyAgICBBU1NFUlQobV9lbGVtZW50 ICYmIG1fZWxlbWVudC0+aGFzVGFnTmFtZShpbnB1dFRhZykpOworICAgIEhUTUxJbnB1dEVsZW1l bnQqIGlucHV0RWxlbWVudCA9IHN0YXRpY19jYXN0PEhUTUxJbnB1dEVsZW1lbnQqPihtX2VsZW1l bnQpOworICAgICpyZXN1bHQgPSBpbnB1dEVsZW1lbnQtPmlzQXV0b2ZpbGxlZCgpID8gVFJVRSA6 IEZBTFNFOworICAgIHJldHVybiBTX09LOworfQorCiAvLyBET01IVE1MSW5wdXRFbGVtZW50IC0t IElGb3JtUHJvbXB0QWRkaXRpb25zIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQogCiBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIERPTUhUTUxJbnB1dEVsZW1lbnQ6OmlzVXNl ckVkaXRlZCggCkluZGV4OiBXZWJLaXQvd2luL0RPTUhUTUxDbGFzc2VzLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViS2l0L3dpbi9ET01IVE1MQ2xhc3Nlcy5oCShyZXZpc2lvbiA1MTY5NykKKysrIFdlYktp dC93aW4vRE9NSFRNTENsYXNzZXMuaAkod29ya2luZyBjb3B5KQpAQCAtMjAyMCw2ICsyMDIwLDkg QEAgcHVibGljOgogICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBzZXRBdXRv ZmlsbGVkKCAKICAgICAgICAgLyogW2luXSAqLyBCT09MIGZpbGxlZCk7CiAKKyAgICB2aXJ0dWFs IEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgaXNBdXRvZmlsbGVkKAorICAgICAgICAvKiBbcmV0 dmFsXVtvdXRdICovIEJPT0wgKnJlc3VsdCk7CisgICAgCiAgICAgLy8gSUZvcm1Qcm9tcHRBZGRp dGlvbnMKICAgICB2aXJ0dWFsIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgaXNVc2VyRWRpdGVk KCAKICAgICAgICAgLyogW3JldHZhbF1bb3V0XSAqLyBCT09MICpyZXN1bHQpOwpJbmRleDogV2Vi S2l0L3dpbi9JbnRlcmZhY2VzL0RPTVByaXZhdGUuaWRsCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93 aW4vSW50ZXJmYWNlcy9ET01Qcml2YXRlLmlkbAkocmV2aXNpb24gNTE2OTcpCisrKyBXZWJLaXQv d2luL0ludGVyZmFjZXMvRE9NUHJpdmF0ZS5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTUxLDkgKzUx LDggQEAgaW50ZXJmYWNlIElET01FbGVtZW50UHJpdmF0ZSA6IElVbmtub3duCiAKIC8qCiAgICAg QWxsIHRoZSBtZXRob2RzIGluIHRoaXMgY2F0ZWdvcnkgYXJlIHVzZWQgYnkgU2FmYXJpIGZvcm1z IGF1dG9maWxsIGFuZCBzaG91bGQgbm90IGJlIHVzZWQgZm9yIGFueSBvdGhlciBwdXJwb3NlLgot ICAgIFRoZXkgYXJlIHN0b3BnYXAgbWVhc3VyZXMgdW50aWwgd2UgZmluaXNoIHRyYW5zaXRpb25p bmcgZm9ybSBjb250cm9scyB0byBub3QgdXNlIE5TVmlldy4gRWFjaCBvbmUgc2hvdWxkIGJlY29t ZQotICAgIHJlcGxhY2VhYmxlIGJ5IHB1YmxpYyBET00gQVBJLCBhbmQgd2hlbiB0aGF0IGhhcHBl bnMgU2FmYXJpIHdpbGwgc3dpdGNoIHRvIGltcGxlbWVudGF0aW9ucyB1c2luZyB0aGF0IHB1Ymxp YyBBUEksCi0gICAgYW5kIHRoZXNlIHdpbGwgYmUgZGVsZXRlZC4KKyAgICBFYWNoIG9uZSBzaG91 bGQgZXZlbnR1YWxseSBiZSByZXBsYWNlZCBieSBwdWJsaWMgRE9NIEFQSSwgYW5kIHdoZW4gdGhh dCBoYXBwZW5zIFNhZmFyaSB3aWxsIHN3aXRjaCB0byBpbXBsZW1lbnRhdGlvbnMgCisgICAgdXNp bmcgdGhhdCBwdWJsaWMgQVBJLCBhbmQgdGhlc2Ugd2lsbCBiZSBkZWxldGVkLgogCiAgICAgQGlu dGVyZmFjZSBET01IVE1MSW5wdXRFbGVtZW50KEZvcm1zQXV0b0ZpbGxUcmFuc2l0aW9uKQogKi8K QEAgLTg5LDYgKzg4LDExIEBAIGludGVyZmFjZSBJRm9ybXNBdXRvRmlsbFRyYW5zaXRpb24gOiBJ VW4KICAgICAgICAgLSAodm9pZClfc2V0QXV0b2ZpbGxlZDooQk9PTClmaWxsZWQ7CiAgICAgKi8K ICAgICBIUkVTVUxUIHNldEF1dG9maWxsZWQoW2luXSBCT09MIGZpbGxlZCk7CisKKyAgICAvKgor ICAgICAgICAtIChCT09MKV9pc0F1dG9maWxsZWQ7CisgICAgKi8KKyAgICBIUkVTVUxUIGlzQXV0 b2ZpbGxlZChbb3V0LCByZXR2YWxdIEJPT0wqIHJlc3VsdCk7CiB9CiAKIC8qCg==