32248 2009-12-07 14:42:12 -0800 [Chromium]: Issue with setting selection 2009-12-07 17:22:36 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 finnur.webkit webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 169474 0 finnur.webkit 2009-12-07 14:42:12 -0800 Chromium has some issues where the Find in page is not always starting from the right point after you close the Find session. This is described in this bug: http://code.google.com/p/chromium/issues/detail?id=27910 Basically, a fix was put in for a nasty focus issue for Gmail where we set the selection to 0,0. This is supposed to be done for content-editable fields only, but was not restricted to content-editable fields. Now it is. We otherwise end up setting the selection to 0,0 more often than needed, which can in certain scenarios confuse the find algorithm into thinking the user messed with the selection during runs. On a related note, I also noticed that Find isn't setting the selection when we end the Find session anymore (will follow this patch up with a browser test to catch this in the future). 169483 1 44435 finnur.webkit 2009-12-07 14:54:17 -0800 Created attachment 44435 Fix for Chromium issue http://crbug.com/27910 169485 2 webkit.review.bot 2009-12-07 14:59:30 -0800 style-queue ran check-webkit-style on attachment 44435 without any errors. 169487 3 44435 ojan 2009-12-07 15:04:46 -0800 Comment on attachment 44435 Fix for Chromium issue http://crbug.com/27910 > Index: WebKit/chromium/src/WebFrameImpl.cpp > =================================================================== > --- WebKit/chromium/src/WebFrameImpl.cpp (revision 51798) > +++ WebKit/chromium/src/WebFrameImpl.cpp (working copy) > @@ -1669,6 +1669,7 @@ void WebFrameImpl::setFindEndstateFocusA > + // No node related to the active match was focusable, so set the > + // active match as the selection (so that when you end the Find session, > + // you'll have the last thing you found highlighted) and make sure that > + // we have nothing focused (otherwise you might have text selected but > + // a link focused, which is weird). > + frame()->selection()->setSelection(m_activeMatch.get()); > + frame()->document()->setFocusedNode(0); Doesn't setSelection already set the focus appropriately? e.g. if you set the selection to some text inside a link, shouldn't the link be focused? 169492 4 finnur.webkit 2009-12-07 15:12:30 -0800 The intent here is to have the whole link appear with the focus ring around it (consistent with Firefox) and be able to press Enter to navigate to that url. If I just do the selection part, and search for a partial text match within a link, then that partial match gets highlighted when I close the box, no focus ring appears and pressing Enter does nothing. 169513 5 44435 fishd 2009-12-07 15:58:34 -0800 Comment on attachment 44435 Fix for Chromium issue http://crbug.com/27910 Since the WebKit bug links to the Chromium bug, I think it is sufficient to just include the WebKit bug link in the ChangeLog. > Index: WebKit/chromium/src/WebFrameImpl.cpp ... > if (node && node != frame()->document()) { > // Found a focusable parent node. Set focus to it. > frame()->document()->setFocusedNode(node); > + return; > } else { nit: now that have the return statement, please remove the else statement so that you can reduce the indentation of the following code. R=me otherwise. 169520 6 44443 finnur.webkit 2009-12-07 16:17:40 -0800 Created attachment 44443 Addressed review comments 169552 7 44443 commit-queue 2009-12-07 17:22:32 -0800 Comment on attachment 44443 Addressed review comments Clearing flags on attachment: 44443 Committed r51818: <http://trac.webkit.org/changeset/51818> 169553 8 commit-queue 2009-12-07 17:22:36 -0800 All reviewed patches have been landed. Closing bug. 44435 2009-12-07 14:54:17 -0800 2009-12-07 16:17:40 -0800 Fix for Chromium issue http://crbug.com/27910 patch.txt text/plain 3695 finnur.webkit SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTE3OTgpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDktMTItMDcgIEZpbm51 ciBUaG9yYXJpbnNzb24gIDxmaW5udXIud2Via2l0QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBIHBhdGNoIGZvciBDaHJvbWl1bSB0 byByZXN0cmljdCB0aGUgc2NvcGUgb2YgdGhlIEdtYWlsIGZvY3VzIGZpeCwKKyAgICAgICAgd2hl cmUgd2Ugc2V0IHRoZSBTZWxlY3Rpb24gdG8gMCwwIGZvciBjb250ZW50LWVkaXRhYmxlIGZpZWxk cyBhbmQKKyAgICAgICAgYWxzbyBtYWtlIHN1cmUgd2Ugc2V0IHRoZSBzZWxlY3Rpb24gZW5kLXN0 YXRlIGZvciBmaW5kIHRvIHNlbGVjdCB0aGUKKyAgICAgICAgdGV4dCBmb3VuZCAod2hlbiBub3Qg Zm9jdXNpbmcgYSBsaW5rIHdlIGZvdW5kKS4KKyAgICAgICAgVGhpcyBmaXhlcyBDaHJvbWl1bSBi dWc6IAorICAgICAgICBodHRwOi8vY29kZS5nb29nbGUuY29tL3AvY2hyb21pdW0vaXNzdWVzL2Rl dGFpbD9pZD0yNzkxMAorICAgICAgICBXZWJLaXQgYnVnOiBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzIyNDgKKworICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUltcGw6OnNldEZpbmRFbmRzdGF0ZUZvY3VzQW5k U2VsZWN0aW9uKToKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJWaWV3SW1wbDo6c2V0Rm9jdXMpOgorCiAyMDA5LTEyLTA3ICBZYWFyIFNjaG5pdG1h biAgPHlhYXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hl ci4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAJKHJldmlzaW9uIDUxNzk4 KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xNjY5LDYgKzE2NjksNyBAQCB2b2lkIFdlYkZyYW1lSW1wbDo6c2V0RmluZEVuZHN0YXRl Rm9jdXNBCiAgICAgICAgIGlmIChub2RlICYmIG5vZGUgIT0gZnJhbWUoKS0+ZG9jdW1lbnQoKSkg ewogICAgICAgICAgICAgLy8gRm91bmQgYSBmb2N1c2FibGUgcGFyZW50IG5vZGUuIFNldCBmb2N1 cyB0byBpdC4KICAgICAgICAgICAgIGZyYW1lKCktPmRvY3VtZW50KCktPnNldEZvY3VzZWROb2Rl KG5vZGUpOworICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAg ICAgLy8gSXRlcmF0ZSBvdmVyIGFsbCB0aGUgbm9kZXMgaW4gdGhlIHJhbmdlIHVudGlsIHdlIGZp bmQgYSBmb2N1c2FibGUgbm9kZS4KICAgICAgICAgICAgIC8vIFRoaXMsIGZvciBleGFtcGxlLCBz ZXRzIGZvY3VzIHRvIHRoZSBmaXJzdCBsaW5rIGlmIHlvdSBzZWFyY2ggZm9yCkBAIC0xNjc3LDEx ICsxNjc4LDE5IEBAIHZvaWQgV2ViRnJhbWVJbXBsOjpzZXRGaW5kRW5kc3RhdGVGb2N1c0EKICAg ICAgICAgICAgIHdoaWxlIChub2RlICYmIG5vZGUgIT0gbV9hY3RpdmVNYXRjaC0+cGFzdExhc3RO b2RlKCkpIHsKICAgICAgICAgICAgICAgICBpZiAobm9kZS0+aXNGb2N1c2FibGUoKSkgewogICAg ICAgICAgICAgICAgICAgICBmcmFtZSgpLT5kb2N1bWVudCgpLT5zZXRGb2N1c2VkTm9kZShub2Rl KTsKLSAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgICAgIHJldHVy bjsKICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgbm9kZSA9IG5vZGUtPnRyYXZl cnNlTmV4dE5vZGUoKTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQorCisgICAgICAgIC8vIE5v IG5vZGUgcmVsYXRlZCB0byB0aGUgYWN0aXZlIG1hdGNoIHdhcyBmb2N1c2FibGUsIHNvIHNldCB0 aGUKKyAgICAgICAgLy8gYWN0aXZlIG1hdGNoIGFzIHRoZSBzZWxlY3Rpb24gKHNvIHRoYXQgd2hl biB5b3UgZW5kIHRoZSBGaW5kIHNlc3Npb24sCisgICAgICAgIC8vIHlvdSdsbCBoYXZlIHRoZSBs YXN0IHRoaW5nIHlvdSBmb3VuZCBoaWdobGlnaHRlZCkgYW5kIG1ha2Ugc3VyZSB0aGF0CisgICAg ICAgIC8vIHdlIGhhdmUgbm90aGluZyBmb2N1c2VkIChvdGhlcndpc2UgeW91IG1pZ2h0IGhhdmUg dGV4dCBzZWxlY3RlZCBidXQKKyAgICAgICAgLy8gYSBsaW5rIGZvY3VzZWQsIHdoaWNoIGlzIHdl aXJkKS4KKyAgICAgICAgZnJhbWUoKS0+c2VsZWN0aW9uKCktPnNldFNlbGVjdGlvbihtX2FjdGl2 ZU1hdGNoLmdldCgpKTsKKyAgICAgICAgZnJhbWUoKS0+ZG9jdW1lbnQoKS0+c2V0Rm9jdXNlZE5v ZGUoMCk7CiAgICAgfQogfQogCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBs LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAko cmV2aXNpb24gNTE3OTgpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAko d29ya2luZyBjb3B5KQpAQCAtOTI1LDExICs5MjUsMTEgQEAgdm9pZCBXZWJWaWV3SW1wbDo6c2V0 Rm9jdXMoYm9vbCBlbmFibGUpCiAgICAgICAgICAgICAgICAgRWxlbWVudCogZWxlbWVudCA9IHN0 YXRpY19jYXN0PEVsZW1lbnQqPihmb2N1c2VkTm9kZSk7CiAgICAgICAgICAgICAgICAgaWYgKGVs ZW1lbnQtPmlzVGV4dEZvcm1Db250cm9sKCkpCiAgICAgICAgICAgICAgICAgICAgIGVsZW1lbnQt PnVwZGF0ZUZvY3VzQXBwZWFyYW5jZSh0cnVlKTsKLSAgICAgICAgICAgICAgICBlbHNlIHsKKyAg ICAgICAgICAgICAgICBlbHNlIGlmIChmb2N1c2VkTm9kZS0+aXNDb250ZW50RWRpdGFibGUoKSkg ewogICAgICAgICAgICAgICAgICAgICAvLyB1cGRhdGVGb2N1c0FwcGVhcmFuY2UoKSBzZWxlY3Rz IGFsbCB0aGUgdGV4dCBvZgogICAgICAgICAgICAgICAgICAgICAvLyBjb250ZW50c2VkaXRhYmxl IERJVnMuIFNvIHdlIHNldCB0aGUgc2VsZWN0aW9uIGV4cGxpY2l0bHkKICAgICAgICAgICAgICAg ICAgICAgLy8gaW5zdGVhZC4gTm90ZSB0aGF0IHRoaXMgaGFzIHRoZSBzaWRlIGVmZmVjdCBvZiBt b3ZpbmcgdGhlCi0gICAgICAgICAgICAgICAgICAgIC8vIGNhcmV0IGJhY2sgdG8gdGhlIGJlZ2lu aW5nIG9mIHRoZSB0ZXh0LgorICAgICAgICAgICAgICAgICAgICAvLyBjYXJldCBiYWNrIHRvIHRo ZSBiZWdpbm5pbmcgb2YgdGhlIHRleHQuCiAgICAgICAgICAgICAgICAgICAgIFBvc2l0aW9uIHBv c2l0aW9uKGZvY3VzZWROb2RlLCAwLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBQb3NpdGlvbjo6UG9zaXRpb25Jc09mZnNldEluQW5jaG9yKTsKICAgICAgICAgICAgICAg ICAgICAgZm9jdXNlZEZyYW1lLT5zZWxlY3Rpb24oKS0+c2V0U2VsZWN0aW9uKAo= 44443 2009-12-07 16:17:40 -0800 2009-12-07 17:22:32 -0800 Addressed review comments patch2.txt text/plain 4129 finnur.webkit SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTE3OTgpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMTItMDcgIEZpbm51 ciBUaG9yYXJpbnNzb24gIDxmaW5udXIud2Via2l0QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBIHBhdGNoIGZvciBDaHJvbWl1bSB0 byByZXN0cmljdCB0aGUgc2NvcGUgb2YgdGhlIEdtYWlsIGZvY3VzIGZpeCwKKyAgICAgICAgd2hl cmUgd2Ugc2V0IHRoZSBTZWxlY3Rpb24gdG8gMCwwIGZvciBjb250ZW50LWVkaXRhYmxlIGZpZWxk cyBhbmQKKyAgICAgICAgYWxzbyBtYWtlIHN1cmUgd2Ugc2V0IHRoZSBzZWxlY3Rpb24gZW5kLXN0 YXRlIGZvciBmaW5kIHRvIHNlbGVjdCB0aGUKKyAgICAgICAgdGV4dCBmb3VuZCAod2hlbiBub3Qg Zm9jdXNpbmcgYSBsaW5rIHdlIGZvdW5kKS4KKyAgICAgICAgV2ViS2l0IGJ1ZzogaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMjQ4CisKKyAgICAgICAgKiBzcmMvV2Vi RnJhbWVJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWVJbXBsOjpzZXRGaW5kRW5k c3RhdGVGb2N1c0FuZFNlbGVjdGlvbik6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OnNldEZvY3VzKToKKwogMjAwOS0xMi0wNyAg WWFhciBTY2huaXRtYW4gIDx5YWFyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBGaXNoZXIuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCShy ZXZpc2lvbiA1MTc5OCkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTY2OSwxOSArMTY2OSwyOCBAQCB2b2lkIFdlYkZyYW1lSW1wbDo6 c2V0RmluZEVuZHN0YXRlRm9jdXNBCiAgICAgICAgIGlmIChub2RlICYmIG5vZGUgIT0gZnJhbWUo KS0+ZG9jdW1lbnQoKSkgewogICAgICAgICAgICAgLy8gRm91bmQgYSBmb2N1c2FibGUgcGFyZW50 IG5vZGUuIFNldCBmb2N1cyB0byBpdC4KICAgICAgICAgICAgIGZyYW1lKCktPmRvY3VtZW50KCkt PnNldEZvY3VzZWROb2RlKG5vZGUpOwotICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgLy8g SXRlcmF0ZSBvdmVyIGFsbCB0aGUgbm9kZXMgaW4gdGhlIHJhbmdlIHVudGlsIHdlIGZpbmQgYSBm b2N1c2FibGUgbm9kZS4KLSAgICAgICAgICAgIC8vIFRoaXMsIGZvciBleGFtcGxlLCBzZXRzIGZv Y3VzIHRvIHRoZSBmaXJzdCBsaW5rIGlmIHlvdSBzZWFyY2ggZm9yCi0gICAgICAgICAgICAvLyB0 ZXh0IGFuZCB0ZXh0IHRoYXQgaXMgd2l0aGluIG9uZSBvciBtb3JlIGxpbmtzLgotICAgICAgICAg ICAgbm9kZSA9IG1fYWN0aXZlTWF0Y2gtPmZpcnN0Tm9kZSgpOwotICAgICAgICAgICAgd2hpbGUg KG5vZGUgJiYgbm9kZSAhPSBtX2FjdGl2ZU1hdGNoLT5wYXN0TGFzdE5vZGUoKSkgewotICAgICAg ICAgICAgICAgIGlmIChub2RlLT5pc0ZvY3VzYWJsZSgpKSB7Ci0gICAgICAgICAgICAgICAgICAg IGZyYW1lKCktPmRvY3VtZW50KCktPnNldEZvY3VzZWROb2RlKG5vZGUpOwotICAgICAgICAgICAg ICAgICAgICBicmVhazsKLSAgICAgICAgICAgICAgICB9Ci0gICAgICAgICAgICAgICAgbm9kZSA9 IG5vZGUtPnRyYXZlcnNlTmV4dE5vZGUoKTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAg fQorCisgICAgICAgIC8vIEl0ZXJhdGUgb3ZlciBhbGwgdGhlIG5vZGVzIGluIHRoZSByYW5nZSB1 bnRpbCB3ZSBmaW5kIGEgZm9jdXNhYmxlIG5vZGUuCisgICAgICAgIC8vIFRoaXMsIGZvciBleGFt cGxlLCBzZXRzIGZvY3VzIHRvIHRoZSBmaXJzdCBsaW5rIGlmIHlvdSBzZWFyY2ggZm9yCisgICAg ICAgIC8vIHRleHQgYW5kIHRleHQgdGhhdCBpcyB3aXRoaW4gb25lIG9yIG1vcmUgbGlua3MuCisg ICAgICAgIG5vZGUgPSBtX2FjdGl2ZU1hdGNoLT5maXJzdE5vZGUoKTsKKyAgICAgICAgd2hpbGUg KG5vZGUgJiYgbm9kZSAhPSBtX2FjdGl2ZU1hdGNoLT5wYXN0TGFzdE5vZGUoKSkgeworICAgICAg ICAgICAgaWYgKG5vZGUtPmlzRm9jdXNhYmxlKCkpIHsKKyAgICAgICAgICAgICAgICBmcmFtZSgp LT5kb2N1bWVudCgpLT5zZXRGb2N1c2VkTm9kZShub2RlKTsKKyAgICAgICAgICAgICAgICByZXR1 cm47CiAgICAgICAgICAgICB9CisgICAgICAgICAgICBub2RlID0gbm9kZS0+dHJhdmVyc2VOZXh0 Tm9kZSgpOwogICAgICAgICB9CisKKyAgICAgICAgLy8gTm8gbm9kZSByZWxhdGVkIHRvIHRoZSBh Y3RpdmUgbWF0Y2ggd2FzIGZvY3VzYWJsZSwgc28gc2V0IHRoZQorICAgICAgICAvLyBhY3RpdmUg bWF0Y2ggYXMgdGhlIHNlbGVjdGlvbiAoc28gdGhhdCB3aGVuIHlvdSBlbmQgdGhlIEZpbmQgc2Vz c2lvbiwKKyAgICAgICAgLy8geW91J2xsIGhhdmUgdGhlIGxhc3QgdGhpbmcgeW91IGZvdW5kIGhp Z2hsaWdodGVkKSBhbmQgbWFrZSBzdXJlIHRoYXQKKyAgICAgICAgLy8gd2UgaGF2ZSBub3RoaW5n IGZvY3VzZWQgKG90aGVyd2lzZSB5b3UgbWlnaHQgaGF2ZSB0ZXh0IHNlbGVjdGVkIGJ1dAorICAg ICAgICAvLyBhIGxpbmsgZm9jdXNlZCwgd2hpY2ggaXMgd2VpcmQpLgorICAgICAgICBmcmFtZSgp LT5zZWxlY3Rpb24oKS0+c2V0U2VsZWN0aW9uKG1fYWN0aXZlTWF0Y2guZ2V0KCkpOworICAgICAg ICBmcmFtZSgpLT5kb2N1bWVudCgpLT5zZXRGb2N1c2VkTm9kZSgwKTsKICAgICB9CiB9CiAKSW5k ZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCShyZXZpc2lvbiA1MTc5OCkKKysrIFdl YktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05MjUs MTEgKzkyNSwxMSBAQCB2b2lkIFdlYlZpZXdJbXBsOjpzZXRGb2N1cyhib29sIGVuYWJsZSkKICAg ICAgICAgICAgICAgICBFbGVtZW50KiBlbGVtZW50ID0gc3RhdGljX2Nhc3Q8RWxlbWVudCo+KGZv Y3VzZWROb2RlKTsKICAgICAgICAgICAgICAgICBpZiAoZWxlbWVudC0+aXNUZXh0Rm9ybUNvbnRy b2woKSkKICAgICAgICAgICAgICAgICAgICAgZWxlbWVudC0+dXBkYXRlRm9jdXNBcHBlYXJhbmNl KHRydWUpOwotICAgICAgICAgICAgICAgIGVsc2UgeworICAgICAgICAgICAgICAgIGVsc2UgaWYg KGZvY3VzZWROb2RlLT5pc0NvbnRlbnRFZGl0YWJsZSgpKSB7CiAgICAgICAgICAgICAgICAgICAg IC8vIHVwZGF0ZUZvY3VzQXBwZWFyYW5jZSgpIHNlbGVjdHMgYWxsIHRoZSB0ZXh0IG9mCiAgICAg ICAgICAgICAgICAgICAgIC8vIGNvbnRlbnRzZWRpdGFibGUgRElWcy4gU28gd2Ugc2V0IHRoZSBz ZWxlY3Rpb24gZXhwbGljaXRseQogICAgICAgICAgICAgICAgICAgICAvLyBpbnN0ZWFkLiBOb3Rl IHRoYXQgdGhpcyBoYXMgdGhlIHNpZGUgZWZmZWN0IG9mIG1vdmluZyB0aGUKLSAgICAgICAgICAg ICAgICAgICAgLy8gY2FyZXQgYmFjayB0byB0aGUgYmVnaW5pbmcgb2YgdGhlIHRleHQuCisgICAg ICAgICAgICAgICAgICAgIC8vIGNhcmV0IGJhY2sgdG8gdGhlIGJlZ2lubmluZyBvZiB0aGUgdGV4 dC4KICAgICAgICAgICAgICAgICAgICAgUG9zaXRpb24gcG9zaXRpb24oZm9jdXNlZE5vZGUsIDAs CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBvc2l0aW9uOjpQb3NpdGlv bklzT2Zmc2V0SW5BbmNob3IpOwogICAgICAgICAgICAgICAgICAgICBmb2N1c2VkRnJhbWUtPnNl bGVjdGlvbigpLT5zZXRTZWxlY3Rpb24oCg==