32235 2009-12-07 11:49:25 -0800 Chromium buildbots are not red when they fail 2009-12-07 13:52:36 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yaar webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 169410 0 yaar 2009-12-07 11:49:25 -0800 Error returns code are not properly processed. 169426 1 44424 yaar 2009-12-07 12:31:13 -0800 Created attachment 44424 make buildbot red when checkout and compile fail 169429 2 webkit.review.bot 2009-12-07 12:34:34 -0800 style-queue ran check-webkit-style on attachment 44424 without any errors. 169430 3 44424 commit-queue 2009-12-07 12:42:55 -0800 Comment on attachment 44424 make buildbot red when checkout and compile fail Rejecting patch 44424 from commit-queue. yaar@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. - If you have committer rights please correct the error in WebKitTools/Scripts/modules/committers.py by adding yourself to the file (no review needed) and then set the committer flag again. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. 169456 4 44424 commit-queue 2009-12-07 13:30:29 -0800 Comment on attachment 44424 make buildbot red when checkout and compile fail Rejecting patch 44424 from commit-queue. yaar@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. - If you have committer rights please correct the error in WebKitTools/Scripts/modules/committers.py by adding yourself to the file (no review needed) and then set the committer flag again. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. 169462 5 44424 commit-queue 2009-12-07 13:52:31 -0800 Comment on attachment 44424 make buildbot red when checkout and compile fail Clearing flags on attachment: 44424 Committed r51794: <http://trac.webkit.org/changeset/51794> 169463 6 commit-queue 2009-12-07 13:52:36 -0800 All reviewed patches have been landed. Closing bug. 44424 2009-12-07 12:31:13 -0800 2009-12-07 13:52:31 -0800 make buildbot red when checkout and compile fail bug-32235-20091207153112.patch text/plain 1013 yaar ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1NWJmZDVlLi43M2VmMjJiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMDktMTIt MDcgIFlhYXIgU2Nobml0bWFuICA8eWFhckBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hyb21pdW0gYnVpbGRib3RzIGFyZSBu b3QgcmVkIHdoZW4gdGhleSBmYWlsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zMjIzNQorCisgICAgICAgICogU2NyaXB0cy9idWlsZC13ZWJraXQ6CisK KzIwMDktMTItMDcgIFlhYXIgU2Nobml0bWFuICA8eWFhckBjaHJvbWl1bS5vcmc+CisKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgogCiAgICAgICAgIGZpeGVzIHRvIGJ1aWxkLXdl YmtpdCAtLWNocm9taXVtCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL2J1aWxkLXdl YmtpdCBiL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CmluZGV4IDU3MDM4OTkuLjMw ZWMwYTEgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CisrKyBi L1dlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CkBAIC0zMjUsNyArMzI1LDcgQEAgaWYg KGlzQ2hyb21pdW0oKSkgewogICAgICMgQ2hyb21pdW0gZG9lc24ndCBidWlsZCBieSBwcm9qZWN0 IGRpcmVjdG9yaWVzLgogICAgIEBwcm9qZWN0cyA9ICgpOwogICAgIG15ICRyZXN1bHQgPSBidWls ZENocm9taXVtKCRjbGVhbiwgQG9wdGlvbnMpOwotICAgIGV4aXQgJHJlc3VsdCBpZiAkcmVzdWx0 OworICAgIGV4aXQgZXhpdFN0YXR1cygkcmVzdWx0KSBpZiBleGl0U3RhdHVzKCRyZXN1bHQpOwog fQogCiAjIEJ1aWxkLCBhbmQgYWJvcnQgaWYgdGhlIGJ1aWxkIGZhaWxzLgo=