32234 2009-12-07 11:38:47 -0800 Consider changing run-webkit-websocketserver to log to stdout 2009-12-07 18:40:57 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 1 ap webkit-unassigned commit-queue webkit.review.bot yuzo oldest_to_newest 169406 0 ap 2009-12-07 11:38:47 -0800 run-webkit-websocketserver is used for interactive debugging, and it would be nice to immediately see its output in console. This is what run-webkit-httpd does, for example. 169568 1 44455 yuzo 2009-12-07 17:57:49 -0800 Created attachment 44455 Make run-webkit-websocketserver log to stderr rather than to a file 169569 2 yuzo 2009-12-07 17:58:32 -0800 Hi, reviewers, Can you review this? Yuzo 169570 3 webkit.review.bot 2009-12-07 18:01:04 -0800 style-queue ran check-webkit-style on attachment 44455 without any errors. 169577 4 44455 ap 2009-12-07 18:31:53 -0800 Comment on attachment 44455 Make run-webkit-websocketserver log to stderr rather than to a file r=me. Thanks! 169579 5 44455 commit-queue 2009-12-07 18:40:52 -0800 Comment on attachment 44455 Make run-webkit-websocketserver log to stderr rather than to a file Clearing flags on attachment: 44455 Committed r51824: <http://trac.webkit.org/changeset/51824> 169580 6 commit-queue 2009-12-07 18:40:57 -0800 All reviewed patches have been landed. Closing bug. 44455 2009-12-07 17:57:49 -0800 2009-12-07 18:40:52 -0800 Make run-webkit-websocketserver log to stderr rather than to a file bug-32234-20091208105747.patch text/plain 2173 yuzo ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmNmVhYzY0Li44MGYxNTI0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTIt MDcgIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgcnVuLXdlYmtpdC13ZWJzb2NrZXRz ZXJ2ZXIgbG9nIHRvIHN0ZGVyciByYXRoZXIgdGhhbiB0byBhIGZpbGUuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjIzNAorCisgICAgICAgICogU2Ny aXB0cy9ydW4td2Via2l0LXdlYnNvY2tldHNlcnZlcjoKKwogMjAwOS0xMi0wNyAgRG1pdHJ5IFRp dG92ICA8ZGltaWNoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBE YXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC13 ZWJzb2NrZXRzZXJ2ZXIgYi9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtd2Vic29ja2V0 c2VydmVyCmluZGV4IGFkYTEzM2QuLmUwNTMwM2EgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1Nj cmlwdHMvcnVuLXdlYmtpdC13ZWJzb2NrZXRzZXJ2ZXIKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy9ydW4td2Via2l0LXdlYnNvY2tldHNlcnZlcgpAQCAtMzQsNyArMzQsNyBAQCB1c2Ugd2Fybmlu Z3M7CiAKIHVzZSBGaWxlOjpTcGVjOwogdXNlIEZpbmRCaW47Ci11c2UgSVBDOjpPcGVuMzsKK3Vz ZSBJUEM6Ok9wZW4yOwogCiB1c2UgbGliICRGaW5kQmluOjpCaW47CiB1c2Ugd2Via2l0ZGlyczsK QEAgLTQ2LDcgKzQ2LDYgQEAgbXkgJHdlYlNvY2tldFBvcnQgPSA4ODgwOwogCiBteSAkc3JjRGly ID0gc291cmNlRGlyKCk7CiBteSAkbGF5b3V0VGVzdHNOYW1lID0gIiRzcmNEaXIvTGF5b3V0VGVz dHMiOwotbXkgJGxvZ0ZpbGUgPSAiL3RtcC93ZWJraXQtd2Vic29ja2V0c2VydmVyLnR4dCI7CiBt eSAkdGVzdERpcmVjdG9yeSA9IEZpbGU6OlNwZWMtPnJlbDJhYnMoJGxheW91dFRlc3RzTmFtZSk7 CiBteSAkd2ViU29ja2V0U2VydmVyUElEID0gMDsKIApAQCAtNTQsNyArNTMsNiBAQCBteSAkd2Vi U29ja2V0U2VydmVyUElEID0gMDsKIHByaW50ICJTdGFydGluZyBXZWIgU29ja2V0IHNlcnZlci4u LlxuIjsKIG9wZW5XZWJTb2NrZXRTZXJ2ZXIoKTsKIHByaW50ICJTdGFydGVkLlxuIjsKLXByaW50 ICJMb2dnaW5nIHRvOiAkbG9nRmlsZVxuIjsKIHByaW50ICJIaXQgW0VOVEVSXSB0byBzdG9wIGl0 LiI7CiA8U1RESU4+OwogcHJpbnQgIlN0b3BwaW5nIFdlYiBTb2NrZXQgc2VydmVyLi4uXG4iOwpA QCAtNzUsMTEgKzczLDEwIEBAIHN1YiBvcGVuV2ViU29ja2V0U2VydmVyKCkKICAgICAgICAgIi1w IiwgIiR3ZWJTb2NrZXRQb3J0IiwKICAgICAgICAgIi1kIiwgIiR3ZWJTb2NrZXRIYW5kbGVyRGly IiwKICAgICAgICAgIi1zIiwgIiR3ZWJTb2NrZXRIYW5kbGVyU2NhbkRpciIsCi0gICAgICAgICIt bCIsICIkbG9nRmlsZSIsCiAgICAgKTsKIAogICAgICRFTlZ7IlBZVEhPTlBBVEgifSA9ICR3ZWJT b2NrZXRQeXRob25QYXRoOwotICAgICR3ZWJTb2NrZXRTZXJ2ZXJQSUQgPSBvcGVuMyhcKldFQlNP Q0tFVFNFUlZFUl9JTiwgXCpXRUJTT0NLRVRTRVJWRVJfT1VULCBcKldFQlNPQ0tFVFNFUlZFUl9F UlIsICR3ZWJTb2NrZXRTZXJ2ZXJQYXRoLCBAYXJncyk7CisgICAgJHdlYlNvY2tldFNlcnZlclBJ RCA9IG9wZW4yKFwqV0VCU09DS0VUU0VSVkVSX0lOLCBcKldFQlNPQ0tFVFNFUlZFUl9PVVQsICR3 ZWJTb2NrZXRTZXJ2ZXJQYXRoLCBAYXJncyk7CiAKICAgICBteSAkbGlzdGVuID0gImh0dHA6Ly8x MjcuMC4wLjE6JHdlYlNvY2tldFBvcnQiOwogICAgIG15ICRyZXRyeUNvdW50ID0gMTA7CkBAIC05 NCw3ICs5MSw2IEBAIHN1YiBjbG9zZVdlYlNvY2tldFNlcnZlcigpCiB7CiAgICAgY2xvc2UgV0VC U09DS0VUU0VSVkVSX0lOOwogICAgIGNsb3NlIFdFQlNPQ0tFVFNFUlZFUl9PVVQ7Ci0gICAgY2xv c2UgV0VCU09DS0VUU0VSVkVSX0VSUjsKICAgICBraWxsIDE1LCAkd2ViU29ja2V0U2VydmVyUElE OwogfQogCg==