32213 2009-12-07 00:53:26 -0800 [Chromium] accesskey is not supported on Chromium Mac. 2017-07-27 23:51:49 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 suzhe suzhe commit-queue eric fishd hbono imsurinder90 pam thakis webkit.review.bot oldest_to_newest 169216 0 suzhe 2009-12-07 00:53:26 -0800 See chromium issue: http://crbug.com/23221 URLs (if applicable) : http://djmitche.github.com/buildbot/docs/0.7.11/ OS version : 10.5.8 Behavior in Safari 3.x/4.x (if applicable): Correct (use ctrl+alt) Behavior in Firefox 3.x (if applicable): Correct (use ctrl) Behavior in Chrome for Windows: Correct (use alt or shift+alt) What steps will reproduce the problem? 1. Open above URL. 2. Press ctrl+alt+# (1 to 9) in the webpage. 3. What is the expected result? Jumps to corresponding section. eg. ctrl+alt+1 to introduction, ctrl+alt+2 to installation, etc. What happens instead? Nothing happens. 169217 1 44392 suzhe 2009-12-07 01:07:29 -0800 Created attachment 44392 Patch to fix this issue. 169218 2 webkit.review.bot 2009-12-07 01:09:07 -0800 style-queue ran check-webkit-style on attachment 44392 without any errors. 169592 3 fishd 2009-12-07 20:48:17 -0800 Can you construct a layout test for this using eventSender? 169593 4 suzhe 2009-12-07 20:55:37 -0800 This fix is chromium specific, should I add a layout test in chromium tree? 169594 5 44392 commit-queue 2009-12-07 20:55:54 -0800 Comment on attachment 44392 Patch to fix this issue. Clearing flags on attachment: 44392 Committed r51832: <http://trac.webkit.org/changeset/51832> 169595 6 commit-queue 2009-12-07 20:55:59 -0800 All reviewed patches have been landed. Closing bug. 169710 7 eric 2009-12-08 10:24:03 -0800 Since chromium tests are eventually moving into svn.webkit.org I'm not sure why the test wouldn't just go there. I guess since the chromium test results aren't in svn.webkit.org yet, maybe it makes sense to just put it in svn.chromium.org for now... 169872 8 suzhe 2009-12-08 19:16:52 -0800 There is already a layout test for access key: LayoutTests/fast/forms/access-key.html. I'll check if it works with chromium. 169881 9 hbono 2009-12-08 19:46:07 -0800 (In reply to comment #8) > There is already a layout test for access key: > LayoutTests/fast/forms/access-key.html. I'll check if it works with chromium. This test has been passing on our Mac test_shell with or without this change. So, I think we need another test that fails without this change but passes with this change, right? Nevertheless, I'm not a WebKit guru and I may be wrong. 169882 10 thakis 2009-12-08 19:52:19 -0800 WebKit tests are executed using testshell. To test for this patch, we need to test the plumbing between chrome and webkit, which can't be done with a layout test (at least not until we run layout tests using chrome, which is currently not planned i believe). This would have to be tested in a browser test as far as I understand. 169889 11 hbono 2009-12-08 20:15:43 -0800 (In reply to comment #10) > WebKit tests are executed using testshell. To test for this patch, we need to > test the plumbing between chrome and webkit, which can't be done with a layout > test (at least not until we run layout tests using chrome, which is currently > not planned i believe). I'm afraid I don't think so. Our EventSendingController calls WebViewImpl::handleInputEvent() to send a key event. So, if we add a new modifier string "systemKey" so eventSender.keyDown() can manually set/reset the isSystemKey value of a WebInputEvent, I think we can write a new layout test that fails without this change but passes with this change. That is, we need to change DumpRenderTree of WebKit as well as our test_shell. I sometimes changes DumpRenderTree (or TestShell) to write layout tests for such cases. Am I doing something wrong? 169890 12 suzhe 2009-12-08 20:19:41 -0800 I'm investigating why the test passes on our Mac TestShell. Will give you update asap. 169924 13 suzhe 2009-12-09 00:39:57 -0800 Ok, it's a bug of chromium's test_shell, which wrongly marks keys with ctrl+alt modifiers as system keys. It's correct on Windows and Linux, but not Mac. I'll submit a CL to fix it. 1332909 14 imsurinder90 2017-07-27 23:51:49 -0700 Hi All, I am using Webkit5.8 with annulen webkit5.212.1 Mac OS X Yosemite 10.10.2 I am still experiencing issues with accesskeys not working. The last comment of this post is dated "2009-12-09 00:39:57 PST". So i guess this issue would have been resolved. Can someone please clarify whether this issue is fixed or not with latest Webkit version? If it is still not fixed. Any workaround or patch for the same will be helpful Thanks, Surinder 44392 2009-12-07 01:07:29 -0800 2009-12-07 20:55:54 -0800 Patch to fix this issue. bug-32213.patch text/plain 2962 suzhe SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCe+8iOeJiOacrCA1MTc0N++8iQor KysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJ77yI5bel5L2c5Ymv5pys77yJ CkBAIC00NjEsNyArNDYxLDcgQEAKICAgICBQbGF0Zm9ybUtleWJvYXJkRXZlbnRCdWlsZGVyIGV2 dChldmVudCk7CiAKICAgICBpZiAoaGFuZGxlci0+a2V5RXZlbnQoZXZ0KSkgewotICAgICAgICBp ZiAoV2ViSW5wdXRFdmVudDo6UmF3S2V5RG93biA9PSBldmVudC50eXBlICYmICFldnQuaXNTeXN0 ZW1LZXkoKSkKKyAgICAgICAgaWYgKFdlYklucHV0RXZlbnQ6OlJhd0tleURvd24gPT0gZXZlbnQu dHlwZSkKICAgICAgICAgICAgIG1fc3VwcHJlc3NOZXh0S2V5cHJlc3NFdmVudCA9IHRydWU7CiAg ICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KQEAgLTUyNiwzMSArNTI2LDMzIEBACiAgICAgLy8g aGFuZGxlZCBieSBXZWJraXQuIEEga2V5RG93biBldmVudCBpcyB0eXBpY2FsbHkgYXNzb2NpYXRl ZCB3aXRoIGEKICAgICAvLyBrZXlQcmVzcyhjaGFyKSBldmVudCBhbmQgYSBrZXlVcCBldmVudC4g V2UgcmVzZXQgdGhpcyBmbGFnIGhlcmUgYXMgaXQKICAgICAvLyBvbmx5IGFwcGxpZXMgdG8gdGhl IGN1cnJlbnQga2V5UHJlc3MgZXZlbnQuCi0gICAgaWYgKG1fc3VwcHJlc3NOZXh0S2V5cHJlc3NF dmVudCkgewotICAgICAgICBtX3N1cHByZXNzTmV4dEtleXByZXNzRXZlbnQgPSBmYWxzZTsKLSAg ICAgICAgcmV0dXJuIHRydWU7Ci0gICAgfQorICAgIGJvb2wgc3VwcHJlc3MgPSBtX3N1cHByZXNz TmV4dEtleXByZXNzRXZlbnQ7CisgICAgbV9zdXBwcmVzc05leHRLZXlwcmVzc0V2ZW50ID0gZmFs c2U7CiAKICAgICBGcmFtZSogZnJhbWUgPSBmb2N1c2VkV2ViQ29yZUZyYW1lKCk7CiAgICAgaWYg KCFmcmFtZSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICByZXR1cm4gc3VwcHJlc3M7 CiAKICAgICBFdmVudEhhbmRsZXIqIGhhbmRsZXIgPSBmcmFtZS0+ZXZlbnRIYW5kbGVyKCk7CiAg ICAgaWYgKCFoYW5kbGVyKQotICAgICAgICByZXR1cm4ga2V5RXZlbnREZWZhdWx0KGV2ZW50KTsK KyAgICAgICAgcmV0dXJuIHN1cHByZXNzIHx8IGtleUV2ZW50RGVmYXVsdChldmVudCk7CiAKICAg ICBQbGF0Zm9ybUtleWJvYXJkRXZlbnRCdWlsZGVyIGV2dChldmVudCk7CiAgICAgaWYgKCFldnQu aXNDaGFyYWN0ZXJLZXkoKSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAKKyAgICAvLyBBY2Nlc3Nr ZXlzIGFyZSB0cmlnZ2VyZWQgYnkgY2hhciBldmVudHMgYW5kIGNhbid0IGJlIHN1cHByZXNzZWQu CisgICAgaWYgKGhhbmRsZXItPmhhbmRsZUFjY2Vzc0tleShldnQpKQorICAgICAgICByZXR1cm4g dHJ1ZTsKKwogICAgIC8vIFNhZmFyaSAzLjEgZG9lcyBub3QgcGFzcyBvZmYgd2luZG93cyBzeXN0 ZW0ga2V5IG1lc3NhZ2VzIChXTV9TWVNDSEFSKSB0bwogICAgIC8vIHRoZSBldmVudEhhbmRsZXI6 OmtleUV2ZW50LiBXZSBtaW1pYyB0aGlzIGJlaGF2aW9yIG9uIGFsbCBwbGF0Zm9ybXMgc2luY2UK ICAgICAvLyBmb3Igbm93IHdlIGFyZSBjb252ZXJ0aW5nIG90aGVyIHBsYXRmb3JtJ3Mga2V5IGV2 ZW50cyB0byB3aW5kb3dzIGtleQogICAgIC8vIGV2ZW50cy4KICAgICBpZiAoZXZ0LmlzU3lzdGVt S2V5KCkpCi0gICAgICAgIHJldHVybiBoYW5kbGVyLT5oYW5kbGVBY2Nlc3NLZXkoZXZ0KTsKKyAg ICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgaWYgKCFoYW5kbGVyLT5rZXlFdmVudChldnQpKQor ICAgIGlmICghc3VwcHJlc3MgJiYgIWhhbmRsZXItPmtleUV2ZW50KGV2dCkpCiAgICAgICAgIHJl dHVybiBrZXlFdmVudERlZmF1bHQoZXZlbnQpOwogCiAgICAgcmV0dXJuIHRydWU7CkluZGV4OiBX ZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJ77yI54mI5pysIDUxNzU077yJCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9n Ce+8iOW3peS9nOWJr+acrO+8iQpAQCAtMSwzICsxLDIxIEBACisyMDA5LTEyLTA3ICBaaGUgU3Ug IDxzdXpoZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBhY2Nlc3NrZXkgaXMgbm90IHN1cHBvcnRlZCBvbiBD aHJvbWl1bSBNYWMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMjIxMworCisgICAgICAgIFRoaXMgY2hhbmdlIGZpeGVzIChwYXJ0aWFsbHkpIHRoZSBh Y2Nlc3NrZXkgaXNzdWUgYnkgZGVjb3VwbGluZyB0aGUKKyAgICAgICAgY29kZSBmb3IgaGFuZGxp bmcgYWNjZXNza2V5cyBhbmQgc3lzdGVtIGtleXMuIEJlY2F1c2Ugb24gTWFjLAorICAgICAgICB0 aGUgbW9kaWZpZXJzIG9mIGFjY2Vzc2tleXMgYXJlIGN0cmwrYWx0LCB3aGljaCBhcmUgbm90IG1h cmtlZCBhcworICAgICAgICBzeXN0ZW0ga2V5cy4KKyAgICAgICAgSW4gb3JkZXIgdG8gZnVsbHkg Zml4IHRoaXMgaXNzdWUsIHNvbWUgY2hhbmdlcyBpbiBDaHJvbWl1bSBjb2RlIGlzCisgICAgICAg IGFsc28gcmVxdWlyZWQuCisKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6a2V5RXZlbnQpOgorICAgICAgICAoV2ViS2l0OjpXZWJW aWV3SW1wbDo6Y2hhckV2ZW50KToKKwogMjAwOS0xMi0wNCAgSmFtZXMgSGF3a2lucyAgPGpoYXdr aW5zQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCg==