32204 2009-12-06 18:01:49 -0800 REGRESSION (r51728): update-webkit fails when the current directory is not inside a Subversion working copy 2009-12-06 20:58:18 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P1 Normal --- 1 mitz webkit-unassigned abarth webkit.review.bot oldest_to_newest 169138 0 mitz 2009-12-06 18:01:49 -0800 update-webkit fails when the current directory is not inside a Subversion working copy. Prior to r51728, the script worked when invoked from any directory, and updated the working copy. 169139 1 44372 mitz 2009-12-06 18:09:31 -0800 Created attachment 44372 Invoke isSVN() in the correct working directory 169141 2 webkit.review.bot 2009-12-06 18:13:01 -0800 style-queue ran check-webkit-style on attachment 44372 without any errors. 169147 3 mitz 2009-12-06 19:28:25 -0800 Fixed in <http://trac.webkit.org/projects/webkit/changeset/51745> 169149 4 abarth 2009-12-06 20:58:18 -0800 Sorry for the regression. I wish we had tests for these scripts. Thanks for cleaning up after me. 44372 2009-12-06 18:09:31 -0800 2009-12-06 19:18:46 -0800 Invoke isSVN() in the correct working directory 32204_r1.diff text/plain 1267 mitz SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUxNzQyKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTItMDYgIERhbiBCZXJuc3RlaW4gIDxt aXR6QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBSRUdSRVNTSU9OIChyNTE3MjgpOiB1cGRhdGUtd2Via2l0IGZhaWxzIHdoZW4gdGhl IGN1cnJlbnQgZGlyZWN0b3J5IGlzCisgICAgICAgIG5vdCBpbnNpZGUgYSBTdWJ2ZXJzaW9uIHdv cmtpbmcgY29weQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzIyMDQKKworICAgICAgICAqIFNjcmlwdHMvdXBkYXRlLXdlYmtpdDogSW52b2tlIGlzU1ZO KCkgaW4gdGhlIGNvcnJlY3Qgd29ya2luZworICAgICAgICBkaXJlY3RvcnkuCisKIDIwMDktMTIt MDYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBFcmljIFNlaWRlbC4KSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQJKHJldmlzaW9u IDUxNzQyKQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0CSh3b3JraW5nIGNv cHkpCkBAIC00Nyw2ICs0Nyw4IEBAIG15ICRzaG93SGVscDsKIAogZGV0ZXJtaW5lSXNDaHJvbWl1 bSgpOwogCitjaGRpcldlYktpdCgpOworCiBteSAkaXNHaXQgPSBpc0dpdCgpOwogbXkgJGlzU1ZO ID0gaXNTVk4oKTsKIApAQCAtNzEsNyArNzMsNiBAQCBwdXNoIEBzdm5PcHRpb25zLCAnLXEnIGlm ICRxdWlldDsKICMgRG9uJ3QgcHJvbXB0IHdoZW4gdXNpbmcgc3ZuLTEuNiBvciBuZXdlci4KIHB1 c2ggQHN2bk9wdGlvbnMsIHF3KC0tYWNjZXB0IHBvc3Rwb25lKSBpZiBpc1NWTlZlcnNpb24xNk9y TmV3ZXIoKTsKIAotY2hkaXJXZWJLaXQoKTsKIHByaW50ICJVcGRhdGluZyBPcGVuU291cmNlXG4i IHVubGVzcyAkcXVpZXQ7CiBydW5Tdm5VcGRhdGUoKSBpZiAkaXNTVk47CiBydW5HaXRVcGRhdGUo KSBpZiAkaXNHaXQ7Cg==