32203 2009-12-06 17:12:38 -0800 Bad length parsing in WebSocket 2009-12-07 20:05:58 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ukai webkit-unassigned ap webkit.review.bot oldest_to_newest 169133 0 ukai 2009-12-06 17:12:38 -0800 WebSocket spec says "Frames denoted by bytes that have the high bit set (0x80 to 0xFF) have a leading length indicator, which is encoded as a series of 7-bit bytes stored in octets with the 8th bit being set for all but the last byte", but current implementation doesn't count the last byte with 8th bit off. 169134 1 44370 ukai 2009-12-06 17:29:05 -0800 Created attachment 44370 Fix bad legnth parsing in WebSocket. 169135 2 webkit.review.bot 2009-12-06 17:31:36 -0800 style-queue ran check-webkit-style on attachment 44370 without any errors. 169190 3 ap 2009-12-06 22:59:23 -0800 + int c = *p; Can "c" have a descriptive name? - msg += "\x80\x81\x81" + msg += "\x80\x81\x01" # skip 1*128+1 bytes. ChangeLog should explain why changing an existing test is OK. It is not obvious why/if the bug it was originally created for is still tested. 169196 4 44388 ukai 2009-12-06 23:21:04 -0800 Created attachment 44388 Fix wrong length parsing in WebSocket. 169197 5 webkit.review.bot 2009-12-06 23:22:18 -0800 style-queue ran check-webkit-style on attachment 44388 without any errors. 169587 6 ukai 2009-12-07 20:05:58 -0800 Committed r51829: <http://trac.webkit.org/changeset/51829> 44370 2009-12-06 17:29:05 -0800 2009-12-06 23:20:59 -0800 Fix bad legnth parsing in WebSocket. bug-32203-20091207102903.patch text/plain 3359 ukai ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkN2ZlYjE0Li5mMDU4NmUzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTIt MDYgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGJhZCBsZWdudGggcGFyc2luZyBp biBXZWJTb2NrZXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMjIwMworCisgICAgICAgICogd2Vic29ja2V0L3Rlc3RzL2ZyYW1lLWxlbmd0aC1sb25n ZXItdGhhbi1idWZmZXJfd3NoLnB5OgorICAgICAgICAqIHdlYnNvY2tldC90ZXN0cy9mcmFtZS1s ZW5ndGgtc2tpcF93c2gucHk6CisKIDIwMDktMTItMDMgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6 YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXhpbmcgbGF5b3V0IHRlc3QgYnVzdGFnZSBvbiBw bGF0Zm9ybXMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJzb2NrZXQvdGVzdHMvZnJhbWUt bGVuZ3RoLWxvbmdlci10aGFuLWJ1ZmZlcl93c2gucHkgYi9MYXlvdXRUZXN0cy93ZWJzb2NrZXQv dGVzdHMvZnJhbWUtbGVuZ3RoLWxvbmdlci10aGFuLWJ1ZmZlcl93c2gucHkKaW5kZXggOGFkODY4 Yi4uMGY5MWM5NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvd2Vic29ja2V0L3Rlc3RzL2ZyYW1l LWxlbmd0aC1sb25nZXItdGhhbi1idWZmZXJfd3NoLnB5CisrKyBiL0xheW91dFRlc3RzL3dlYnNv Y2tldC90ZXN0cy9mcmFtZS1sZW5ndGgtbG9uZ2VyLXRoYW4tYnVmZmVyX3dzaC5weQpAQCAtMyw3 ICszLDcgQEAgZGVmIHdlYl9zb2NrZXRfZG9fZXh0cmFfaGFuZHNoYWtlKHJlcXVlc3QpOgogCiBk ZWYgd2ViX3NvY2tldF90cmFuc2Zlcl9kYXRhKHJlcXVlc3QpOgogICBtc2cgPSAiXDBoZWxsb1x4 ZmYiCi0gIG1zZyArPSAiXHg4MFx4ODFceDgxIgorICBtc2cgKz0gIlx4ODBceDgxXHgwMSIgICMg c2tpcCAxKjEyOCsxIGJ5dGVzLgogICBtc2cgKz0gIlx4MDFceGZmIgogICBtc2cgKz0gIlwwc2hv dWxkIGJlIHNraXBwZWRceGZmIgogICByZXF1ZXN0LmNvbm5lY3Rpb24ud3JpdGUobXNnKQpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvd2Vic29ja2V0L3Rlc3RzL2ZyYW1lLWxlbmd0aC1za2lwX3dz aC5weSBiL0xheW91dFRlc3RzL3dlYnNvY2tldC90ZXN0cy9mcmFtZS1sZW5ndGgtc2tpcF93c2gu cHkKaW5kZXggNTU3MTY5MS4uZDE0ZjU1MCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvd2Vic29j a2V0L3Rlc3RzL2ZyYW1lLWxlbmd0aC1za2lwX3dzaC5weQorKysgYi9MYXlvdXRUZXN0cy93ZWJz b2NrZXQvdGVzdHMvZnJhbWUtbGVuZ3RoLXNraXBfd3NoLnB5CkBAIC0zLDcgKzMsNyBAQCBkZWYg d2ViX3NvY2tldF9kb19leHRyYV9oYW5kc2hha2UocmVxdWVzdCk6CiAKIGRlZiB3ZWJfc29ja2V0 X3RyYW5zZmVyX2RhdGEocmVxdWVzdCk6CiAgIG1zZyA9ICJcMGhlbGxvXHhmZiIKLSAgbXNnICs9 ICJceDgwXHg4MVx4ODEiCisgIG1zZyArPSAiXHg4MFx4ODFceDAxIiAgICMgc2tpcCAxKjEyOCsx IGJ5dGVzLgogICBtc2cgKz0gIlx4MDEiCiAgIG1zZyArPSAiXDBzaG91bGQgYmUgc2tpcHBlZCIg KyAoIiAiICogMTA5KSArICJceGZmIgogICBtc2cgKz0gIlwwd29ybGRceGZmIgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiODhiYWUwLi5l YmQyMDIxIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDA5LTEyLTA2ICBGdW1pdG9zaGkgVWthaSAgPHVrYWlA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZpeCBiYWQgbGVnbnRoIHBhcnNpbmcgaW4gV2ViU29ja2V0LgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzIyMDMKKworICAgICAgICAqIHdl YnNvY2tldHMvV2ViU29ja2V0Q2hhbm5lbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJTb2Nr ZXRDaGFubmVsOjpkaWRSZWNlaXZlRGF0YSk6CisKIDIwMDktMTItMDMgIENocmlzIEZsZWl6YWNo ICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRl bC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXRDaGFubmVsLmNwcCBi L1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXRDaGFubmVsLmNwcAppbmRleCAyZGRlNzcwLi42 MDA5ZWQ5IDEwMDY0NAotLS0gYS9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0Q2hhbm5lbC5j cHAKKysrIGIvV2ViQ29yZS93ZWJzb2NrZXRzL1dlYlNvY2tldENoYW5uZWwuY3BwCkBAIC0xODcs MTQgKzE4NywxNyBAQCB2b2lkIFdlYlNvY2tldENoYW5uZWw6OmRpZFJlY2VpdmVEYXRhKFNvY2tl dFN0cmVhbUhhbmRsZSogaGFuZGxlLCBjb25zdCBjaGFyKiBkYQogICAgICAgICB1bnNpZ25lZCBj aGFyIGZyYW1lQnl0ZSA9IHN0YXRpY19jYXN0PHVuc2lnbmVkIGNoYXI+KCpwKyspOwogICAgICAg ICBpZiAoKGZyYW1lQnl0ZSAmIDB4ODApID09IDB4ODApIHsKICAgICAgICAgICAgIGludCBsZW5n dGggPSAwOwotICAgICAgICAgICAgd2hpbGUgKHAgPCBlbmQgJiYgKCpwICYgMHg4MCkgPT0gMHg4 MCkgeworICAgICAgICAgICAgd2hpbGUgKHAgPCBlbmQpIHsKICAgICAgICAgICAgICAgICBpZiAo bGVuZ3RoID4gc3RkOjpudW1lcmljX2xpbWl0czxpbnQ+OjptYXgoKSAvIDEyOCkgewogICAgICAg ICAgICAgICAgICAgICBMT0coTmV0d29yaywgImZyYW1lIGxlbmd0aCBvdmVyZmxvdyAlZCIsIGxl bmd0aCk7CiAgICAgICAgICAgICAgICAgICAgIGhhbmRsZS0+Y2xvc2UoKTsKICAgICAgICAgICAg ICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAgICBsZW5n dGggPSBsZW5ndGggKiAxMjggKyAoKnAgJiAweDdmKTsKKyAgICAgICAgICAgICAgICBpbnQgYyA9 ICpwOworICAgICAgICAgICAgICAgIGxlbmd0aCA9IGxlbmd0aCAqIDEyOCArIChjICYgMHg3Zik7 CiAgICAgICAgICAgICAgICAgKytwOworICAgICAgICAgICAgICAgIGlmICghKGMgJiAweDgwKSkK KyAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBp ZiAocCArIGxlbmd0aCA8IGVuZCkgewogICAgICAgICAgICAgICAgIHAgKz0gbGVuZ3RoOwo= 44388 2009-12-06 23:21:04 -0800 2009-12-07 09:11:39 -0800 Fix wrong length parsing in WebSocket. bug-32203-20091207162102.patch text/plain 3733 ukai ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwNWYzZTk1Li5kM2ViZGI5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDktMTIt MDYgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHdyb25nIGxlbmd0aCBwYXJzaW5n IGluIFdlYlNvY2tldC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTMyMjAzCisKKyAgICAgICAgVGhlc2UgdHdvIHRlc3RzIGFzc3VtZWQgd3JvbmcgbGVu Z3RoIGVuY29kaW5nIGluIGZyYW1lOiBpdCBwYXJzZWQKKyAgICAgICAgbGVuZ3RoIGZyb20gYnl0 ZXMgd2l0aCA4dGggYml0IG9uLiAgQnV0IHNwZWMgc2F5cyBsZW5ndGggaXMgZW5jb2RlZAorICAg ICAgICBhcyBhIHNlcmllcyBvZiA3LWJpdCBieXRlcyBzdG9yZWQgaW4gb2N0ZXN0cyB3aXRoIHRo ZSA4dGggYml0IG9uCisgICAgICAgICpidXQgdGhlIGxhc3QgYnl0ZSouCisgICAgICAgIFRoZXNl IHRlc3RzIGVuY29kZXMgYSBmcmFtZSB0aGF0IGhhcyAxMjkgbGVuZ3RoLCBzbyBpdCBtdXN0IGJl CisgICAgICAgIFx4ODFcMHgwMSBpbnN0ZWFkIG9mIFx4ODFcMHg4MS4KKworICAgICAgICAqIHdl YnNvY2tldC90ZXN0cy9mcmFtZS1sZW5ndGgtbG9uZ2VyLXRoYW4tYnVmZmVyX3dzaC5weToKKyAg ICAgICAgKiB3ZWJzb2NrZXQvdGVzdHMvZnJhbWUtbGVuZ3RoLXNraXBfd3NoLnB5OgorCiAyMDA5 LTEyLTA2ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3dlYnNvY2tldC90 ZXN0cy9mcmFtZS1sZW5ndGgtbG9uZ2VyLXRoYW4tYnVmZmVyX3dzaC5weSBiL0xheW91dFRlc3Rz L3dlYnNvY2tldC90ZXN0cy9mcmFtZS1sZW5ndGgtbG9uZ2VyLXRoYW4tYnVmZmVyX3dzaC5weQpp bmRleCA4YWQ4NjhiLi4wZjkxYzk2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy93ZWJzb2NrZXQv dGVzdHMvZnJhbWUtbGVuZ3RoLWxvbmdlci10aGFuLWJ1ZmZlcl93c2gucHkKKysrIGIvTGF5b3V0 VGVzdHMvd2Vic29ja2V0L3Rlc3RzL2ZyYW1lLWxlbmd0aC1sb25nZXItdGhhbi1idWZmZXJfd3No LnB5CkBAIC0zLDcgKzMsNyBAQCBkZWYgd2ViX3NvY2tldF9kb19leHRyYV9oYW5kc2hha2UocmVx dWVzdCk6CiAKIGRlZiB3ZWJfc29ja2V0X3RyYW5zZmVyX2RhdGEocmVxdWVzdCk6CiAgIG1zZyA9 ICJcMGhlbGxvXHhmZiIKLSAgbXNnICs9ICJceDgwXHg4MVx4ODEiCisgIG1zZyArPSAiXHg4MFx4 ODFceDAxIiAgIyBza2lwIDEqMTI4KzEgYnl0ZXMuCiAgIG1zZyArPSAiXHgwMVx4ZmYiCiAgIG1z ZyArPSAiXDBzaG91bGQgYmUgc2tpcHBlZFx4ZmYiCiAgIHJlcXVlc3QuY29ubmVjdGlvbi53cml0 ZShtc2cpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJzb2NrZXQvdGVzdHMvZnJhbWUtbGVu Z3RoLXNraXBfd3NoLnB5IGIvTGF5b3V0VGVzdHMvd2Vic29ja2V0L3Rlc3RzL2ZyYW1lLWxlbmd0 aC1za2lwX3dzaC5weQppbmRleCA1NTcxNjkxLi5kMTRmNTUwIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy93ZWJzb2NrZXQvdGVzdHMvZnJhbWUtbGVuZ3RoLXNraXBfd3NoLnB5CisrKyBiL0xheW91 dFRlc3RzL3dlYnNvY2tldC90ZXN0cy9mcmFtZS1sZW5ndGgtc2tpcF93c2gucHkKQEAgLTMsNyAr Myw3IEBAIGRlZiB3ZWJfc29ja2V0X2RvX2V4dHJhX2hhbmRzaGFrZShyZXF1ZXN0KToKIAogZGVm IHdlYl9zb2NrZXRfdHJhbnNmZXJfZGF0YShyZXF1ZXN0KToKICAgbXNnID0gIlwwaGVsbG9ceGZm IgotICBtc2cgKz0gIlx4ODBceDgxXHg4MSIKKyAgbXNnICs9ICJceDgwXHg4MVx4MDEiICAgIyBz a2lwIDEqMTI4KzEgYnl0ZXMuCiAgIG1zZyArPSAiXHgwMSIKICAgbXNnICs9ICJcMHNob3VsZCBi ZSBza2lwcGVkIiArICgiICIgKiAxMDkpICsgIlx4ZmYiCiAgIG1zZyArPSAiXDB3b3JsZFx4ZmYi CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IDgyZjUyODUuLmYxZjA4YzAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTItMDYgIEZ1bWl0b3NoaSBV a2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRml4IHdyb25nIGxlbmd0aCBwYXJzaW5nIGluIFdlYlNvY2tldC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMjAzCisK KyAgICAgICAgKiB3ZWJzb2NrZXRzL1dlYlNvY2tldENoYW5uZWwuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6V2ViU29ja2V0Q2hhbm5lbDo6ZGlkUmVjZWl2ZURhdGEpOgorCiAyMDA5LTEyLTA2ICBP bGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFj aWVqIFN0YWNob3dpYWsuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0 Q2hhbm5lbC5jcHAgYi9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0Q2hhbm5lbC5jcHAKaW5k ZXggMmRkZTc3MC4uYTIyMmI0ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS93ZWJzb2NrZXRzL1dlYlNv Y2tldENoYW5uZWwuY3BwCisrKyBiL1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXRDaGFubmVs LmNwcApAQCAtMTg3LDE0ICsxODcsMTcgQEAgdm9pZCBXZWJTb2NrZXRDaGFubmVsOjpkaWRSZWNl aXZlRGF0YShTb2NrZXRTdHJlYW1IYW5kbGUqIGhhbmRsZSwgY29uc3QgY2hhciogZGEKICAgICAg ICAgdW5zaWduZWQgY2hhciBmcmFtZUJ5dGUgPSBzdGF0aWNfY2FzdDx1bnNpZ25lZCBjaGFyPigq cCsrKTsKICAgICAgICAgaWYgKChmcmFtZUJ5dGUgJiAweDgwKSA9PSAweDgwKSB7CiAgICAgICAg ICAgICBpbnQgbGVuZ3RoID0gMDsKLSAgICAgICAgICAgIHdoaWxlIChwIDwgZW5kICYmICgqcCAm IDB4ODApID09IDB4ODApIHsKKyAgICAgICAgICAgIHdoaWxlIChwIDwgZW5kKSB7CiAgICAgICAg ICAgICAgICAgaWYgKGxlbmd0aCA+IHN0ZDo6bnVtZXJpY19saW1pdHM8aW50Pjo6bWF4KCkgLyAx MjgpIHsKICAgICAgICAgICAgICAgICAgICAgTE9HKE5ldHdvcmssICJmcmFtZSBsZW5ndGggb3Zl cmZsb3cgJWQiLCBsZW5ndGgpOwogICAgICAgICAgICAgICAgICAgICBoYW5kbGUtPmNsb3NlKCk7 CiAgICAgICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgICAgICB9Ci0gICAgICAg ICAgICAgICAgbGVuZ3RoID0gbGVuZ3RoICogMTI4ICsgKCpwICYgMHg3Zik7CisgICAgICAgICAg ICAgICAgY2hhciBtc2dCeXRlID0gKnA7CisgICAgICAgICAgICAgICAgbGVuZ3RoID0gbGVuZ3Ro ICogMTI4ICsgKG1zZ0J5dGUgJiAweDdmKTsKICAgICAgICAgICAgICAgICArK3A7CisgICAgICAg ICAgICAgICAgaWYgKCEobXNnQnl0ZSAmIDB4ODApKQorICAgICAgICAgICAgICAgICAgICBicmVh azsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGlmIChwICsgbGVuZ3RoIDwgZW5kKSB7CiAg ICAgICAgICAgICAgICAgcCArPSBsZW5ndGg7Cg==