32193 2009-12-06 08:47:48 -0800 [check-webkit-style] False positive for DEFINE_OPCODE(op_jtrue) { 2009-12-08 15:55:57 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned eric levin mjs webkit.review.bot oldest_to_newest 169096 0 abarth 2009-12-06 08:47:48 -0800 DEFINE_OPCODE(op_jtrue) { generates the warning JavaScriptCore/interpreter/Interpreter.cpp:2650: Place brace on its own line for function definitions. [whitespace/braces] [4] However, this is a false positive <https://bugs.webkit.org/show_bug.cgi?id=32190#c8> because this is some sort of macro. Maybe we should notice the ALL CAPS "function" name and skip the brace check? 169801 1 44488 levin 2009-12-08 14:50:32 -0800 Created attachment 44488 Patch 169802 2 webkit.review.bot 2009-12-08 14:52:20 -0800 style-queue ran check-webkit-style on attachment 44488 without any errors. 169812 3 44492 levin 2009-12-08 15:14:20 -0800 Created attachment 44492 Patch 169813 4 webkit.review.bot 2009-12-08 15:19:00 -0800 style-queue ran check-webkit-style on attachment 44492 without any errors. 169815 5 44492 abarth 2009-12-08 15:21:58 -0800 Comment on attachment 44492 Patch Very clever. Hopefully not too clever. :) I might add 0-9 in the character class in case we have numbers in the macro names MSG_ROUTED3, etc. 169819 6 44492 levin 2009-12-08 15:29:56 -0800 Comment on attachment 44492 Patch I'll do the change suggested by Adam and land this. 169826 7 levin 2009-12-08 15:55:57 -0800 Commited (with the suggested change) as http://trac.webkit.org/changeset/51876 44488 2009-12-08 14:50:32 -0800 2009-12-08 15:14:13 -0800 Patch bug-32193-20091208145031.patch text/plain 2147 levin ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlYTMzODY1Li5hM2I3MmM3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTIt MDggIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaGVjay13ZWJraXQtc3R5bGVdIEZhbHNl IHBvc2l0aXZlIGZvciBERUZJTkVfT1BDT0RFKG9wX2p0cnVlKSB7CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjE5MworCisgICAgICAgICogU2NyaXB0 cy9tb2R1bGVzL2NwcF9zdHlsZS5weTogSWdub3JlIGxpbmVzIHRoYXQgc3RhcnQgd2l0aCBzb21l dGhpbmcKKyAgICAgICAgICB0aGF0IGxvb2tzIGxpa2UgYSBtYWNyby4KKyAgICAgICAgKiBTY3Jp cHRzL21vZHVsZXMvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5OiBBZGQgYSB0ZXN0IHRvIHZlcmlmeSB0 aGUKKyAgICAgICAgICBiZWhhdmlvciBjaGFuZ2UuCisKIDIwMDktMTItMDggIERtaXRyeSBUaXRv diAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRs ZXIuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlLnB5 IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZS5weQppbmRleCAzN2Q3NDE0 Li44MWQ4Y2U1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0 eWxlLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGUucHkKQEAg LTE5MDEsNyArMTkwMSw4IEBAIGRlZiBjaGVja19icmFjZXMoZmlsZW5hbWUsIGNsZWFuX2xpbmVz LCBsaW5lX251bWJlciwgZXJyb3IpOgogICAgICAgICAgICAgICAgICAgJ1RoaXMgeyBzaG91bGQg YmUgYXQgdGhlIGVuZCBvZiB0aGUgcHJldmlvdXMgbGluZScpCiAgICAgZWxpZiAoc2VhcmNoKHIn XClccyooY29uc3RccyopP3tccyokJywgbGluZSkKICAgICAgICAgICBhbmQgbGluZS5jb3VudCgn KCcpID09IGxpbmUuY291bnQoJyknKQotICAgICAgICAgIGFuZCBub3Qgc2VhcmNoKHInXGIoaWZ8 Zm9yfGZvcmVhY2h8d2hpbGV8c3dpdGNoKVxiJywgbGluZSkpOgorICAgICAgICAgIGFuZCBub3Qg c2VhcmNoKHInXGIoaWZ8Zm9yfGZvcmVhY2h8d2hpbGV8c3dpdGNoKVxiJywgbGluZSkKKyAgICAg ICAgICBhbmQgbm90IG1hdGNoKHInXHMqW0EtWl9dezIsfScsIGxpbmUpKToKICAgICAgICAgZXJy b3IoZmlsZW5hbWUsIGxpbmVfbnVtYmVyLCAnd2hpdGVzcGFjZS9icmFjZXMnLCA0LAogICAgICAg ICAgICAgICAnUGxhY2UgYnJhY2Ugb24gaXRzIG93biBsaW5lIGZvciBmdW5jdGlvbiBkZWZpbml0 aW9ucy4nKQogCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0 eWxlX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZV91 bml0dGVzdC5weQppbmRleCA3Y2RkZGUwLi45YTU2NjFlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xz L1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGVfdW5pdHRlc3QucHkKQEAgLTExMTgsNiArMTExOCw5 IEBAIGNsYXNzIENwcFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgICAgICdp ZiAoY29uZGl0aW9uKSB7JywKICAgICAgICAgICAgICcnKQogICAgICAgICBzZWxmLmFzc2VydF9t dWx0aV9saW5lX2xpbnQoCisgICAgICAgICAgICAnTUFDUk8obWFjcm9BcmcpIHsnLAorICAgICAg ICAgICAgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgKICAgICAgICAg ICAgICdpbnQgZm9vKCkgeycsCiAgICAgICAgICAgICAnUGxhY2UgYnJhY2Ugb24gaXRzIG93biBs aW5lIGZvciBmdW5jdGlvbiBkZWZpbml0aW9ucy4gIFt3aGl0ZXNwYWNlL2JyYWNlc10gWzRdJykK ICAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAo= 44492 2009-12-08 15:14:20 -0800 2009-12-08 15:29:56 -0800 Patch bug-32193-20091208151419.patch text/plain 2377 levin ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlYTMzODY1Li43ZWExODY4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTIt MDggIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaGVjay13ZWJraXQtc3R5bGVdIEZhbHNl IHBvc2l0aXZlIGZvciBERUZJTkVfT1BDT0RFKG9wX2p0cnVlKSB7CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjE5MworCisgICAgICAgICogU2NyaXB0 cy9tb2R1bGVzL2NwcF9zdHlsZS5weTogRm9yIHRoZSBmdW5jdGlvbiB7IHJ1bGUsIGlmIHRoZXJl IGlzIHNwYWNlCisgICAgICAgICAgYXQgdGhlIGJlZ2lubmluZyBvZiBsaW5lLCBpZ25vcmUgbGlu ZXMgd2hpY2ggdGhlbiBoYXZlIGEgbWFjcm8uCisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2Nw cF9zdHlsZV91bml0dGVzdC5weTogQWRkIHRlc3RzIHRvIHZlcmlmeSB0aGUKKyAgICAgICAgICBu ZXcgYmVoYXZpb3IuCisKIDIwMDktMTItMDggIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9X ZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlLnB5IGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy9tb2R1bGVzL2NwcF9zdHlsZS5weQppbmRleCAzN2Q3NDE0Li41MDQxYzA5IDEwMDY0NAot LS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlLnB5CisrKyBiL1dlYktp dFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGUucHkKQEAgLTE5MDEsNyArMTkwMSw4IEBA IGRlZiBjaGVja19icmFjZXMoZmlsZW5hbWUsIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZXJy b3IpOgogICAgICAgICAgICAgICAgICAgJ1RoaXMgeyBzaG91bGQgYmUgYXQgdGhlIGVuZCBvZiB0 aGUgcHJldmlvdXMgbGluZScpCiAgICAgZWxpZiAoc2VhcmNoKHInXClccyooY29uc3RccyopP3tc cyokJywgbGluZSkKICAgICAgICAgICBhbmQgbGluZS5jb3VudCgnKCcpID09IGxpbmUuY291bnQo JyknKQotICAgICAgICAgIGFuZCBub3Qgc2VhcmNoKHInXGIoaWZ8Zm9yfGZvcmVhY2h8d2hpbGV8 c3dpdGNoKVxiJywgbGluZSkpOgorICAgICAgICAgIGFuZCBub3Qgc2VhcmNoKHInXGIoaWZ8Zm9y fGZvcmVhY2h8d2hpbGV8c3dpdGNoKVxiJywgbGluZSkKKyAgICAgICAgICBhbmQgbm90IG1hdGNo KHInXHMrW0EtWl9dezIsfScsIGxpbmUpKToKICAgICAgICAgZXJyb3IoZmlsZW5hbWUsIGxpbmVf bnVtYmVyLCAnd2hpdGVzcGFjZS9icmFjZXMnLCA0LAogICAgICAgICAgICAgICAnUGxhY2UgYnJh Y2Ugb24gaXRzIG93biBsaW5lIGZvciBmdW5jdGlvbiBkZWZpbml0aW9ucy4nKQogCmRpZmYgLS1n aXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5IGIv V2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZV91bml0dGVzdC5weQppbmRleCA3 Y2RkZGUwLi5hYmJlZmExIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMv Y3BwX3N0eWxlX3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9j cHBfc3R5bGVfdW5pdHRlc3QucHkKQEAgLTExMTgsNiArMTExOCwxMiBAQCBjbGFzcyBDcHBTdHls ZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAgICAnaWYgKGNvbmRpdGlvbikgeycs CiAgICAgICAgICAgICAnJykKICAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAor ICAgICAgICAgICAgJyAgICBNQUNSTyhtYWNyb0FyZykgeycsCisgICAgICAgICAgICAnJykKKyAg ICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAorICAgICAgICAgICAgJ0FDQ0VTU09S X0dFVFRFUihNZXNzYWdlRXZlbnRQb3J0cykgeycsCisgICAgICAgICAgICAnUGxhY2UgYnJhY2Ug b24gaXRzIG93biBsaW5lIGZvciBmdW5jdGlvbiBkZWZpbml0aW9ucy4gIFt3aGl0ZXNwYWNlL2Jy YWNlc10gWzRdJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAogICAgICAg ICAgICAgJ2ludCBmb28oKSB7JywKICAgICAgICAgICAgICdQbGFjZSBicmFjZSBvbiBpdHMgb3du IGxpbmUgZm9yIGZ1bmN0aW9uIGRlZmluaXRpb25zLiAgW3doaXRlc3BhY2UvYnJhY2VzXSBbNF0n KQogICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoCg==