32192 2009-12-06 08:44:02 -0800 [check-webkit-style] False positive for camel case of JSC op codes 2009-12-08 10:59:02 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned eric levin mjs webkit.review.bot oldest_to_newest 169094 0 abarth 2009-12-06 08:44:02 -0800 According to <https://bugs.webkit.org/show_bug.cgi?id=32190#c7>, check-webkit-style should have an exception for the camelCase naming rule for JavaScript OP codes. Mjs suggests that we white list variables with the substring "_op_", possibly only in the JavaScriptCore directory. 169571 1 44456 levin 2009-12-07 18:07:53 -0800 Created attachment 44456 Patch 169572 2 44457 levin 2009-12-07 18:09:18 -0800 Created attachment 44457 Patch 169573 3 webkit.review.bot 2009-12-07 18:11:37 -0800 style-queue ran check-webkit-style on attachment 44457 without any errors. 169708 4 44457 abarth 2009-12-08 10:18:55 -0800 Comment on attachment 44457 Patch Thanks! 169729 5 levin 2009-12-08 10:59:02 -0800 Committed as http://trac.webkit.org/changeset/51866 44456 2009-12-07 18:07:53 -0800 2009-12-07 18:09:14 -0800 Patch bug-32192-20091207180751.patch text/plain 2907 levin ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAyOTJjOTYwLi5jMTBiMjAzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTIt MDcgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaGVjay13ZWJraXQtc3R5bGVdIEZhbHNl IHBvc2l0aXZlIGZvciBjYW1lbCBjYXNlIG9mIEpTQyBvcCBjb2RlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzIxOTIKKworICAgICAgICAqIFNjcmlw dHMvbW9kdWxlcy9jcHBfc3R5bGUucHk6IEFkZGVkIGFuIGV4Y2VwdGlvbiBmb3IgdGhlIEpTQyBv cAorCSAgICAgIGNvZGUgZnVuY3Rpb25zIGFuZCBjb25zdF9pdGVyYXRvciBhcyB3ZWxsIHNpbmNl IEkgbm90aWNlZCBhIGZhbHNlCisJICAgICAgcG9zaXRpdmUgdGhlcmUgd2hlbiB0ZXN0aW5nIHRo ZSBmaXguCisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZV91bml0dGVzdC5weTog QWRkZWQgdGVzdHMgZm9yIHRoZXNlCisgICAgICAgICAgY2hhbmdlcy4KKwogMjAwOS0xMi0wNyAg Tmlrb2xhcyBaaW1tZXJtYW5uICA8bnppbW1lcm1hbm5AcmltLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlci4KZGlmZiAtLWdpdCBhL1dlYktpdFRv b2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGUucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21v ZHVsZXMvY3BwX3N0eWxlLnB5CmluZGV4IGZjMTQzYTkuLmM2M2JmNzUgMTAwNjQ0Ci0tLSBhL1dl YktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGUucHkKKysrIGIvV2ViS2l0VG9vbHMv U2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZS5weQpAQCAtMjczNCw3ICsyNzM0LDEwIEBAIGRlZiBj aGVja19pZGVudGlmaWVyX25hbWVfaW5fZGVjbGFyYXRpb24oZmlsZW5hbWUsIGxpbmVfbnVtYmVy LCBsaW5lLCBlcnJvcik6CiAgICAgICAgICMgUmVtb3ZlICJtXyIgYW5kICJzXyIgdG8gYWxsb3cg dGhlbS4KICAgICAgICAgbW9kaWZpZWRfaWRlbnRpZmllciA9IHN1YihyJyhefCg/PD06OikpW21z XV8nLCAnJywgaWRlbnRpZmllcikKICAgICAgICAgaWYgbW9kaWZpZWRfaWRlbnRpZmllci5maW5k KCdfJykgPj0gMDoKLSAgICAgICAgICAgIGVycm9yKGZpbGVuYW1lLCBsaW5lX251bWJlciwgJ3Jl YWRhYmlsaXR5L25hbWluZycsIDQsIGlkZW50aWZpZXIgKyAiIGlzIGluY29ycmVjdGx5IG5hbWVk LiBEb24ndCB1c2UgdW5kZXJzY29yZXMgaW4geW91ciBpZGVudGlmaWVyIG5hbWVzLiIpCisgICAg ICAgICAgICAjIFZhcmlvdXMgZXhjZXB0aW9ucyB0byB0aGUgcnVsZTogSmF2YVNjcmlwdCBvcCBj b2RlcyBmdW5jdGlvbnMsIGNvbnN0X2l0ZXJhdG9yLgorICAgICAgICAgICAgaWYgKG5vdCAoZmls ZW5hbWUuZmluZCgnSmF2YVNjcmlwdENvcmUnKSA+PSAwIGFuZCBtb2RpZmllZF9pZGVudGlmaWVy LmZpbmQoJ19vcF8nKSA+PSAwKQorICAgICAgICAgICAgICAgIGFuZCBub3QgbW9kaWZpZWRfaWRl bnRpZmllciA9PSAiY29uc3RfaXRlcmF0b3IiKToKKyAgICAgICAgICAgICAgICBlcnJvcihmaWxl bmFtZSwgbGluZV9udW1iZXIsICdyZWFkYWJpbGl0eS9uYW1pbmcnLCA0LCBpZGVudGlmaWVyICsg IiBpcyBpbmNvcnJlY3RseSBuYW1lZC4gRG9uJ3QgdXNlIHVuZGVyc2NvcmVzIGluIHlvdXIgaWRl bnRpZmllciBuYW1lcy4iKQogCiAgICAgICAgICMgVGhlcmUgY2FuIGJlIG9ubHkgb25lIGRlY2xh cmF0aW9uIGluIG5vbi1mb3ItY29udHJvbCBzdGF0ZW1lbnRzLgogICAgICAgICBpZiBjb250cm9s X3N0YXRlbWVudDoKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBf c3R5bGVfdW5pdHRlc3QucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxl X3VuaXR0ZXN0LnB5CmluZGV4IDNmMGYyMzAuLmU2ZTQyNmYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRv b2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGVfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9v bHMvU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZV91bml0dGVzdC5weQpAQCAtMzY5Miw2ICszNjky LDE0IEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAg ICAgICAgICAgICAgICAgICBbJ3ZhcmlhYmxlXzEnICsgbmFtZV9lcnJvcl9tZXNzYWdlLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAndmFyaWFibGVfMicgKyBuYW1lX2Vycm9yX21lc3NhZ2Vd KQogCisgICAgICAgICMgVGhlcmUgaXMgYW4gZXhjZXB0aW9uIGZvciBvcCBjb2RlIGZ1bmN0aW9u cyBidXQgb25seSBpbiB0aGUgSmF2YVNjcmlwdENvcmUgZGlyZWN0b3J5LgorICAgICAgICBzZWxm LmFzc2VydF9saW50KCd2b2lkIHRoaXNfb3BfY29kZShpbnQgdmFyMSwgaW50IHZhcjIpJywgJycs ICdKYXZhU2NyaXB0Q29yZS9mb28uY3BwJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgndm9p ZCB0aGlzX29wX2NvZGUoaW50IHZhcjEsIGludCB2YXIyKScsICd0aGlzX29wX2NvZGUnICsgbmFt ZV9lcnJvcl9tZXNzYWdlKQorCisgICAgICAgICMgY29uc3RfaXRlcmF0b3IgaXMgYWxsb3dlZCBh cyB3ZWxsLgorICAgICAgICBzZWxmLmFzc2VydF9saW50KCd0eXBlZGVmIFZlY3RvclR5cGU6OmNv bnN0X2l0ZXJhdG9yIGNvbnN0X2l0ZXJhdG9yOycsICcnKQorCisKICAgICBkZWYgdGVzdF9vdGhl cihzZWxmKToKICAgICAgICAgIyBGSVhNRTogSW1wbGVtZW50IHRoaXMuCiAgICAgICAgIHBhc3MK 44457 2009-12-07 18:09:18 -0800 2009-12-08 10:18:55 -0800 Patch bug-32192-20091207180917.patch text/plain 2913 levin ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAyOTJjOTYwLi44YjM3MzEzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTIt MDcgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaGVjay13ZWJraXQtc3R5bGVdIEZhbHNl IHBvc2l0aXZlIGZvciBjYW1lbCBjYXNlIG9mIEpTQyBvcCBjb2RlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzIxOTIKKworICAgICAgICAqIFNjcmlw dHMvbW9kdWxlcy9jcHBfc3R5bGUucHk6IEFkZGVkIGFuIGV4Y2VwdGlvbiBmb3IgdGhlIEpTQyBv cAorICAgICAgICAgIGNvZGUgZnVuY3Rpb25zIGFuZCBjb25zdF9pdGVyYXRvciBhcyB3ZWxsIHNp bmNlIEkgbm90aWNlZCBhIGZhbHNlCisgICAgICAgICAgcG9zaXRpdmUgdGhlcmUgd2hlbiB0ZXN0 aW5nIHRoZSBmaXguCisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZV91bml0dGVz dC5weTogQWRkZWQgdGVzdHMgZm9yIHRoZXNlCisgICAgICAgICAgY2hhbmdlcy4KKwogMjAwOS0x Mi0wNyAgTmlrb2xhcyBaaW1tZXJtYW5uICA8bnppbW1lcm1hbm5AcmltLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlci4KZGlmZiAtLWdpdCBhL1dl YktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGUucHkgYi9XZWJLaXRUb29scy9TY3Jp cHRzL21vZHVsZXMvY3BwX3N0eWxlLnB5CmluZGV4IGZjMTQzYTkuLmM2M2JmNzUgMTAwNjQ0Ci0t LSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGUucHkKKysrIGIvV2ViS2l0 VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZS5weQpAQCAtMjczNCw3ICsyNzM0LDEwIEBA IGRlZiBjaGVja19pZGVudGlmaWVyX25hbWVfaW5fZGVjbGFyYXRpb24oZmlsZW5hbWUsIGxpbmVf bnVtYmVyLCBsaW5lLCBlcnJvcik6CiAgICAgICAgICMgUmVtb3ZlICJtXyIgYW5kICJzXyIgdG8g YWxsb3cgdGhlbS4KICAgICAgICAgbW9kaWZpZWRfaWRlbnRpZmllciA9IHN1YihyJyhefCg/PD06 OikpW21zXV8nLCAnJywgaWRlbnRpZmllcikKICAgICAgICAgaWYgbW9kaWZpZWRfaWRlbnRpZmll ci5maW5kKCdfJykgPj0gMDoKLSAgICAgICAgICAgIGVycm9yKGZpbGVuYW1lLCBsaW5lX251bWJl ciwgJ3JlYWRhYmlsaXR5L25hbWluZycsIDQsIGlkZW50aWZpZXIgKyAiIGlzIGluY29ycmVjdGx5 IG5hbWVkLiBEb24ndCB1c2UgdW5kZXJzY29yZXMgaW4geW91ciBpZGVudGlmaWVyIG5hbWVzLiIp CisgICAgICAgICAgICAjIFZhcmlvdXMgZXhjZXB0aW9ucyB0byB0aGUgcnVsZTogSmF2YVNjcmlw dCBvcCBjb2RlcyBmdW5jdGlvbnMsIGNvbnN0X2l0ZXJhdG9yLgorICAgICAgICAgICAgaWYgKG5v dCAoZmlsZW5hbWUuZmluZCgnSmF2YVNjcmlwdENvcmUnKSA+PSAwIGFuZCBtb2RpZmllZF9pZGVu dGlmaWVyLmZpbmQoJ19vcF8nKSA+PSAwKQorICAgICAgICAgICAgICAgIGFuZCBub3QgbW9kaWZp ZWRfaWRlbnRpZmllciA9PSAiY29uc3RfaXRlcmF0b3IiKToKKyAgICAgICAgICAgICAgICBlcnJv cihmaWxlbmFtZSwgbGluZV9udW1iZXIsICdyZWFkYWJpbGl0eS9uYW1pbmcnLCA0LCBpZGVudGlm aWVyICsgIiBpcyBpbmNvcnJlY3RseSBuYW1lZC4gRG9uJ3QgdXNlIHVuZGVyc2NvcmVzIGluIHlv dXIgaWRlbnRpZmllciBuYW1lcy4iKQogCiAgICAgICAgICMgVGhlcmUgY2FuIGJlIG9ubHkgb25l IGRlY2xhcmF0aW9uIGluIG5vbi1mb3ItY29udHJvbCBzdGF0ZW1lbnRzLgogICAgICAgICBpZiBj b250cm9sX3N0YXRlbWVudDoKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxl cy9jcHBfc3R5bGVfdW5pdHRlc3QucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3Bw X3N0eWxlX3VuaXR0ZXN0LnB5CmluZGV4IDNmMGYyMzAuLmU2ZTQyNmYgMTAwNjQ0Ci0tLSBhL1dl YktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGVfdW5pdHRlc3QucHkKKysrIGIvV2Vi S2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZV91bml0dGVzdC5weQpAQCAtMzY5Miw2 ICszNjkyLDE0IEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAg ICAgICAgICAgICAgICAgICAgICAgICBbJ3ZhcmlhYmxlXzEnICsgbmFtZV9lcnJvcl9tZXNzYWdl LAogICAgICAgICAgICAgICAgICAgICAgICAgICAndmFyaWFibGVfMicgKyBuYW1lX2Vycm9yX21l c3NhZ2VdKQogCisgICAgICAgICMgVGhlcmUgaXMgYW4gZXhjZXB0aW9uIGZvciBvcCBjb2RlIGZ1 bmN0aW9ucyBidXQgb25seSBpbiB0aGUgSmF2YVNjcmlwdENvcmUgZGlyZWN0b3J5LgorICAgICAg ICBzZWxmLmFzc2VydF9saW50KCd2b2lkIHRoaXNfb3BfY29kZShpbnQgdmFyMSwgaW50IHZhcjIp JywgJycsICdKYXZhU2NyaXB0Q29yZS9mb28uY3BwJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGlu dCgndm9pZCB0aGlzX29wX2NvZGUoaW50IHZhcjEsIGludCB2YXIyKScsICd0aGlzX29wX2NvZGUn ICsgbmFtZV9lcnJvcl9tZXNzYWdlKQorCisgICAgICAgICMgY29uc3RfaXRlcmF0b3IgaXMgYWxs b3dlZCBhcyB3ZWxsLgorICAgICAgICBzZWxmLmFzc2VydF9saW50KCd0eXBlZGVmIFZlY3RvclR5 cGU6OmNvbnN0X2l0ZXJhdG9yIGNvbnN0X2l0ZXJhdG9yOycsICcnKQorCisKICAgICBkZWYgdGVz dF9vdGhlcihzZWxmKToKICAgICAgICAgIyBGSVhNRTogSW1wbGVtZW50IHRoaXMuCiAgICAgICAg IHBhc3MK