32175 2009-12-04 15:13:22 -0800 REGRESSION: websocket/tests/url-parsing.html is crashing on Leopard Bot 2009-12-05 15:59:38 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac (Intel) OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric ap ap darin webkit.review.bot oldest_to_newest 168948 0 eric 2009-12-04 15:13:22 -0800 REGRESSION: websocket/tests/url-parsing.html is crashing on Leopard Bot It just crashed the last 3 builds in a row: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r51714%20(7901)/results.html http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r51715%20(7901)/results.html http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r51716%20(7901)/results.html It does not seem related to the r51714 checkin however. 168969 1 ap 2009-12-04 16:12:33 -0800 I do sometimes get this assertion on Leopard, but never on SnowLeopard. 168970 2 darin 2009-12-04 16:13:11 -0800 Makes it sound like a CFNetwork bug. 168983 3 44340 ap 2009-12-04 16:43:01 -0800 Created attachment 44340 proposed fix I think it's just a change in behavior in CFNetwork, not a bug. The fix is a little heavy-handed, as there is no need to call CFWriteStreamClose(), and probably no need to unschedule the read stream. But it seems to work fine in my testing. 168985 4 ap 2009-12-04 16:44:23 -0800 *** Bug 32091 has been marked as a duplicate of this bug. *** 168988 5 webkit.review.bot 2009-12-04 16:48:16 -0800 style-queue ran check-webkit-style on attachment 44340 without any errors. 169037 6 44340 eric 2009-12-05 13:05:57 -0800 Comment on attachment 44340 proposed fix OK. Here's hoping it stops the crashes. :) 169052 7 ap 2009-12-05 15:59:38 -0800 Committed revision 51732. 44340 2009-12-04 16:43:01 -0800 2009-12-05 13:05:56 -0800 proposed fix WSLeoCrash.txt text/plain 1814 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTcyMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTItMDQgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMTc1CisgICAgICAgIFJF R1JFU1NJT046IHdlYnNvY2tldC90ZXN0cy91cmwtcGFyc2luZy5odG1sIGlzIGNyYXNoaW5nIG9u IExlb3BhcmQgQm90CisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2NmL1NvY2tldFN0cmVh bUhhbmRsZUNGTmV0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNvY2tldFN0cmVhbUhhbmRsZTo6 cmVhZFN0cmVhbUNhbGxiYWNrKTogQ2FsbCBwbGF0Zm9ybUNsb3NlKCkgdG8gdW5zY2hlZHVsZSBi b3RoCisgICAgICAgIHN0cmVhbXMsIGd1YXJhbnRlZWluZyB0aGF0IHRoZXJlIHdpbGwgYmUgbm8g Y2FsbGJhY2tzIGFmdGVyIFNvY2tldFN0cmVhbUhhbmRsZSBpcyBkZXN0cm95ZWQuCisgICAgICAg IChXZWJDb3JlOjpTb2NrZXRTdHJlYW1IYW5kbGU6OndyaXRlU3RyZWFtQ2FsbGJhY2spOiBFZGl0 ZWQgYSBjb21tZW50IGEgYml0LgorCiAyMDA5LTEyLTA0ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5m cmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCklu ZGV4OiBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvU29ja2V0U3RyZWFtSGFuZGxlQ0ZOZXQu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9Tb2NrZXRTdHJl YW1IYW5kbGVDRk5ldC5jcHAJKHJldmlzaW9uIDUxNzAyKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2NmL1NvY2tldFN0cmVhbUhhbmRsZUNGTmV0LmNwcAkod29ya2luZyBjb3B5KQpAQCAt NTI5LDcgKzUyOSw3IEBAIHZvaWQgU29ja2V0U3RyZWFtSGFuZGxlOjpyZWFkU3RyZWFtQ2FsbGIK ICAgICAgICAgYnJlYWs7CiAgICAgfQogICAgIGNhc2Uga0NGU3RyZWFtRXZlbnRFbmRFbmNvdW50 ZXJlZDoKLSAgICAgICAgbV9jbGllbnQtPmRpZENsb3NlKHRoaXMpOworICAgICAgICBwbGF0Zm9y bUNsb3NlKCk7CiAgICAgICAgIGJyZWFrOwogICAgIH0KIH0KQEAgLTU3MSw3ICs1NzEsNyBAQCB2 b2lkIFNvY2tldFN0cmVhbUhhbmRsZTo6d3JpdGVTdHJlYW1DYWxsCiAgICAgICAgIGJyZWFrOwog ICAgIH0KICAgICBjYXNlIGtDRlN0cmVhbUV2ZW50RW5kRW5jb3VudGVyZWQ6Ci0gICAgICAgIC8v IEZJWE1FOiBDdXJyZW50bHksIHdlIGNhbGwgZGlkQ2xvc2UgZnJvbSByZWFkIGNhbGxiYWNrLCBi dXQgdGhlc2UgY2FuIGNvbWUgaW5kZXBlbmRlbnRseSAoZS5nLiBhIHNlcnZlciBjYW4gc3RvcCBs aXN0ZW5pbmcsIGJ1dCBrZWVwIHNlbmRpbmcgZGF0YSkuCisgICAgICAgIC8vIEZJWE1FOiBDdXJy ZW50bHksIHdlIGhhbmRsZSBjbG9zaW5nIGluIHJlYWQgY2FsbGJhY2ssIGJ1dCB0aGVzZSBjYW4g Y29tZSBpbmRlcGVuZGVudGx5IChlLmcuIGEgc2VydmVyIGNhbiBzdG9wIGxpc3RlbmluZywgYnV0 IGtlZXAgc2VuZGluZyBkYXRhKS4KICAgICAgICAgYnJlYWs7CiAgICAgfQogfQo=