32162 2009-12-04 08:57:26 -0800 Assert in BidiContext is wrong and only works by luck 2009-12-04 09:14:43 -0800 1 1 1 Unclassified WebKit Text 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 manyoso manyoso webkit.review.bot oldest_to_newest 168785 0 manyoso 2009-12-04 08:57:26 -0800 The first assert in BidiContext only works through sheer luck. The enum WTF::Unicode::Direction has LeftToRight == 0 and RightToLeft == 1 for both ICU and Qt4. Other implementations that have different values for this enum will fail. Fix coming... 168787 1 44319 manyoso 2009-12-04 09:02:48 -0800 Created attachment 44319 Fix for assert. 168789 2 webkit.review.bot 2009-12-04 09:07:28 -0800 style-queue ran check-webkit-style on attachment 44319 without any errors. 168790 3 manyoso 2009-12-04 09:14:43 -0800 Landed with r51697. 44319 2009-12-04 09:02:48 -0800 2009-12-04 09:10:03 -0800 Fix for assert. 32162.diff text/plain 1152 manyoso ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg N2ZiNzdkMy4uOWFmZjBkYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMi0wNCAgQWRhbSBUcmVhdCAg PGF0cmVhdEByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZpeCB3cm9uZyBhc3NlcnQgdGhhdCB3YXMgb25seSB3b3JraW5nIHRocm91Z2gg c2hlZXIgbHVjay4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMyMTYyCisKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L0JpZGlDb250ZXh0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkJpZGlDb250ZXh0OjpjcmVhdGUpOgorCiAyMDA5LTEyLTA0ICBUb3Ig QXJuZSBWZXN0YsO4ICA8dG9yLmFybmUudmVzdGJvQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vdGV4 dC9CaWRpQ29udGV4dC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL3RleHQvQmlkaUNvbnRleHQuY3Bw CmluZGV4IDU0NjU3MWUuLjU5ZGI3YmQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vdGV4 dC9CaWRpQ29udGV4dC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0JpZGlDb250ZXh0 LmNwcApAQCAtMzAsNyArMzAsNyBAQCB1c2luZyBuYW1lc3BhY2UgV1RGOjpVbmljb2RlOwogCiBQ YXNzUmVmUHRyPEJpZGlDb250ZXh0PiBCaWRpQ29udGV4dDo6Y3JlYXRlKHVuc2lnbmVkIGNoYXIg bGV2ZWwsIERpcmVjdGlvbiBkaXJlY3Rpb24sIGJvb2wgb3ZlcnJpZGUsIEJpZGlDb250ZXh0KiBw YXJlbnQpCiB7Ci0gICAgQVNTRVJUKGRpcmVjdGlvbiA9PSBsZXZlbCAlIDIgPyBSaWdodFRvTGVm dCA6IExlZnRUb1JpZ2h0KTsKKyAgICBBU1NFUlQoZGlyZWN0aW9uID09IChsZXZlbCAlIDIgPyBS aWdodFRvTGVmdCA6IExlZnRUb1JpZ2h0KSk7CiAKICAgICBpZiAocGFyZW50KQogICAgICAgICBy ZXR1cm4gYWRvcHRSZWYobmV3IEJpZGlDb250ZXh0KGxldmVsLCBkaXJlY3Rpb24sIG92ZXJyaWRl LCBwYXJlbnQpKTsK