32151 2009-12-04 05:08:45 -0800 String::append(const String& str) check whether str.length() != 0 2009-12-04 12:01:36 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 0 zherczeg webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 168731 0 zherczeg 2009-12-04 05:08:45 -0800 In CachedScript.cpp: const String& CachedScript::script() { ASSERT(!isPurgeable()); if (!m_script && m_data) { m_script = m_decoder->decode(m_data->data(), encodedSize()); m_script += m_decoder->flush(); setDecodedSize(m_script.length() * sizeof(UChar)); } m_decodedDataDeletionTimer.startOneShot(0); return m_script; } m_decoder->flush() usually returns with an empty string. However, the append duplicates the original string even in this case. (The script can be half mbyte or more). This is an unnecessary allocation and copy. 168741 1 44309 zherczeg 2009-12-04 05:37:07 -0800 Created attachment 44309 (Platform) String append patch 168743 2 webkit.review.bot 2009-12-04 05:37:31 -0800 style-queue ran check-webkit-style on attachment 44309 without any errors. 168862 3 44309 commit-queue 2009-12-04 12:01:27 -0800 Comment on attachment 44309 (Platform) String append patch Clearing flags on attachment: 44309 Committed r51705: <http://trac.webkit.org/changeset/51705> 168863 4 commit-queue 2009-12-04 12:01:36 -0800 All reviewed patches have been landed. Closing bug. 44309 2009-12-04 05:37:07 -0800 2009-12-04 12:01:27 -0800 (Platform) String append patch 0001-String-append.patch text/plain 1789 zherczeg RnJvbSAzZDhhZGRiOTY4ZTNmMTc3OTdhOTgyZDFmNjVkZGUyZDA4MmRlNDg5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBGcmksIDQgRGVjIDIwMDkgMTQ6MzI6NDYgKzAxMDAKU3ViamVjdDogW1BBVENI XSBTdHJpbmcgYXBwZW5kCgpTaWduZWQtb2ZmLWJ5OiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdA aW5mLnUtc3plZ2VkLmh1PgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgIHwg ICAxNSArKysrKysrKysrKysrKysKIFdlYkNvcmUvcGxhdGZvcm0vdGV4dC9TdHJpbmcuY3BwIHwg ICAgMyArKysKIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmlu ZGV4IDg1NjFiMjAuLjdmYTA5ZjIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMTItMDQgIFpvbHRhbiBI ZXJjemVnICA8emhlcmN6ZWdAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoZWNrIHdoZXRoZXIgdGhlIHJpZ2h0IHNpZGUg b2YgYSBzdHJpbmcgYXBwZW5kIGlzIG5vbi1lbXB0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzIxNTEKKworICAgICAgICBFc3BlY2lhbGx5IGJlbmVm aWNpYWwgZm9yIENhY2hlZFNjcmlwdDo6c2NyaXB0KCkgbWV0aG9kCisgICAgICAgIHdoaWNoIHVz dWFsbHkgYXBwZW5kcyBhbiBlbXB0eSBzdHJpbmcgcmV0dXJuZWQgYnkgZmx1c2goKQorICAgICAg ICB0byBpdHMgbV9zY3JpcHQgbWVtYmVyLiBtX3NjcmlwdCBpcyBvZnRlbiBodW5kcmVkcyBvZiBr Ynl0ZXMKKyAgICAgICAgd2hpY2ggaXMgZHVwbGF0ZWQgd2l0aG91dCByZWFzb24uCisKKyAgICAg ICAgKiBwbGF0Zm9ybS90ZXh0L1N0cmluZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHJpbmc6 OmFwcGVuZCk6CisKIDIwMDktMTEtMjkgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUB3ZWJraXQu b3JnPgogCiAgICAgICAgIEJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0v dGV4dC9TdHJpbmcuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1N0cmluZy5jcHAKaW5kZXgg NDQ1ODJhOS4uMjQ2NTlhNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1N0cmlu Zy5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1N0cmluZy5jcHAKQEAgLTgxLDYgKzgx LDkgQEAgU3RyaW5nOjpTdHJpbmcoY29uc3QgY2hhciogc3RyLCB1bnNpZ25lZCBsZW5ndGgpCiAK IHZvaWQgU3RyaW5nOjphcHBlbmQoY29uc3QgU3RyaW5nJiBzdHIpCiB7CisgICAgaWYgKHN0ci5p c0VtcHR5KCkpCisgICAgICAgcmV0dXJuOworCiAgICAgLy8gRklYTUU6IFRoaXMgaXMgZXh0cmVt ZWx5IGluZWZmaWNpZW50LiBTbyBtdWNoIHNvIHRoYXQgd2UgbWlnaHQgd2FudCB0byB0YWtlIHRo aXMKICAgICAvLyBvdXQgb2YgU3RyaW5nJ3MgQVBJLiBXZSBjYW4gbWFrZSBpdCBiZXR0ZXIgYnkg b3B0aW1pemluZyB0aGUgY2FzZSB3aGVyZSBleGFjdGx5CiAgICAgLy8gb25lIFN0cmluZyBpcyBw b2ludGluZyBhdCB0aGlzIFN0cmluZ0ltcGwsIGJ1dCBldmVuIHRoZW4gaXQncyBnb2luZyB0byBy ZXF1aXJlIGEKLS0gCjEuNi4wLjQKCg==