32135 2009-12-03 14:32:14 -0800 [Qt] New layout tests result added 2009-12-03 15:32:46 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P3 Normal --- 1 ossy webkit-unassigned abecsi commit-queue eric webkit.review.bot oldest_to_newest 168548 0 ossy 2009-12-03 14:32:14 -0800 There are two new tests seem to be good if compared to the Mac expected png files. We can find only some pixel differences. --- /home/ossy/webkit/LayoutTests/platform/mac/fast/css/namespaces/namespaces-escapes-expected.txt 2009-12-02 18:14:34.000000000 -0600 +++ /home/ossy/webkit/LayoutTests/platform/qt/fast/css/namespaces/namespaces-escapes-expected.txt 2009-12-03 17:55:23.000000000 -0600 @@ -1,8 +1,8 @@ layer at (0,0) size 800x600 RenderView at (0,0) size 800x600 -layer at (0,0) size 800x50 - RenderBlock {html} at (0,0) size 800x50 - RenderBody {body} at (8,16) size 784x18 - RenderBlock {p} at (0,0) size 784x18 [bgcolor=#00FF00] - RenderText {#text} at (0,0) size 299x18 - text run at (0,0) width 299: "This sentence should have a green background." +layer at (0,0) size 800x52 + RenderBlock {html} at (0,0) size 800x52 + RenderBody {body} at (8,16) size 784x20 + RenderBlock {p} at (0,0) size 784x20 [bgcolor=#00FF00] + RenderText {#text} at (0,0) size 341x20 + text run at (0,0) width 341: "This sentence should have a green background." --- /home/ossy/webkit/LayoutTests/platform/mac/fast/css/namespaces/namespaces-invalid-at-expected.txt 2009-12-02 18:14:34.000000000 -0600 +++ /home/ossy/webkit/LayoutTests/platform/qt/fast/css/namespaces/namespaces-invalid-at-expected.txt 2009-12-03 17:55:23.000000000 -0600 @@ -1,17 +1,17 @@ layer at (0,0) size 800x600 RenderView at (0,0) size 800x600 -layer at (0,0) size 800x118 - RenderBlock {html} at (0,0) size 800x118 - RenderBody {body} at (8,16) size 784x86 - RenderBlock {p} at (0,0) size 784x18 - RenderInline {t} at (0,0) size 299x18 [bgcolor=#00FF00] - RenderText {#text} at (0,0) size 299x18 - text run at (0,0) width 299: "This sentence should have a green background." - RenderBlock {p} at (0,34) size 784x18 - RenderInline {t2} at (0,0) size 299x18 [bgcolor=#00FF00] - RenderText {#text} at (0,0) size 299x18 - text run at (0,0) width 299: "This sentence should have a green background." - RenderBlock {p} at (0,68) size 784x18 - RenderInline {t3} at (0,0) size 299x18 [bgcolor=#00FF00] - RenderText {#text} at (0,0) size 299x18 - text run at (0,0) width 299: "This sentence should have a green background." +layer at (0,0) size 800x124 + RenderBlock {html} at (0,0) size 800x124 + RenderBody {body} at (8,16) size 784x92 + RenderBlock {p} at (0,0) size 784x20 + RenderInline {t} at (0,0) size 341x20 [bgcolor=#00FF00] + RenderText {#text} at (0,0) size 341x20 + text run at (0,0) width 341: "This sentence should have a green background." + RenderBlock {p} at (0,36) size 784x20 + RenderInline {t2} at (0,0) size 341x20 [bgcolor=#00FF00] + RenderText {#text} at (0,0) size 341x20 + text run at (0,0) width 341: "This sentence should have a green background." + RenderBlock {p} at (0,72) size 784x20 + RenderInline {t3} at (0,0) size 341x20 [bgcolor=#00FF00] + RenderText {#text} at (0,0) size 341x20 + text run at (0,0) width 341: "This sentence should have a green background." 168552 1 44269 ossy 2009-12-03 14:40:50 -0800 Created attachment 44269 proposed patch 168554 2 webkit.review.bot 2009-12-03 14:43:48 -0800 style-queue ran check-webkit-style on attachment 44269 without any errors. 168565 3 44269 eric 2009-12-03 15:14:18 -0800 Comment on attachment 44269 proposed patch OK. I'm surprised this needs to be a render tree dump at all. :( 168572 4 44269 commit-queue 2009-12-03 15:24:27 -0800 Comment on attachment 44269 proposed patch Clearing flags on attachment: 44269 Committed r51665: <http://trac.webkit.org/changeset/51665> 168573 5 commit-queue 2009-12-03 15:24:31 -0800 All reviewed patches have been landed. Closing bug. 168576 6 ossy 2009-12-03 15:28:19 -0800 (In reply to comment #3) > (From update of attachment 44269 [details]) > OK. > > I'm surprised this needs to be a render tree dump at all. :( Thx. I attached the diff for reviewer to check validity easily. Do you say this kind of patches don't need detailed diffs? 168577 7 eric 2009-12-03 15:32:46 -0800 No, my comment was that I don't think this test shoudl have been written as a render tree dump. It could have been dumpAsText() with the proper getComputedStyle() calls to validate that the text was green. 44269 2009-12-03 14:40:50 -0800 2009-12-03 15:24:27 -0800 proposed patch patch.diff text/plain 2665 ossy ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkZDJkOTcxLi45MmJmMGU2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTIt MDMgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzIxMzUKKworICAgICAgICBbUXRdIEFkZCBleHBlY3RlZCBmaWxl cyBmb3IgbmV3IHRlc3RzIHdlIHBhc3MuCisgICAgICAgIENvbXBhcmVkIHRvIHRoZSBNYWMgZXhw ZWN0ZWQgcG5nIGZpbGVzLgorCisgICAgICAgICogcGxhdGZvcm0vcXQvZmFzdC9jc3MvbmFtZXNw YWNlcy9uYW1lc3BhY2VzLWVzY2FwZXMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBw bGF0Zm9ybS9xdC9mYXN0L2Nzcy9uYW1lc3BhY2VzL25hbWVzcGFjZXMtaW52YWxpZC1hdC1leHBl Y3RlZC50eHQ6IEFkZGVkLgorCiAyMDA5LTEyLTAzICBCcmlhbiBXZWluc3RlaW4gIDxid2VpbnN0 ZWluQGFwcGxlLmNvbT4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBBbGV4ZXkgUHJvc2t1 cnlha292LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvZmFzdC9jc3MvbmFt ZXNwYWNlcy9uYW1lc3BhY2VzLWVzY2FwZXMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vcXQvZmFzdC9jc3MvbmFtZXNwYWNlcy9uYW1lc3BhY2VzLWVzY2FwZXMtZXhwZWN0ZWQu dHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjgyYzdjOGYKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9mYXN0L2Nzcy9uYW1lc3BhY2VzL25h bWVzcGFjZXMtZXNjYXBlcy1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw4IEBACitsYXllciBhdCAo MCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBhdCAoMCwwKSBzaXplIDgwMHg2MDAKK2xh eWVyIGF0ICgwLDApIHNpemUgODAweDUyCisgIFJlbmRlckJsb2NrIHtodG1sfSBhdCAoMCwwKSBz aXplIDgwMHg1MgorICAgIFJlbmRlckJvZHkge2JvZHl9IGF0ICg4LDE2KSBzaXplIDc4NHgyMAor ICAgICAgUmVuZGVyQmxvY2sge3B9IGF0ICgwLDApIHNpemUgNzg0eDIwIFtiZ2NvbG9yPSMwMEZG MDBdCisgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDM0MXgyMAorICAg ICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDM0MTogIlRoaXMgc2VudGVuY2Ugc2hvdWxk IGhhdmUgYSBncmVlbiBiYWNrZ3JvdW5kLiIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL3F0L2Zhc3QvY3NzL25hbWVzcGFjZXMvbmFtZXNwYWNlcy1pbnZhbGlkLWF0LWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvY3NzL25hbWVzcGFjZXMvbmFtZXNw YWNlcy1pbnZhbGlkLWF0LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi4xZjE0NzhjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v cXQvZmFzdC9jc3MvbmFtZXNwYWNlcy9uYW1lc3BhY2VzLWludmFsaWQtYXQtZXhwZWN0ZWQudHh0 CkBAIC0wLDAgKzEsMTcgQEAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJW aWV3IGF0ICgwLDApIHNpemUgODAweDYwMAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4MTI0Cisg IFJlbmRlckJsb2NrIHtodG1sfSBhdCAoMCwwKSBzaXplIDgwMHgxMjQKKyAgICBSZW5kZXJCb2R5 IHtib2R5fSBhdCAoOCwxNikgc2l6ZSA3ODR4OTIKKyAgICAgIFJlbmRlckJsb2NrIHtwfSBhdCAo MCwwKSBzaXplIDc4NHgyMAorICAgICAgICBSZW5kZXJJbmxpbmUge3R9IGF0ICgwLDApIHNpemUg MzQxeDIwIFtiZ2NvbG9yPSMwMEZGMDBdCisgICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0 ICgwLDApIHNpemUgMzQxeDIwCisgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCAz NDE6ICJUaGlzIHNlbnRlbmNlIHNob3VsZCBoYXZlIGEgZ3JlZW4gYmFja2dyb3VuZC4iCisgICAg ICBSZW5kZXJCbG9jayB7cH0gYXQgKDAsMzYpIHNpemUgNzg0eDIwCisgICAgICAgIFJlbmRlcklu bGluZSB7dDJ9IGF0ICgwLDApIHNpemUgMzQxeDIwIFtiZ2NvbG9yPSMwMEZGMDBdCisgICAgICAg ICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgMzQxeDIwCisgICAgICAgICAgICB0 ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCAzNDE6ICJUaGlzIHNlbnRlbmNlIHNob3VsZCBoYXZlIGEg Z3JlZW4gYmFja2dyb3VuZC4iCisgICAgICBSZW5kZXJCbG9jayB7cH0gYXQgKDAsNzIpIHNpemUg Nzg0eDIwCisgICAgICAgIFJlbmRlcklubGluZSB7dDN9IGF0ICgwLDApIHNpemUgMzQxeDIwIFti Z2NvbG9yPSMwMEZGMDBdCisgICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNp emUgMzQxeDIwCisgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCAzNDE6ICJUaGlz IHNlbnRlbmNlIHNob3VsZCBoYXZlIGEgZ3JlZW4gYmFja2dyb3VuZC4iCg==