32134 2009-12-03 14:22:01 -0800 LayoutTests/transitions/shorthand-transitions.html is flaky 2009-12-03 15:38:53 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jparent jparent webkit.review.bot oldest_to_newest 168544 0 jparent 2009-12-03 14:22:01 -0800 This is a timing dependent test, that uses a variety of different tolerances for checking each value - some allow for 100ms variation, others only 50ms. This results in flaky behavior - see http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#maxResults=200&tests=LayoutTests%2Ftransitions%2Fshorthand-transitions.html for the history of this test running on Chromium's bots. For the slowest, most loaded bot, this fails 26% of the time! 168550 1 44268 jparent 2009-12-03 14:37:42 -0800 Created attachment 44268 Make tolerances consistent - all now allow for 100ms variation. 168551 2 webkit.review.bot 2009-12-03 14:38:22 -0800 style-queue ran check-webkit-style on attachment 44268 without any errors. 168569 3 44268 eric 2009-12-03 15:20:19 -0800 Comment on attachment 44268 Make tolerances consistent - all now allow for 100ms variation. Needs a clearer comment. We discussed in person. Thanks! 168581 4 jparent 2009-12-03 15:38:53 -0800 Comment made better (with math!) and committed in http://trac.webkit.org/changeset/51666. 44268 2009-12-03 14:37:42 -0800 2009-12-03 15:20:19 -0800 Make tolerances consistent - all now allow for 100ms variation. shorthandTransitions.txt text/plain 2132 jparent SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUxNjY0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMTItMDMgIEp1bGllIFBhcmVudCAgPGpw YXJlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE1ha2Ugc2hvcnRoYW5kLXRyYW5zaXRpb25zLmh0bWwgbGVzcyBmbGFreS4K KyAgICAgICAgVGhlIHRlc3QgY3VycmVudGx5IGFsbG93cyBmb3IgdGltaW5nIHJlbGF0ZWQgZGlm ZmVyZW5jZXMgYnkgdXNpbmcgYSB0b2xlcmFuY2UsIGJ1dCB0aGUgdG9sZXJhbmNlCisgICAgICAg IGlzIGluY29uc2lzdGVudCBpbiB0aGUgdGVzdCwgZXZlbiBmb3IgdmFsdWVzIHJlYWQgYXQgdGhl IHNhbWUgdGltZSAoc29tZSB2YWx1ZXMgYXJlIGFsbG93ZWQgYSAxMDBtcyAKKyAgICAgICAgZGlm ZmVyZW5jZSwgb3RoZXJzIGFyZSBvbmx5IGFsbG93ZWQgNTBtcykuICBUaGlzIGNoYW5nZSBtYWtl cyBhbGwgdmFsdWVzIGhhdmUgYSAxMDBtcyB0b2xlcmFuY2UuCisgICAgICAgIChvcGVuIHF1ZXN0 aW9uOiBpcyAxMDBtcyBlbm91Z2g/ICBJJ3ZlIGxvb2tlZCB0aHJvdWdoIGEgYnVuY2ggb2YgbG9n cyBvZiBmYWlsdXJlcyBhbmQgaXQgc2VlbXMgdG8gYmUsCisgICAgICAgIHNvIHRoaXMgc2hvdWxk IGRlZmluaXRlbHkgaGVscCByZWR1Y2UgYnV0IHRoaXMgbWF5IG5vdCBlbnRpcmVseSBlbGltaW5h dGUgZmxha2luZXNzKS4KKyAgICAgICAgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zMjEzNAorCisgICAgICAgICogdHJhbnNpdGlvbnMvc2hvcnRoYW5k LXRyYW5zaXRpb25zLmh0bWw6CisKIDIwMDktMTItMDMgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWlu c3RlaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IEFsZXhleSBQcm9z a3VyeWFrb3YuCkluZGV4OiBMYXlvdXRUZXN0cy90cmFuc2l0aW9ucy9zaG9ydGhhbmQtdHJhbnNp dGlvbnMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy90cmFuc2l0aW9ucy9zaG9ydGhh bmQtdHJhbnNpdGlvbnMuaHRtbAkocmV2aXNpb24gNTE2NDIpCisrKyBMYXlvdXRUZXN0cy90cmFu c2l0aW9ucy9zaG9ydGhhbmQtdHJhbnNpdGlvbnMuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMzMs MTIgKzMzLDEzIEBACiAgICAgCiAgICAgY29uc3QgZXhwZWN0ZWRWYWx1ZXMgPSBbCiAgICAgICAv LyBbdGltZSwgZWxlbWVudC1pZCwgcHJvcGVydHksIGV4cGVjdGVkLXZhbHVlLCB0b2xlcmFuY2Vd CisgICAgICAvLyBUb2xlcmFuY2UgaXMgY29tcHV0ZWQgdG8gYWxsb3cgMTAwbXMgdmFyaWFuY2Uu CiAgICAgICBbMC41LCAnYm94JywgJ3BhZGRpbmctdG9wJywgNSwgMV0sCi0gICAgICBbMC41LCAn Ym94JywgJ21hcmdpbi10b3AnLCAyNSwgMl0sCi0gICAgICBbMC41LCAnYm94JywgJ291dGxpbmUt Y29sb3InLCBbMTI4LCAwLCAxMjhdLCAxMF0sCi0gICAgICBbMC41LCAnYm94JywgJ2JhY2tncm91 bmQtY29sb3InLCBbMTI4LCAxMjgsIDI1NV0sIDEwXSwKKyAgICAgIFswLjUsICdib3gnLCAnbWFy Z2luLXRvcCcsIDI1LCAzXSwKKyAgICAgIFswLjUsICdib3gnLCAnb3V0bGluZS1jb2xvcicsIFsx MjgsIDAsIDEyOF0sIDI2XSwKKyAgICAgIFswLjUsICdib3gnLCAnYmFja2dyb3VuZC1jb2xvcics IFsxMjgsIDEyOCwgMjU1XSwgMjZdLAogICAgICAgWzAuNSwgJ2JveCcsICctd2Via2l0LWJvcmRl ci10b3AtcmlnaHQtcmFkaXVzJywgMTAsIDJdLAotICAgICAgWzAuNSwgJ2JveCcsICctd2Via2l0 LXRyYW5zZm9ybS1vcmlnaW4nLCBbNTAsIDUwXSwgNV0sCisgICAgICBbMC41LCAnYm94JywgJy13 ZWJraXQtdHJhbnNmb3JtLW9yaWdpbicsIFs1MCwgNTBdLCAxMF0sCiAgICAgXTsKICAgICAKICAg ICBmdW5jdGlvbiBzZXR1cFRlc3QoKQo=