32132 2009-12-03 13:25:02 -0800 websocket/tests/simple.html fails on Windows 2009-12-03 16:07:33 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 ap ap bweinstein ukai webkit.review.bot oldest_to_newest 168521 0 ap 2009-12-03 13:25:02 -0800 <http://build.webkit.org/results/Windows%20Debug%20(Tests)/r51652%20(7132)/websocket/tests/simple-pretty-diff.html> 168522 1 bweinstein 2009-12-03 13:28:24 -0800 Added to Skipped list in r51657. 168524 2 ap 2009-12-03 13:32:44 -0800 I actually think that my changes to the test were incorrect. These events are posted, not dispatched synchronously, so one can't rely on readyState value in a handler. 168580 3 44273 ap 2009-12-03 15:37:10 -0800 Created attachment 44273 proposed fix 168582 4 webkit.review.bot 2009-12-03 15:41:00 -0800 style-queue ran check-webkit-style on attachment 44273 without any errors. 168589 5 ap 2009-12-03 16:07:33 -0800 Committed revision 51667. 44273 2009-12-03 15:37:10 -0800 2009-12-03 15:55:02 -0800 proposed fix NotSoSimple.txt text/plain 3214 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUxNjU3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTItMDMgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMTMy CisgICAgICAgIHdlYnNvY2tldC90ZXN0cy9zaW1wbGUuaHRtbCBmYWlscyBvbiBXaW5kb3dzCisK KyAgICAgICAgKiB3ZWJzb2NrZXQvdGVzdHMvc2NyaXB0LXRlc3RzL3NpbXBsZS5qczoKKyAgICAg ICAgKiB3ZWJzb2NrZXQvdGVzdHMvc2ltcGxlLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgTWFrZSB0 aGUgdGVzdCB3ZWFrZXIgLSByZWFkeVN0YXRlIGNvdWxkIGFscmVhZHkgZ3JvdyBieSB0aGUgdGlt ZSBhIHBvc3RlZCBldmVudCBnZXRzIGRpc3BhdGNoZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93 aW4vU2tpcHBlZDogVW4tc2tpcCB0aGUgdGVzdC4KKwogMjAwOS0xMi0wMyAgQnJpYW4gV2VpbnN0 ZWluICA8YndlaW5zdGVpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkg QWxleGV5IFByb3NrdXJ5YWtvdi4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9Ta2lw cGVkCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9Ta2lwcGVkCShyZXZp c2lvbiA1MTY1NykKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9Ta2lwcGVkCSh3b3JraW5n IGNvcHkpCkBAIC03MjIsNiArNzIyLDMgQEAgaW5zcGVjdG9yL3RpbWVsaW5lLW5ldHdvcmstcmVz b3VyY2UuaHRtbAogCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z MjAzOCAtIEZsYWt5IG9uIFdpbmRvd3MKIGh0dHAvdGVzdHMvY2FjaGUvc3VicmVzb3VyY2UtZmFp bG92ZXItdG8tbmV0d29yay5odG1sCi0KLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTMyMTMyCi13ZWJzb2NrZXQvdGVzdHMvc2ltcGxlLmh0bWwKSW5kZXg6IExheW91 dFRlc3RzL3dlYnNvY2tldC90ZXN0cy9zaW1wbGUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL3dlYnNvY2tldC90ZXN0cy9zaW1wbGUtZXhwZWN0ZWQudHh0CShyZXZpc2lv biA1MTY1MykKKysrIExheW91dFRlc3RzL3dlYnNvY2tldC90ZXN0cy9zaW1wbGUtZXhwZWN0ZWQu dHh0CSh3b3JraW5nIGNvcHkpCkBAIC0yLDEwICsyLDEwIEBAIFNpbXBsZSBXZWIgU29ja2V0IHRl c3QKIAogT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdl cywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgogCi1DcmVhdGVkIGEgc29ja2V0IHRvICd3 czovL2xvY2FsaG9zdDo4ODgwL3dlYnNvY2tldC90ZXN0cy9zaW1wbGUnOyByZWFkeVN0YXRlID0g MC4KLUNvbm5lY3RlZDsgcmVhZHlTdGF0ZSA9IDEuCi1SZWNlaXZlZDogJ0hlbGxvIGZyb20gU2lt cGxlIFdTSC4nOyByZWFkeVN0YXRlID0gMS4KLUNsb3NlZDsgcmVhZHlTdGF0ZSA9IDIuCitDcmVh dGVkIGEgc29ja2V0IHRvICd3czovL2xvY2FsaG9zdDo4ODgwL3dlYnNvY2tldC90ZXN0cy9zaW1w bGUnOyByZWFkeVN0YXRlIDAuCitDb25uZWN0ZWQ7IHJlYWR5U3RhdGUgPj0gMC4KK1JlY2VpdmVk OiAnSGVsbG8gZnJvbSBTaW1wbGUgV1NILic7IHJlYWR5U3RhdGUgPj0gMS4KK0Nsb3NlZDsgcmVh ZHlTdGF0ZSAyLgogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBM RVRFCkluZGV4OiBMYXlvdXRUZXN0cy93ZWJzb2NrZXQvdGVzdHMvc2NyaXB0LXRlc3RzL3NpbXBs ZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy93ZWJzb2NrZXQvdGVzdHMvc2NyaXB0LXRl c3RzL3NpbXBsZS5qcwkocmV2aXNpb24gNTE2NTMpCisrKyBMYXlvdXRUZXN0cy93ZWJzb2NrZXQv dGVzdHMvc2NyaXB0LXRlc3RzL3NpbXBsZS5qcwkod29ya2luZyBjb3B5KQpAQCAtMTQsMjEgKzE0 LDIxIEBAIGZ1bmN0aW9uIGVuZFRlc3QoKQogfQogCiB2YXIgd3MgPSBuZXcgV2ViU29ja2V0KCJ3 czovL2xvY2FsaG9zdDo4ODgwL3dlYnNvY2tldC90ZXN0cy9zaW1wbGUiKTsKLWRlYnVnKCJDcmVh dGVkIGEgc29ja2V0IHRvICciICsgd3MuVVJMICsgIic7IHJlYWR5U3RhdGUgPSAiICsgd3MucmVh ZHlTdGF0ZSArICIuIik7CitkZWJ1ZygiQ3JlYXRlZCBhIHNvY2tldCB0byAnIiArIHdzLlVSTCAr ICInOyByZWFkeVN0YXRlICIgKyB3cy5yZWFkeVN0YXRlICsgIi4iKTsKIAogd3Mub25vcGVuID0g ZnVuY3Rpb24oKQogewotICAgIGRlYnVnKCJDb25uZWN0ZWQ7IHJlYWR5U3RhdGUgPSAiICsgd3Mu cmVhZHlTdGF0ZSArICIuIik7CisgICAgZGVidWcoIkNvbm5lY3RlZDsgcmVhZHlTdGF0ZSAiICsg KCh3cy5yZWFkeVN0YXRlID49IDApID8gIj49IDAuIiA6IHdzLnJlYWR5U3RhdGUpKTsKIH07CiAK IHdzLm9ubWVzc2FnZSA9IGZ1bmN0aW9uKG1lc3NhZ2VFdmVudCkKIHsKLSAgICBkZWJ1ZygiUmVj ZWl2ZWQ6ICciICsgbWVzc2FnZUV2ZW50LmRhdGEgKyAiJzsgcmVhZHlTdGF0ZSA9ICIgKyB3cy5y ZWFkeVN0YXRlICsgIi4iKTsKKyAgICBkZWJ1ZygiUmVjZWl2ZWQ6ICciICsgbWVzc2FnZUV2ZW50 LmRhdGEgKyAiJzsgcmVhZHlTdGF0ZSAiICsgKCh3cy5yZWFkeVN0YXRlID49IDEpID8gIj49IDEu IiA6IHdzLnJlYWR5U3RhdGUpKTsKIH07CiAKIHdzLm9uY2xvc2UgPSBmdW5jdGlvbigpCiB7Ci0g ICAgZGVidWcoIkNsb3NlZDsgcmVhZHlTdGF0ZSA9ICIgKyB3cy5yZWFkeVN0YXRlICsgIi4iKTsK KyAgICBkZWJ1ZygiQ2xvc2VkOyByZWFkeVN0YXRlICIgKyB3cy5yZWFkeVN0YXRlICsgIi4iKTsK ICAgICBlbmRUZXN0KCk7CiB9OwogCg==