32118 2009-12-03 07:57:00 -0800 Chromium: Add support for settings containing ":" 2010-06-01 22:23:30 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman abarth dglazkov eric ossy timothy webkit.review.bot oldest_to_newest 168407 0 pfeldman 2009-12-03 07:57:00 -0800 Current escaping does not handle ":". Aslo has a drive-by fix for setting group id early. 168409 1 44242 pfeldman 2009-12-03 08:04:17 -0800 Created attachment 44242 [PATCH] The fix 168410 2 webkit.review.bot 2009-12-03 08:06:08 -0800 style-queue ran check-webkit-style on attachment 44242 without any errors. 168416 3 pfeldman 2009-12-03 08:45:43 -0800 Sending WebCore/ChangeLog Sending WebCore/inspector/front-end/WatchExpressionsSidebarPane.js Sending WebKit/chromium/ChangeLog Sending WebKit/chromium/src/InspectorClientImpl.cpp Transmitting file data ....Committed revision 51637. 232667 4 webkit.review.bot 2010-06-01 03:32:06 -0700 http://trac.webkit.org/changeset/60469 might have broken Qt Linux ARMv5 Release 232698 5 timothy 2010-06-01 05:41:42 -0700 This Qt Linux bot shit is getting old. 233078 6 eric 2010-06-01 22:23:30 -0700 Yup. Since the Qt bots still seem to have network issues, we're going to try bug 39282 as a workaround. We could also just remove them from the set of builders the sherriffbot watches. 44242 2009-12-03 08:04:17 -0800 2009-12-03 08:10:38 -0800 [PATCH] The fix settings text/plain 3177 pfeldman SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvSW5zcGVjdG9yQ2xpZW50SW1wbC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9JbnNwZWN0b3JDbGllbnRJbXBsLmNwcAkocmV2 aXNpb24gNTE2MzYpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL0luc3BlY3RvckNsaWVudEltcGwu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODEsMjAgKzE4MSwxOSBAQAogICAgIGZvciAoVmVjdG9y PFN0cmluZz46Oml0ZXJhdG9yIGl0ID0gZW50cmllcy5iZWdpbigpOyBpdCAhPSBlbnRyaWVzLmVu ZCgpOyArK2l0KSB7CiAgICAgICAgIFZlY3RvcjxTdHJpbmc+IHRva2VuczsKICAgICAgICAgaXQt PnNwbGl0KCI6IiwgdG9rZW5zKTsKLSAgICAgICAgaWYgKHRva2Vucy5zaXplKCkgIT0gMykKKyAg ICAgICAgaWYgKHRva2Vucy5zaXplKCkgPCAzKQogICAgICAgICAgICAgY29udGludWU7CiAKICAg ICAgICAgU3RyaW5nIG5hbWUgPSBkZWNvZGVVUkxFc2NhcGVTZXF1ZW5jZXModG9rZW5zWzBdKTsK ICAgICAgICAgU3RyaW5nIHR5cGUgPSB0b2tlbnNbMV07Ci0gICAgICAgIFN0cmluZyBzZXR0aW5n OworICAgICAgICBTdHJpbmcgdmFsdWUgPSB0b2tlbnNbMl07CisgICAgICAgIGZvciAoc2l6ZV90 IGkgPSAzOyBpIDwgdG9rZW5zLnNpemUoKTsgKytpKQorICAgICAgICAgICAgdmFsdWUgKz0gIjoi ICsgdG9rZW5zW2ldOworCiAgICAgICAgIGlmICh0eXBlID09ICJzdHJpbmciKQotICAgICAgICAg ICAgc2V0dGluZyA9IGRlY29kZVVSTEVzY2FwZVNlcXVlbmNlcyh0b2tlbnNbMl0pOwotICAgICAg ICBlbHNlIGlmICh0eXBlID09ICJib29sZWFuIikKLSAgICAgICAgICAgIHNldHRpbmcgPSB0b2tl bnNbMl07Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAg dmFsdWUgPSBkZWNvZGVVUkxFc2NhcGVTZXF1ZW5jZXModmFsdWUpOwogCi0gICAgICAgIG1fc2V0 dGluZ3MtPnNldChuYW1lLCBzZXR0aW5nKTsKKyAgICAgICAgbV9zZXR0aW5ncy0+c2V0KG5hbWUs IHZhbHVlKTsKICAgICB9CiB9CiAKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTE2MzYpCisr KyBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQg QEAKKzIwMDktMTItMDMgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hyb21pdW06 IEFkZCBzdXBwb3J0IGZvciBzZXR0aW5ncyBjb250YWluaW5nICI6IgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjExOAorCisgICAgICAgICogc3Jj L0luc3BlY3RvckNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpJbnNwZWN0b3JDbGll bnRJbXBsOjpsb2FkU2V0dGluZ3MpOgorCiAyMDA5LTEyLTAzICBQYXZlbCBGZWxkbWFuICA8cGZl bGRtYW5AZGhjcC0xNzItMjgtMTc0LTIyMC5zcGIuY29ycC5nb29nbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IFRpbW90aHkgSGF0Y2hlci4KSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA1MTYzNikKKysrIFdlYkNv cmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTItMDMg IFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hyb21pdW06IEFkZCBzdXBwb3J0IGZv ciBzZXR0aW5ncyBjb250YWluaW5nICI6IgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMjExOAorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVu ZC9XYXRjaEV4cHJlc3Npb25zU2lkZWJhclBhbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu V2F0Y2hFeHByZXNzaW9uc1NlY3Rpb24pOgorCiAyMDA5LTEyLTAzICBSYWZhZWwgQW50b2dub2xs aSAgPGFudG9nbm9sbGlAcHJvZnVzaW9uLm1vYmk+LCBLZW5uZXRoIENocmlzdGlhbnNlbiA8a2Vu bmV0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KSW5k ZXg6IFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9XYXRjaEV4cHJlc3Npb25zU2lkZWJhclBh bmUuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1dhdGNoRXhw cmVzc2lvbnNTaWRlYmFyUGFuZS5qcwkocmV2aXNpb24gNTE2MzYpCisrKyBXZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvV2F0Y2hFeHByZXNzaW9uc1NpZGViYXJQYW5lLmpzCSh3b3JraW5nIGNv cHkpCkBAIC02Nyw2ICs2Nyw4IEBACiAKIFdlYkluc3BlY3Rvci5XYXRjaEV4cHJlc3Npb25zU2Vj dGlvbiA9IGZ1bmN0aW9uKCkKIHsKKyAgICB0aGlzLl93YXRjaE9iamVjdEdyb3VwSWQgPSAid2F0 Y2gtZ3JvdXAiOworCiAgICAgV2ViSW5zcGVjdG9yLk9iamVjdFByb3BlcnRpZXNTZWN0aW9uLmNh bGwodGhpcyk7CiAKICAgICB0aGlzLndhdGNoRXhwcmVzc2lvbnMgPSB0aGlzLmxvYWRTYXZlZEV4 cHJlc3Npb25zKCk7CkBAIC03NSw4ICs3Nyw2IEBACiAgICAgdGhpcy5lZGl0YWJsZSA9IHRydWU7 CiAgICAgdGhpcy5leHBhbmRlZCA9IHRydWU7CiAgICAgdGhpcy5wcm9wZXJ0aWVzRWxlbWVudC5h ZGRTdHlsZUNsYXNzKCJ3YXRjaC1leHByZXNzaW9ucyIpOwotCi0gICAgdGhpcy5fd2F0Y2hPYmpl Y3RHcm91cElkID0gIndhdGNoLWdyb3VwIjsKIH0KIAogV2ViSW5zcGVjdG9yLldhdGNoRXhwcmVz c2lvbnNTZWN0aW9uLk5ld1dhdGNoRXhwcmVzc2lvbiA9ICJceEEwIjsK