32113 2009-12-03 03:23:49 -0800 [Qt] Use DirectConnection for the QNetworkReply in the QNetworkReplyHandler 2009-12-15 08:20:02 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zecke webkit-unassigned hausmann markus webkit.review.bot oldest_to_newest 168344 0 44224 zecke 2009-12-03 03:23:49 -0800 Created attachment 44224 Use direct Qt signal connections We should use DirectConnection to achieve a improvement in latency on network jobs. This also means that the loading will be more stable across different runs. The only possible problem is that it might cause crashes on Qt4.5 and Qt4.6... we will have to figure if it is crashing or not. 171314 1 webkit.review.bot 2009-12-14 01:22:55 -0800 style-queue ran check-webkit-style on attachment 44224 without any errors. 171331 2 zecke 2009-12-14 03:22:20 -0800 Landed it in r52089. Waiting for the bot to run the tests before closing the bug. 171342 3 zecke 2009-12-14 05:09:14 -0800 mgoetz just highlighted that I have blindly converted everything to DirectConnection. With some luck I'm not reverting bug #25556. Once we are confident that it is not crashing we should remove the signal and do a direct function call again. 171740 4 markus 2009-12-15 00:08:10 -0800 This patch depends on a bugfix inside Qt 4.6. It should hit qt.gitorious.org in the next days. http://pastebin.ca/1714463 171752 5 44852 zecke 2009-12-15 01:10:45 -0800 Created attachment 44852 [Qt] Followup for direct signals and slots connections in QNetworkReplyHandler 171755 6 webkit.review.bot 2009-12-15 01:14:07 -0800 style-queue ran check-webkit-style on attachment 44852 without any errors. 171849 7 44852 hausmann 2009-12-15 07:08:18 -0800 Comment on attachment 44852 [Qt] Followup for direct signals and slots connections in QNetworkReplyHandler Good idea and good save :), r=me 171869 8 zecke 2009-12-15 08:20:02 -0800 Landed in r52153. 44224 2009-12-03 03:23:49 -0800 2009-12-15 01:10:30 -0800 Use direct Qt signal connections 0005-Qt-Connect-QNetworkReply-via-direct-connections.patch text/plain 3211 zecke RnJvbSAyMTdkYjRjOGJjMTk0ZWUxNTA2ZDAyZGIzYWRlY2FhMDdmZWYzMjU1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciA8emVja2VAc2Vs ZmlzaC5vcmc+CkRhdGU6IFRodSwgMyBEZWMgMjAwOSAxMTo0OTo1NSArMDEwMApTdWJqZWN0OiBb UEFUQ0ggNS81XSBbUXRdIENvbm5lY3QgUU5ldHdvcmtSZXBseSB2aWEgZGlyZWN0IGNvbm5lY3Rp b25zCgpJbiB0aGUgcGFzdCB3ZSBoYXZlIHN3aXRjaGVkIGZyb20gYXV0byBjb25uZWN0aW9ucyB0 byBxdWV1ZWQKY29ubmVjdGlvbnMgdG8gZ2V0IHNvbWUgbW9yZSBzdGFiaWxpdHkuIFRoZSBwcm9i bGVtIHdpdGggdGhlClF1ZXVlZCBjb25uZWN0aW9ucyBpcyBsYXRlbmN5LiBFdmVuIHdoZW4gcnVu bmluZyBzaW1wbGUgbG9hZGluZwp0ZXN0cyB0aGUgdGltZSBpdCB0YWtlcyB0byBydW5zIGhpZ2hs eSB2YXJpZXMgYW5kIGJ5IHVzaW5nCmRpcmVjdCBjb25uZWN0aW9ucyB0aGVzZSB0ZXN0cyBwcm9k dWNlIGEgcHJldHR5IHN0YWJsZSByZXN1bHQuCgpXZSB3aWxsIGhhdmUgdG8gbG9vayBvdXQgZm9y IGNyYXNoZXMgY29taW5nIGZyb20gd2l0aGluIHRoZQpRTmV0d29ya0FjY2Vzc01hbmFnZXIgZHVl IHRoaXMgcGF0Y2guCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgfCAgIDE4ICsrKysrKysrKysrKysrKysrKwogLi4uL3BsYXRmb3JtL25ldHdv cmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwICAgfCAgICA4ICsrKystLS0tCiAyIGZpbGVz IGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmNWRjNmI1Li41Zjc2 ODg5IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIxIEBACisyMDA5LTEyLTAzICBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhl ciAgPHplY2tlQHNlbGZpc2gub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtRdF0gQ29ubmVjdCBRTmV0d29ya1JlcGx5IHZpYSBkaXJlY3QgY29u bmVjdGlvbnMKKyAgICAgICAgCisgICAgICAgIEluIHRoZSBwYXN0IHdlIGhhdmUgc3dpdGNoZWQg ZnJvbSBhdXRvIGNvbm5lY3Rpb25zIHRvIHF1ZXVlZAorICAgICAgICBjb25uZWN0aW9ucyB0byBn ZXQgc29tZSBtb3JlIHN0YWJpbGl0eS4gVGhlIHByb2JsZW0gd2l0aCB0aGUKKyAgICAgICAgUXVl dWVkIGNvbm5lY3Rpb25zIGlzIGxhdGVuY3kuIEV2ZW4gd2hlbiBydW5uaW5nIHNpbXBsZSBsb2Fk aW5nCisgICAgICAgIHRlc3RzIHRoZSB0aW1lIGl0IHRha2VzIHRvIHJ1bnMgaGlnaGx5IHZhcmll cyBhbmQgYnkgdXNpbmcKKyAgICAgICAgZGlyZWN0IGNvbm5lY3Rpb25zIHRoZXNlIHRlc3RzIHBy b2R1Y2UgYSBwcmV0dHkgc3RhYmxlIHJlc3VsdC4KKyAgICAgICAgCisgICAgICAgIFdlIHdpbGwg aGF2ZSB0byBsb29rIG91dCBmb3IgY3Jhc2hlcyBjb21pbmcgZnJvbSB3aXRoaW4gdGhlCisgICAg ICAgIFFOZXR3b3JrQWNjZXNzTWFuYWdlciBkdWUgdGhpcyBwYXRjaC4KKworICAgICAgICAqIHBs YXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UU5ldHdvcmtSZXBseUhhbmRsZXI6OnN0YXJ0KToKKwogMjAwOS0xMS0zMCAgSG9sZ2Vy IEhhbnMgUGV0ZXIgRnJleXRoZXIgIDx6ZWNrZUBzZWxmaXNoLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwCmluZGV4IGY3YmJiOWQuLmYzNTI2ODggMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxl ci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5k bGVyLmNwcApAQCAtNDI3LDE4ICs0MjcsMTggQEAgdm9pZCBRTmV0d29ya1JlcGx5SGFuZGxlcjo6 c3RhcnQoKQogICAgIG1fcmVwbHktPnNldFBhcmVudCh0aGlzKTsKIAogICAgIGNvbm5lY3QobV9y ZXBseSwgU0lHTkFMKGZpbmlzaGVkKCkpLAotICAgICAgICAgICAgdGhpcywgU0xPVChmaW5pc2go KSksIFF0OjpRdWV1ZWRDb25uZWN0aW9uKTsKKyAgICAgICAgICAgIHRoaXMsIFNMT1QoZmluaXNo KCkpLCBRdDo6RGlyZWN0Q29ubmVjdGlvbik7CiAKICAgICAvLyBGb3IgaHR0cChzKSB3ZSBrbm93 IHRoYXQgdGhlIGhlYWRlcnMgYXJlIGNvbXBsZXRlIHVwb24gbWV0YURhdGFDaGFuZ2VkKCkgZW1p c3Npb24sIHNvIHdlCiAgICAgLy8gY2FuIHNlbmQgdGhlIHJlc3BvbnNlIGFzIGVhcmx5IGFzIHBv c3NpYmxlCiAgICAgaWYgKHNjaGVtZSA9PSBRTGF0aW4xU3RyaW5nKCJodHRwIikgfHwgc2NoZW1l ID09IFFMYXRpbjFTdHJpbmcoImh0dHBzIikpCiAgICAgICAgIGNvbm5lY3QobV9yZXBseSwgU0lH TkFMKG1ldGFEYXRhQ2hhbmdlZCgpKSwKLSAgICAgICAgICAgICAgICB0aGlzLCBTTE9UKHNlbmRS ZXNwb25zZUlmTmVlZGVkKCkpLCBRdDo6UXVldWVkQ29ubmVjdGlvbik7CisgICAgICAgICAgICAg ICAgdGhpcywgU0xPVChzZW5kUmVzcG9uc2VJZk5lZWRlZCgpKSwgUXQ6OkRpcmVjdENvbm5lY3Rp b24pOwogCiAgICAgY29ubmVjdChtX3JlcGx5LCBTSUdOQUwocmVhZHlSZWFkKCkpLAotICAgICAg ICAgICAgdGhpcywgU0xPVChmb3J3YXJkRGF0YSgpKSwgUXQ6OlF1ZXVlZENvbm5lY3Rpb24pOwor ICAgICAgICAgICAgdGhpcywgU0xPVChmb3J3YXJkRGF0YSgpKSwgUXQ6OkRpcmVjdENvbm5lY3Rp b24pOwogICAgIGNvbm5lY3QodGhpcywgU0lHTkFMKHByb2Nlc3NRdWV1ZWRJdGVtcygpKSwKLSAg ICAgICAgICAgIHRoaXMsIFNMT1Qoc2VuZFF1ZXVlZEl0ZW1zKCkpLCBRdDo6UXVldWVkQ29ubmVj dGlvbik7CisgICAgICAgICAgICB0aGlzLCBTTE9UKHNlbmRRdWV1ZWRJdGVtcygpKSwgUXQ6OkRp cmVjdENvbm5lY3Rpb24pOwogfQogCiB2b2lkIFFOZXR3b3JrUmVwbHlIYW5kbGVyOjpyZXNldFN0 YXRlKCkKLS0gCjEuNi4zLjMKCg== 44852 2009-12-15 01:10:45 -0800 2009-12-15 07:08:17 -0800 [Qt] Followup for direct signals and slots connections in QNetworkReplyHandler bug-32113-20091215101041.patch text/plain 2636 zecke ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODQ3MWQ1Ny4uNzQ4MTczOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMi0xNSAgSG9sZ2VyIEhhbnMg UGV0ZXIgRnJleXRoZXIgIDx6ZWNrZUBzZWxmaXNoLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEZvbGxvd3VwIGZvciBkaXJlY3Qgc2ln bmFscyBhbmQgc2xvdHMgY29ubmVjdGlvbnMgaW4gUU5ldHdvcmtSZXBseUhhbmRsZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMTEzCisKKyAgICAg ICAgRm9yIFF0IHZlcnNpb25zIHByaW9yIHRvIDQuNi4xIHdlIHdpbGwgbmVlZCB0byB1c2UgUXVl dWVkQ29ubmVjdGlvbgorICAgICAgICBmb3IgdGhlIHNpZ25hbCBhbmQgc2xvdCBjb25uZWN0aW9u IHRvIGF2b2lkIHJ1bm5pbmcgaW50byBhIGJ1ZyBpbi4KKworICAgICAgICAqIHBsYXRmb3JtL25l dHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UU5l dHdvcmtSZXBseUhhbmRsZXI6OnN0YXJ0KToKKwogMjAwOS0xMi0xNCAgSG9sZ2VyIEhhbnMgUGV0 ZXIgRnJleXRoZXIgIDx6ZWNrZUBzZWxmaXNoLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9R TmV0d29ya1JlcGx5SGFuZGxlci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUU5l dHdvcmtSZXBseUhhbmRsZXIuY3BwCmluZGV4IGUwZWYyMDUuLjFlZGM1YzYgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAKKysr IGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcApA QCAtMzgsNiArMzgsMTYgQEAKICNpbmNsdWRlIDxRRGVidWc+CiAjaW5jbHVkZSA8UUNvcmVBcHBs aWNhdGlvbj4KIAorLy8gV2hhdCB0eXBlIG9mIGNvbm5lY3Rpb24gc2hvdWxkIGJlIHVzZWQgZm9y IHRoZSBzaWduYWxzIG9mIHRoZQorLy8gUU5ldHdvcmtSZXBseT8gVGhpcyBkZXBlbmRzIG9uIGlm IFF0IGhhcyBhIGJ1Z2ZpeCBmb3IgdGhpcyBvciBub3QuCisvLyBJdCBpcyBmaXhlZCBpbiBRdCA0 LjYuMS4gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjExMwor I2lmIFFUX1ZFUlNJT04gPiBRVF9WRVJTSU9OX0NIRUNLKDQsIDYsIDApCisjZGVmaW5lIFNJR05B TF9DT05OIFF0OjpEaXJlY3RDb25uZWN0aW9uCisjZWxzZQorI2RlZmluZSBTSUdOQUxfQ09OTiBR dDo6UXVldWVkQ29ubmVjdGlvbgorI2VuZGlmCisKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiAv LyBUYWtlIGEgZGVlcCBjb3B5IG9mIHRoZSBGb3JtRGF0YUVsZW1lbnQKQEAgLTQzMSwxOCArNDQx LDIwIEBAIHZvaWQgUU5ldHdvcmtSZXBseUhhbmRsZXI6OnN0YXJ0KCkKICAgICBtX3JlcGx5LT5z ZXRQYXJlbnQodGhpcyk7CiAKICAgICBjb25uZWN0KG1fcmVwbHksIFNJR05BTChmaW5pc2hlZCgp KSwKLSAgICAgICAgICAgIHRoaXMsIFNMT1QoZmluaXNoKCkpLCBRdDo6RGlyZWN0Q29ubmVjdGlv bik7CisgICAgICAgICAgICB0aGlzLCBTTE9UKGZpbmlzaCgpKSwgU0lHTkFMX0NPTk4pOwogCiAg ICAgLy8gRm9yIGh0dHAocykgd2Uga25vdyB0aGF0IHRoZSBoZWFkZXJzIGFyZSBjb21wbGV0ZSB1 cG9uIG1ldGFEYXRhQ2hhbmdlZCgpIGVtaXNzaW9uLCBzbyB3ZQogICAgIC8vIGNhbiBzZW5kIHRo ZSByZXNwb25zZSBhcyBlYXJseSBhcyBwb3NzaWJsZQogICAgIGlmIChzY2hlbWUgPT0gUUxhdGlu MVN0cmluZygiaHR0cCIpIHx8IHNjaGVtZSA9PSBRTGF0aW4xU3RyaW5nKCJodHRwcyIpKQogICAg ICAgICBjb25uZWN0KG1fcmVwbHksIFNJR05BTChtZXRhRGF0YUNoYW5nZWQoKSksCi0gICAgICAg ICAgICAgICAgdGhpcywgU0xPVChzZW5kUmVzcG9uc2VJZk5lZWRlZCgpKSwgUXQ6OkRpcmVjdENv bm5lY3Rpb24pOworICAgICAgICAgICAgICAgIHRoaXMsIFNMT1Qoc2VuZFJlc3BvbnNlSWZOZWVk ZWQoKSksIFNJR05BTF9DT05OKTsKIAogICAgIGNvbm5lY3QobV9yZXBseSwgU0lHTkFMKHJlYWR5 UmVhZCgpKSwKLSAgICAgICAgICAgIHRoaXMsIFNMT1QoZm9yd2FyZERhdGEoKSksIFF0OjpEaXJl Y3RDb25uZWN0aW9uKTsKKyAgICAgICAgICAgIHRoaXMsIFNMT1QoZm9yd2FyZERhdGEoKSksIFNJ R05BTF9DT05OKTsKKworICAgIC8vIE1ha2UgdGhpcyBhIGRpcmVjdCBmdW5jdGlvbiBjYWxsIG9u Y2Ugd2UgcmVxdWlyZSA0LjYuMSsuCiAgICAgY29ubmVjdCh0aGlzLCBTSUdOQUwocHJvY2Vzc1F1 ZXVlZEl0ZW1zKCkpLAotICAgICAgICAgICAgdGhpcywgU0xPVChzZW5kUXVldWVkSXRlbXMoKSks IFF0OjpEaXJlY3RDb25uZWN0aW9uKTsKKyAgICAgICAgICAgIHRoaXMsIFNMT1Qoc2VuZFF1ZXVl ZEl0ZW1zKCkpLCBTSUdOQUxfQ09OTik7CiB9CiAKIHZvaWQgUU5ldHdvcmtSZXBseUhhbmRsZXI6 OnJlc2V0U3RhdGUoKQo=