32110 2009-12-03 02:30:31 -0800 Allow custom memory allocation control for WebCore's FrameLoaderClient 2009-12-11 08:19:54 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 1 zoltan webkit-unassigned webkit.review.bot oldest_to_newest 168335 0 44221 zoltan 2009-12-03 02:30:31 -0800 Created attachment 44221 Patch Inherits the following class from Noncopyable because it is instantiated by 'new' and no need to be copyable: class name - instantiated at: WebCore/'location' class FrameLoaderClient - (its child class) svg/graphics/SVGImage.cpp:229 168336 1 webkit.review.bot 2009-12-03 02:31:08 -0800 style-queue ran check-webkit-style on attachment 44221 without any errors. 168513 2 44221 eric 2009-12-03 12:58:19 -0800 Comment on attachment 44221 Patch Are you using a script to find these? 168676 3 44221 abarth 2009-12-03 23:28:18 -0800 Comment on attachment 44221 Patch Are you sure this is right? This is just an abstract interface. 168730 4 zoltan 2009-12-04 05:03:24 -0800 (In reply to comment #2) > (From update of attachment 44221 [details]) > Are you using a script to find these? No, I'm using a static source analyzer tool (called Columbus, developed by our department) and check the results by 'hand'. (In reply to comment #3) > (From update of attachment 44221 [details]) > Are you sure this is right? This is just an abstract interface. This is right, but not necessary, so okay, in the future at the case of abstract interfaces I won't go up to the superclass in the inheritance tree. 168734 5 zoltan 2009-12-04 05:16:39 -0800 Hmm. I checked. This is the instantiation line: static FrameLoaderClient* dummyFrameLoaderClient = new EmptyFrameLoaderClient; So, I have to inherit either EmptyFrameLoaderClient or FrameLoaderClient which are both abstract interfaces. FrameLoaderClient is the super class of EmptyFrameLoaderClient, so firt FrameLoaderClient should be inherited. (If some classes inherit from Noncopyable it also inherit from FastAllocBase, so the customization of the new/delete operator will be done.) 170699 6 44674 zoltan 2009-12-11 04:57:20 -0800 Created attachment 44674 Patch 170702 7 zoltan 2009-12-11 04:58:30 -0800 Ignore my last comments. You're right! New patch updated and filed! 170705 8 webkit.review.bot 2009-12-11 05:00:42 -0800 style-queue ran check-webkit-style on attachment 44674 without any errors. 170771 9 44674 zoltan 2009-12-11 08:19:43 -0800 Comment on attachment 44674 Patch Clearing flags on attachment: 44674 Committed r51990: <http://trac.webkit.org/changeset/51990> 170772 10 zoltan 2009-12-11 08:19:54 -0800 All reviewed patches have been landed. Closing bug. 44221 2009-12-03 02:30:31 -0800 2009-12-11 04:56:55 -0800 Patch 20091203113029.patch text/plain 1430 zoltan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTYyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMTItMDMgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWxsb3cgY3VzdG9tIG1lbW9yeSBhbGxvY2F0aW9uIGNvbnRyb2wgZm9yIFdlYkNvcmUncyBGcmFt ZUxvYWRlckNsaWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9CisKKyAgICAgICAgSW5oZXJpdHMgdGhlIGZvbGxvd2luZyBjbGFzcyBmcm9tIE5vbmNv cHlhYmxlIGJlY2F1c2UgaXQgaXMKKyAgICAgICAgaW5zdGFudGlhdGVkIGJ5ICduZXcnIGFuZCBu byBuZWVkIHRvIGJlIGNvcHlhYmxlOgorCisgICAgICAgIGNsYXNzIG5hbWUgICAgICAgICAgICAg IC0gaW5zdGFudGlhdGVkIGF0OiBXZWJDb3JlLydsb2NhdGlvbicKKworICAgICAgICBjbGFzcyBG cmFtZUxvYWRlckNsaWVudCAtIChpdHMgY2hpbGQgY2xhc3MpIHN2Zy9ncmFwaGljcy9TVkdJbWFn ZS5jcHA6MjI5CisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXJDbGllbnQuaDoKKwogMjAw OS0xMi0wMyAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IE1hY2llaiBTdGFjaG93aWFrLgpJbmRleDogV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2Fk ZXJDbGllbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlckNsaWVu dC5oCShyZXZpc2lvbiA1MTYyNikKKysrIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyQ2xpZW50 LmgJKHdvcmtpbmcgY29weSkKQEAgLTc2LDcgKzc2LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog CiAgICAgdHlwZWRlZiB2b2lkIChQb2xpY3lDaGVja2VyOjoqRnJhbWVQb2xpY3lGdW5jdGlvbiko UG9saWN5QWN0aW9uKTsKIAotICAgIGNsYXNzIEZyYW1lTG9hZGVyQ2xpZW50IHsKKyAgICBjbGFz cyBGcmFtZUxvYWRlckNsaWVudCA6IHB1YmxpYyBOb25jb3B5YWJsZSB7CiAgICAgcHVibGljOgog ICAgICAgICAvLyBBbiBpbmxpbmUgZnVuY3Rpb24gY2Fubm90IGJlIHRoZSBmaXJzdCBub24tYWJz dHJhY3QgdmlydHVhbCBmdW5jdGlvbiBkZWNsYXJlZAogICAgICAgICAvLyBpbiB0aGUgY2xhc3Mg YXMgaXQgcmVzdWx0cyBpbiB0aGUgdnRhYmxlIGJlaW5nIGdlbmVyYXRlZCBhcyBhIHdlYWsgc3lt Ym9sLgo= 44674 2009-12-11 04:57:20 -0800 2009-12-11 08:19:43 -0800 Patch bug-32110-20091211135718.patch text/plain 1298 zoltan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTk4MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMTItMTEgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWxsb3cgY3VzdG9tIG1lbW9yeSBhbGxvY2F0aW9uIGNvbnRyb2wgZm9yIFdlYkNvcmUncyBFbXB0 eUZyYW1lTG9hZGVyQ2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zMjExMAorCisgICAgICAgIEluaGVyaXRzIHRoZSBmb2xsb3dpbmcgY2xhc3Mg ZnJvbSBOb25jb3B5YWJsZSBiZWNhdXNlIGl0IGlzCisgICAgICAgIGluc3RhbnRpYXRlZCBieSAn bmV3JyBhbmQgbm8gbmVlZCB0byBiZSBjb3B5YWJsZToKKworICAgICAgICBjbGFzcyBuYW1lICAg ICAgICAgICAgICAtIGluc3RhbnRpYXRlZCBhdDogV2ViQ29yZS8nbG9jYXRpb24nCisKKyAgICAg ICAgY2xhc3MgRW1wdHlGcmFtZUxvYWRlckNsaWVudCAtIHN2Zy9ncmFwaGljcy9TVkdJbWFnZS5j cHA6MjI5CisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXJDbGllbnQuaDoKKwogMjAwOS0x Mi0xMSAgR3JhY2UgS2xvYmEgIDxrbG9iYWdAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9sb2FkZXIvRW1wdHlDbGllbnRzLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvRW1wdHlDbGllbnRzLmgJKHJldmlzaW9uIDUxOTgw KQorKysgV2ViQ29yZS9sb2FkZXIvRW1wdHlDbGllbnRzLmgJKHdvcmtpbmcgY29weSkKQEAgLTE2 Nyw3ICsxNjcsNyBAQCBwdWJsaWM6CiAjZW5kaWYKIH07CiAKLWNsYXNzIEVtcHR5RnJhbWVMb2Fk ZXJDbGllbnQgOiBwdWJsaWMgRnJhbWVMb2FkZXJDbGllbnQgeworY2xhc3MgRW1wdHlGcmFtZUxv YWRlckNsaWVudCA6IHB1YmxpYyBGcmFtZUxvYWRlckNsaWVudCwgcHVibGljIE5vbmNvcHlhYmxl IHsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5FbXB0eUZyYW1lTG9hZGVyQ2xpZW50KCkgeyAgfQog ICAgIHZpcnR1YWwgdm9pZCBmcmFtZUxvYWRlckRlc3Ryb3llZCgpIHsgfQo=