32101 2009-12-02 21:05:36 -0800 [bzt] REGRESSION: style-queue fails because patch["id"] is an integer 2009-12-02 23:19:22 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED DUPLICATE 32083 P2 Normal --- 1 abarth webkit-unassigned eric webkit.review.bot oldest_to_newest 168255 0 abarth 2009-12-02 21:05:36 -0800 style-queue fails because patch["id"] is an integer. Popen needs strings! 168256 1 44206 abarth 2009-12-02 21:07:44 -0800 Created attachment 44206 Patch 168270 2 webkit.review.bot 2009-12-02 21:14:31 -0800 style-queue ran check-webkit-style on attachment 44206 without any errors. 168272 3 abarth 2009-12-02 21:19:00 -0800 Eric is much more awesome than I. *** This bug has been marked as a duplicate of bug 32083 *** 44206 2009-12-02 21:07:44 -0800 2009-12-02 23:19:22 -0800 Patch bug-32101-20091202210742.patch text/plain 2764 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5MGUyYTlmLi5lNjkwZWM1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTIt MDIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbYnp0XSBSRUdSRVNTSU9OOiBzdHlsZS1xdWV1 ZSBmYWlscyBiZWNhdXNlIHBhdGNoWyJpZCJdIGlzIGFuIGludGVnZXIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMTAxCisKKyAgICAgICAgV2UgbmVl ZCB0byBwYXNzIHN0cmluZ3MgdG8gUG9wZW4uICBXZSBkb24ndCBoYXZlIHRoZSBhYmlsaXR5IHRv IHRlc3QKKyAgICAgICAgdGhpcyB5ZXQuICBJIG5lZWQgdG8gYnVpbGQgb3V0IG1vcmUgdGVzdGlu ZyBpbmZyYXN0cnVjdHVyZS4KKworICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9x dWV1ZXMucHk6CisKIDIwMDktMTItMDEgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9sbGl2 aWVycy5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQg YS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29tbWFuZHMvcXVldWVzLnB5IGIvV2ViS2l0 VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL3F1ZXVlcy5weQppbmRleCA1ZDJlNDgxLi4x ZjFkMzIwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29tbWFuZHMv cXVldWVzLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9xdWV1 ZXMucHkKQEAgLTEzMyw3ICsxMzMsNyBAQCBjbGFzcyBDb21taXRRdWV1ZShBYnN0cmFjdFF1ZXVl LCBMYW5kaW5nU2VxdWVuY2VFcnJvckhhbmRsZXIpOgogCiAgICAgZGVmIHByb2Nlc3Nfd29ya19p dGVtKHNlbGYsIHBhdGNoKToKICAgICAgICAgc2VsZi5fY2Nfd2F0Y2hlcnMocGF0Y2hbImJ1Z19p ZCJdKQotICAgICAgICBzZWxmLnJ1bl9idWd6aWxsYV90b29sKFsibGFuZC1hdHRhY2htZW50Iiwg Ii0tZm9yY2UtY2xlYW4iLCAiLS1ub24taW50ZXJhY3RpdmUiLCAiLS1wYXJlbnQtY29tbWFuZD1j b21taXQtcXVldWUiLCAiLS1xdWlldCIsIHBhdGNoWyJpZCJdXSkKKyAgICAgICAgc2VsZi5ydW5f YnVnemlsbGFfdG9vbChbImxhbmQtYXR0YWNobWVudCIsICItLWZvcmNlLWNsZWFuIiwgIi0tbm9u LWludGVyYWN0aXZlIiwgIi0tcGFyZW50LWNvbW1hbmQ9Y29tbWl0LXF1ZXVlIiwgIi0tcXVpZXQi LCBzdHIocGF0Y2hbImlkIl0pXSkKIAogICAgIGRlZiBoYW5kbGVfdW5leHBlY3RlZF9lcnJvcihz ZWxmLCBwYXRjaCwgbWVzc2FnZSk6CiAgICAgICAgIHNlbGYudG9vbC5idWdzLnJlamVjdF9wYXRj aF9mcm9tX2NvbW1pdF9xdWV1ZShwYXRjaFsiaWQiXSwgbWVzc2FnZSkKQEAgLTE5OSw3ICsxOTks NyBAQCBjbGFzcyBTdHlsZVF1ZXVlKEFic3RyYWN0VHJ5UXVldWUpOgogCiAgICAgZGVmIHByb2Nl c3Nfd29ya19pdGVtKHNlbGYsIHBhdGNoKToKICAgICAgICAgdHJ5OgotICAgICAgICAgICAgc2Vs Zi5ydW5fYnVnemlsbGFfdG9vbChbImNoZWNrLXN0eWxlIiwgIi0tZm9yY2UtY2xlYW4iLCAiLS1u b24taW50ZXJhY3RpdmUiLCAiLS1wYXJlbnQtY29tbWFuZD1zdHlsZS1xdWV1ZSIsIHBhdGNoWyJp ZCJdXSkKKyAgICAgICAgICAgIHNlbGYucnVuX2J1Z3ppbGxhX3Rvb2woWyJjaGVjay1zdHlsZSIs ICItLWZvcmNlLWNsZWFuIiwgIi0tbm9uLWludGVyYWN0aXZlIiwgIi0tcGFyZW50LWNvbW1hbmQ9 c3R5bGUtcXVldWUiLCBzdHIocGF0Y2hbImlkIl0pXSkKICAgICAgICAgICAgIG1lc3NhZ2UgPSAi JXMgcmFuIGNoZWNrLXdlYmtpdC1zdHlsZSBvbiBhdHRhY2htZW50ICVzIHdpdGhvdXQgYW55IGVy cm9ycy4iICUgKHNlbGYubmFtZSwgcGF0Y2hbImlkIl0pCiAgICAgICAgICAgICBzZWxmLnRvb2wu YnVncy5wb3N0X2NvbW1lbnRfdG9fYnVnKHBhdGNoWyJidWdfaWQiXSwgbWVzc2FnZSwgY2M9c2Vs Zi53YXRjaGVycykKICAgICAgICAgICAgIHNlbGYuX3BhdGNoZXMuZGlkX3Bhc3MocGF0Y2gpCkBA IC0yMzgsNSArMjM4LDUgQEAgY2xhc3MgQnVpbGRRdWV1ZShBYnN0cmFjdFRyeVF1ZXVlKToKICAg ICAgICAgcmV0dXJuIChUcnVlLCAiQnVpbGRpbmcgcGF0Y2ggJXMgb24gYnVnICVzLiIgJSAocGF0 Y2hbImlkIl0sIHBhdGNoWyJidWdfaWQiXSksIHBhdGNoKQogCiAgICAgZGVmIHByb2Nlc3Nfd29y a19pdGVtKHNlbGYsIHBhdGNoKToKLSAgICAgICAgc2VsZi5ydW5fYnVnemlsbGFfdG9vbChbImJ1 aWxkLWF0dGFjaG1lbnQiLCBzZWxmLnBvcnQuZmxhZygpLCAiLS1mb3JjZS1jbGVhbiIsICItLXF1 aWV0IiwgIi0tbm9uLWludGVyYWN0aXZlIiwgIi0tcGFyZW50LWNvbW1hbmQ9YnVpbGQtcXVldWUi LCAiLS1uby11cGRhdGUiLCBwYXRjaFsiaWQiXV0pCisgICAgICAgIHNlbGYucnVuX2J1Z3ppbGxh X3Rvb2woWyJidWlsZC1hdHRhY2htZW50Iiwgc2VsZi5wb3J0LmZsYWcoKSwgIi0tZm9yY2UtY2xl YW4iLCAiLS1xdWlldCIsICItLW5vbi1pbnRlcmFjdGl2ZSIsICItLXBhcmVudC1jb21tYW5kPWJ1 aWxkLXF1ZXVlIiwgIi0tbm8tdXBkYXRlIiwgc3RyKHBhdGNoWyJpZCJdKV0pCiAgICAgICAgIHNl bGYuX3BhdGNoZXMuZGlkX3Bhc3MocGF0Y2gpCg==