32081 2009-12-02 11:56:53 -0800 repaint events from outside the viewport aren't received 2009-12-03 06:27:42 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 antognolli+webkit webkit-unassigned benjamin hyatt kenneth simon.fraser oldest_to_newest 168113 0 antognolli+webkit 2009-12-02 11:56:53 -0800 Repaint events are clipped with the viewport area to prevent those that are fully outside the screen of triggering some rendering. This optimization prevents one of implementing backing stores that keeps some content of the page in a cache, because this cache should be marked as dirty when a repaint is called. Since the repaints are being clipped, no dirty area is marked. 168117 1 44171 antognolli+webkit 2009-12-02 12:04:04 -0800 Created attachment 44171 Patch adding a new paintEntireContents property. This new property asks WebCore to request repaints even if they are out of the screen. This is useful if implementing a backing store which already has some area of the page rendered, but needs to know that something has changed and so is now "dirty". 168126 2 44171 simon.fraser 2009-12-02 12:46:15 -0800 Comment on attachment 44171 Patch adding a new paintEntireContents property. Is m_paintEntireContents ever going to change for a given platform? In other words, could you just have a virtual method, bool paintsEntireContents() const, that returns false by default, and you override for platforms that need it? > bool m_paintEntireContents; // should this be m_hasBacking ? I like m_paintEntireContents. 168138 3 kenneth 2009-12-02 13:12:03 -0800 (In reply to comment #2) > (From update of attachment 44171 [details]) > Is m_paintEntireContents ever going to change for a given platform? In other > words, could you just have a virtual method, bool paintsEntireContents() const, > that returns false by default, and you override for platforms that need it? > > > bool m_paintEntireContents; // should this be m_hasBacking ? > > I like m_paintEntireContents. For Qt, we have two views, one canvas based and one widget based. It might make sense only implementing tiling for the canvas based one, or at least make it a configuration. 168140 4 antognolli+webkit 2009-12-02 13:22:19 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 44171 [details] [details]) > > Is m_paintEntireContents ever going to change for a given platform? In other > > words, could you just have a virtual method, bool paintsEntireContents() const, > > that returns false by default, and you override for platforms that need it? > > > > > bool m_paintEntireContents; // should this be m_hasBacking ? > > > > I like m_paintEntireContents. > > For Qt, we have two views, one canvas based and one widget based. It might make > sense only implementing tiling for the canvas based one, or at least make it a > configuration. For EFL we also have two views, and one of them uses a tiled backing store, the other one doesn't. So it would be good to have something configurable. But anyway, we can clip the repaint request on the single backing store later, if necessary... 168158 5 kenneth 2009-12-02 14:05:39 -0800 At least you should remove this comment // should this be m_hasBacking ? Can you update the patch? 168162 6 44184 antognolli+webkit 2009-12-02 14:12:46 -0800 Created attachment 44184 Patch adding a new paintEntireContents property. Patch updated! 168163 7 kenneth 2009-12-02 14:14:59 -0800 Please remove or replace + No new tests. (OOPS!) with No change in behavior, so no new tests added. 168164 8 kenneth 2009-12-02 14:16:51 -0800 Another thing, shouldn't it be called paintEntireContent and not paintEntireContents - notice the trailing s. 168166 9 simon.fraser 2009-12-02 14:24:11 -0800 It should be paintsEntireContents. It's descriptive, not imperative. 168253 10 44205 antognolli+webkit 2009-12-02 20:57:29 -0800 Created attachment 44205 Patch adding a new paintsEntireContents property. ok, updating property to paintsEntireContents and fixed the Changelog message of no tests added. 168281 11 44205 simon.fraser 2009-12-02 21:33:12 -0800 Comment on attachment 44205 Patch adding a new paintsEntireContents property. > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > +2009-12-02 Rafael Antognolli <antognolli@profusion.mobi> > + > + Reviewed by NOBODY (OOPS!). > + > + repaint events from outside the viewport aren't received > + https://bugs.webkit.org/show_bug.cgi?id=32081 > + This Changelog entry needs to explain the justification for the change in more detail. What does it mean for a view to paint its entire contents? Why does it need to be settable? > diff --git a/WebCore/page/FrameView.cpp b/WebCore/page/FrameView.cpp > +void ScrollView::setPaintsEntireContents(bool paint) > +{ > + m_paintsEntireContents = paint; > +} Parameter name could be improved: paintsEntireContents would be fine. > + if (!m_paintsEntireContents) I have a slight preference for calling paintsEntireContents() here (it's inline, so no extra overhead), so this code matches the code in FrameView. > diff --git a/WebCore/platform/ScrollView.h b/WebCore/platform/ScrollView.h > index dbbbff1..e269678 100644 > --- a/WebCore/platform/ScrollView.h > +++ b/WebCore/platform/ScrollView.h > @@ -92,6 +92,9 @@ public: > virtual void setCanHaveScrollbars(bool); > bool canHaveScrollbars() const { return horizontalScrollbarMode() != ScrollbarAlwaysOff || verticalScrollbarMode() != ScrollbarAlwaysOff; } > > + bool paintsEntireContents() const { return m_paintsEntireContents; } > + void setPaintsEntireContents(bool flag); You can omit the parameter name here in the header. I'd like to see a comment here explaining the purpose of the 'paintsEntireContents' behavior. 168282 12 44205 simon.fraser 2009-12-02 21:33:39 -0800 Comment on attachment 44205 Patch adding a new paintsEntireContents property. Patch needs revision before commit, so commit-queue- 168385 13 kenneth 2009-12-03 06:27:42 -0800 Landed in r51636 44171 2009-12-02 12:04:04 -0800 2009-12-02 14:12:46 -0800 Patch adding a new paintEntireContents property. webkit-paintEintireContents_property.patch text/plain 4559 antognolli+webkit ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTQ1MGExMi4uYWNjODZiNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAwOS0xMi0wMiAgUmFmYWVsIEFudG9n bm9sbGkgIDxhbnRvZ25vbGxpQHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHJlcGFpbnQgZXZlbnRzIGZyb20gb3V0c2lkZSB0 aGUgdmlld3BvcnQgYXJlbid0IHJlY2VpdmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMjA4MQorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMh KQorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJh bWVWaWV3OjpyZXBhaW50Q29udGVudFJlY3RhbmdsZSk6CisgICAgICAgICogcGxhdGZvcm0vU2Ny b2xsVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxWaWV3OjpTY3JvbGxWaWV3KToK KyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6OnNldFBhaW50RW50aXJlQ29udGVudHMpOgor ICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsVmlldzo6d2hlZWxFdmVudCk6CisgICAgICAgICogcGxh dGZvcm0vU2Nyb2xsVmlldy5oOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsVmlldzo6cGFpbnRF bnRpcmVDb250ZW50cyk6CisKIDIwMDktMTItMDIgIERhdmUgSHlhdHQgIDxoeWF0dEBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJD b3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4 IGQwZjljNDcuLjQ4NDMxNzMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3Bw CisrKyBiL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC05NDksOSArOTQ5LDEwIEBAIHZv aWQgRnJhbWVWaWV3OjpyZXBhaW50Q29udGVudFJlY3RhbmdsZShjb25zdCBJbnRSZWN0JiByLCBi b29sIGltbWVkaWF0ZSkKIAogICAgIGRvdWJsZSBkZWxheSA9IGFkanVzdGVkRGVmZXJyZWRSZXBh aW50RGVsYXkoKTsKICAgICBpZiAoKG1fZGVmZXJyaW5nUmVwYWludHMgfHwgbV9kZWZlcnJlZFJl cGFpbnRUaW1lci5pc0FjdGl2ZSgpIHx8IGRlbGF5KSAmJiAhaW1tZWRpYXRlKSB7Ci0gICAgICAg IEludFJlY3QgdmlzaWJsZUNvbnRlbnQgPSB2aXNpYmxlQ29udGVudFJlY3QoKTsKLSAgICAgICAg dmlzaWJsZUNvbnRlbnQuaW50ZXJzZWN0KHIpOwotICAgICAgICBpZiAodmlzaWJsZUNvbnRlbnQu aXNFbXB0eSgpKQorICAgICAgICBJbnRSZWN0IHBhaW50UmVjdCA9IHI7CisgICAgICAgIGlmICgh cGFpbnRFbnRpcmVDb250ZW50cygpKQorICAgICAgICAgICAgcGFpbnRSZWN0LmludGVyc2VjdCh2 aXNpYmxlQ29udGVudFJlY3QoKSk7CisgICAgICAgIGlmIChwYWludFJlY3QuaXNFbXB0eSgpKQog ICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICBpZiAobV9yZXBhaW50Q291bnQgPT0gY1JlcGFp bnRSZWN0VW5pb25UaHJlc2hvbGQpIHsKICAgICAgICAgICAgIEludFJlY3QgdW5pb25lZFJlY3Q7 CkBAIC05NjEsOSArOTYyLDkgQEAgdm9pZCBGcmFtZVZpZXc6OnJlcGFpbnRDb250ZW50UmVjdGFu Z2xlKGNvbnN0IEludFJlY3QmIHIsIGJvb2wgaW1tZWRpYXRlKQogICAgICAgICAgICAgbV9yZXBh aW50UmVjdHMuYXBwZW5kKHVuaW9uZWRSZWN0KTsKICAgICAgICAgfQogICAgICAgICBpZiAobV9y ZXBhaW50Q291bnQgPCBjUmVwYWludFJlY3RVbmlvblRocmVzaG9sZCkKLSAgICAgICAgICAgIG1f cmVwYWludFJlY3RzLmFwcGVuZCh2aXNpYmxlQ29udGVudCk7CisgICAgICAgICAgICBtX3JlcGFp bnRSZWN0cy5hcHBlbmQocGFpbnRSZWN0KTsKICAgICAgICAgZWxzZQotICAgICAgICAgICAgbV9y ZXBhaW50UmVjdHNbMF0udW5pdGUodmlzaWJsZUNvbnRlbnQpOworICAgICAgICAgICAgbV9yZXBh aW50UmVjdHNbMF0udW5pdGUocGFpbnRSZWN0KTsKICAgICAgICAgbV9yZXBhaW50Q291bnQrKzsK ICAgICAKICAgICAgICAgaWYgKCFtX2RlZmVycmluZ1JlcGFpbnRzICYmICFtX2RlZmVycmVkUmVw YWludFRpbWVyLmlzQWN0aXZlKCkpCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9s bFZpZXcuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcAppbmRleCBlOTFmOGVl Li40YjY3YjVmIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCisr KyBiL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAKQEAgLTQ5LDYgKzQ5LDcgQEAgU2Ny b2xsVmlldzo6U2Nyb2xsVmlldygpCiAgICAgLCBtX3VwZGF0ZVNjcm9sbGJhcnNQYXNzKDApCiAg ICAgLCBtX2RyYXdQYW5TY3JvbGxJY29uKGZhbHNlKQogICAgICwgbV91c2VGaXhlZExheW91dChm YWxzZSkKKyAgICAsIG1fcGFpbnRFbnRpcmVDb250ZW50cyhmYWxzZSkKIHsKICAgICBwbGF0Zm9y bUluaXQoKTsKIH0KQEAgLTE2OCw2ICsxNjksMTEgQEAgYm9vbCBTY3JvbGxWaWV3OjpjYW5CbGl0 T25TY3JvbGwoKSBjb25zdAogICAgIHJldHVybiBtX2NhbkJsaXRPblNjcm9sbDsKIH0KIAordm9p ZCBTY3JvbGxWaWV3OjpzZXRQYWludEVudGlyZUNvbnRlbnRzKGJvb2wgcGFpbnQpCit7CisgICAg bV9wYWludEVudGlyZUNvbnRlbnRzID0gcGFpbnQ7Cit9CisKICNpZiAhUExBVEZPUk0oR1RLKQog SW50UmVjdCBTY3JvbGxWaWV3Ojp2aXNpYmxlQ29udGVudFJlY3QoYm9vbCBpbmNsdWRlU2Nyb2xs YmFycykgY29uc3QKIHsKQEAgLTcwNywxOCArNzEzLDE5IEBAIHZvaWQgU2Nyb2xsVmlldzo6ZnJh bWVSZWN0c0NoYW5nZWQoKQogCiB2b2lkIFNjcm9sbFZpZXc6OnJlcGFpbnRDb250ZW50UmVjdGFu Z2xlKGNvbnN0IEludFJlY3QmIHJlY3QsIGJvb2wgbm93KQogewotICAgIEludFJlY3QgdmlzaWJs ZUNvbnRlbnQgPSB2aXNpYmxlQ29udGVudFJlY3QoKTsKLSAgICB2aXNpYmxlQ29udGVudC5pbnRl cnNlY3QocmVjdCk7Ci0gICAgaWYgKHZpc2libGVDb250ZW50LmlzRW1wdHkoKSkKKyAgICBJbnRS ZWN0IHBhaW50UmVjdCA9IHJlY3Q7CisgICAgaWYgKCFtX3BhaW50RW50aXJlQ29udGVudHMpCisg ICAgICAgIHBhaW50UmVjdC5pbnRlcnNlY3QodmlzaWJsZUNvbnRlbnRSZWN0KCkpOworICAgIGlm IChwYWludFJlY3QuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm47CiAKICAgICBpZiAocGxhdGZv cm1XaWRnZXQoKSkgewotICAgICAgICBwbGF0Zm9ybVJlcGFpbnRDb250ZW50UmVjdGFuZ2xlKHZp c2libGVDb250ZW50LCBub3cpOworICAgICAgICBwbGF0Zm9ybVJlcGFpbnRDb250ZW50UmVjdGFu Z2xlKHBhaW50UmVjdCwgbm93KTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAogICAgIGlmICho b3N0V2luZG93KCkpCi0gICAgICAgIGhvc3RXaW5kb3coKS0+cmVwYWludChjb250ZW50c1RvV2lu ZG93KHZpc2libGVDb250ZW50KSwgdHJ1ZSwgbm93KTsKKyAgICAgICAgaG9zdFdpbmRvdygpLT5y ZXBhaW50KGNvbnRlbnRzVG9XaW5kb3cocGFpbnRSZWN0KSwgdHJ1ZSwgbm93KTsKIH0KIAogSW50 UmVjdCBTY3JvbGxWaWV3OjpzY3JvbGxDb3JuZXJSZWN0KCkgY29uc3QKZGlmZiAtLWdpdCBhL1dl YkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3 LmgKaW5kZXggZGJiYmZmMS4uZTI2OTY3OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9T Y3JvbGxWaWV3LmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmgKQEAgLTkyLDYg KzkyLDkgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXRDYW5IYXZlU2Nyb2xsYmFycyhi b29sKTsKICAgICBib29sIGNhbkhhdmVTY3JvbGxiYXJzKCkgY29uc3QgeyByZXR1cm4gaG9yaXpv bnRhbFNjcm9sbGJhck1vZGUoKSAhPSBTY3JvbGxiYXJBbHdheXNPZmYgfHwgdmVydGljYWxTY3Jv bGxiYXJNb2RlKCkgIT0gU2Nyb2xsYmFyQWx3YXlzT2ZmOyB9CiAKKyAgICBib29sIHBhaW50RW50 aXJlQ29udGVudHMoKSBjb25zdCB7IHJldHVybiBtX3BhaW50RW50aXJlQ29udGVudHM7IH0KKyAg ICB2b2lkIHNldFBhaW50RW50aXJlQ29udGVudHMoYm9vbCBmbGFnKTsKKwogICAgIC8vIE92ZXJy aWRkZW4gYnkgRnJhbWVWaWV3IHRvIGNyZWF0ZSBjdXN0b20gQ1NTIHNjcm9sbGJhcnMgaWYgYXBw bGljYWJsZS4KICAgICB2aXJ0dWFsIFBhc3NSZWZQdHI8U2Nyb2xsYmFyPiBjcmVhdGVTY3JvbGxi YXIoU2Nyb2xsYmFyT3JpZW50YXRpb24pOwogCkBAIC0yNzIsNiArMjc1LDggQEAgcHJpdmF0ZToK ICAgICBib29sIG1fZHJhd1BhblNjcm9sbEljb247CiAgICAgYm9vbCBtX3VzZUZpeGVkTGF5b3V0 OwogCisgICAgYm9vbCBtX3BhaW50RW50aXJlQ29udGVudHM7IC8vIHNob3VsZCB0aGlzIGJlIG1f aGFzQmFja2luZyA/CisKICAgICB2b2lkIGluaXQoKTsKICAgICB2b2lkIGRlc3Ryb3koKTsKIAo= 44184 2009-12-02 14:12:46 -0800 2009-12-02 20:57:29 -0800 Patch adding a new paintEntireContents property. webkit-paintEintireContents_property.patch text/plain 4526 antognolli+webkit ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTQ1MGExMi4uYWNjODZiNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAwOS0xMi0wMiAgUmFmYWVsIEFudG9n bm9sbGkgIDxhbnRvZ25vbGxpQHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHJlcGFpbnQgZXZlbnRzIGZyb20gb3V0c2lkZSB0 aGUgdmlld3BvcnQgYXJlbid0IHJlY2VpdmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMjA4MQorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMh KQorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJh bWVWaWV3OjpyZXBhaW50Q29udGVudFJlY3RhbmdsZSk6CisgICAgICAgICogcGxhdGZvcm0vU2Ny b2xsVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxWaWV3OjpTY3JvbGxWaWV3KToK KyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6OnNldFBhaW50RW50aXJlQ29udGVudHMpOgor ICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsVmlldzo6d2hlZWxFdmVudCk6CisgICAgICAgICogcGxh dGZvcm0vU2Nyb2xsVmlldy5oOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsVmlldzo6cGFpbnRF bnRpcmVDb250ZW50cyk6CisKIDIwMDktMTItMDIgIERhdmUgSHlhdHQgIDxoeWF0dEBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJD b3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4 IGQwZjljNDcuLjQ4NDMxNzMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3Bw CisrKyBiL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC05NDksOSArOTQ5LDEwIEBAIHZv aWQgRnJhbWVWaWV3OjpyZXBhaW50Q29udGVudFJlY3RhbmdsZShjb25zdCBJbnRSZWN0JiByLCBi b29sIGltbWVkaWF0ZSkKIAogICAgIGRvdWJsZSBkZWxheSA9IGFkanVzdGVkRGVmZXJyZWRSZXBh aW50RGVsYXkoKTsKICAgICBpZiAoKG1fZGVmZXJyaW5nUmVwYWludHMgfHwgbV9kZWZlcnJlZFJl cGFpbnRUaW1lci5pc0FjdGl2ZSgpIHx8IGRlbGF5KSAmJiAhaW1tZWRpYXRlKSB7Ci0gICAgICAg IEludFJlY3QgdmlzaWJsZUNvbnRlbnQgPSB2aXNpYmxlQ29udGVudFJlY3QoKTsKLSAgICAgICAg dmlzaWJsZUNvbnRlbnQuaW50ZXJzZWN0KHIpOwotICAgICAgICBpZiAodmlzaWJsZUNvbnRlbnQu aXNFbXB0eSgpKQorICAgICAgICBJbnRSZWN0IHBhaW50UmVjdCA9IHI7CisgICAgICAgIGlmICgh cGFpbnRFbnRpcmVDb250ZW50cygpKQorICAgICAgICAgICAgcGFpbnRSZWN0LmludGVyc2VjdCh2 aXNpYmxlQ29udGVudFJlY3QoKSk7CisgICAgICAgIGlmIChwYWludFJlY3QuaXNFbXB0eSgpKQog ICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICBpZiAobV9yZXBhaW50Q291bnQgPT0gY1JlcGFp bnRSZWN0VW5pb25UaHJlc2hvbGQpIHsKICAgICAgICAgICAgIEludFJlY3QgdW5pb25lZFJlY3Q7 CkBAIC05NjEsOSArOTYyLDkgQEAgdm9pZCBGcmFtZVZpZXc6OnJlcGFpbnRDb250ZW50UmVjdGFu Z2xlKGNvbnN0IEludFJlY3QmIHIsIGJvb2wgaW1tZWRpYXRlKQogICAgICAgICAgICAgbV9yZXBh aW50UmVjdHMuYXBwZW5kKHVuaW9uZWRSZWN0KTsKICAgICAgICAgfQogICAgICAgICBpZiAobV9y ZXBhaW50Q291bnQgPCBjUmVwYWludFJlY3RVbmlvblRocmVzaG9sZCkKLSAgICAgICAgICAgIG1f cmVwYWludFJlY3RzLmFwcGVuZCh2aXNpYmxlQ29udGVudCk7CisgICAgICAgICAgICBtX3JlcGFp bnRSZWN0cy5hcHBlbmQocGFpbnRSZWN0KTsKICAgICAgICAgZWxzZQotICAgICAgICAgICAgbV9y ZXBhaW50UmVjdHNbMF0udW5pdGUodmlzaWJsZUNvbnRlbnQpOworICAgICAgICAgICAgbV9yZXBh aW50UmVjdHNbMF0udW5pdGUocGFpbnRSZWN0KTsKICAgICAgICAgbV9yZXBhaW50Q291bnQrKzsK ICAgICAKICAgICAgICAgaWYgKCFtX2RlZmVycmluZ1JlcGFpbnRzICYmICFtX2RlZmVycmVkUmVw YWludFRpbWVyLmlzQWN0aXZlKCkpCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9s bFZpZXcuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcAppbmRleCBlOTFmOGVl Li40YjY3YjVmIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCisr KyBiL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAKQEAgLTQ5LDYgKzQ5LDcgQEAgU2Ny b2xsVmlldzo6U2Nyb2xsVmlldygpCiAgICAgLCBtX3VwZGF0ZVNjcm9sbGJhcnNQYXNzKDApCiAg ICAgLCBtX2RyYXdQYW5TY3JvbGxJY29uKGZhbHNlKQogICAgICwgbV91c2VGaXhlZExheW91dChm YWxzZSkKKyAgICAsIG1fcGFpbnRFbnRpcmVDb250ZW50cyhmYWxzZSkKIHsKICAgICBwbGF0Zm9y bUluaXQoKTsKIH0KQEAgLTE2OCw2ICsxNjksMTEgQEAgYm9vbCBTY3JvbGxWaWV3OjpjYW5CbGl0 T25TY3JvbGwoKSBjb25zdAogICAgIHJldHVybiBtX2NhbkJsaXRPblNjcm9sbDsKIH0KIAordm9p ZCBTY3JvbGxWaWV3OjpzZXRQYWludEVudGlyZUNvbnRlbnRzKGJvb2wgcGFpbnQpCit7CisgICAg bV9wYWludEVudGlyZUNvbnRlbnRzID0gcGFpbnQ7Cit9CisKICNpZiAhUExBVEZPUk0oR1RLKQog SW50UmVjdCBTY3JvbGxWaWV3Ojp2aXNpYmxlQ29udGVudFJlY3QoYm9vbCBpbmNsdWRlU2Nyb2xs YmFycykgY29uc3QKIHsKQEAgLTcwNywxOCArNzEzLDE5IEBAIHZvaWQgU2Nyb2xsVmlldzo6ZnJh bWVSZWN0c0NoYW5nZWQoKQogCiB2b2lkIFNjcm9sbFZpZXc6OnJlcGFpbnRDb250ZW50UmVjdGFu Z2xlKGNvbnN0IEludFJlY3QmIHJlY3QsIGJvb2wgbm93KQogewotICAgIEludFJlY3QgdmlzaWJs ZUNvbnRlbnQgPSB2aXNpYmxlQ29udGVudFJlY3QoKTsKLSAgICB2aXNpYmxlQ29udGVudC5pbnRl cnNlY3QocmVjdCk7Ci0gICAgaWYgKHZpc2libGVDb250ZW50LmlzRW1wdHkoKSkKKyAgICBJbnRS ZWN0IHBhaW50UmVjdCA9IHJlY3Q7CisgICAgaWYgKCFtX3BhaW50RW50aXJlQ29udGVudHMpCisg ICAgICAgIHBhaW50UmVjdC5pbnRlcnNlY3QodmlzaWJsZUNvbnRlbnRSZWN0KCkpOworICAgIGlm IChwYWludFJlY3QuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm47CiAKICAgICBpZiAocGxhdGZv cm1XaWRnZXQoKSkgewotICAgICAgICBwbGF0Zm9ybVJlcGFpbnRDb250ZW50UmVjdGFuZ2xlKHZp c2libGVDb250ZW50LCBub3cpOworICAgICAgICBwbGF0Zm9ybVJlcGFpbnRDb250ZW50UmVjdGFu Z2xlKHBhaW50UmVjdCwgbm93KTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAogICAgIGlmICho b3N0V2luZG93KCkpCi0gICAgICAgIGhvc3RXaW5kb3coKS0+cmVwYWludChjb250ZW50c1RvV2lu ZG93KHZpc2libGVDb250ZW50KSwgdHJ1ZSwgbm93KTsKKyAgICAgICAgaG9zdFdpbmRvdygpLT5y ZXBhaW50KGNvbnRlbnRzVG9XaW5kb3cocGFpbnRSZWN0KSwgdHJ1ZSwgbm93KTsKIH0KIAogSW50 UmVjdCBTY3JvbGxWaWV3OjpzY3JvbGxDb3JuZXJSZWN0KCkgY29uc3QKZGlmZiAtLWdpdCBhL1dl YkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3 LmgKaW5kZXggZGJiYmZmMS4uZTI2OTY3OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9T Y3JvbGxWaWV3LmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmgKQEAgLTkyLDYg KzkyLDkgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXRDYW5IYXZlU2Nyb2xsYmFycyhi b29sKTsKICAgICBib29sIGNhbkhhdmVTY3JvbGxiYXJzKCkgY29uc3QgeyByZXR1cm4gaG9yaXpv bnRhbFNjcm9sbGJhck1vZGUoKSAhPSBTY3JvbGxiYXJBbHdheXNPZmYgfHwgdmVydGljYWxTY3Jv bGxiYXJNb2RlKCkgIT0gU2Nyb2xsYmFyQWx3YXlzT2ZmOyB9CiAKKyAgICBib29sIHBhaW50RW50 aXJlQ29udGVudHMoKSBjb25zdCB7IHJldHVybiBtX3BhaW50RW50aXJlQ29udGVudHM7IH0KKyAg ICB2b2lkIHNldFBhaW50RW50aXJlQ29udGVudHMoYm9vbCBmbGFnKTsKKwogICAgIC8vIE92ZXJy aWRkZW4gYnkgRnJhbWVWaWV3IHRvIGNyZWF0ZSBjdXN0b20gQ1NTIHNjcm9sbGJhcnMgaWYgYXBw bGljYWJsZS4KICAgICB2aXJ0dWFsIFBhc3NSZWZQdHI8U2Nyb2xsYmFyPiBjcmVhdGVTY3JvbGxi YXIoU2Nyb2xsYmFyT3JpZW50YXRpb24pOwogCkBAIC0yNzIsNiArMjc1LDggQEAgcHJpdmF0ZToK ICAgICBib29sIG1fZHJhd1BhblNjcm9sbEljb247CiAgICAgYm9vbCBtX3VzZUZpeGVkTGF5b3V0 OwogCisgICAgYm9vbCBtX3BhaW50RW50aXJlQ29udGVudHM7CisKICAgICB2b2lkIGluaXQoKTsK ICAgICB2b2lkIGRlc3Ryb3koKTsKIAo= 44205 2009-12-02 20:57:29 -0800 2009-12-02 21:33:39 -0800 Patch adding a new paintsEntireContents property. paintsEntireContents.patch text/plain 4561 antognolli+webkit ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTQ1MGExMi4uYWNjODZiNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAwOS0xMi0wMiAgUmFmYWVsIEFudG9n bm9sbGkgIDxhbnRvZ25vbGxpQHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHJlcGFpbnQgZXZlbnRzIGZyb20gb3V0c2lkZSB0 aGUgdmlld3BvcnQgYXJlbid0IHJlY2VpdmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMjA4MQorCisgICAgICAgIE5vIGNoYW5nZSBpbiBiZWhhdmlv ciwgc28gbm8gbmV3IHRlc3RzIGFkZGVkLgorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpyZXBhaW50Q29udGVudFJlY3RhbmdsZSk6 CisgICAgICAgICogcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpT Y3JvbGxWaWV3OjpTY3JvbGxWaWV3KToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6OnNl dFBhaW50c0VudGlyZUNvbnRlbnRzKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6Ondo ZWVsRXZlbnQpOgorICAgICAgICAqIHBsYXRmb3JtL1Njcm9sbFZpZXcuaDoKKyAgICAgICAgKFdl YkNvcmU6OlNjcm9sbFZpZXc6OnBhaW50c0VudGlyZUNvbnRlbnRzKToKKwogMjAwOS0xMi0wMiAg RGF2ZSBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJp biBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvV2ViQ29y ZS9wYWdlL0ZyYW1lVmlldy5jcHAKaW5kZXggZDBmOWM0Ny4uNDg0MzE3MyAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5j cHAKQEAgLTk0OSw5ICs5NDksMTAgQEAgdm9pZCBGcmFtZVZpZXc6OnJlcGFpbnRDb250ZW50UmVj dGFuZ2xlKGNvbnN0IEludFJlY3QmIHIsIGJvb2wgaW1tZWRpYXRlKQogCiAgICAgZG91YmxlIGRl bGF5ID0gYWRqdXN0ZWREZWZlcnJlZFJlcGFpbnREZWxheSgpOwogICAgIGlmICgobV9kZWZlcnJp bmdSZXBhaW50cyB8fCBtX2RlZmVycmVkUmVwYWludFRpbWVyLmlzQWN0aXZlKCkgfHwgZGVsYXkp ICYmICFpbW1lZGlhdGUpIHsKLSAgICAgICAgSW50UmVjdCB2aXNpYmxlQ29udGVudCA9IHZpc2li bGVDb250ZW50UmVjdCgpOwotICAgICAgICB2aXNpYmxlQ29udGVudC5pbnRlcnNlY3Qocik7Ci0g ICAgICAgIGlmICh2aXNpYmxlQ29udGVudC5pc0VtcHR5KCkpCisgICAgICAgIEludFJlY3QgcGFp bnRSZWN0ID0gcjsKKyAgICAgICAgaWYgKCFwYWludHNFbnRpcmVDb250ZW50cygpKQorICAgICAg ICAgICAgcGFpbnRSZWN0LmludGVyc2VjdCh2aXNpYmxlQ29udGVudFJlY3QoKSk7CisgICAgICAg IGlmIChwYWludFJlY3QuaXNFbXB0eSgpKQogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICBp ZiAobV9yZXBhaW50Q291bnQgPT0gY1JlcGFpbnRSZWN0VW5pb25UaHJlc2hvbGQpIHsKICAgICAg ICAgICAgIEludFJlY3QgdW5pb25lZFJlY3Q7CkBAIC05NjEsOSArOTYyLDkgQEAgdm9pZCBGcmFt ZVZpZXc6OnJlcGFpbnRDb250ZW50UmVjdGFuZ2xlKGNvbnN0IEludFJlY3QmIHIsIGJvb2wgaW1t ZWRpYXRlKQogICAgICAgICAgICAgbV9yZXBhaW50UmVjdHMuYXBwZW5kKHVuaW9uZWRSZWN0KTsK ICAgICAgICAgfQogICAgICAgICBpZiAobV9yZXBhaW50Q291bnQgPCBjUmVwYWludFJlY3RVbmlv blRocmVzaG9sZCkKLSAgICAgICAgICAgIG1fcmVwYWludFJlY3RzLmFwcGVuZCh2aXNpYmxlQ29u dGVudCk7CisgICAgICAgICAgICBtX3JlcGFpbnRSZWN0cy5hcHBlbmQocGFpbnRSZWN0KTsKICAg ICAgICAgZWxzZQotICAgICAgICAgICAgbV9yZXBhaW50UmVjdHNbMF0udW5pdGUodmlzaWJsZUNv bnRlbnQpOworICAgICAgICAgICAgbV9yZXBhaW50UmVjdHNbMF0udW5pdGUocGFpbnRSZWN0KTsK ICAgICAgICAgbV9yZXBhaW50Q291bnQrKzsKICAgICAKICAgICAgICAgaWYgKCFtX2RlZmVycmlu Z1JlcGFpbnRzICYmICFtX2RlZmVycmVkUmVwYWludFRpbWVyLmlzQWN0aXZlKCkpCmRpZmYgLS1n aXQgYS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9T Y3JvbGxWaWV3LmNwcAppbmRleCBlOTFmOGVlLi40YjY3YjVmIDEwMDY0NAotLS0gYS9XZWJDb3Jl L3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmll dy5jcHAKQEAgLTQ5LDYgKzQ5LDcgQEAgU2Nyb2xsVmlldzo6U2Nyb2xsVmlldygpCiAgICAgLCBt X3VwZGF0ZVNjcm9sbGJhcnNQYXNzKDApCiAgICAgLCBtX2RyYXdQYW5TY3JvbGxJY29uKGZhbHNl KQogICAgICwgbV91c2VGaXhlZExheW91dChmYWxzZSkKKyAgICAsIG1fcGFpbnRzRW50aXJlQ29u dGVudHMoZmFsc2UpCiB7CiAgICAgcGxhdGZvcm1Jbml0KCk7CiB9CkBAIC0xNjgsNiArMTY5LDEx IEBAIGJvb2wgU2Nyb2xsVmlldzo6Y2FuQmxpdE9uU2Nyb2xsKCkgY29uc3QKICAgICByZXR1cm4g bV9jYW5CbGl0T25TY3JvbGw7CiB9CiAKK3ZvaWQgU2Nyb2xsVmlldzo6c2V0UGFpbnRzRW50aXJl Q29udGVudHMoYm9vbCBwYWludCkKK3sKKyAgICBtX3BhaW50c0VudGlyZUNvbnRlbnRzID0gcGFp bnQ7Cit9CisKICNpZiAhUExBVEZPUk0oR1RLKQogSW50UmVjdCBTY3JvbGxWaWV3Ojp2aXNpYmxl Q29udGVudFJlY3QoYm9vbCBpbmNsdWRlU2Nyb2xsYmFycykgY29uc3QKIHsKQEAgLTcwNywxOCAr NzEzLDE5IEBAIHZvaWQgU2Nyb2xsVmlldzo6ZnJhbWVSZWN0c0NoYW5nZWQoKQogCiB2b2lkIFNj cm9sbFZpZXc6OnJlcGFpbnRDb250ZW50UmVjdGFuZ2xlKGNvbnN0IEludFJlY3QmIHJlY3QsIGJv b2wgbm93KQogewotICAgIEludFJlY3QgdmlzaWJsZUNvbnRlbnQgPSB2aXNpYmxlQ29udGVudFJl Y3QoKTsKLSAgICB2aXNpYmxlQ29udGVudC5pbnRlcnNlY3QocmVjdCk7Ci0gICAgaWYgKHZpc2li bGVDb250ZW50LmlzRW1wdHkoKSkKKyAgICBJbnRSZWN0IHBhaW50UmVjdCA9IHJlY3Q7CisgICAg aWYgKCFtX3BhaW50c0VudGlyZUNvbnRlbnRzKQorICAgICAgICBwYWludFJlY3QuaW50ZXJzZWN0 KHZpc2libGVDb250ZW50UmVjdCgpKTsKKyAgICBpZiAocGFpbnRSZWN0LmlzRW1wdHkoKSkKICAg ICAgICAgcmV0dXJuOwogCiAgICAgaWYgKHBsYXRmb3JtV2lkZ2V0KCkpIHsKLSAgICAgICAgcGxh dGZvcm1SZXBhaW50Q29udGVudFJlY3RhbmdsZSh2aXNpYmxlQ29udGVudCwgbm93KTsKKyAgICAg ICAgcGxhdGZvcm1SZXBhaW50Q29udGVudFJlY3RhbmdsZShwYWludFJlY3QsIG5vdyk7CiAgICAg ICAgIHJldHVybjsKICAgICB9CiAKICAgICBpZiAoaG9zdFdpbmRvdygpKQotICAgICAgICBob3N0 V2luZG93KCktPnJlcGFpbnQoY29udGVudHNUb1dpbmRvdyh2aXNpYmxlQ29udGVudCksIHRydWUs IG5vdyk7CisgICAgICAgIGhvc3RXaW5kb3coKS0+cmVwYWludChjb250ZW50c1RvV2luZG93KHBh aW50UmVjdCksIHRydWUsIG5vdyk7CiB9CiAKIEludFJlY3QgU2Nyb2xsVmlldzo6c2Nyb2xsQ29y bmVyUmVjdCgpIGNvbnN0CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcu aCBiL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5oCmluZGV4IGRiYmJmZjEuLmUyNjk2Nzgg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5oCisrKyBiL1dlYkNvcmUv cGxhdGZvcm0vU2Nyb2xsVmlldy5oCkBAIC05Miw2ICs5Miw5IEBAIHB1YmxpYzoKICAgICB2aXJ0 dWFsIHZvaWQgc2V0Q2FuSGF2ZVNjcm9sbGJhcnMoYm9vbCk7CiAgICAgYm9vbCBjYW5IYXZlU2Ny b2xsYmFycygpIGNvbnN0IHsgcmV0dXJuIGhvcml6b250YWxTY3JvbGxiYXJNb2RlKCkgIT0gU2Ny b2xsYmFyQWx3YXlzT2ZmIHx8IHZlcnRpY2FsU2Nyb2xsYmFyTW9kZSgpICE9IFNjcm9sbGJhckFs d2F5c09mZjsgfQogCisgICAgYm9vbCBwYWludHNFbnRpcmVDb250ZW50cygpIGNvbnN0IHsgcmV0 dXJuIG1fcGFpbnRzRW50aXJlQ29udGVudHM7IH0KKyAgICB2b2lkIHNldFBhaW50c0VudGlyZUNv bnRlbnRzKGJvb2wgZmxhZyk7CisKICAgICAvLyBPdmVycmlkZGVuIGJ5IEZyYW1lVmlldyB0byBj cmVhdGUgY3VzdG9tIENTUyBzY3JvbGxiYXJzIGlmIGFwcGxpY2FibGUuCiAgICAgdmlydHVhbCBQ YXNzUmVmUHRyPFNjcm9sbGJhcj4gY3JlYXRlU2Nyb2xsYmFyKFNjcm9sbGJhck9yaWVudGF0aW9u KTsKIApAQCAtMjcyLDYgKzI3NSw4IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX2RyYXdQYW5TY3Jv bGxJY29uOwogICAgIGJvb2wgbV91c2VGaXhlZExheW91dDsKIAorICAgIGJvb2wgbV9wYWludHNF bnRpcmVDb250ZW50czsKKwogICAgIHZvaWQgaW5pdCgpOwogICAgIHZvaWQgZGVzdHJveSgpOwog Cg==