<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>32071</bug_id>
          
          <creation_ts>2009-12-02 09:26:57 -0800</creation_ts>
          <short_desc>bugzilla-tool post-* and land-* should ask for confirmation before posting/landing</short_desc>
          <delta_ts>2010-01-19 16:54:51 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>31757</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ddkilzer</cc>
    
    <cc>hamaji</cc>
    
    <cc>levin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>168019</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-12-02 09:26:57 -0800</bug_when>
    <thetext>bugzilla-tool post-* should ask for confirmation before posting

https://bugs.webkit.org/show_bug.cgi?id=32051#c4

Something like:

&gt; bugzilla-tool post-diff
Parsing ChangeLog

About to post 12k patch titled &quot;Patch&quot; containing changes to 5 files:
 WebCore/ChangeLog
 WebCore/dom/Document.cpp
 LayoutTests/ChangeLog
 LayoutTests/fast/dom/Document-not-suck.html
 LayoutTests/fast/dom/Document-not-suck-expected.txt
to bug 12345 &quot;Fix Document.cpp not to suck&quot;.

For post-* we can ask about accepting the licenses, which is covered by bug 31757.  You don&apos;t have to do that in the first pass, but whoever adds license confirmation can just tack it on the same confirmation message, since we wouldn&apos;t need two separate prompts.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>182530</commentid>
    <comment_count>1</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-01-19 16:54:51 -0800</bug_when>
    <thetext>Yay!  They do now. :)

Well, at least they show you the diff.  They could do more, but I think we can close this for now.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>