32062 2009-12-02 02:24:08 -0800 [bzt] build-attachment shouldn't check whether the builders are red 2009-12-02 02:51:32 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned commit-queue eric oldest_to_newest 167936 0 abarth 2009-12-02 02:24:08 -0800 build-attachment shouldn't check whether the builders are red 167938 1 44139 abarth 2009-12-02 02:25:49 -0800 Created attachment 44139 Patch 167941 2 44139 eric 2009-12-02 02:28:05 -0800 Comment on attachment 44139 Patch As long as you checked for all callers of build(), then this is OK. 167949 3 44139 commit-queue 2009-12-02 02:51:27 -0800 Comment on attachment 44139 Patch Clearing flags on attachment: 44139 Committed r51596: <http://trac.webkit.org/changeset/51596> 167950 4 commit-queue 2009-12-02 02:51:32 -0800 All reviewed patches have been landed. Closing bug. 44139 2009-12-02 02:25:49 -0800 2009-12-02 02:51:27 -0800 Patch bug-32062-20091202022547.patch text/plain 2720 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5NTliOTA4Li45ODM0ODc4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTIt MDIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbYnp0XSBidWlsZC1hdHRhY2htZW50IHNob3Vs ZG4ndCBjaGVjayB3aGV0aGVyIHRoZSBidWlsZGVycyBhcmUgcmVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjA2MgorCisgICAgICAgIGJ1aWxkLWF0 dGFjaG1lbnQgZG9lc24ndCB0b3VjaCB0aGUgcmVtb3RlIHJlcG9zaXRvcnksIHNvIHRoZXJlIGlz bid0IGEKKyAgICAgICAgbmVlZCB0byBob2xkIG9mZiB3aGVuIHRoZSBidWlsZGVycyBhcmUgcmVk LgorCisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL2Rvd25sb2FkLnB5OgorICAg ICAgICAqIFNjcmlwdHMvbW9kdWxlcy9sYW5kaW5nc2VxdWVuY2UucHk6CisKIDIwMDktMTItMDIg IEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFk YW0gQmFydGguCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29tbWFu ZHMvZG93bmxvYWQucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29tbWFuZHMvZG93 bmxvYWQucHkKaW5kZXggZWNhYWRkMC4uYTQ1NjMyYyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMv U2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL2Rvd25sb2FkLnB5CisrKyBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvbW9kdWxlcy9jb21tYW5kcy9kb3dubG9hZC5weQpAQCAtMTI5LDYgKzEyOSw3IEBAIGNs YXNzIExhbmREaWZmU2VxdWVuY2UoQ29uZGl0aW9uYWxMYW5kaW5nU2VxdWVuY2UpOgogICAgICAg ICBDb25kaXRpb25hbExhbmRpbmdTZXF1ZW5jZS5fX2luaXRfXyhzZWxmLCBwYXRjaCwgb3B0aW9u cywgdG9vbCkKIAogICAgIGRlZiBydW4oc2VsZik6CisgICAgICAgIHNlbGYuY2hlY2tfYnVpbGRl cnMoKQogICAgICAgICBzZWxmLmJ1aWxkKCkKICAgICAgICAgc2VsZi50ZXN0KCkKICAgICAgICAg Y29tbWl0X2xvZyA9IHNlbGYuY29tbWl0KCkKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Njcmlw dHMvbW9kdWxlcy9sYW5kaW5nc2VxdWVuY2UucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVs ZXMvbGFuZGluZ3NlcXVlbmNlLnB5CmluZGV4IDc2NTVlYWEuLmVjYjIzMWUgMTAwNjQ0Ci0tLSBh L1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9sYW5kaW5nc2VxdWVuY2UucHkKKysrIGIvV2Vi S2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2xhbmRpbmdzZXF1ZW5jZS5weQpAQCAtNTEsNiArNTEs NyBAQCBjbGFzcyBMYW5kaW5nU2VxdWVuY2U6CiAgICAgICAgIHNlbGYuY2xlYW4oKQogICAgICAg ICBzZWxmLnVwZGF0ZSgpCiAgICAgICAgIHNlbGYuYXBwbHlfcGF0Y2goKQorICAgICAgICBzZWxm LmNoZWNrX2J1aWxkZXJzKCkKICAgICAgICAgc2VsZi5idWlsZCgpCiAgICAgICAgIHNlbGYudGVz dCgpCiAgICAgICAgIGNvbW1pdF9sb2cgPSBzZWxmLmNvbW1pdCgpCkBAIC04MiwxMCArODMsMTAg QEAgY2xhc3MgTGFuZGluZ1NlcXVlbmNlOgogICAgICAgICBsb2coIlByb2Nlc3NpbmcgcGF0Y2gg JXMgZnJvbSBidWcgJXMuIiAlIChzZWxmLl9wYXRjaFsiaWQiXSwgc2VsZi5fcGF0Y2hbImJ1Z19p ZCJdKSkKICAgICAgICAgc2VsZi5fdG9vbC5zY20oKS5hcHBseV9wYXRjaChzZWxmLl9wYXRjaCwg Zm9yY2U9c2VsZi5fb3B0aW9ucy5ub25faW50ZXJhY3RpdmUpCiAKLSAgICBkZWYgYnVpbGQoc2Vs Zik6Ci0gICAgICAgICMgTWFrZSBzdXJlIHRoZSB0cmVlIGlzIHN0aWxsIGdyZWVuIGFmdGVyIHVw ZGF0aW5nLCBiZWZvcmUgYnVpbGRpbmcgdGhpcyBwYXRjaC4KLSAgICAgICAgIyBUaGUgZmlyc3Qg cGF0Y2ggZW5kcyB1cCBjaGVja2luZyB0cmVlIHN0YXR1cyB0d2ljZSwgYnV0IHRoYXQncyBPSy4K KyAgICBkZWYgY2hlY2tfYnVpbGRlcnMoc2VsZik6CiAgICAgICAgIHNlbGYuX3Rvb2wuc3RlcHMu ZW5zdXJlX2J1aWxkZXJzX2FyZV9ncmVlbihzZWxmLl90b29sLmJ1aWxkYm90LCBzZWxmLl9vcHRp b25zKQorCisgICAgZGVmIGJ1aWxkKHNlbGYpOgogICAgICAgICBzZWxmLl90b29sLnN0ZXBzLmJ1 aWxkX3dlYmtpdChxdWlldD1zZWxmLl9vcHRpb25zLnF1aWV0LCBwb3J0PXNlbGYuX3BvcnQpCiAK ICAgICBkZWYgdGVzdChzZWxmKToKQEAgLTEyMCw2ICsxMjEsMTAgQEAgY2xhc3MgQ29uZGl0aW9u YWxMYW5kaW5nU2VxdWVuY2UoTGFuZGluZ1NlcXVlbmNlKToKICAgICAgICAgaWYgc2VsZi5fb3B0 aW9ucy51cGRhdGU6CiAgICAgICAgICAgICBMYW5kaW5nU2VxdWVuY2UudXBkYXRlKHNlbGYpCiAK KyAgICBkZWYgY2hlY2tfYnVpbGRlcnMoc2VsZik6CisgICAgICAgIGlmIHNlbGYuX29wdGlvbnMu YnVpbGQ6CisgICAgICAgICAgICBMYW5kaW5nU2VxdWVuY2UuY2hlY2tfYnVpbGRlcnMoc2VsZikK KwogICAgIGRlZiBidWlsZChzZWxmKToKICAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy5idWlsZDoK ICAgICAgICAgICAgIExhbmRpbmdTZXF1ZW5jZS5idWlsZChzZWxmKQo=