32061 2009-12-02 02:22:36 -0800 REGRESSION(51590): style-queue and build-queue think they are empty when they are not 2009-12-02 02:44:40 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue webkit.review.bot oldest_to_newest 167935 0 eric 2009-12-02 02:22:36 -0800 style-queue and build-queue think their empty when they are not This is due to a regression from r51590. In fetch_attachment, we depend on attachment['id'] == attachment_id. Thats not true if one is an int and the other is a string. Lets fix all ids to be ints, and update the unit tests accordingly. The unit test I was fixing in r51590 was wrong. For now I'm papering over the comparison problem because fetch_attachment is very difficult to test due to there being no network abstraction in bugzilla that I can Mock out. 167937 1 44138 eric 2009-12-02 02:25:48 -0800 Created attachment 44138 Patch 167942 2 webkit.review.bot 2009-12-02 02:28:35 -0800 style-queue ran check-webkit-style on attachment 44138 without any errors. 167943 3 44138 abarth 2009-12-02 02:29:36 -0800 Comment on attachment 44138 Patch Thanks. Sorry about the bad test. 167944 4 mrowe 2009-12-02 02:39:47 -0800 “think *they are* empty” 167945 5 eric 2009-12-02 02:40:50 -0800 Thanks. :) I should not still be awake at 6am my body's time. ;p 167946 6 44138 commit-queue 2009-12-02 02:44:35 -0800 Comment on attachment 44138 Patch Clearing flags on attachment: 44138 Committed r51595: <http://trac.webkit.org/changeset/51595> 167947 7 commit-queue 2009-12-02 02:44:40 -0800 All reviewed patches have been landed. Closing bug. 44138 2009-12-02 02:25:48 -0800 2009-12-02 02:44:35 -0800 Patch bug-32061-20091202022547.patch text/plain 4614 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5NTliOTA4Li42OTUwZTRhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMDktMTIt MDIgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04oNTE1OTApOiBzdHlsZS1xdWV1 ZSBhbmQgYnVpbGQtcXVldWUgdGhpbmsgdGhlaXIgZW1wdHkgd2hlbiB0aGV5IGFyZSBub3QKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMDYxCisKKyAg ICAgICAgKiBTY3JpcHRzL21vZHVsZXMvYnVnemlsbGEucHk6IG1ha2UgYWxsIGlkIGxvb2t1cHMg cmV0dXJuIGludHMgaW5zdGVhZCBvZiBzdHJpbmdzLgorICAgICAgICAqIFNjcmlwdHMvbW9kdWxl cy9idWd6aWxsYV91bml0dGVzdC5weTogQWRkIGFuZCB1cGRhdGUgdW5pdCB0ZXN0cyB0byB1c2Ug aW50cy4KKworMjAwOS0xMi0wMiAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKICAg ICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KIAogICAgICAgICBidWlsZC1xdWV1ZSBpcyB0 aHJvd2luZyBleGNlcHRpb25zIGFuZCBjb21wbGFpbmluZyBhYm91dApkaWZmIC0tZ2l0IGEvV2Vi S2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2J1Z3ppbGxhLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy9tb2R1bGVzL2J1Z3ppbGxhLnB5CmluZGV4IGRkMmU1NjkuLjVmMTYwOTEgMTAwNjQ0Ci0tLSBh L1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9idWd6aWxsYS5weQorKysgYi9XZWJLaXRUb29s cy9TY3JpcHRzL21vZHVsZXMvYnVnemlsbGEucHkKQEAgLTk1LDEwICs5NSwxMCBAQCBkZWYgaXNf bWFjX29zX3goKToKIGRlZiBwYXJzZV9idWdfaWQobWVzc2FnZSk6CiAgICAgbWF0Y2ggPSByZS5z ZWFyY2goImh0dHBcOi8vd2Via2l0XC5vcmcvYi8oP1A8YnVnX2lkPlxkKykiLCBtZXNzYWdlKQog ICAgIGlmIG1hdGNoOgotICAgICAgICByZXR1cm4gbWF0Y2guZ3JvdXAoJ2J1Z19pZCcpCisgICAg ICAgIHJldHVybiBpbnQobWF0Y2guZ3JvdXAoJ2J1Z19pZCcpKQogICAgIG1hdGNoID0gcmUuc2Vh cmNoKEJ1Z3ppbGxhLmJ1Z19zZXJ2ZXJfcmVnZXggKyAic2hvd19idWdcLmNnaVw/aWQ9KD9QPGJ1 Z19pZD5cZCspIiwgbWVzc2FnZSkKICAgICBpZiBtYXRjaDoKLSAgICAgICAgcmV0dXJuIG1hdGNo Lmdyb3VwKCdidWdfaWQnKQorICAgICAgICByZXR1cm4gaW50KG1hdGNoLmdyb3VwKCdidWdfaWQn KSkKICAgICByZXR1cm4gTm9uZQogCiAjIEZJWE1FOiBUaGlzIHNob3VsZCBub3QgZGVwZW5kIG9u IGdpdCBmb3IgY29uZmlnIHN0b3JhZ2UKQEAgLTE3Myw3ICsxNzMsNyBAQCBjbGFzcyBCdWd6aWxs YToKICAgICAgICAgYXR0YWNobWVudFsnYnVnX2lkJ10gPSBidWdfaWQKICAgICAgICAgYXR0YWNo bWVudFsnaXNfb2Jzb2xldGUnXSA9IChlbGVtZW50Lmhhc19rZXkoJ2lzb2Jzb2xldGUnKSBhbmQg ZWxlbWVudFsnaXNvYnNvbGV0ZSddID09ICIxIikKICAgICAgICAgYXR0YWNobWVudFsnaXNfcGF0 Y2gnXSA9IChlbGVtZW50Lmhhc19rZXkoJ2lzcGF0Y2gnKSBhbmQgZWxlbWVudFsnaXNwYXRjaCdd ID09ICIxIikKLSAgICAgICAgYXR0YWNobWVudFsnaWQnXSA9IHN0cihlbGVtZW50LmZpbmQoJ2F0 dGFjaGlkJykuc3RyaW5nKQorICAgICAgICBhdHRhY2htZW50WydpZCddID0gaW50KGVsZW1lbnQu ZmluZCgnYXR0YWNoaWQnKS5zdHJpbmcpCiAgICAgICAgIGF0dGFjaG1lbnRbJ3VybCddID0gc2Vs Zi5hdHRhY2htZW50X3VybF9mb3JfaWQoYXR0YWNobWVudFsnaWQnXSkKICAgICAgICAgYXR0YWNo bWVudFsnbmFtZSddID0gdW5pY29kZShlbGVtZW50LmZpbmQoJ2Rlc2MnKS5zdHJpbmcpCiAgICAg ICAgIGF0dGFjaG1lbnRbJ3R5cGUnXSA9IHN0cihlbGVtZW50LmZpbmQoJ3R5cGUnKS5zdHJpbmcp CkBAIC0yMTcsNyArMjE3LDkgQEAgY2xhc3MgQnVnemlsbGE6CiAgICAgICAgICAgICByZXR1cm4g Tm9uZQogICAgICAgICBhdHRhY2htZW50cyA9IHNlbGYuZmV0Y2hfYXR0YWNobWVudHNfZnJvbV9i dWcoYnVnX2lkKQogICAgICAgICBmb3IgYXR0YWNobWVudCBpbiBhdHRhY2htZW50czoKLSAgICAg ICAgICAgIGlmIGF0dGFjaG1lbnRbJ2lkJ10gPT0gYXR0YWNobWVudF9pZDoKKyAgICAgICAgICAg ICMgRklYTUU6IE9uY2Ugd2UgaGF2ZSBhIHJlYWwgQXR0YWNobWVudCBjbGFzcyB3ZSBzaG91bGRu J3QgcGFwZXIgb3ZlciB0aGlzIHBvc3NpYmxlIGNvbXBhcmlzb24gZmFpbHVyZQorICAgICAgICAg ICAgIyBhbmQgd2Ugc2hvdWxkIHJlbW92ZSB0aGUgaW50KCkgPT0gaW50KCkgaGFja3MgYW5kIGxl YXZlIGl0IGp1c3QgPT0uCisgICAgICAgICAgICBpZiBpbnQoYXR0YWNobWVudFsnaWQnXSkgPT0g aW50KGF0dGFjaG1lbnRfaWQpOgogICAgICAgICAgICAgICAgIHNlbGYuX3ZhbGlkYXRlX2NvbW1p dHRlcl9hbmRfcmV2aWV3ZXIoYXR0YWNobWVudCkKICAgICAgICAgICAgICAgICByZXR1cm4gYXR0 YWNobWVudAogICAgICAgICByZXR1cm4gTm9uZSAjIFRoaXMgc2hvdWxkIG5ldmVyIGJlIGhpdC4K ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9idWd6aWxsYV91bml0dGVz dC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9idWd6aWxsYV91bml0dGVzdC5weQpp bmRleCA1MGMyMGM1Li4xM2JmNTVhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21v ZHVsZXMvYnVnemlsbGFfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1 bGVzL2J1Z3ppbGxhX3VuaXR0ZXN0LnB5CkBAIC0yOSw3ICsyOSw3IEBACiBpbXBvcnQgdW5pdHRl c3QKIAogZnJvbSBtb2R1bGVzLmNvbW1pdHRlcnMgaW1wb3J0IENvbW1pdHRlckxpc3QsIFJldmll d2VyLCBDb21taXR0ZXIKLWZyb20gbW9kdWxlcy5idWd6aWxsYSBpbXBvcnQgQnVnemlsbGEKK2Zy b20gbW9kdWxlcy5idWd6aWxsYSBpbXBvcnQgQnVnemlsbGEsIHBhcnNlX2J1Z19pZAogCiBmcm9t IG1vZHVsZXMuQmVhdXRpZnVsU291cCBpbXBvcnQgQmVhdXRpZnVsU291cAogCkBAIC02MSwxMCAr NjEsMTAgQEAgY2xhc3MgQnVnemlsbGFUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAg PC9hdHRhY2htZW50PgogJycnCiAgICAgX2V4cGVjdGVkX2V4YW1wbGVfYXR0YWNobWVudF9wYXJz aW5nID0gewotICAgICAgICAnYnVnX2lkJyA6ICIxMDAiLAorICAgICAgICAnYnVnX2lkJyA6IDEw MCwKICAgICAgICAgJ2lzX29ic29sZXRlJyA6IFRydWUsCiAgICAgICAgICdpc19wYXRjaCcgOiBU cnVlLAotICAgICAgICAnaWQnIDogIjMzNzIxIiwKKyAgICAgICAgJ2lkJyA6IDMzNzIxLAogICAg ICAgICAndXJsJyA6ICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9hdHRhY2htZW50LmNnaT9pZD0z MzcyMSIsCiAgICAgICAgICduYW1lJyA6ICJGaXhlZCB3aGl0ZXNwYWNlIGlzc3VlIiwKICAgICAg ICAgJ3R5cGUnIDogInRleHQvcGxhaW4iLApAQCAtNzQsNiArNzQsMjAgQEAgY2xhc3MgQnVnemls bGFUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgJ2NvbW1pdHRlcl9lbWFpbCcgOiAn dHdvQHRlc3QuY29tJywKICAgICB9CiAKKyAgICBkZWYgdGVzdF9wYXJzZV9idWdfaWQoc2VsZik6 CisgICAgICAgICMgRklYTUU6IFRoZXNlIHdvdWxkIGJlIGFsbCBiZXR0ZXIgYXMgZG9jdGVzdHMK KyAgICAgICAgYnVncyA9IEJ1Z3ppbGxhKCkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoMTIz NDUsIHBhcnNlX2J1Z19pZCgiaHR0cDovL3dlYmtpdC5vcmcvYi8xMjM0NSIpKQorICAgICAgICBz ZWxmLmFzc2VydEVxdWFscygxMjM0NSwgcGFyc2VfYnVnX2lkKCJodHRwOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM0NSIpKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFscygx MjM0NSwgcGFyc2VfYnVnX2lkKGJ1Z3Muc2hvcnRfYnVnX3VybF9mb3JfYnVnX2lkKDEyMzQ1KSkp CisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKDEyMzQ1LCBwYXJzZV9idWdfaWQoYnVncy5idWdf dXJsX2Zvcl9idWdfaWQoMTIzNDUpKSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoMTIzNDUs IHBhcnNlX2J1Z19pZChidWdzLmJ1Z191cmxfZm9yX2J1Z19pZCgxMjM0NSwgeG1sPVRydWUpKSkK KworICAgICAgICAjIE91ciBidWcgcGFyc2VyIGlzIHN1cGVyLWZyYWdpbGUsIGJ1dCBhdCBsZWFz dCB3ZSdyZSB0ZXN0aW5nIGl0LgorICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhOb25lLCBwYXJz ZV9idWdfaWQoImh0dHA6Ly93d3cud2Via2l0Lm9yZy9iLzEyMzQ1IikpCisgICAgICAgIHNlbGYu YXNzZXJ0RXF1YWxzKE5vbmUsIHBhcnNlX2J1Z19pZCgiaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/Y3R5cGU9eG1sJmlkPTEyMzQ1IikpCisKKwogICAgIGRlZiB0ZXN0X2F0dGFj aG1lbnRfcGFyc2luZyhzZWxmKToKICAgICAgICAgYnVnemlsbGEgPSBCdWd6aWxsYSgpCiAK