32046 2009-12-01 18:14:33 -0800 Incorrect code in WebGLRenderingContext.cpp 2009-12-01 22:28:17 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 levin webkit-unassigned webkit.review.bot oldest_to_newest 167823 0 44119 levin 2009-12-01 18:14:33 -0800 Created attachment 44119 Patch See title. 167826 1 levin 2009-12-01 18:18:33 -0800 I'll fix the bug title/url on landing (since I created this using bugzilla-tool create-bug) 167827 2 webkit.review.bot 2009-12-01 18:18:41 -0800 style-queue ran check-webkit-style on attachment 44119 without any errors. 167851 3 44119 eric 2009-12-01 20:22:23 -0800 Comment on attachment 44119 Patch Your ChangeLog needs to reference the bug. Otherwise this looks fine. Can't be cq'd as is, but I doubt you had planned to use the cq anyway. 167879 4 levin 2009-12-01 22:28:17 -0800 Committed as http://trac.webkit.org/changeset/51588 44119 2009-12-01 18:14:33 -0800 2009-12-01 20:22:23 -0800 Patch 20091201181431.patch text/plain 2143 levin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Mzk4Zjc0NC4uNWE2ZDNmMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0xMi0wMSAgRGF2aWQgTGV2aW4g IDxsZXZpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTmVlZCBhIHNob3J0IGRlc2NyaXB0aW9uIGFuZCBidWcgVVJMIChPT1BT ISkKKworICAgICAgICBGaXggaW5jb3JyZWN0IGNvZGUgdGhhdCBoYXBwZW5lZCB0byB3b3JrLiAh PSBoYXMgaGlnaGVyIHByZWNlbmRlbmNlIHRoYW4gJi4KKyAgICAgICAgVGhlIHNpbXBsZXN0IGZp eCBpcyB0byByZW1vdmUgdGhlICIhPSAwIiB3aGljaCB2aW9sYXRlcyBXZWJLaXQgc3R5bGUKKyAg ICAgICAgZ3VpZGVsaW5lcyBhbnl3YXkuCisKKyAgICAgICAgQWxzbyBhZGRlZCBwZXJpb2RzIHRv IGZldyBjb21tZW50cyBpbiB0aGUgc2FtZSBmdW5jdGlvbi4KKworICAgICAgICAqIGh0bWwvY2Fu dmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJl bmRlcmluZ0NvbnRleHQ6OnZhbGlkYXRlSW5kZXhBcnJheSk6CisKIDIwMDktMTItMDEgIFBhdmVs IEZlbGRtYW4gIDxwZmVsZG1hbkBkaGNwLTE3Mi0yOC0xNzQtMjIwLnNwYi5jb3JwLmdvb2dsZS5j b20+CiAKICAgICAgICAgTm90IHJldmlld2VkOiBjaHJvbWl1bSBidWlsZCBmaXgsIGFkZGVkIG1p c3NpbmcgaW1wb3J0LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRl cmluZ0NvbnRleHQuY3BwIGIvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRl eHQuY3BwCmluZGV4IDMyMjIyZDQuLmExOWQ1YzYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9j YW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAorKysgYi9XZWJDb3JlL2h0bWwvY2FudmFz L1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKQEAgLTU3NywxMSArNTc3LDExIEBAIGJvb2wgV2Vi R0xSZW5kZXJpbmdDb250ZXh0Ojp2YWxpZGF0ZUluZGV4QXJyYXkodW5zaWduZWQgbG9uZyBjb3Vu dCwgdW5zaWduZWQgbG9uCiAgICAgdW5zaWduZWQgbG9uZyB1b2Zmc2V0ID0gc3RhdGljX2Nhc3Q8 dW5zaWduZWQgbG9uZz4ob2Zmc2V0KTsKICAgICAKICAgICBpZiAodHlwZSA9PSBHcmFwaGljc0Nv bnRleHQzRDo6VU5TSUdORURfU0hPUlQpIHsKLSAgICAgICAgLy8gRm9yIGFuIHVuc2lnbmVkIHNo b3J0IGFycmF5LCBvZmZzZXQgbXVzdCBiZSBkaXZpc2libGUgYnkgMiBmb3IgYWxpZ25tZW50IHJl YXNvbnMKLSAgICAgICAgaWYgKHVvZmZzZXQgJiAxICE9IDApCisgICAgICAgIC8vIEZvciBhbiB1 bnNpZ25lZCBzaG9ydCBhcnJheSwgb2Zmc2V0IG11c3QgYmUgZGl2aXNpYmxlIGJ5IDIgZm9yIGFs aWdubWVudCByZWFzb25zLgorICAgICAgICBpZiAodW9mZnNldCAmIDEpCiAgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7CiAgICAgICAgIAotICAgICAgICAvLyBNYWtlIHVvZmZzZXQgYW4gZWxlbWVu dCBvZmZzZXQKKyAgICAgICAgLy8gTWFrZSB1b2Zmc2V0IGFuIGVsZW1lbnQgb2Zmc2V0LgogICAg ICAgICB1b2Zmc2V0IC89IDI7CiAgICAgCiAgICAgICAgIHVuc2lnbmVkIGxvbmcgbiA9IG1fYm91 bmRFbGVtZW50QXJyYXlCdWZmZXItPmJ5dGVMZW5ndGgoR3JhcGhpY3NDb250ZXh0M0Q6OkVMRU1F TlRfQVJSQVlfQlVGRkVSKSAvIDI7CkBAIC02MDcsNyArNjA3LDcgQEAgYm9vbCBXZWJHTFJlbmRl cmluZ0NvbnRleHQ6OnZhbGlkYXRlSW5kZXhBcnJheSh1bnNpZ25lZCBsb25nIGNvdW50LCB1bnNp Z25lZCBsb24KICAgICAgICAgfQogICAgIH0gICAgCiAgICAgICAgIAotICAgIC8vIFRoZW4gc2V0 IHRoZSBsYXN0IGluZGV4IGluIHRoZSBpbmRleCBhcnJheSBhbmQgbWFrZSBzdXJlIGl0IGlzIHZh bGlkCisgICAgLy8gVGhlbiBzZXQgdGhlIGxhc3QgaW5kZXggaW4gdGhlIGluZGV4IGFycmF5IGFu ZCBtYWtlIHN1cmUgaXQgaXMgdmFsaWQuCiAgICAgbnVtRWxlbWVudHMgPSBsYXN0SW5kZXggKyAx OwogICAgIHJldHVybiBudW1FbGVtZW50cyA+IDA7CiB9Cg==