32041 2009-12-01 16:56:54 -0800 [wx] Get DumpRenderTree building after waf switch 2009-12-02 17:23:05 -0800 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) All All RESOLVED FIXED Wx P2 Normal --- 1 kevino webkit-unassigned webkit.review.bot oldest_to_newest 167786 0 kevino 2009-12-01 16:56:54 -0800 Restore the DumpRenderTree build for wx after the switch to waf. 167788 1 44113 kevino 2009-12-01 16:59:39 -0800 Created attachment 44113 patch to build DRT as part of wx build process 167790 2 webkit.review.bot 2009-12-01 17:04:30 -0800 style-queue ran check-webkit-style on attachment 44113 without any errors. 168198 3 44113 eric 2009-12-02 15:47:28 -0800 Comment on attachment 44113 patch to build DRT as part of wx build process rs=me. I'm still confused why wx would want to have its own build system. That just seems like more headache/overhead for a project with so few maintainers. 168220 4 kevino 2009-12-02 17:23:05 -0800 (In reply to comment #3) > (From update of attachment 44113 [details]) > rs=me. I'm still confused why wx would want to have its own build system. > That just seems like more headache/overhead for a project with so few > maintainers. Not really. One thing I learned from maintaining wxWebKit for several years is that dealing with IDEs and their limitations accounts for a large degree of maintenance effort. After the switch to waf, I rarely ever touch the wx build system; it pretty much autodetects most changes and maintains itself. :) To give an example, a grep in WebCore/ChangeLog for .gypi yields 147 results but a grep for wscript yields 6. So since it's introduction in August, I have changed the WebCore/wscript file 6 times, with the first being its introduction into the codebase. :-) WebKitTools/wx/settings.py, the most often changed file, has 26 changes, including its introduction. (Half of those changes were in the first month as we ironed out the bugs in the build system.) This is a general idea of how much I've needed to update the build system over 4 months to keep things running smoothly. My impression is that a vast majority of the build fix commits I make these days are actual source code issues - a new abstract client interface method I need to implement, a missing header the wx port needs on platform X, etc. In hindsight, even though it's a small list of files now, I actually should have made the DRT wscript auto-generate the list of sources to build too, but I can do that next time a change is needed. In the end, even sharing maintenance work means doing some maintenance work - I prefer to just have the computer do it for me whenever possible so that I nor anyone else has to do it, and also avoid filling the commit history with "adding file X to the Y port build..." messages. And I haven't even talked about how waf automatically takes advantage of multi-processor machines to speed up the build for all users and seems to have less overhead than make on Unix... ;) And, I mean, it's Python, the language I'd like to do everything in. ;) Anyway, landed in r51618, thanks! 44113 2009-12-01 16:59:39 -0800 2009-12-02 15:47:28 -0800 patch to build DRT as part of wx build process drt_wx.patch text/plain 5006 kevino SW5kZXg6IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3d4L0xheW91dFRlc3RDb250cm9sbGVy V3guY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3d4L0xheW91 dFRlc3RDb250cm9sbGVyV3guY3BwCShyZXZpc2lvbiA1MTU1NykKKysrIFdlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL3d4L0xheW91dFRlc3RDb250cm9sbGVyV3guY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zMjMsMyArMzIzLDI4IEBACiB7CiAgICAgLy8gRklYTUU6IEltcGxlbWVudCB0aGlzLgog fQorCit2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzZXRUaW1lbGluZVByb2ZpbGluZ0VuYWJs ZWQoYm9vbCBlbmFibGVkKQoreworCit9CisKK3ZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OmV2 YWx1YXRlU2NyaXB0SW5Jc29sYXRlZFdvcmxkKHVuc2lnbmVkIHdvcmxkSWQsIEpTT2JqZWN0UmVm IGdsb2JhbE9iamVjdCwgSlNTdHJpbmdSZWYgc2NyaXB0KQoreworCit9CisKK3ZvaWQgTGF5b3V0 VGVzdENvbnRyb2xsZXI6OmRpc2FibGVJbWFnZUxvYWRpbmcoKQoreworCit9CisKK3ZvaWQgTGF5 b3V0VGVzdENvbnRyb2xsZXI6OndoaXRlTGlzdEFjY2Vzc0Zyb21PcmlnaW4oSlNTdHJpbmdSZWYg c291cmNlT3JpZ2luLCBKU1N0cmluZ1JlZiBkZXN0aW5hdGlvblByb3RvY29sLCBKU1N0cmluZ1Jl ZiBkZXN0aW5hdGlvbkhvc3QsIGJvb2wgYWxsb3dEZXN0aW5hdGlvblN1YmRvbWFpbnMpCit7CisK K30KKworSlNSZXRhaW5QdHI8SlNTdHJpbmdSZWY+IExheW91dFRlc3RDb250cm9sbGVyOjpjb3Vu dGVyVmFsdWVGb3JFbGVtZW50QnlJZChKU1N0cmluZ1JlZiBpZCkKK3sKKworfQpJbmRleDogV2Vi S2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvd3NjcmlwdAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29s cy9EdW1wUmVuZGVyVHJlZS93c2NyaXB0CShyZXZpc2lvbiAwKQorKysgV2ViS2l0VG9vbHMvRHVt cFJlbmRlclRyZWUvd3NjcmlwdAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw2NiBAQAorIyEgL3Vz ci9iaW4vZW52IHB5dGhvbgorCisjIENvcHlyaWdodCAoQykgMjAwOSBLZXZpbiBPbGxpdmllciAg QWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMKKyMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3Vy Y2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisjIG1vZGlmaWNhdGlvbiwgYXJl IHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucworIyBhcmUg bWV0OgorIyAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhl IGFib3ZlIGNvcHlyaWdodAorIyAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFu ZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisjIDIuIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5h cnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0CisjICAgIG5vdGljZSwg dGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0 aGUKKyMgICAgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdp dGggdGhlIGRpc3RyaWJ1dGlvbi4KKyMKKyMgVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBB UFBMRSBDT01QVVRFUiwgSU5DLiBgYEFTIElTJycgQU5EIEFOWQorIyBFWFBSRVNTIE9SIElNUExJ RUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRQorIyBJTVBM SUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJ Q1VMQVIKKyMgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gIElOIE5PIEVWRU5UIFNIQUxMIEFQUExF IENPTVBVVEVSLCBJTkMuIE9SCisjIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJF Q1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLAorIyBFWEVNUExBUlksIE9SIENPTlNF UVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCisjIFBST0NV UkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRB LCBPUgorIyBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VE IEFORCBPTiBBTlkgVEhFT1JZCisjIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwg U1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorIyAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RI RVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyMgT0YgVEhJUyBTT0ZU V0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4g CisjCisjIHd4QnJvd3NlciBzYW1wbGUgYXBwIGJ1aWxkIHNjcmlwdCBmb3IgdGhlIHdhZiBidWls ZCBzeXN0ZW0KKworaW1wb3J0IHN5cworCitmcm9tIHNldHRpbmdzIGltcG9ydCAqCisKK2luY2x1 ZGVfcGF0aHMgPSBbCisgICAgICAgICAgICAgICAgb3MucGF0aC5qb2luKG91dHB1dF9kaXIpLAor ICAgICAgICAgICAgICAgIG9zLnBhdGguam9pbih3a19yb290LCAnSmF2YVNjcmlwdENvcmUnKSwK KyAgICAgICAgICAgICAgICBvcy5wYXRoLmpvaW4od2tfcm9vdCwgJ1dlYkNvcmUnKSwKKyAgICAg ICAgICAgICAgICBvcy5wYXRoLmpvaW4od2tfcm9vdCwgJ1dlYktpdCcsICd3eCcpLCAKKyAgICAg ICAgICAgICAgICAnLicsIAorICAgICAgICAgICAgICAgICd3eCcKKyAgICAgICAgICAgICAgICBd Citzb3VyY2VzID0gWworICAgICAgICAgICAgJ0xheW91dFRlc3RDb250cm9sbGVyLmNwcCcsCisg ICAgICAgICAgICAnV29ya1F1ZXVlLmNwcCcsCisgICAgICAgICAgICAnd3gvRHVtcFJlbmRlclRy ZWVXeC5jcHAnLAorICAgICAgICAgICAgJ3d4L0xheW91dFRlc3RDb250cm9sbGVyV3guY3BwJywK KyAgICAgICAgICAgICd3eC9Xb3JrUXVldWVJdGVtV3guY3BwJworICAgICAgICAgIF0KKworZGVm IHNldF9vcHRpb25zKG9wdCk6CisgICAgY29tbW9uX3NldF9vcHRpb25zKG9wdCkKKworZGVmIGNv bmZpZ3VyZShjb25mKToKKyAgICBjb21tb25fY29uZmlndXJlKGNvbmYpCisgICAgCitkZWYgYnVp bGQoYmxkKToKKyAgICBpbXBvcnQgT3B0aW9ucworCisgICAgb2JqID0gYmxkLm5ld190YXNrX2dl bigKKyAgICAgICAgZmVhdHVyZXMgPSAnY3h4IGNwcm9ncmFtJywKKyAgICAgICAgaW5jbHVkZXMg PSAnICcuam9pbihpbmNsdWRlX3BhdGhzKSwKKyAgICAgICAgc291cmNlID0gc291cmNlcywKKyAg ICAgICAgdGFyZ2V0ID0gJ0R1bXBSZW5kZXJUcmVlJywKKyAgICAgICAgdXNlbGliID0gJ1dYV0VC S0lUIFdYICcgKyBnZXRfY29uZmlnKCksCisgICAgICAgIGxpYnBhdGggPSBbb3V0cHV0X2Rpcl0s CisgICAgICAgIHVzZWxpYl9sb2NhbCA9ICcnLAorICAgICAgICBpbnN0YWxsX3BhdGggPSBvdXRw dXRfZGlyKQorICAgICAgICAKSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CShyZXZpc2lv biA1MTU1NykKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CSh3b3JraW5nIGNv cHkpCkBAIC0zMTYsNiArMzE2LDcgQEAKIAogaWYgKGlzV3goKSkgewogICAgIGRvd25sb2FkV2Fm SWZOZWVkZWQoKTsKKyAgICBwdXNoIEBwcm9qZWN0cywgJ1dlYktpdFRvb2xzL0R1bXBSZW5kZXJU cmVlJzsKICAgICBwdXNoIEBwcm9qZWN0cywgJ1dlYktpdFRvb2xzL3d4L2Jyb3dzZXInOwogICAg IHB1c2ggQHByb2plY3RzLCAnV2ViS2l0L3d4L2JpbmRpbmdzL3B5dGhvbic7CiB9CkluZGV4OiBX ZWJLaXRUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTU1OSkKKysrIFdlYktpdFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDIwIEBACisyMDA5LTEyLTAxICBLZXZpbiBPbGxpdmllciAgPGtldmlub0B0 aGVvbGxpdmllcnMuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFt3eF0gR2V0IER1bXBSZW5kZXJUcmVlIGJ1aWxkaW5nIGFmdGVyIHdhZiBzd2l0 Y2guCisgICAgICAgIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzIwNDEKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3dzY3JpcHQ6IEFkZGVkLgor ICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3d4L0xheW91dFRlc3RDb250cm9sbGVyV3guY3BwOgor ICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldFRpbWVsaW5lUHJvZmlsaW5nRW5hYmxl ZCk6CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcjo6ZXZhbHVhdGVTY3JpcHRJbklzb2xh dGVkV29ybGQpOgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OmRpc2FibGVJbWFnZUxv YWRpbmcpOgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OndoaXRlTGlzdEFjY2Vzc0Zy b21PcmlnaW4pOgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OmNvdW50ZXJWYWx1ZUZv ckVsZW1lbnRCeUlkKToKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoKKwogMjAwOS0x Mi0wMSAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHVz ZXIgY29udGVudCBiZWZvcmUgcnVubmluZyBlYWNoIHRlc3Qgb24gV2luZG93cwo=