<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>32036</bug_id>
          
          <creation_ts>2009-12-01 14:58:27 -0800</creation_ts>
          <short_desc>Implement CredentialStorage::getFromPersistentStorage for CFNetwork</short_desc>
          <delta_ts>2009-12-01 15:35:53 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows XP</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alexey Proskuryakov">ap</reporter>
          <assigned_to name="Alexey Proskuryakov">ap</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>167750</commentid>
    <comment_count>0</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2009-12-01 14:58:27 -0800</bug_when>
    <thetext>CredentialStorage::getFromPersistentStorage() is currently unimplemented. It&apos;s used by WebSocket code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>167756</commentid>
    <comment_count>1</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2009-12-01 15:03:10 -0800</bug_when>
    <thetext>*** Bug 32037 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>167758</commentid>
    <comment_count>2</comment_count>
      <attachid>44107</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2009-12-01 15:05:57 -0800</bug_when>
    <thetext>Created attachment 44107
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>167764</commentid>
    <comment_count>3</comment_count>
      <attachid>44107</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-12-01 15:30:30 -0800</bug_when>
    <thetext>Comment on attachment 44107
proposed patch

&gt; +CFURLCredentialRef wkCopyCredentialFromCFPersistentStorage(CFURLProtectionSpaceRef protectionSpace);

I wouldn&apos;t have named this argument.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>167768</commentid>
    <comment_count>4</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2009-12-01 15:35:53 -0800</bug_when>
    <thetext>Committed &lt;http://trac.webkit.org/changeset/51561&gt;.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>44107</attachid>
            <date>2009-12-01 15:05:57 -0800</date>
            <delta_ts>2009-12-01 15:30:30 -0800</delta_ts>
            <desc>proposed patch</desc>
            <filename>CFNetworkPersistentCredentials.txt</filename>
            <type>text/plain</type>
            <size>3843</size>
            <attacher name="Alexey Proskuryakov">ap</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA1MTU1OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTMgQEAKKzIwMDktMTItMDEgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs
ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMDM2CisgICAgICAgIElt
cGxlbWVudCBDcmVkZW50aWFsU3RvcmFnZTo6Z2V0RnJvbVBlcnNpc3RlbnRTdG9yYWdlIGZvciBD
Rk5ldHdvcmsKKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2YvQ3JlZGVudGlhbFN0b3Jh
Z2VDRk5ldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDcmVkZW50aWFsU3RvcmFnZTo6Z2V0RnJv
bVBlcnNpc3RlbnRTdG9yYWdlKToKKwogMjAwOS0xMi0wMSAgRGFuaWVsIEJhdGVzICA8ZGJhdGVz
QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KSW5kZXg6
IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9DcmVkZW50aWFsU3RvcmFnZUNGTmV0LmNwcAo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvQ3JlZGVudGlhbFN0b3Jh
Z2VDRk5ldC5jcHAJKHJldmlzaW9uIDUxNTIyKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr
L2NmL0NyZWRlbnRpYWxTdG9yYWdlQ0ZOZXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNiwxNyAr
MjYsMTcgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJDcmVkZW50aWFsU3RvcmFn
ZS5oIgogCisjaW5jbHVkZSAiQXV0aGVudGljYXRpb25DRi5oIgogI2luY2x1ZGUgIkNyZWRlbnRp
YWwuaCIKLSNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5oIgogI2luY2x1ZGUgIlByb3RlY3Rpb25T
cGFjZS5oIgorI2luY2x1ZGUgPFdlYktpdFN5c3RlbUludGVyZmFjZS9XZWJLaXRTeXN0ZW1JbnRl
cmZhY2UuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBDcmVkZW50aWFsIENyZWRlbnRpYWxT
dG9yYWdlOjpnZXRGcm9tUGVyc2lzdGVudFN0b3JhZ2UoY29uc3QgUHJvdGVjdGlvblNwYWNlJiBw
cm90ZWN0aW9uU3BhY2UpCiB7Ci0gICAgVU5VU0VEX1BBUkFNKHByb3RlY3Rpb25TcGFjZSk7Ci0g
ICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4gQ3JlZGVudGlhbCgpOworICAgIFJldGFp
blB0cjxDRlVSTENyZWRlbnRpYWxSZWY+IGNyZWRlbnRpYWxDRihBZG9wdENGLCB3a0NvcHlDcmVk
ZW50aWFsRnJvbUNGUGVyc2lzdGVudFN0b3JhZ2UocHJvdGVjdGlvblNwYWNlLmdldCgpKSk7Cisg
ICAgcmV0dXJuIGNvcmUoY3JlZGVudGlhbENGLmdldCgpKTsKIH0KIAogfSAvLyBuYW1lc3BhY2Ug
V2ViQ29yZQpJbmRleDogV2ViS2l0TGlicmFyaWVzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX
ZWJLaXRMaWJyYXJpZXMvQ2hhbmdlTG9nCShyZXZpc2lvbiA1MTU1OSkKKysrIFdlYktpdExpYnJh
cmllcy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0xMi0w
MSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MzIwMzYKKyAgICAgICAgSW1wbGVtZW50IENyZWRlbnRpYWxTdG9yYWdl
OjpnZXRGcm9tUGVyc2lzdGVudFN0b3JhZ2UgZm9yIENGTmV0d29yaworCisgICAgICAgICogd2lu
L2luY2x1ZGUvV2ViS2l0U3lzdGVtSW50ZXJmYWNlL1dlYktpdFN5c3RlbUludGVyZmFjZS5oOgor
ICAgICAgICAqIHdpbi9saWIvV2ViS2l0U3lzdGVtSW50ZXJmYWNlLmxpYjoKKyAgICAgICAgKiB3
aW4vbGliL1dlYktpdFN5c3RlbUludGVyZmFjZV9kZWJ1Zy5saWI6CisgICAgICAgIFVwZGF0ZSBX
ZWJLaXRTeXN0ZW1JbnRlcmZhY2UuCisKIDIwMDktMTEtMjQgIEFsZXhleSBQcm9za3VyeWFrb3Yg
IDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQnJhZHkgRWlkc29uLgpJbmRl
eDogV2ViS2l0TGlicmFyaWVzL3dpbi9pbmNsdWRlL1dlYktpdFN5c3RlbUludGVyZmFjZS9XZWJL
aXRTeXN0ZW1JbnRlcmZhY2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRMaWJyYXJpZXMvd2luL2lu
Y2x1ZGUvV2ViS2l0U3lzdGVtSW50ZXJmYWNlL1dlYktpdFN5c3RlbUludGVyZmFjZS5oCShyZXZp
c2lvbiA1MTUyMikKKysrIFdlYktpdExpYnJhcmllcy93aW4vaW5jbHVkZS9XZWJLaXRTeXN0ZW1J
bnRlcmZhY2UvV2ViS2l0U3lzdGVtSW50ZXJmYWNlLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ3LDYg
KzQ3LDcgQEAgdHlwZWRlZiBzdHJ1Y3QgX19DRkhUVFBNZXNzYWdlKiBDRkhUVFBNZQogdHlwZWRl
ZiBjb25zdCBzdHJ1Y3QgX19DRk51bWJlciogQ0ZOdW1iZXJSZWY7CiB0eXBlZGVmIHN0cnVjdCBf
X0NGUmVhZFN0cmVhbSogQ0ZSZWFkU3RyZWFtUmVmOwogdHlwZWRlZiBjb25zdCBzdHJ1Y3QgX19D
RlVSTCogQ0ZVUkxSZWY7Cit0eXBlZGVmIHN0cnVjdCBfQ0ZVUkxQcm90ZWN0aW9uU3BhY2UqIENG
VVJMUHJvdGVjdGlvblNwYWNlUmVmOwogCiB2b2lkIHdrU2V0Rm9udFNtb290aGluZ0xldmVsKGlu
dCB0eXBlKTsKIGludCB3a0dldEZvbnRTbW9vdGhpbmdMZXZlbCgpOwpAQCAtODYsNiArODcsOCBA
QCB2b2lkIHdrU2V0Q09OTkVDVFByb3h5Rm9yU3RyZWFtKENGUmVhZFN0CiB2b2lkIHdrU2V0Q09O
TkVDVFByb3h5QXV0aG9yaXphdGlvbkZvclN0cmVhbShDRlJlYWRTdHJlYW1SZWYsIENGU3RyaW5n
UmVmIHByb3h5QXV0aG9yaXphdGlvblN0cmluZyk7CiBDRkhUVFBNZXNzYWdlUmVmIHdrQ29weUNP
Tk5FQ1RQcm94eVJlc3BvbnNlKENGUmVhZFN0cmVhbVJlZiwgQ0ZVUkxSZWYgcmVzcG9uc2VVUkwp
OwogCitDRlVSTENyZWRlbnRpYWxSZWYgd2tDb3B5Q3JlZGVudGlhbEZyb21DRlBlcnNpc3RlbnRT
dG9yYWdlKENGVVJMUHJvdGVjdGlvblNwYWNlUmVmIHByb3RlY3Rpb25TcGFjZSk7CisKIENGU3Ry
aW5nUmVmIHdrQ0ZOZXR3b3JrRXJyb3JHZXRMb2NhbGl6ZWREZXNjcmlwdGlvbihDRkluZGV4IGVy
cm9yQ29kZSk7CiAKICNlbmRpZiAvLyBXZWJLaXRTeXN0ZW1JbnRlcmZhY2VfaApJbmRleDogV2Vi
S2l0TGlicmFyaWVzL3dpbi9saWIvV2ViS2l0U3lzdGVtSW50ZXJmYWNlLmxpYgo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
CkNhbm5vdCBkaXNwbGF5OiBmaWxlIG1hcmtlZCBhcyBhIGJpbmFyeSB0eXBlLgpzdm46bWltZS10
eXBlID0gYXBwbGljYXRpb24vb2N0ZXQtc3RyZWFtCgoKSW5kZXg6IFdlYktpdExpYnJhcmllcy93
aW4vbGliL1dlYktpdFN5c3RlbUludGVyZmFjZV9kZWJ1Zy5saWIKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpDYW5ub3Qg
ZGlzcGxheTogZmlsZSBtYXJrZWQgYXMgYSBiaW5hcnkgdHlwZS4Kc3ZuOm1pbWUtdHlwZSA9IGFw
cGxpY2F0aW9uL29jdGV0LXN0cmVhbQoK
</data>
<flag name="review"
          id="25882"
          type_id="1"
          status="+"
          setter="darin"
    />
    <flag name="commit-queue"
          id="25883"
          type_id="3"
          status="-"
          setter="ap"
    />
          </attachment>
      

    </bug>

</bugzilla>