32024 2009-12-01 08:50:46 -0800 [GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER 2009-12-07 11:23:03 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gyuyoung webkit-unassigned commit-queue eric webkit.review.bot oldest_to_newest 167647 0 44085 gyuyoung 2009-12-01 08:50:46 -0800 Created attachment 44085 patch for the build error when JAVASCRIPT_DEBUGGER is disabled on gtk When I try to build webkit without ENABLE(JAVASCRIPT_DEBUGGER), there are some problems. First, even though I run './configure --enable-javascript-debugger=no', the ENABLE(JAVASCRIPT_DEBUGGER) is still enabled. I'm going to report the reason. Second, when I defined 'ENABLE_JAVASCRIPT_DEBUGGER 0' as IPHONE, ANDROID in wtf/Platform.h, there are two build errors as below, -f "WebKit/gtk/webkit/.deps/libwebkit_1_0_la-webkitwebinspector.Tpo"; exit 1; fi WebKit/gtk/webkit/webkitwebinspector.cpp: In function 'void webkit_web_inspector_set_property(GObject*, guint, const GValue*, GParamSpec*)': WebKit/gtk/webkit/webkitwebinspector.cpp:353: error: 'class WebCore::InspectorController' has no member named 'enableProfiler' WebKit/gtk/webkit/webkitwebinspector.cpp:355: error: 'class WebCore::InspectorController' has no member named 'disableProfiler' WebKit/gtk/webkit/webkitwebinspector.cpp: In function 'void webkit_web_inspector_get_property(GObject*, guint, GValue*, GParamSpec*)': WebKit/gtk/webkit/webkitwebinspector.cpp:388: error: 'class WebCore::InspectorController' has no member named 'profilerEnabled' make[1]: *** [WebKit/gtk/webkit/libwebkit_1_0_la-webkitwebinspector.lo] Error 1 make[1]: Leaving directory `/root/workspace/WebKit' make: *** [all] Error 2 Tpo" "WebKit/gtk/webkit/.deps/libwebkit_1_0_la-webkitwebinspector.Plo"; else rm -f "WebKit/gtk/webkit/.deps/libwebkit_1_0_la-webkitwebinspector.Tpo"; exit 1; fi WebKit/gtk/webkit/webkitwebinspector.cpp: In function 'void webkit_web_inspector_get_property(GObject*, guint, GValue*, GParamSpec*)': WebKit/gtk/webkit/webkitwebinspector.cpp:388: error: 'class WebCore::InspectorController' has no member named 'profilerEnabled' make[1]: *** [WebKit/gtk/webkit/libwebkit_1_0_la-webkitwebinspector.lo] Error 1 make[1]: Leaving directory `/root/workspace/WebKit' make: *** [all] Error 2 The reason of upper build errors is that webkitwebinspector.cpp still invokes the enableProfiler(), disableProfiler() and profilerEnabled() defined in WebCore/inspector/InspectorController.h. In my opinion, it seems embedded device based on gtk doesn't need to use JAVASCRIPT_DEBUGGER feature. I make a try a patch for webkitwebinspector.cpp. If there are any nits or problems, please let me know. Thanks. 167789 1 webkit.review.bot 2009-12-01 17:04:13 -0800 style-queue ran check-webkit-style on attachment 44085 without any errors. 167793 2 44085 eric 2009-12-01 17:08:31 -0800 Comment on attachment 44085 patch for the build error when JAVASCRIPT_DEBUGGER is disabled on gtk I'm surprised that these case statements would be outisde the #if. Does the UI still show JS profiling stuff, and does the console object still expose profiling JS commands? This looks OK as a build fix, but is probably not the full fix. 167794 3 44085 eric 2009-12-01 17:09:23 -0800 Comment on attachment 44085 patch for the build error when JAVASCRIPT_DEBUGGER is disabled on gtk Actually, nevermind. This has no ChangeLog. see http://webkit.org/coding/contributing.html 167843 4 44126 gyuyoung 2009-12-01 19:09:22 -0800 Created attachment 44126 patch with Changelog Thank you for your comment. When I define "ENABLE_JAVASCRIPT_DEBUGGER 0" in Platform.h, there are no build errors on this patch. However, I also think that this patch is not full fix. I will report full patch to this bug. 168055 5 44126 gustavo 2009-12-02 10:26:31 -0800 Comment on attachment 44126 patch with Changelog Hrm. Yeah, I think the case statements should indeed be outside the #if clauses, because it would be kind of an API breakage otherwise, but you should perhaps add a g_message to the #else case, and make sure get_property already sets false to the value, just to be sure. 168207 6 44192 gyuyoung 2009-12-02 16:18:04 -0800 Created attachment 44192 Patch with g_message I add a g_message to #else case. However, I'm not sure it is you want. If there are problems, please let me know. Thanks. 168847 7 44323 gyuyoung 2009-12-04 11:05:33 -0800 Created attachment 44323 patch for the build error when JAVASCRIPT_DEBUGGER is disabled on gtk I have tried to solve the build breaks. As I mentioned in description, there are two cases of error. First, there are build errors as below when the javascript-debugger is disabled in configure(./configure --enable-javascript-debugger=no). WebCore/bindings/js/JSConsoleCustom.cpp:42: error: no ‘JSC::JSValue WebCore::JSConsole::profiles(JSC::ExecState*) const’ member function declared in class ‘WebCore::JSConsole’ WebCore/bindings/js/JSConsoleCustom.cpp:54: error: no ‘JSC::JSValue WebCore::JSConsole::profile(JSC::ExecState*, const JSC::ArgList&)’ member function declared in class ‘WebCore::JSConsole’ WebCore/bindings/js/JSConsoleCustom.cpp:62: error: no ‘JSC::JSValue WebCore::JSConsole::profileEnd(JSC::ExecState*, const JSC::ArgList&)’ member function declared in class ‘WebCore::JSConsole’ make[1]: *** [WebCore/bindings/js/libWebCore_la-JSConsoleCustom.lo] Error 1 make[1]: Leaving directory `/home/gyuyoung/workspace/WebKit' make: *** [all] Error 2 I think that JSConsole.h of DerivedSources doesn't make the JSConsole::profiles() because of the configure setting, but JSConsoleCustom.cpp still compiles the JSConsole::profiles(), which are wrapped by JAVASCRIPT_DEBUGGER as below, #if ENABLE(JAVASCRIPT_DEBUGGER) typedef Vector<RefPtr<JSC::Profile> > ProfilesArray; JSValue JSConsole::profiles(ExecState* exec) const { const ProfilesArray& profiles = impl()->profiles(); MarkedArgumentBuffer list; ProfilesArray::const_iterator end = profiles.end(); for (ProfilesArray::const_iterator iter = profiles.begin(); iter != end; ++iter) list.append(toJS(exec, iter->get())); return constructArray(exec, list); } ... #endif The reason is that JAVASCRIPT_DEBUGGER macro is enabled by Platform.h as below, 679 #if !defined(ENABLE_JAVASCRIPT_DEBUGGER) 680 #define ENABLE_JAVASCRIPT_DEBUGGER 1 681 #endif Upper condition means that if ENABLE_JAVASCRIPT_DEBUGGER is not defined, the ENABLE_JAVASCRIPT_DEBUGGER should be enabled. (It seems the ENABLE_JAVASCRIPT_DEBUGGER is enabled by WebCore/GNUmakefile.am when it is set as "yes" in configure) I think this make the build errors even though the "javascript-debugger" is disabled by configure. IMO, why don't we make the ENABLE_JAVASCRIPT_DEBUGGER set as 0(disable) when it is not defined ? If user sets the javascript-debugger as "no", it means that user doesn't want to use it. So, I think the feature can be disabled as default. BTW, even if the macro is set as 0 basically, as mentioned in description, there are still build breaks as below, -f "WebKit/gtk/webkit/.deps/libwebkit_1_0_la-webkitwebinspector.Tpo"; exit 1; fi WebKit/gtk/webkit/webkitwebinspector.cpp: In function 'void webkit_web_inspector_set_property(GObject*, guint, const GValue*, GParamSpec*)': WebKit/gtk/webkit/webkitwebinspector.cpp:353: error: 'class WebCore::InspectorController' has no member named 'enableProfiler' WebKit/gtk/webkit/webkitwebinspector.cpp:355: error: 'class WebCore::InspectorController' has no member named 'disableProfiler' WebKit/gtk/webkit/webkitwebinspector.cpp: In function 'void webkit_web_inspector_get_property(GObject*, guint, GValue*, GParamSpec*)': WebKit/gtk/webkit/webkitwebinspector.cpp:388: error: 'class WebCore::InspectorController' has no member named 'profilerEnabled' make[1]: *** [WebKit/gtk/webkit/libwebkit_1_0_la-webkitwebinspector.lo] Error 1 make[1]: Leaving directory `/root/workspace/WebKit' make: *** [all] Error 2 Tpo" "WebKit/gtk/webkit/.deps/libwebkit_1_0_la-webkitwebinspector.Plo"; else rm -f "WebKit/gtk/webkit/.deps/libwebkit_1_0_la-webkitwebinspector.Tpo"; exit 1; fi WebKit/gtk/webkit/webkitwebinspector.cpp: In function 'void webkit_web_inspector_get_property(GObject*, guint, GValue*, GParamSpec*)': WebKit/gtk/webkit/webkitwebinspector.cpp:388: error: 'class WebCore::InspectorController' has no member named 'profilerEnabled' make[1]: *** [WebKit/gtk/webkit/libwebkit_1_0_la-webkitwebinspector.lo] Error 1 make[1]: Leaving directory `/root/workspace/WebKit' make: *** [all] Error 2 The webkitwebinspector.cpp invokes some functions related to JAVASCRIPT_DEBUGGER macro regardless of enabling/disabling it. I make a patch for it. Please review it. 168849 8 webkit.review.bot 2009-12-04 11:10:06 -0800 style-queue ran check-webkit-style on attachment 44323 without any errors. 168992 9 gyuyoung 2009-12-04 17:20:00 -0800 Dear Eric : Could you review this patch ? (In reply to comment #7) > Created an attachment (id=44323) [details] > patch for the build error when JAVASCRIPT_DEBUGGER is disabled on gtk > > I have tried to solve the build breaks. As I mentioned in description, there > are two cases of error. First, there are build errors as below when the > javascript-debugger is disabled in configure(./configure > --enable-javascript-debugger=no). > > WebCore/bindings/js/JSConsoleCustom.cpp:42: error: no ‘JSC::JSValue > WebCore::JSConsole::profiles(JSC::ExecState*) const’ member function declared > in class ‘WebCore::JSConsole’ > WebCore/bindings/js/JSConsoleCustom.cpp:54: error: no ‘JSC::JSValue > WebCore::JSConsole::profile(JSC::ExecState*, const JSC::ArgList&)’ member > function declared in class ‘WebCore::JSConsole’ > WebCore/bindings/js/JSConsoleCustom.cpp:62: error: no ‘JSC::JSValue > WebCore::JSConsole::profileEnd(JSC::ExecState*, const JSC::ArgList&)’ member > function declared in class ‘WebCore::JSConsole’ > make[1]: *** [WebCore/bindings/js/libWebCore_la-JSConsoleCustom.lo] Error 1 > make[1]: Leaving directory `/home/gyuyoung/workspace/WebKit' > make: *** [all] Error 2 > > I think that JSConsole.h of DerivedSources doesn't make the > JSConsole::profiles() because of the configure setting, but JSConsoleCustom.cpp > still compiles the JSConsole::profiles(), which are wrapped by > JAVASCRIPT_DEBUGGER as below, > > #if ENABLE(JAVASCRIPT_DEBUGGER) > > typedef Vector<RefPtr<JSC::Profile> > ProfilesArray; > > JSValue JSConsole::profiles(ExecState* exec) const > { > const ProfilesArray& profiles = impl()->profiles(); > MarkedArgumentBuffer list; > > ProfilesArray::const_iterator end = profiles.end(); > for (ProfilesArray::const_iterator iter = profiles.begin(); iter != end; > ++iter) > list.append(toJS(exec, iter->get())); > > return constructArray(exec, list); > } > ... > #endif > > The reason is that JAVASCRIPT_DEBUGGER macro is enabled by Platform.h as below, > > 679 #if !defined(ENABLE_JAVASCRIPT_DEBUGGER) > 680 #define ENABLE_JAVASCRIPT_DEBUGGER 1 > 681 #endif > > Upper condition means that if ENABLE_JAVASCRIPT_DEBUGGER is not defined, the > ENABLE_JAVASCRIPT_DEBUGGER should be enabled. > (It seems the ENABLE_JAVASCRIPT_DEBUGGER is enabled by WebCore/GNUmakefile.am > when it is set as "yes" in configure) > I think this make the build errors even though the "javascript-debugger" is > disabled by configure. > > IMO, why don't we make the ENABLE_JAVASCRIPT_DEBUGGER set as 0(disable) when it > is not defined ? If user sets the javascript-debugger as "no", it means that > user doesn't want to use it. So, I think the feature can be disabled as > default. > > BTW, even if the macro is set as 0 basically, as mentioned in description, > there are still build breaks as below, > > -f "WebKit/gtk/webkit/.deps/libwebkit_1_0_la-webkitwebinspector.Tpo"; exit 1; > fi > WebKit/gtk/webkit/webkitwebinspector.cpp: In function 'void > webkit_web_inspector_set_property(GObject*, guint, const GValue*, > GParamSpec*)': > WebKit/gtk/webkit/webkitwebinspector.cpp:353: error: 'class > WebCore::InspectorController' has no member named 'enableProfiler' > WebKit/gtk/webkit/webkitwebinspector.cpp:355: error: 'class > WebCore::InspectorController' has no member named 'disableProfiler' > WebKit/gtk/webkit/webkitwebinspector.cpp: In function 'void > webkit_web_inspector_get_property(GObject*, guint, GValue*, GParamSpec*)': > WebKit/gtk/webkit/webkitwebinspector.cpp:388: error: 'class > WebCore::InspectorController' has no member named 'profilerEnabled' > make[1]: *** [WebKit/gtk/webkit/libwebkit_1_0_la-webkitwebinspector.lo] Error 1 > make[1]: Leaving directory `/root/workspace/WebKit' > make: *** [all] Error 2 > > Tpo" "WebKit/gtk/webkit/.deps/libwebkit_1_0_la-webkitwebinspector.Plo"; else rm > -f "WebKit/gtk/webkit/.deps/libwebkit_1_0_la-webkitwebinspector.Tpo"; exit 1; > fi > WebKit/gtk/webkit/webkitwebinspector.cpp: In function 'void > webkit_web_inspector_get_property(GObject*, guint, GValue*, GParamSpec*)': > WebKit/gtk/webkit/webkitwebinspector.cpp:388: error: 'class > WebCore::InspectorController' has no member named 'profilerEnabled' > make[1]: *** [WebKit/gtk/webkit/libwebkit_1_0_la-webkitwebinspector.lo] Error 1 > make[1]: Leaving directory `/root/workspace/WebKit' > make: *** [all] Error 2 > > The webkitwebinspector.cpp invokes some functions related to > JAVASCRIPT_DEBUGGER macro regardless of enabling/disabling it. > > I make a patch for it. Please review it. 169000 10 44323 eric 2009-12-04 17:48:57 -0800 Comment on attachment 44323 patch for the build error when JAVASCRIPT_DEBUGGER is disabled on gtk The platform change is wrong. I do not think you should change the default value for ENABLE_JAVASCRIPT_DEBUGGER. 169009 11 44345 gyuyoung 2009-12-04 19:04:22 -0800 Created attachment 44345 patch for the build error when JAVASCRIPT_DEBUGGER is disabled on gtk-2 I add '-DENABLE_JAVASCRIPT_DEBUGGER 0' to WebCore/GNUmakefile.am as below, =========================================================== if ENABLE_JAVASCRIPT_DEBUGGER FEATURE_DEFINES_JAVASCRIPT += ENABLE_JAVASCRIPT_DEBUGGER=1 webcore_cppflags += \ -DENABLE_JAVASCRIPT_DEBUGGER=1 else webcore_cppflags += \ -DENABLE_JAVASCRIPT_DEBUGGER=0 endif # END ENABLE_JAVASCRIPT_DEBUGGER =========================================================== I find that some features ,for example ENABLE_DATABASE, ENABLE_ICONDATABASE, ENABLE_WEB_SOCKETS, already use this way. 169025 12 44348 gyuyoung 2009-12-04 23:06:35 -0800 Created attachment 44348 patch for the build error when JAVASCRIPT_DEBUGGER is disabled on gtk-3 Oops, I added an unnecessary blank line to Changelog. I make a patch again. Thanks. 169026 13 webkit.review.bot 2009-12-04 23:08:38 -0800 style-queue ran check-webkit-style on attachment 44348 without any errors. 169321 14 gyuyoung 2009-12-07 07:33:05 -0800 Dear Eric, Sorry for frequent review request. Could you review my latest patch again ? I want to fix this defect. 169370 15 44348 eric 2009-12-07 10:35:15 -0800 Comment on attachment 44348 patch for the build error when JAVASCRIPT_DEBUGGER is disabled on gtk-3 I don't know really anything about the GNUmakefile.am, but this looks sane enough. Seems strange that whatever build system is using that file doesn't have a cleaner/more consistent way to set feature defines. 169394 16 44348 commit-queue 2009-12-07 11:22:57 -0800 Comment on attachment 44348 patch for the build error when JAVASCRIPT_DEBUGGER is disabled on gtk-3 Clearing flags on attachment: 44348 Committed r51783: <http://trac.webkit.org/changeset/51783> 169395 17 commit-queue 2009-12-07 11:23:03 -0800 All reviewed patches have been landed. Closing bug. 44085 2009-12-01 08:50:46 -0800 2009-12-01 19:09:22 -0800 patch for the build error when JAVASCRIPT_DEBUGGER is disabled on gtk javascript_debugger_patch.patch text/plain 1126 gyuyoung SW5kZXg6IFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmluc3BlY3Rvci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViaW5zcGVjdG9yLmNwcAkocmV2aXNpb24g NTE1MzIpCisrKyBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJpbnNwZWN0b3IuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0zNDYsMTIgKzM0NiwxNCBAQAogCiAgICAgc3dpdGNoKHByb3BfaWQpIHsK ICAgICBjYXNlIFBST1BfSkFWQVNDUklQVF9QUk9GSUxJTkdfRU5BQkxFRDogeworI2lmIEVOQUJM RShKQVZBU0NSSVBUX0RFQlVHR0VSKQogICAgICAgICBib29sIGVuYWJsZWQgPSBnX3ZhbHVlX2dl dF9ib29sZWFuKHZhbHVlKTsKICAgICAgICAgV2ViQ29yZTo6SW5zcGVjdG9yQ29udHJvbGxlciog Y29udHJvbGxlciA9IHByaXYtPnBhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIoKTsKICAgICAgICAg aWYgKGVuYWJsZWQpCiAgICAgICAgICAgICBjb250cm9sbGVyLT5lbmFibGVQcm9maWxlcigpOwog ICAgICAgICBlbHNlCiAgICAgICAgICAgICBjb250cm9sbGVyLT5kaXNhYmxlUHJvZmlsZXIoKTsK KyNlbmRpZgogICAgICAgICBicmVhazsKICAgICB9CiAgICAgY2FzZSBQUk9QX1RJTUVMSU5FX1BS T0ZJTElOR19FTkFCTEVEOiB7CkBAIC0zODIsNyArMzg0LDkgQEAKICAgICAgICAgZ192YWx1ZV9z ZXRfc3RyaW5nKHZhbHVlLCBwcml2LT5pbnNwZWN0ZWRfdXJpKTsKICAgICAgICAgYnJlYWs7CiAg ICAgY2FzZSBQUk9QX0pBVkFTQ1JJUFRfUFJPRklMSU5HX0VOQUJMRUQ6CisjaWYgRU5BQkxFKEpB VkFTQ1JJUFRfREVCVUdHRVIpCiAgICAgICAgIGdfdmFsdWVfc2V0X2Jvb2xlYW4odmFsdWUsIHBy aXYtPnBhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIoKS0+cHJvZmlsZXJFbmFibGVkKCkpOworI2Vu ZGlmCiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgUFJPUF9USU1FTElORV9QUk9GSUxJTkdfRU5B QkxFRDoKICAgICAgICAgZ192YWx1ZV9zZXRfYm9vbGVhbih2YWx1ZSwgcHJpdi0+cGFnZS0+aW5z cGVjdG9yQ29udHJvbGxlcigpLT50aW1lbGluZUFnZW50KCkgIT0gMCk7Cg== 44126 2009-12-01 19:09:22 -0800 2009-12-02 16:18:04 -0800 patch with Changelog javascript-debugger.patch text/plain 1765 gyuyoung SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDUxNTY5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTIt MDEgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBFcmljIFNlaWRlbC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzIwMjQKKyAgICAgICAgW0dUS10gV2ViS2l0IGRvZXMgbm90IGNvbXBpbGUg d2l0aG91dCBKQVZBU0NSSVBUX0RFQlVHR0VSCisKKyAgICAgICAgRml4IGJ1aWxkIGVycm9ycyB3 aGVuIGphdmFzY3JpcHQtZGVidWdnZXIgaXMgZGlzYWJsZWQgb24gR1RLCisKKyAgICAgICAgKiB3 ZWJraXQvd2Via2l0d2ViaW5zcGVjdG9yLmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfaW5zcGVj dG9yX3NldF9wcm9wZXJ0eSk6CisgICAgICAgICh3ZWJraXRfd2ViX2luc3BlY3Rvcl9nZXRfcHJv cGVydHkpOgorCiAyMDA5LTEyLTAxICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkBy aW0uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KSW5kZXg6IHdlYmtp dC93ZWJraXR3ZWJpbnNwZWN0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHdlYmtpdC93ZWJraXR3ZWJp bnNwZWN0b3IuY3BwCShyZXZpc2lvbiA1MTU2OSkKKysrIHdlYmtpdC93ZWJraXR3ZWJpbnNwZWN0 b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNDYsMTIgKzM0NiwxNCBAQAogCiAgICAgc3dpdGNo KHByb3BfaWQpIHsKICAgICBjYXNlIFBST1BfSkFWQVNDUklQVF9QUk9GSUxJTkdfRU5BQkxFRDog eworI2lmIEVOQUJMRShKQVZBU0NSSVBUX0RFQlVHR0VSKQogICAgICAgICBib29sIGVuYWJsZWQg PSBnX3ZhbHVlX2dldF9ib29sZWFuKHZhbHVlKTsKICAgICAgICAgV2ViQ29yZTo6SW5zcGVjdG9y Q29udHJvbGxlciogY29udHJvbGxlciA9IHByaXYtPnBhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIo KTsKICAgICAgICAgaWYgKGVuYWJsZWQpCiAgICAgICAgICAgICBjb250cm9sbGVyLT5lbmFibGVQ cm9maWxlcigpOwogICAgICAgICBlbHNlCiAgICAgICAgICAgICBjb250cm9sbGVyLT5kaXNhYmxl UHJvZmlsZXIoKTsKKyNlbmRpZgogICAgICAgICBicmVhazsKICAgICB9CiAgICAgY2FzZSBQUk9Q X1RJTUVMSU5FX1BST0ZJTElOR19FTkFCTEVEOiB7CkBAIC0zODIsNyArMzg0LDkgQEAKICAgICAg ICAgZ192YWx1ZV9zZXRfc3RyaW5nKHZhbHVlLCBwcml2LT5pbnNwZWN0ZWRfdXJpKTsKICAgICAg ICAgYnJlYWs7CiAgICAgY2FzZSBQUk9QX0pBVkFTQ1JJUFRfUFJPRklMSU5HX0VOQUJMRUQ6Cisj aWYgRU5BQkxFKEpBVkFTQ1JJUFRfREVCVUdHRVIpCiAgICAgICAgIGdfdmFsdWVfc2V0X2Jvb2xl YW4odmFsdWUsIHByaXYtPnBhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIoKS0+cHJvZmlsZXJFbmFi bGVkKCkpOworI2VuZGlmCiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgUFJPUF9USU1FTElORV9Q Uk9GSUxJTkdfRU5BQkxFRDoKICAgICAgICAgZ192YWx1ZV9zZXRfYm9vbGVhbih2YWx1ZSwgcHJp di0+cGFnZS0+aW5zcGVjdG9yQ29udHJvbGxlcigpLT50aW1lbGluZUFnZW50KCkgIT0gMCk7Cg== 44192 2009-12-02 16:18:04 -0800 2009-12-04 11:05:33 -0800 Patch with g_message javascript-debug-patch.patch text/plain 2016 gyuyoung SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDUxNTg4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTIt MDIgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nQGdtYWlsPgorCisgICAgICAgIFJldmlld2VkIGJ5 IEd1c3Rhdm8gTm9yb25oYS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzIwMjQKKyAgICAgICAgW0dUS10gV2ViS2l0IGRvZXMgbm90IGNvbXBpbGUg d2l0aG91dCBKQVZBU0NSSVBUX0RFQlVHR0VSCisKKyAgICAgICAgRml4IGJ1aWxkIGVycm9ycyB3 aGVuIGphdmFzY3JpcHQtZGVidWdnZXIgaXMgZGlzYWJsZWQgb24gR1RLCisKKyAgICAgICAgKiB3 ZWJraXQvd2Via2l0d2ViaW5zcGVjdG9yLmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfaW5zcGVj dG9yX3NldF9wcm9wZXJ0eSk6CisgICAgICAgICh3ZWJraXRfd2ViX2luc3BlY3Rvcl9nZXRfcHJv cGVydHkpOgorCiAyMDA5LTEyLTAxICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkBy aW0uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KSW5kZXg6IHdlYmtp dC93ZWJraXR3ZWJpbnNwZWN0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHdlYmtpdC93ZWJraXR3ZWJp bnNwZWN0b3IuY3BwCShyZXZpc2lvbiA1MTU4OCkKKysrIHdlYmtpdC93ZWJraXR3ZWJpbnNwZWN0 b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNDYsMTIgKzM0NiwxNiBAQAogCiAgICAgc3dpdGNo KHByb3BfaWQpIHsKICAgICBjYXNlIFBST1BfSkFWQVNDUklQVF9QUk9GSUxJTkdfRU5BQkxFRDog eworI2lmIEVOQUJMRShKQVZBU0NSSVBUX0RFQlVHR0VSKQogICAgICAgICBib29sIGVuYWJsZWQg PSBnX3ZhbHVlX2dldF9ib29sZWFuKHZhbHVlKTsKICAgICAgICAgV2ViQ29yZTo6SW5zcGVjdG9y Q29udHJvbGxlciogY29udHJvbGxlciA9IHByaXYtPnBhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIo KTsKICAgICAgICAgaWYgKGVuYWJsZWQpCiAgICAgICAgICAgICBjb250cm9sbGVyLT5lbmFibGVQ cm9maWxlcigpOwogICAgICAgICBlbHNlCiAgICAgICAgICAgICBjb250cm9sbGVyLT5kaXNhYmxl UHJvZmlsZXIoKTsKKyNlbHNlCisgICAgICAgIGdfbWVzc2FnZSgiUFJPUF9KQVZBU0NSSVBUX1BS T0ZJTElOR19FTkFCTEVEIGlzIG5vdCB3b3JrIGJlY2F1c2Ugb2YgdGhlIGphdmFzY3JpcHQgZGVi dWdnZXIgaXMgZGlzYWJsZWRcbiIpOworI2VuZGlmCiAgICAgICAgIGJyZWFrOwogICAgIH0KICAg ICBjYXNlIFBST1BfVElNRUxJTkVfUFJPRklMSU5HX0VOQUJMRUQ6IHsKQEAgLTM4Miw3ICszODYs MTEgQEAKICAgICAgICAgZ192YWx1ZV9zZXRfc3RyaW5nKHZhbHVlLCBwcml2LT5pbnNwZWN0ZWRf dXJpKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBQUk9QX0pBVkFTQ1JJUFRfUFJPRklMSU5H X0VOQUJMRUQ6CisjaWYgRU5BQkxFKEpBVkFTQ1JJUFRfREVCVUdHRVIpCiAgICAgICAgIGdfdmFs dWVfc2V0X2Jvb2xlYW4odmFsdWUsIHByaXYtPnBhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIoKS0+ cHJvZmlsZXJFbmFibGVkKCkpOworI2Vsc2UKKyAgICAgICAgZ19tZXNzYWdlKCJQUk9QX0pBVkFT Q1JJUFRfUFJPRklMSU5HX0VOQUJMRUQgaXMgbm90IHdvcmsgYmVjYXVzZSBvZiB0aGUgamF2YXNj cmlwdCBkZWJ1Z2dlciBpcyBkaXNhYmxlZFxuIik7CisjZW5kaWYKICAgICAgICAgYnJlYWs7CiAg ICAgY2FzZSBQUk9QX1RJTUVMSU5FX1BST0ZJTElOR19FTkFCTEVEOgogICAgICAgICBnX3ZhbHVl X3NldF9ib29sZWFuKHZhbHVlLCBwcml2LT5wYWdlLT5pbnNwZWN0b3JDb250cm9sbGVyKCktPnRp bWVsaW5lQWdlbnQoKSAhPSAwKTsK 44323 2009-12-04 11:05:33 -0800 2009-12-04 19:04:22 -0800 patch for the build error when JAVASCRIPT_DEBUGGER is disabled on gtk javascript-debugger-build-error.patch text/plain 3158 gyuyoung ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAxNDY3MDlkLi45YWZjNmU0IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMDktMTItMDQgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nQGdtYWlsLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzIwMjQKKyAgICAgICAgW0dUS10gV2ViS2l0IGRvZXMg bm90IGNvbXBpbGUgd2l0aG91dCBKQVZBU0NSSVBUX0RFQlVHR0VSCisKKyAgICAgICAgRml4IGJ1 aWxkIGVycm9ycyB3aGVuIGphdmFzY3JpcHQtZGVidWdnZXIgaXMgZGlzYWJsZWQgb24gR1RLCisK KyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKwogMjAwOS0xMi0wMyAgRHJldyBXaWxzb24gIDxh dHdpbHNvbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUm9sbGVkIGJhY2sgcjUxNjMzIGJlY2F1 c2UgaXQgY2F1c2VzIGEgcGVyZiByZWdyZXNzaW9uIGluIENocm9taXVtLgpkaWZmIC0tZ2l0IGEv SmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmggYi9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZv cm0uaAppbmRleCA5ZTFkYmNiLi4yMDgzYzBmIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93 dGYvUGxhdGZvcm0uaAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaApAQCAtNjc3 LDcgKzY3Nyw3IEBACiAjZW5kaWYKIAogI2lmICFkZWZpbmVkKEVOQUJMRV9KQVZBU0NSSVBUX0RF QlVHR0VSKQotI2RlZmluZSBFTkFCTEVfSkFWQVNDUklQVF9ERUJVR0dFUiAxCisjZGVmaW5lIEVO QUJMRV9KQVZBU0NSSVBUX0RFQlVHR0VSIDAKICNlbmRpZgogCiAjaWYgIWRlZmluZWQoRU5BQkxF X0ZUUERJUikKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKaW5kZXggYzBjNDJkNC4uYWEzMzkwYSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAw OS0xMi0wNCAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmdAZ21haWwuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IEVyaWMgU2VpZGVsLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zMjAyNAorICAgICAgICBbR1RLXSBXZWJLaXQgZG9lcyBub3QgY29t cGlsZSB3aXRob3V0IEpBVkFTQ1JJUFRfREVCVUdHRVIKKworICAgICAgICBGaXggYnVpbGQgZXJy b3JzIHdoZW4gamF2YXNjcmlwdC1kZWJ1Z2dlciBpcyBkaXNhYmxlZCBvbiBHVEsKKworICAgICAg ICAqIHdlYmtpdC93ZWJraXR3ZWJpbnNwZWN0b3IuY3BwOgorICAgICAgICAod2Via2l0X3dlYl9p bnNwZWN0b3Jfc2V0X3Byb3BlcnR5KToKKyAgICAgICAgKHdlYmtpdF93ZWJfaW5zcGVjdG9yX2dl dF9wcm9wZXJ0eSk6CisKIDIwMDktMTItMDMgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9XZWJL aXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJpbnNwZWN0b3IuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQv d2Via2l0d2ViaW5zcGVjdG9yLmNwcAppbmRleCA2OGIwM2IyLi4yZmViMDY0IDEwMDY0NAotLS0g YS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJpbnNwZWN0b3IuY3BwCisrKyBiL1dlYktpdC9n dGsvd2Via2l0L3dlYmtpdHdlYmluc3BlY3Rvci5jcHAKQEAgLTM0NiwxMiArMzQ2LDE2IEBAIHN0 YXRpYyB2b2lkIHdlYmtpdF93ZWJfaW5zcGVjdG9yX3NldF9wcm9wZXJ0eShHT2JqZWN0KiBvYmpl Y3QsIGd1aW50IHByb3BfaWQsIGNvCiAKICAgICBzd2l0Y2gocHJvcF9pZCkgewogICAgIGNhc2Ug UFJPUF9KQVZBU0NSSVBUX1BST0ZJTElOR19FTkFCTEVEOiB7CisjaWYgRU5BQkxFKEpBVkFTQ1JJ UFRfREVCVUdHRVIpCiAgICAgICAgIGJvb2wgZW5hYmxlZCA9IGdfdmFsdWVfZ2V0X2Jvb2xlYW4o dmFsdWUpOwogICAgICAgICBXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVyKiBjb250cm9sbGVy ID0gcHJpdi0+cGFnZS0+aW5zcGVjdG9yQ29udHJvbGxlcigpOwogICAgICAgICBpZiAoZW5hYmxl ZCkKICAgICAgICAgICAgIGNvbnRyb2xsZXItPmVuYWJsZVByb2ZpbGVyKCk7CiAgICAgICAgIGVs c2UKICAgICAgICAgICAgIGNvbnRyb2xsZXItPmRpc2FibGVQcm9maWxlcigpOworI2Vsc2UKKyAg ICAgICAgZ19tZXNzYWdlKCJQUk9QX0pBVkFTQ1JJUFRfUFJPRklMSU5HX0VOQUJMRUQgaXMgbm90 IHdvcmsgYmVjYXVzZSBvZiB0aGUgamF2YXNjcmlwdCBkZWJ1Z2dlciBpcyBkaXNhYmxlZFxuIik7 CisjZW5kaWYKICAgICAgICAgYnJlYWs7CiAgICAgfQogICAgIGNhc2UgUFJPUF9USU1FTElORV9Q Uk9GSUxJTkdfRU5BQkxFRDogewpAQCAtMzgyLDcgKzM4NiwxMSBAQCBzdGF0aWMgdm9pZCB3ZWJr aXRfd2ViX2luc3BlY3Rvcl9nZXRfcHJvcGVydHkoR09iamVjdCogb2JqZWN0LCBndWludCBwcm9w X2lkLCBHVgogICAgICAgICBnX3ZhbHVlX3NldF9zdHJpbmcodmFsdWUsIHByaXYtPmluc3BlY3Rl ZF91cmkpOwogICAgICAgICBicmVhazsKICAgICBjYXNlIFBST1BfSkFWQVNDUklQVF9QUk9GSUxJ TkdfRU5BQkxFRDoKKyNpZiBFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dFUikKICAgICAgICAgZ192 YWx1ZV9zZXRfYm9vbGVhbih2YWx1ZSwgcHJpdi0+cGFnZS0+aW5zcGVjdG9yQ29udHJvbGxlcigp LT5wcm9maWxlckVuYWJsZWQoKSk7CisjZWxzZQorICAgICAgICBnX21lc3NhZ2UoIlBST1BfSkFW QVNDUklQVF9QUk9GSUxJTkdfRU5BQkxFRCBpcyBub3Qgd29yayBiZWNhdXNlIG9mIHRoZSBqYXZh c2NyaXB0IGRlYnVnZ2VyIGlzIGRpc2FibGVkXG4iKTsKKyNlbmRpZgogICAgICAgICBicmVhazsK ICAgICBjYXNlIFBST1BfVElNRUxJTkVfUFJPRklMSU5HX0VOQUJMRUQ6CiAgICAgICAgIGdfdmFs dWVfc2V0X2Jvb2xlYW4odmFsdWUsIHByaXYtPnBhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIoKS0+ dGltZWxpbmVBZ2VudCgpICE9IDApOwo= 44345 2009-12-04 19:04:22 -0800 2009-12-04 23:06:35 -0800 patch for the build error when JAVASCRIPT_DEBUGGER is disabled on gtk-2 javascript-debugger.patch text/plain 3122 gyuyoung ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NGJmN2Y1OC4uZTc3YjI1OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0xMi0wNCAgR3l1eW91bmcgS2lt ICA8Z3l1eW91bmdAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVs LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjAy NAorICAgICAgICBbR1RLXSBXZWJLaXQgZG9lcyBub3QgY29tcGlsZSB3aXRob3V0IEpBVkFTQ1JJ UFRfREVCVUdHRVIKKworCisgICAgICAgIEZpeCBidWlsZCBlcnJvcnMgd2hlbiBqYXZhc2NyaXB0 LWRlYnVnZ2VyIGlzIGRpc2FibGVkIG9uIEdUSworCisgICAgICAgICogR05VbWFrZWZpbGUuYW06 CisKIDIwMDktMTItMDQgIEFkYW0gTGFuZ2xleSAgPGFnbEBnb29nbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9HTlVtYWtlZmls ZS5hbSBiL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0KaW5kZXggMmQ4ZWIyZi4uOGE2YTI5MCAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQorKysgYi9XZWJDb3JlL0dOVW1ha2VmaWxl LmFtCkBAIC0yMTEyLDYgKzIxMTIsMTAgQEAgRkVBVFVSRV9ERUZJTkVTX0pBVkFTQ1JJUFQgKz0g RU5BQkxFX0pBVkFTQ1JJUFRfREVCVUdHRVI9MQogd2ViY29yZV9jcHBmbGFncyArPSBcCiAJLURF TkFCTEVfSkFWQVNDUklQVF9ERUJVR0dFUj0xCiAKK2Vsc2UKK3dlYmNvcmVfY3BwZmxhZ3MgKz0g XAorCS1ERU5BQkxFX0pBVkFTQ1JJUFRfREVCVUdHRVI9MAorCiBlbmRpZiAjIEVORCBFTkFCTEVf SkFWQVNDUklQVF9ERUJVR0dFUgogCiAjIC0tLS0KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hh bmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggYzBjNDJkNC4uYWEzMzkwYSAxMDA2 NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMi0wNCAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmdAZ21h aWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjAyNAorICAgICAgICBbR1RL XSBXZWJLaXQgZG9lcyBub3QgY29tcGlsZSB3aXRob3V0IEpBVkFTQ1JJUFRfREVCVUdHRVIKKwor ICAgICAgICBGaXggYnVpbGQgZXJyb3JzIHdoZW4gamF2YXNjcmlwdC1kZWJ1Z2dlciBpcyBkaXNh YmxlZCBvbiBHVEsKKworICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJpbnNwZWN0b3IuY3BwOgor ICAgICAgICAod2Via2l0X3dlYl9pbnNwZWN0b3Jfc2V0X3Byb3BlcnR5KToKKyAgICAgICAgKHdl YmtpdF93ZWJfaW5zcGVjdG9yX2dldF9wcm9wZXJ0eSk6CisKIDIwMDktMTItMDMgIEJyYWR5IEVp ZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWlu aWcuCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJpbnNwZWN0b3IuY3Bw IGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViaW5zcGVjdG9yLmNwcAppbmRleCA2OGIwM2Iy Li4yZmViMDY0IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJpbnNwZWN0 b3IuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmluc3BlY3Rvci5jcHAKQEAg LTM0NiwxMiArMzQ2LDE2IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfaW5zcGVjdG9yX3NldF9w cm9wZXJ0eShHT2JqZWN0KiBvYmplY3QsIGd1aW50IHByb3BfaWQsIGNvCiAKICAgICBzd2l0Y2go cHJvcF9pZCkgewogICAgIGNhc2UgUFJPUF9KQVZBU0NSSVBUX1BST0ZJTElOR19FTkFCTEVEOiB7 CisjaWYgRU5BQkxFKEpBVkFTQ1JJUFRfREVCVUdHRVIpCiAgICAgICAgIGJvb2wgZW5hYmxlZCA9 IGdfdmFsdWVfZ2V0X2Jvb2xlYW4odmFsdWUpOwogICAgICAgICBXZWJDb3JlOjpJbnNwZWN0b3JD b250cm9sbGVyKiBjb250cm9sbGVyID0gcHJpdi0+cGFnZS0+aW5zcGVjdG9yQ29udHJvbGxlcigp OwogICAgICAgICBpZiAoZW5hYmxlZCkKICAgICAgICAgICAgIGNvbnRyb2xsZXItPmVuYWJsZVBy b2ZpbGVyKCk7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIGNvbnRyb2xsZXItPmRpc2FibGVQ cm9maWxlcigpOworI2Vsc2UKKyAgICAgICAgZ19tZXNzYWdlKCJQUk9QX0pBVkFTQ1JJUFRfUFJP RklMSU5HX0VOQUJMRUQgaXMgbm90IHdvcmsgYmVjYXVzZSBvZiB0aGUgamF2YXNjcmlwdCBkZWJ1 Z2dlciBpcyBkaXNhYmxlZFxuIik7CisjZW5kaWYKICAgICAgICAgYnJlYWs7CiAgICAgfQogICAg IGNhc2UgUFJPUF9USU1FTElORV9QUk9GSUxJTkdfRU5BQkxFRDogewpAQCAtMzgyLDcgKzM4Niwx MSBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX2luc3BlY3Rvcl9nZXRfcHJvcGVydHkoR09iamVj dCogb2JqZWN0LCBndWludCBwcm9wX2lkLCBHVgogICAgICAgICBnX3ZhbHVlX3NldF9zdHJpbmco dmFsdWUsIHByaXYtPmluc3BlY3RlZF91cmkpOwogICAgICAgICBicmVhazsKICAgICBjYXNlIFBS T1BfSkFWQVNDUklQVF9QUk9GSUxJTkdfRU5BQkxFRDoKKyNpZiBFTkFCTEUoSkFWQVNDUklQVF9E RUJVR0dFUikKICAgICAgICAgZ192YWx1ZV9zZXRfYm9vbGVhbih2YWx1ZSwgcHJpdi0+cGFnZS0+ aW5zcGVjdG9yQ29udHJvbGxlcigpLT5wcm9maWxlckVuYWJsZWQoKSk7CisjZWxzZQorICAgICAg ICBnX21lc3NhZ2UoIlBST1BfSkFWQVNDUklQVF9QUk9GSUxJTkdfRU5BQkxFRCBpcyBub3Qgd29y ayBiZWNhdXNlIG9mIHRoZSBqYXZhc2NyaXB0IGRlYnVnZ2VyIGlzIGRpc2FibGVkXG4iKTsKKyNl bmRpZgogICAgICAgICBicmVhazsKICAgICBjYXNlIFBST1BfVElNRUxJTkVfUFJPRklMSU5HX0VO QUJMRUQ6CiAgICAgICAgIGdfdmFsdWVfc2V0X2Jvb2xlYW4odmFsdWUsIHByaXYtPnBhZ2UtPmlu c3BlY3RvckNvbnRyb2xsZXIoKS0+dGltZWxpbmVBZ2VudCgpICE9IDApOwo= 44348 2009-12-04 23:06:35 -0800 2009-12-07 11:22:57 -0800 patch for the build error when JAVASCRIPT_DEBUGGER is disabled on gtk-3 javascript-debugger-error.patch text/plain 3120 gyuyoung ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NGJmN2Y1OC4uZGZmNGExMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0xMi0wNCAgR3l1eW91bmcgS2lt ICA8Z3l1eW91bmdAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVs LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjAy NAorICAgICAgICBbR1RLXSBXZWJLaXQgZG9lcyBub3QgY29tcGlsZSB3aXRob3V0IEpBVkFTQ1JJ UFRfREVCVUdHRVIKKworICAgICAgICBGaXggYnVpbGQgZXJyb3JzIHdoZW4gamF2YXNjcmlwdC1k ZWJ1Z2dlciBpcyBkaXNhYmxlZCBvbiBHVEsKKworICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOgor CiAyMDA5LTEyLTA0ICBBZGFtIExhbmdsZXkgIDxhZ2xAZ29vZ2xlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvR05VbWFrZWZpbGUu YW0gYi9XZWJDb3JlL0dOVW1ha2VmaWxlLmFtCmluZGV4IDJkOGViMmYuLjhhNmEyOTAgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0KKysrIGIvV2ViQ29yZS9HTlVtYWtlZmlsZS5h bQpAQCAtMjExMiw2ICsyMTEyLDEwIEBAIEZFQVRVUkVfREVGSU5FU19KQVZBU0NSSVBUICs9IEVO QUJMRV9KQVZBU0NSSVBUX0RFQlVHR0VSPTEKIHdlYmNvcmVfY3BwZmxhZ3MgKz0gXAogCS1ERU5B QkxFX0pBVkFTQ1JJUFRfREVCVUdHRVI9MQogCitlbHNlCit3ZWJjb3JlX2NwcGZsYWdzICs9IFwK KwktREVOQUJMRV9KQVZBU0NSSVBUX0RFQlVHR0VSPTAKKwogZW5kaWYgIyBFTkQgRU5BQkxFX0pB VkFTQ1JJUFRfREVCVUdHRVIKIAogIyAtLS0tCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5n ZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IGMwYzQyZDQuLmFhMzM5MGEgMTAwNjQ0 Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTItMDQgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KKworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzIwMjQKKyAgICAgICAgW0dUS10g V2ViS2l0IGRvZXMgbm90IGNvbXBpbGUgd2l0aG91dCBKQVZBU0NSSVBUX0RFQlVHR0VSCisKKyAg ICAgICAgRml4IGJ1aWxkIGVycm9ycyB3aGVuIGphdmFzY3JpcHQtZGVidWdnZXIgaXMgZGlzYWJs ZWQgb24gR1RLCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2ViaW5zcGVjdG9yLmNwcDoKKyAg ICAgICAgKHdlYmtpdF93ZWJfaW5zcGVjdG9yX3NldF9wcm9wZXJ0eSk6CisgICAgICAgICh3ZWJr aXRfd2ViX2luc3BlY3Rvcl9nZXRfcHJvcGVydHkpOgorCiAyMDA5LTEyLTAzICBCcmFkeSBFaWRz b24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2Vpbmln LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViaW5zcGVjdG9yLmNwcCBi L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmluc3BlY3Rvci5jcHAKaW5kZXggNjhiMDNiMi4u MmZlYjA2NCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViaW5zcGVjdG9y LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJpbnNwZWN0b3IuY3BwCkBAIC0z NDYsMTIgKzM0NiwxNiBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX2luc3BlY3Rvcl9zZXRfcHJv cGVydHkoR09iamVjdCogb2JqZWN0LCBndWludCBwcm9wX2lkLCBjbwogCiAgICAgc3dpdGNoKHBy b3BfaWQpIHsKICAgICBjYXNlIFBST1BfSkFWQVNDUklQVF9QUk9GSUxJTkdfRU5BQkxFRDogewor I2lmIEVOQUJMRShKQVZBU0NSSVBUX0RFQlVHR0VSKQogICAgICAgICBib29sIGVuYWJsZWQgPSBn X3ZhbHVlX2dldF9ib29sZWFuKHZhbHVlKTsKICAgICAgICAgV2ViQ29yZTo6SW5zcGVjdG9yQ29u dHJvbGxlciogY29udHJvbGxlciA9IHByaXYtPnBhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIoKTsK ICAgICAgICAgaWYgKGVuYWJsZWQpCiAgICAgICAgICAgICBjb250cm9sbGVyLT5lbmFibGVQcm9m aWxlcigpOwogICAgICAgICBlbHNlCiAgICAgICAgICAgICBjb250cm9sbGVyLT5kaXNhYmxlUHJv ZmlsZXIoKTsKKyNlbHNlCisgICAgICAgIGdfbWVzc2FnZSgiUFJPUF9KQVZBU0NSSVBUX1BST0ZJ TElOR19FTkFCTEVEIGlzIG5vdCB3b3JrIGJlY2F1c2Ugb2YgdGhlIGphdmFzY3JpcHQgZGVidWdn ZXIgaXMgZGlzYWJsZWRcbiIpOworI2VuZGlmCiAgICAgICAgIGJyZWFrOwogICAgIH0KICAgICBj YXNlIFBST1BfVElNRUxJTkVfUFJPRklMSU5HX0VOQUJMRUQ6IHsKQEAgLTM4Miw3ICszODYsMTEg QEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl9pbnNwZWN0b3JfZ2V0X3Byb3BlcnR5KEdPYmplY3Qq IG9iamVjdCwgZ3VpbnQgcHJvcF9pZCwgR1YKICAgICAgICAgZ192YWx1ZV9zZXRfc3RyaW5nKHZh bHVlLCBwcml2LT5pbnNwZWN0ZWRfdXJpKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBQUk9Q X0pBVkFTQ1JJUFRfUFJPRklMSU5HX0VOQUJMRUQ6CisjaWYgRU5BQkxFKEpBVkFTQ1JJUFRfREVC VUdHRVIpCiAgICAgICAgIGdfdmFsdWVfc2V0X2Jvb2xlYW4odmFsdWUsIHByaXYtPnBhZ2UtPmlu c3BlY3RvckNvbnRyb2xsZXIoKS0+cHJvZmlsZXJFbmFibGVkKCkpOworI2Vsc2UKKyAgICAgICAg Z19tZXNzYWdlKCJQUk9QX0pBVkFTQ1JJUFRfUFJPRklMSU5HX0VOQUJMRUQgaXMgbm90IHdvcmsg YmVjYXVzZSBvZiB0aGUgamF2YXNjcmlwdCBkZWJ1Z2dlciBpcyBkaXNhYmxlZFxuIik7CisjZW5k aWYKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBQUk9QX1RJTUVMSU5FX1BST0ZJTElOR19FTkFC TEVEOgogICAgICAgICBnX3ZhbHVlX3NldF9ib29sZWFuKHZhbHVlLCBwcml2LT5wYWdlLT5pbnNw ZWN0b3JDb250cm9sbGVyKCktPnRpbWVsaW5lQWdlbnQoKSAhPSAwKTsK