32017 2009-12-01 04:36:51 -0800 [V8] Don't crash in DOMWindow event getter in OOM situations 2009-12-01 07:45:36 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ager webkit-unassigned abarth commit-queue dglazkov webkit.review.bot oldest_to_newest 167569 0 ager 2009-12-01 04:36:51 -0800 There are missing null checks in the DOMWindow event property getter and setter. V8Proxy::context(frame) can return a null handle in OOM situations either if failing to initialize a context or if an OOM is handled gracefully and javascript is disabled. 167570 1 44068 ager 2009-12-01 04:45:14 -0800 Created attachment 44068 Add missing null checks. 167571 2 webkit.review.bot 2009-12-01 04:48:35 -0800 style-queue ran check-webkit-style on attachment 44068 without any errors. 167595 3 44068 eric 2009-12-01 07:22:58 -0800 Comment on attachment 44068 Add missing null checks. This makes me wonder about all the other calls to "V8Proxy::context(frame)". It would be nice if there was some way to restrict the heap size for v8 artificially so as to fake OOM bugs, but I can see how this would be difficult to test. 167603 4 44068 commit-queue 2009-12-01 07:45:31 -0800 Comment on attachment 44068 Add missing null checks. Clearing flags on attachment: 44068 Committed r51536: <http://trac.webkit.org/changeset/51536> 167604 5 commit-queue 2009-12-01 07:45:36 -0800 All reviewed patches have been landed. Closing bug. 44068 2009-12-01 04:45:14 -0800 2009-12-01 07:45:30 -0800 Add missing null checks. 32017.txt text/plain 2012 ager SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTUzMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMDktMTItMDEgIE1hZHMgQWdlciAgPGFnZXJAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtWOF0g RG9uJ3QgY3Jhc2ggaW4gRE9NV2luZG93IGV2ZW50IGdldHRlciBpbiBPT00gc2l0dWF0aW9ucwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzIwMTcKKwor ICAgICAgICBBZGQgbWlzc2luZyBudWxsIGhhbmRsZSBjaGVja3MgaW4gRE9NV2luZG93IGV2ZW50 IHByb3BlcnR5CisgICAgICAgIGFjY2Vzc29ycy4gIFY4UHJveHk6OmNvbnRleHQoZnJhbWUpIGNh biByZXR1cm4gYSBudWxsIGhhbmRsZSBpbgorICAgICAgICBPT00gc2l0dWF0aW9ucyBlaXRoZXIg aWYgZmFpbGluZyB0byBpbml0aWFsaXplIGEgY29udGV4dCBvciBpZiBhbgorICAgICAgICBPT00g aXMgaGFuZGxlZCBncmFjZWZ1bGx5IGFuZCBqYXZhc2NyaXB0IGlzIGRpc2FibGVkLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHdlIGRvbid0IGhhdmUgYSBnb29kIHdheSB0byB0ZXN0 CisgICAgICAgIG91dC1vZi1tZW1vcnkgYnVncy4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1 c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBQ0NFU1NPUl9H RVRURVIpOgorICAgICAgICAoV2ViQ29yZTo6QUNDRVNTT1JfU0VUVEVSKToKKwogMjAwOS0xMi0w MSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBOb3Qg cmV2aWV3ZWQ6IGZpeCB3aW5kb3dzIGJ1aWxkIHZpYSB1bmV4Y2x1ZGluZyBnZW5lcmF0ZWQgZmls ZXMgZnJvbQpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhET01XaW5kb3dDdXN0 b20uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2lu ZG93Q3VzdG9tLmNwcAkocmV2aXNpb24gNTE1MzMpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1 c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3NSw2ICsxNzUs OSBAQCBBQ0NFU1NPUl9HRVRURVIoRE9NV2luZG93RXZlbnQpCiAgICAgICAgIHJldHVybiB2ODo6 VW5kZWZpbmVkKCk7CiAKICAgICB2ODo6TG9jYWw8djg6OkNvbnRleHQ+IGNvbnRleHQgPSBWOFBy b3h5Ojpjb250ZXh0KGZyYW1lKTsKKyAgICBpZiAoY29udGV4dC5Jc0VtcHR5KCkpCisgICAgICAg IHJldHVybiB2ODo6VW5kZWZpbmVkKCk7CisKICAgICB2ODo6TG9jYWw8djg6OlN0cmluZz4gZXZl bnRTeW1ib2wgPSB2ODo6U3RyaW5nOjpOZXdTeW1ib2woImV2ZW50Iik7CiAgICAgdjg6OkhhbmRs ZTx2ODo6VmFsdWU+IGpzRXZlbnQgPSBjb250ZXh0LT5HbG9iYWwoKS0+R2V0SGlkZGVuVmFsdWUo ZXZlbnRTeW1ib2wpOwogICAgIGlmIChqc0V2ZW50LklzRW1wdHkoKSkKQEAgLTE5Myw2ICsxOTYs OSBAQCBBQ0NFU1NPUl9TRVRURVIoRE9NV2luZG93RXZlbnQpCiAgICAgICAgIHJldHVybjsKIAog ICAgIHY4OjpMb2NhbDx2ODo6Q29udGV4dD4gY29udGV4dCA9IFY4UHJveHk6OmNvbnRleHQoZnJh bWUpOworICAgIGlmIChjb250ZXh0LklzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAg djg6OkxvY2FsPHY4OjpTdHJpbmc+IGV2ZW50U3ltYm9sID0gdjg6OlN0cmluZzo6TmV3U3ltYm9s KCJldmVudCIpOwogICAgIGNvbnRleHQtPkdsb2JhbCgpLT5TZXRIaWRkZW5WYWx1ZShldmVudFN5 bWJvbCwgdmFsdWUpOwogfQo=