32015 2009-12-01 03:27:14 -0800 Update expectations of css2.1/t1205-c56* for Qt 2009-12-01 22:32:57 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 hamaji webkit-unassigned hyatt webkit.review.bot oldest_to_newest 167561 0 hamaji 2009-12-01 03:27:14 -0800 I've marked some tests as skipped for Qt in Bug 23264. Update the expectations of some of them. Note that other tests will be fixed in Bug 32014 by converting the tests into dumpAsText tests. 167563 1 44065 hamaji 2009-12-01 03:28:37 -0800 Created attachment 44065 Patch v1 167564 2 webkit.review.bot 2009-12-01 03:31:28 -0800 style-queue ran check-webkit-style on attachment 44065 without any errors. 167594 3 44065 eric 2009-12-01 07:20:25 -0800 Comment on attachment 44065 Patch v1 OK. Looks sane to me. 167873 4 hamaji 2009-12-01 21:50:21 -0800 Committed r51586: <http://trac.webkit.org/changeset/51586> 167881 5 hamaji 2009-12-01 22:32:06 -0800 CCing original authors of these tests. Darin, I understand your concern. I confirmed that these tests fail if I reverse-patch the following fixes. Of course, I know this fact doesn't show I didn't lose any information from the original test, though. Please let me know if there are some more information I can tell. Or, if you feel you'd never be confident, please let me know and I'll just update the expectations of these tests. https://bugs.webkit.org/show_bug.cgi?id=13887 https://bugs.webkit.org/show_bug.cgi?id=12746 167882 6 hamaji 2009-12-01 22:32:57 -0800 Oops, I posted the comment on wrong bug... Please just ignore. 44065 2009-12-01 03:28:37 -0800 2009-12-01 07:20:25 -0800 Patch v1 bug-32015-20091201202835.patch text/plain 4998 hamaji ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyMWE1ZmIyLi4zMGU1ZmVkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTIt MDEgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgZXhwZWN0YXRpb25z IG9mIGNzczIuMS90MTIwNS1jNTYqIGZvciBRdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzIwMTUKKworICAgICAgICAqIHBsYXRmb3JtL3F0L1NraXBw ZWQ6CisgICAgICAgICogcGxhdGZvcm0vcXQvY3NzMi4xL3QxMjA1LWM1NjEtbGlzdC1kaXNwbC0w MC1iLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9jc3MyLjEvdDEyMDUtYzU2 NS1saXN0LXBvcy0wMC1iLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9jc3My LjEvdDEyMDUtYzU2Ni1saXN0LXN0bC0wMC1lLWFnLWV4cGVjdGVkLnR4dDoKKwogMjAwOS0xMS0z MCAgU2hpbmljaGlybyBIYW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAppbmRleCA0ZDE0 YmJmLi4zYTY1NmJmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVk CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKQEAgLTUyNjEsMTAgKzUyNjEs NSBAQCB0cmFuc2l0aW9ucy90cmFuc2l0aW9uLWVuZC1ldmVudC1yZW5kZXJpbmcuaHRtbAogIyBo YW1hamkgd2lsbCBsb29rIGludG8gdGhpcy4KIGVkaXRpbmcvc2VsZWN0aW9uL2xhc3QtZW1wdHkt aW5saW5lLmh0bWwKIAotIyBOZWVkIHRvIHVwZGF0ZSB0aGUgZXhwZWN0YXRpb25zLgotIyBTZWU6 IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzI2NAotY3NzMi4xL3Qx MjA1LWM1NjEtbGlzdC1kaXNwbC0wMC1iLmh0bWwKLWNzczIuMS90MTIwNS1jNTY1LWxpc3QtcG9z LTAwLWIuaHRtbAotY3NzMi4xL3QxMjA1LWM1NjYtbGlzdC1zdGwtMDAtZS1hZy5odG1sCiBmYXN0 L2Jsb2NrL3Bvc2l0aW9uaW5nL2NvbXBsZXgtcGVyY2VudGFnZS1oZWlnaHQuaHRtbAogZmFzdC9s aXN0cy9pdGVtLW5vdC1pbi1saXN0LWxpbmUtd3JhcHBpbmcuaHRtbApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vcXQvY3NzMi4xL3QxMjA1LWM1NjEtbGlzdC1kaXNwbC0wMC1iLWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L2NzczIuMS90MTIwNS1jNTYxLWxp c3QtZGlzcGwtMDAtYi1leHBlY3RlZC50eHQKaW5kZXggYmQ2YjlhMi4uZjdlZGYyMCAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvY3NzMi4xL3QxMjA1LWM1NjEtbGlzdC1kaXNw bC0wMC1iLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9jc3MyLjEv dDEyMDUtYzU2MS1saXN0LWRpc3BsLTAwLWItZXhwZWN0ZWQudHh0CkBAIC05LDggKzksOCBAQCBs YXllciBhdCAoMCwwKSBzaXplIDgwMHgyNDAKICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwyMCkg d2lkdGggODI6ICJkZXNjcmlwdGlvbi4iCiAgICAgICBSZW5kZXJMaXN0SXRlbSB7RElWfSBhdCAo MCw1Nikgc2l6ZSA3ODR4MjAgW2NvbG9yPSMwMDAwODBdCiAgICAgICAgIFJlbmRlckxpc3RNYXJr ZXIgYXQgKDAsMCkgc2l6ZSAxN3gyMDogIjEiCi0gICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBh dCAoMTcsMCkgc2l6ZSAxNzR4MjAKLSAgICAgICAgICB0ZXh0IHJ1biBhdCAoMTcsMCkgd2lkdGgg MTc0OiAiIFRoaXMgc2hvdWxkIGJlIGxpbmUgb25lLiIKKyAgICAgICAgUmVuZGVyVGV4dCB7I3Rl eHR9IGF0ICgxNywwKSBzaXplIDE3MHgyMAorICAgICAgICAgIHRleHQgcnVuIGF0ICgxNywwKSB3 aWR0aCAxNzA6ICJUaGlzIHNob3VsZCBiZSBsaW5lIG9uZS4iCiAgICAgICBSZW5kZXJCbG9jayB7 RElWfSBhdCAoMCw3Nikgc2l6ZSA3ODR4MjAgW2NvbG9yPSMwMDAwODBdCiAgICAgICAgIFJlbmRl clRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDE4NXgyMAogICAgICAgICAgIHRleHQgcnVuIGF0 ICgwLDApIHdpZHRoIDE4NTogIjIuIFRoaXMgc2hvdWxkIGJlIGxpbmUgdHdvLiIKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L2NzczIuMS90MTIwNS1jNTY1LWxpc3QtcG9zLTAw LWItZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvY3NzMi4xL3QxMjA1LWM1 NjUtbGlzdC1wb3MtMDAtYi1leHBlY3RlZC50eHQKaW5kZXggNDNjZjliZi4uYTA1Yjc3MiAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvY3NzMi4xL3QxMjA1LWM1NjUtbGlzdC1w b3MtMDAtYi1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvY3NzMi4x L3QxMjA1LWM1NjUtbGlzdC1wb3MtMDAtYi1leHBlY3RlZC50eHQKQEAgLTE3LDYgKzE3LDYgQEAg bGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4MTAxCiAgICAgICBSZW5kZXJCbG9jayB7T0x9IGF0ICg4 MCw1Nykgc2l6ZSAxNjB4MjAgW2NvbG9yPSMwMDAwODBdIFtiZ2NvbG9yPSMwMDAwODBdCiAgICAg ICAgIFJlbmRlckxpc3RJdGVtIHtMSX0gYXQgKDAsMCkgc2l6ZSAxNjB4MjAKICAgICAgICAgICBS ZW5kZXJMaXN0TWFya2VyIGF0ICgwLDApIHNpemUgMTd4MjA6ICIxIgotICAgICAgICAgIFJlbmRl cklubGluZSB7U1BBTn0gYXQgKDAsMCkgc2l6ZSAzNXgyMCBbY29sb3I9I0ZGRkZGRl0KLSAgICAg ICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMTcsMCkgc2l6ZSAzNXgyMAotICAgICAgICAg ICAgICB0ZXh0IHJ1biBhdCAoMTcsMCkgd2lkdGggMzU6ICIgVGVzdCIKKyAgICAgICAgICBSZW5k ZXJJbmxpbmUge1NQQU59IGF0ICgwLDApIHNpemUgMzF4MjAgW2NvbG9yPSNGRkZGRkZdCisgICAg ICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDE3LDApIHNpemUgMzF4MjAKKyAgICAgICAg ICAgICAgdGV4dCBydW4gYXQgKDE3LDApIHdpZHRoIDMxOiAiVGVzdCIKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL3F0L2NzczIuMS90MTIwNS1jNTY2LWxpc3Qtc3RsLTAwLWUtYWct ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvY3NzMi4xL3QxMjA1LWM1NjYt bGlzdC1zdGwtMDAtZS1hZy1leHBlY3RlZC50eHQKaW5kZXggYzlhNzYyMC4uOWY5NzJhYiAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvY3NzMi4xL3QxMjA1LWM1NjYtbGlzdC1z dGwtMDAtZS1hZy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvY3Nz Mi4xL3QxMjA1LWM1NjYtbGlzdC1zdGwtMDAtZS1hZy1leHBlY3RlZC50eHQKQEAgLTEsMTUgKzEs MTUgQEAKIGxheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAogICBSZW5kZXJWaWV3IGF0ICgwLDAp IHNpemUgODAweDYwMAotbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4MTE0Ci0gIFJlbmRlckJsb2Nr IHtIVE1MfSBhdCAoMCwwKSBzaXplIDgwMHgxMTQKLSAgICBSZW5kZXJCb2R5IHtCT0RZfSBhdCAo OCwxNCkgc2l6ZSA3ODR4ODUKLSAgICAgIFJlbmRlckJsb2NrIHtQfSBhdCAoMCwwKSBzaXplIDc4 NHgxOQotICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAxOTR4MTkKLSAg ICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCAxOTQ6ICJUaGVyZSBzaG91bGQgYmUgbm8g cmVkIGJlbG93LiIKLSAgICAgIFJlbmRlckJsb2NrIHtVTH0gYXQgKDc1LDM0KSBzaXplIDk2eDUx IFtjb2xvcj0jMDBGRjAwXSBbYmdjb2xvcj0jRkYwMDAwXSBbYm9yZGVyOiAoM3B4IHNvbGlkICMw MDAwMDApXQorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4MTE4CisgIFJlbmRlckJsb2NrIHtIVE1M fSBhdCAoMCwwKSBzaXplIDgwMHgxMTgKKyAgICBSZW5kZXJCb2R5IHtCT0RZfSBhdCAoOCwxNikg c2l6ZSA3ODR4ODcKKyAgICAgIFJlbmRlckJsb2NrIHtQfSBhdCAoMCwwKSBzaXplIDc4NHgyMAor ICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAyMTZ4MjAKKyAgICAgICAg ICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCAyMTY6ICJUaGVyZSBzaG91bGQgYmUgbm8gcmVkIGJl bG93LiIKKyAgICAgIFJlbmRlckJsb2NrIHtVTH0gYXQgKDc1LDM2KSBzaXplIDk2eDUxIFtjb2xv cj0jMDBGRjAwXSBbYmdjb2xvcj0jRkYwMDAwXSBbYm9yZGVyOiAoM3B4IHNvbGlkICMwMDAwMDAp XQogICAgICAgICBSZW5kZXJMaXN0SXRlbSB7TEl9IGF0ICgzLDMpIHNpemUgOTB4NDUKLSAgICAg ICAgICBSZW5kZXJMaXN0TWFya2VyIGF0ICgwLDApIHNpemUgNDV4MTY6ICJBIgotICAgICAgICAg IFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoNDUsMCkgc2l6ZSA5MHg0NgotICAgICAgICAgICAgdGV4 dCBydW4gYXQgKDQ1LDApIHdpZHRoIDMwOiAiIHgiCi0gICAgICAgICAgICB0ZXh0IHJ1biBhdCAo MCwxNSkgd2lkdGggNjA6ICJ4IHh4IgotICAgICAgICAgICAgdGV4dCBydW4gYXQgKDAsMzApIHdp ZHRoIDkwOiAieHggeCB4IgorICAgICAgICAgIFJlbmRlckxpc3RNYXJrZXIgYXQgKDAsMCkgc2l6 ZSA0NXgxNDogIkEiCisgICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICg0NSwwKSBzaXpl IDkweDQ0CisgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoNDUsMCkgd2lkdGggNDU6ICJ4IHgiCisg ICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwxNSkgd2lkdGggNzU6ICJ4eCB4eCIKKyAgICAgICAg ICAgIHRleHQgcnVuIGF0ICgwLDMwKSB3aWR0aCA0NTogInggeCIK