32008 2009-11-30 22:20:09 -0800 [Chromium] Keyboard shortcut in dropdown not working. 2009-12-22 19:59:41 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 suzhe webkit-unassigned commit-queue evan fishd hbono webkit.review.bot oldest_to_newest 167508 0 suzhe 2009-11-30 22:20:09 -0800 See chromium issue: http://crbug.com/28776: Chrome Version : 4.0.257.0~svn20091124r32926-0ubuntu1~ucd1 OS + version : Ubuntu 9.10 CPU architecture (32-bit / 64-bit): 32-bit window manager : Gnome URLs (if applicable) : http://www.xe.com/ Behavior in Firefox 3.x (if applicable): OK Behavior in Chrome for Windows (optional): OK What steps will reproduce the problem? 1. Enter http://www.xe.com/ 2. Click on the dropdown to select currency 3. Type the first letter of a currency, for example E (for EUR) What is the expected result? EUR should be selected. What happens instead? Nothing. The only way to change the dropdown with the keyboard is using the arrows. 167512 1 44055 suzhe 2009-11-30 22:34:12 -0800 Created attachment 44055 Patch to fix this issue. 167513 2 webkit.review.bot 2009-11-30 22:38:44 -0800 style-queue ran check-webkit-style on attachment 44055 without any errors. 167520 3 evan 2009-11-30 23:22:50 -0800 [I am not a WebKit reviewer.] This seems fine to me. Is there a way to test this? Can you make the description of what you're fixing more specific in the ChangeLog? (For someone who doesn't know what "keyboard shortcut" means -- I think you mean that pressing a key currently doesn't select the entry starting with that letter?) 167530 4 44058 suzhe 2009-11-30 23:49:51 -0800 Created attachment 44058 Patch to fix this issue. 167531 5 webkit.review.bot 2009-11-30 23:52:41 -0800 style-queue ran check-webkit-style on attachment 44058 without any errors. 167532 6 suzhe 2009-11-30 23:54:01 -0800 I updated the ChangeLog a little. The "keyboard shortcut" is actually not accurate. This issue is about the "type ahead find" feature of the popup listbox, or so called prefix search: you can type in a popup listbox to search the items by prefix. It works on Chromium windows port. The attached patch fixes the Linux and Mac ports. 167544 7 hbono 2009-12-01 01:49:14 -0800 (In reply to comment #3) > [I am not a WebKit reviewer.] This seems fine to me. > > Is there a way to test this? If I recall correctly, we need to change eventSender (and some other code) to write a layout test for this issue so PopupMenu can receive keyboard events sent from eventSender. Even though I have been writing a change to dispatch keyboard events from eventSender to PopupMenu, it is not a high priority issue. (This is the reason why I have not sent any fixes for this issue.) So, I wish James also changes eventSender and adds layout tests. Regards, 167545 8 suzhe 2009-12-01 02:05:29 -0800 (In reply to comment #7) > (In reply to comment #3) > > [I am not a WebKit reviewer.] This seems fine to me. > > > > Is there a way to test this? > > If I recall correctly, we need to change eventSender (and some other code) to > write a layout test for this issue so PopupMenu can receive keyboard events > sent from eventSender. Even though I have been writing a change to dispatch > keyboard events from eventSender to PopupMenu, it is not a high priority issue. > (This is the reason why I have not sent any fixes for this issue.) So, I wish > James also changes eventSender and adds layout tests. > > Regards, I'm not familiar with this part. I'd very appreciate if you could help on it. 167554 9 44063 suzhe 2009-12-01 03:10:28 -0800 Created attachment 44063 Patch to fix this issue. Merged the case-sensitive type ahead find fix from WebCore/dom/SelectElement.cpp. See https://bugs.webkit.org/show_bug.cgi?id=29103. 167556 10 webkit.review.bot 2009-12-01 03:15:40 -0800 style-queue ran check-webkit-style on attachment 44063 without any errors. 174513 11 44063 fishd 2009-12-22 19:50:50 -0800 Comment on attachment 44063 Patch to fix this issue. r=me, but given this and other recent bug fixes in the popup menu code, I think it would be great to invest time in enabling layout tests for this code. 174516 12 44063 commit-queue 2009-12-22 19:59:32 -0800 Comment on attachment 44063 Patch to fix this issue. Clearing flags on attachment: 44063 Committed r52519: <http://trac.webkit.org/changeset/52519> 174517 13 commit-queue 2009-12-22 19:59:41 -0800 All reviewed patches have been landed. Closing bug. 44055 2009-11-30 22:34:12 -0800 2009-11-30 23:49:51 -0800 Patch to fix this issue. bug-32008.patch text/plain 1897 suzhe SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTUyNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMzAgIEphbWVzIFN1ICA8c3V6aGVAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJv bWl1bV0gS2V5Ym9hcmQgc2hvcnRjdXQgaW4gZHJvcGRvd24gbm90IHdvcmtpbmcuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjAwOAorCisgICAgICAg IENvbnNpZGVyIFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6Q2hhciB0eXBlIGV2ZW50IGFzIGNoYXJh Y3RlciB0eXBlCisgICAgICAgIGV2ZW50IG9uIGFsbCBwbGF0Zm9ybXMuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3Jl Ojppc0NoYXJhY3RlclR5cGVFdmVudCk6CisKIDIwMDktMTEtMzAgIEZ1bWl0b3NoaSBVa2FpICA8 dWthaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBDaHJvbWl1bSBidWlsZCBm aXggaW50cm9kdWNlZCBieSByNTEyMTIKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0v UG9wdXBNZW51Q2hyb21pdW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vY2hy b21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCShyZXZpc2lvbiA1MTUyNCkKKysrIFdlYkNvcmUv cGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBA IC02MTAsMTcgKzYxMCwxMCBAQCBib29sIFBvcHVwTGlzdEJveDo6aXNJbnRlcmVzdGVkSW5FdmVu dEZvCiBzdGF0aWMgYm9vbCBpc0NoYXJhY3RlclR5cGVFdmVudChjb25zdCBQbGF0Zm9ybUtleWJv YXJkRXZlbnQmIGV2ZW50KQogewogICAgIC8vIENoZWNrIHdoZXRoZXIgdGhlIGV2ZW50IGlzIGEg Y2hhcmFjdGVyLXR5cGVkIGV2ZW50IG9yIG5vdC4KLSAgICAvLyBJbiBXaW5kb3dzLCBQbGF0Zm9y bUtleWJvYXJkRXZlbnQ6OkNoYXIgKG5vdCBSYXdLZXlEb3duKSB0eXBlIGV2ZW50Ci0gICAgLy8g aXMgY29uc2lkZXJlZCBhcyBjaGFyYWN0ZXIgdHlwZSBldmVudC4gSW4gTWFjIE9TLCBLZXlEb3du IChub3QKLSAgICAvLyBLZXlVcCkgaXMgY29uc2lkZXJlZCBhcyBjaGFyYWN0ZXIgdHlwZSBldmVu dC4KLSNpZiBQTEFURk9STShXSU5fT1MpCi0gICAgaWYgKGV2ZW50LnR5cGUoKSA9PSBQbGF0Zm9y bUtleWJvYXJkRXZlbnQ6OkNoYXIpCi0gICAgICAgIHJldHVybiB0cnVlOwotI2Vsc2UKLSAgICBp ZiAoZXZlbnQudHlwZSgpID09IFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6S2V5RG93bikKLSAgICAg ICAgcmV0dXJuIHRydWU7Ci0jZW5kaWYKLSAgICByZXR1cm4gZmFsc2U7CisgICAgLy8gV2UgdXNl IFJhd0tleURvd24vQ2hhci9LZXlVcCBldmVudCBzY2hlbWUgb24gYWxsIHBsYXRmb3JtcywKKyAg ICAvLyBzbyBQbGF0Zm9ybUtleWJvYXJkRXZlbnQ6OkNoYXIgKG5vdCBSYXdLZXlEb3duKSB0eXBl IGV2ZW50CisgICAgLy8gaXMgY29uc2lkZXJlZCBhcyBjaGFyYWN0ZXIgdHlwZSBldmVudC4KKyAg ICByZXR1cm4gZXZlbnQudHlwZSgpID09IFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6Q2hhcjsKIH0K IAogYm9vbCBQb3B1cExpc3RCb3g6OmhhbmRsZUtleUV2ZW50KGNvbnN0IFBsYXRmb3JtS2V5Ym9h cmRFdmVudCYgZXZlbnQpCg== 44058 2009-11-30 23:49:51 -0800 2009-12-01 03:11:41 -0800 Patch to fix this issue. bug-32008.patch text/plain 1994 suzhe SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTUyNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMTEtMzAgIEphbWVzIFN1ICA8c3V6aGVAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJv bWl1bV0gS2V5Ym9hcmQgc2hvcnRjdXQgaW4gZHJvcGRvd24gbm90IHdvcmtpbmcuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjAwOAorCisgICAgICAg IENvbnNpZGVyIFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6Q2hhciB0eXBlIGV2ZW50IGFzIGNoYXJh Y3RlciB0eXBlCisgICAgICAgIGV2ZW50IG9uIGFsbCBwbGF0Zm9ybXMuIEl0IGZpeGVzIHRoZSAi dHlwZSBhaGVhZCBmaW5kIiBmZWF0dXJlCisgICAgICAgIG9mIHRoZSBwb3B1cCBsaXN0Ym94IG9u IExpbnV4IGFuZCBNYWMgcGxhdGZvcm1zLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0v UG9wdXBNZW51Q2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6aXNDaGFyYWN0ZXJUeXBl RXZlbnQpOgorCiAyMDA5LTExLTMwICBGdW1pdG9zaGkgVWthaSAgPHVrYWlAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFVucmV2aWV3ZWQgQ2hyb21pdW0gYnVpbGQgZml4IGludHJvZHVjZWQgYnkg cjUxMjEyCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVt LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNo cm9taXVtLmNwcAkocmV2aXNpb24gNTE1MjQpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVt L1BvcHVwTWVudUNocm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjEwLDE3ICs2MTAsMTAg QEAgYm9vbCBQb3B1cExpc3RCb3g6OmlzSW50ZXJlc3RlZEluRXZlbnRGbwogc3RhdGljIGJvb2wg aXNDaGFyYWN0ZXJUeXBlRXZlbnQoY29uc3QgUGxhdGZvcm1LZXlib2FyZEV2ZW50JiBldmVudCkK IHsKICAgICAvLyBDaGVjayB3aGV0aGVyIHRoZSBldmVudCBpcyBhIGNoYXJhY3Rlci10eXBlZCBl dmVudCBvciBub3QuCi0gICAgLy8gSW4gV2luZG93cywgUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpD aGFyIChub3QgUmF3S2V5RG93bikgdHlwZSBldmVudAotICAgIC8vIGlzIGNvbnNpZGVyZWQgYXMg Y2hhcmFjdGVyIHR5cGUgZXZlbnQuIEluIE1hYyBPUywgS2V5RG93biAobm90Ci0gICAgLy8gS2V5 VXApIGlzIGNvbnNpZGVyZWQgYXMgY2hhcmFjdGVyIHR5cGUgZXZlbnQuCi0jaWYgUExBVEZPUk0o V0lOX09TKQotICAgIGlmIChldmVudC50eXBlKCkgPT0gUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpD aGFyKQotICAgICAgICByZXR1cm4gdHJ1ZTsKLSNlbHNlCi0gICAgaWYgKGV2ZW50LnR5cGUoKSA9 PSBQbGF0Zm9ybUtleWJvYXJkRXZlbnQ6OktleURvd24pCi0gICAgICAgIHJldHVybiB0cnVlOwot I2VuZGlmCi0gICAgcmV0dXJuIGZhbHNlOworICAgIC8vIFdlIHVzZSBSYXdLZXlEb3duL0NoYXIv S2V5VXAgZXZlbnQgc2NoZW1lIG9uIGFsbCBwbGF0Zm9ybXMsCisgICAgLy8gc28gUGxhdGZvcm1L ZXlib2FyZEV2ZW50OjpDaGFyIChub3QgUmF3S2V5RG93bikgdHlwZSBldmVudAorICAgIC8vIGlz IGNvbnNpZGVyZWQgYXMgY2hhcmFjdGVyIHR5cGUgZXZlbnQuCisgICAgcmV0dXJuIGV2ZW50LnR5 cGUoKSA9PSBQbGF0Zm9ybUtleWJvYXJkRXZlbnQ6OkNoYXI7CiB9CiAKIGJvb2wgUG9wdXBMaXN0 Qm94OjpoYW5kbGVLZXlFdmVudChjb25zdCBQbGF0Zm9ybUtleWJvYXJkRXZlbnQmIGV2ZW50KQo= 44063 2009-12-01 03:10:28 -0800 2009-12-22 19:59:32 -0800 Patch to fix this issue. bug-32008.patch text/plain 3099 suzhe SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTUyNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMDktMTEtMzAgIEphbWVzIFN1ICA8c3V6aGVAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJv bWl1bV0gS2V5Ym9hcmQgc2hvcnRjdXQgaW4gZHJvcGRvd24gbm90IHdvcmtpbmcuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjAwOAorCisgICAgICAg IENvbnNpZGVyIFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6Q2hhciB0eXBlIGV2ZW50IGFzIGNoYXJh Y3RlciB0eXBlCisgICAgICAgIGV2ZW50IG9uIGFsbCBwbGF0Zm9ybXMuIEl0IGZpeGVzIHRoZSAi dHlwZSBhaGVhZCBmaW5kIiBmZWF0dXJlCisgICAgICAgIG9mIHRoZSBwb3B1cCBsaXN0Ym94IG9u IExpbnV4IGFuZCBNYWMgcGxhdGZvcm1zLgorCisgICAgICAgIE1lcmdlIHRoZSBjYXNlLXNlbnNp dGl2ZSB0eXBlIGFoZWFkIGZpbmQgZml4IGZyb20KKyAgICAgICAgV2ViQ29yZS9kb20vU2VsZWN0 RWxlbWVudC5jcHAuIFNlZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjkxMDMKKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNo cm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmlzQ2hhcmFjdGVyVHlwZUV2ZW50KToKKwog MjAwOS0xMS0zMCAgRnVtaXRvc2hpIFVrYWkgIDx1a2FpQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBVbnJldmlld2VkIENocm9taXVtIGJ1aWxkIGZpeCBpbnRyb2R1Y2VkIGJ5IHI1MTIxMgpJbmRl eDogV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHAJ KHJldmlzaW9uIDUxNTI0KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVD aHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYxMCwxNyArNjEwLDEwIEBAIGJvb2wgUG9w dXBMaXN0Qm94Ojppc0ludGVyZXN0ZWRJbkV2ZW50Rm8KIHN0YXRpYyBib29sIGlzQ2hhcmFjdGVy VHlwZUV2ZW50KGNvbnN0IFBsYXRmb3JtS2V5Ym9hcmRFdmVudCYgZXZlbnQpCiB7CiAgICAgLy8g Q2hlY2sgd2hldGhlciB0aGUgZXZlbnQgaXMgYSBjaGFyYWN0ZXItdHlwZWQgZXZlbnQgb3Igbm90 LgotICAgIC8vIEluIFdpbmRvd3MsIFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6Q2hhciAobm90IFJh d0tleURvd24pIHR5cGUgZXZlbnQKLSAgICAvLyBpcyBjb25zaWRlcmVkIGFzIGNoYXJhY3RlciB0 eXBlIGV2ZW50LiBJbiBNYWMgT1MsIEtleURvd24gKG5vdAotICAgIC8vIEtleVVwKSBpcyBjb25z aWRlcmVkIGFzIGNoYXJhY3RlciB0eXBlIGV2ZW50LgotI2lmIFBMQVRGT1JNKFdJTl9PUykKLSAg ICBpZiAoZXZlbnQudHlwZSgpID09IFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6Q2hhcikKLSAgICAg ICAgcmV0dXJuIHRydWU7Ci0jZWxzZQotICAgIGlmIChldmVudC50eXBlKCkgPT0gUGxhdGZvcm1L ZXlib2FyZEV2ZW50OjpLZXlEb3duKQotICAgICAgICByZXR1cm4gdHJ1ZTsKLSNlbmRpZgotICAg IHJldHVybiBmYWxzZTsKKyAgICAvLyBXZSB1c2UgUmF3S2V5RG93bi9DaGFyL0tleVVwIGV2ZW50 IHNjaGVtZSBvbiBhbGwgcGxhdGZvcm1zLAorICAgIC8vIHNvIFBsYXRmb3JtS2V5Ym9hcmRFdmVu dDo6Q2hhciAobm90IFJhd0tleURvd24pIHR5cGUgZXZlbnQKKyAgICAvLyBpcyBjb25zaWRlcmVk IGFzIGNoYXJhY3RlciB0eXBlIGV2ZW50LgorICAgIHJldHVybiBldmVudC50eXBlKCkgPT0gUGxh dGZvcm1LZXlib2FyZEV2ZW50OjpDaGFyOwogfQogCiBib29sIFBvcHVwTGlzdEJveDo6aGFuZGxl S2V5RXZlbnQoY29uc3QgUGxhdGZvcm1LZXlib2FyZEV2ZW50JiBldmVudCkKQEAgLTc0NCwxMyAr NzM3LDE4IEBAIHZvaWQgUG9wdXBMaXN0Qm94Ojp0eXBlQWhlYWRGaW5kKGNvbnN0IFAKICAgICAg ICAgfQogICAgIH0KIAorICAgIC8vIENvbXB1dGUgYSBjYXNlLWZvbGRlZCBjb3B5IG9mIHRoZSBw cmVmaXggc3RyaW5nIGJlZm9yZSBiZWdpbm5pbmcgdGhlIHNlYXJjaCBmb3IKKyAgICAvLyBhIG1h dGNoaW5nIGVsZW1lbnQuIFRoaXMgY29kZSB1c2VzIGZvbGRDYXNlIHRvIHdvcmsgYXJvdW5kIHRo ZSBmYWN0IHRoYXQKKyAgICAvLyBTdHJpbmc6OnN0YXJ0V2l0aCBkb2VzIG5vdCBmb2xkIG5vbi1B U0NJSSBjaGFyYWN0ZXJzLiBUaGlzIGNvZGUgY2FuIGJlIGNoYW5nZWQKKyAgICAvLyB0byB1c2Ug c3RhcnRXaXRoIG9uY2UgdGhhdCBpcyBmaXhlZC4KKyAgICBTdHJpbmcgcHJlZml4V2l0aENhc2VG b2xkZWQocHJlZml4LmZvbGRDYXNlKCkpOwogICAgIGludCBpdGVtQ291bnQgPSBudW1JdGVtcygp OwogICAgIGludCBpbmRleCA9IChtYXgoMCwgbV9zZWxlY3RlZEluZGV4KSArIHNlYXJjaFN0YXJ0 T2Zmc2V0KSAlIGl0ZW1Db3VudDsKICAgICBmb3IgKGludCBpID0gMDsgaSA8IGl0ZW1Db3VudDsg aSsrLCBpbmRleCA9IChpbmRleCArIDEpICUgaXRlbUNvdW50KSB7CiAgICAgICAgIGlmICghaXNT ZWxlY3RhYmxlSXRlbShpbmRleCkpCiAgICAgICAgICAgICBjb250aW51ZTsKIAotICAgICAgICBp ZiAoc3RyaXBMZWFkaW5nV2hpdGVTcGFjZShtX2l0ZW1zW2luZGV4XS0+bGFiZWwpLnN0YXJ0c1dp dGgocHJlZml4LCBmYWxzZSkpIHsKKyAgICAgICAgaWYgKHN0cmlwTGVhZGluZ1doaXRlU3BhY2Uo bV9pdGVtc1tpbmRleF0tPmxhYmVsKS5mb2xkQ2FzZSgpLnN0YXJ0c1dpdGgocHJlZml4V2l0aENh c2VGb2xkZWQpKSB7CiAgICAgICAgICAgICBzZWxlY3RJbmRleChpbmRleCk7CiAgICAgICAgICAg ICByZXR1cm47CiAgICAgICAgIH0K