32004 2009-11-30 19:17:26 -0800 Reloading WebInspector from context menu is closing it instead of reloading. 2009-12-01 09:24:22 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned commit-queue pfeldman timothy webkit.review.bot oldest_to_newest 167491 0 yael 2009-11-30 19:17:26 -0800 Opening WebInspector and reloading it from the context menu is closing it, but not reopening it. The reason is that the m_page of the InspectorController is being cleared but a new one is not being created. A patch will be coming soon. 167581 1 44071 yael 2009-12-01 06:41:30 -0800 Created attachment 44071 Patch Do not delete the page associated with the WebInspector during a reload. 167582 2 yael 2009-12-01 06:44:30 -0800 This patch does not fix the problem for Qt port, only for Mac port. 167583 3 webkit.review.bot 2009-12-01 06:45:18 -0800 style-queue ran check-webkit-style on attachment 44071 without any errors. 167593 4 44071 eric 2009-12-01 07:17:08 -0800 Comment on attachment 44071 Patch Seems we should have a manual test for this. Or some sort of test. 167652 5 44071 commit-queue 2009-12-01 09:24:18 -0800 Comment on attachment 44071 Patch Clearing flags on attachment: 44071 Committed r51544: <http://trac.webkit.org/changeset/51544> 167653 6 commit-queue 2009-12-01 09:24:22 -0800 All reviewed patches have been landed. Closing bug. 44071 2009-12-01 06:41:30 -0800 2009-12-01 09:24:18 -0800 Patch 32004.patch text/plain 1391 yael SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTUyNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMzAgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlbG9hZGluZyBXZWJJbnNwZWN0b3IgZnJvbSBjb250ZXh0IG1lbnUgaXMgY2xvc2luZyBpdCBp bnN0ZWFkIG9mIHJlbG9hZGluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTMyMDA0CisKKyAgICAgICAgV2hlbiByZWxvYWRpbmcgV2ViSW5zcGVjdG9y LCBkb24ndCBkZWxldGUgaXRzIG1fcGFnZS4KKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0 b3JDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXI6 OmNsb3NlKToKKwogMjAwOS0xMS0zMCAgRnVtaXRvc2hpIFVrYWkgIDx1a2FpQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBVbnJldmlld2VkIENocm9taXVtIGJ1aWxkIGZpeCBpbnRyb2R1Y2VkIGJ5 IHI1MTIxMgpJbmRleDogV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAJ KHJldmlzaW9uIDUxNTIzKQorKysgV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxl ci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYyMCw5ICs2MjAsMTIgQEAKICAgICByZWxlYXNlRE9N QWdlbnQoKTsKICAgICBtX3RpbWVsaW5lQWdlbnQgPSAwOwogICAgIG1fc2NyaXB0U3RhdGUgPSAw OwotICAgIGlmIChtX3BhZ2UpCi0gICAgICAgIG1fcGFnZS0+c2V0UGFyZW50SW5zcGVjdG9yQ29u dHJvbGxlcigwKTsKLSAgICBtX3BhZ2UgPSAwOworICAgIGlmIChtX3BhZ2UpIHsKKyAgICAgICAg aWYgKCFtX3BhZ2UtPm1haW5GcmFtZSgpIHx8ICFtX3BhZ2UtPm1haW5GcmFtZSgpLT5sb2FkZXIo KSB8fCAhbV9wYWdlLT5tYWluRnJhbWUoKS0+bG9hZGVyKCktPmlzTG9hZGluZygpKSB7CisgICAg ICAgICAgICBtX3BhZ2UtPnNldFBhcmVudEluc3BlY3RvckNvbnRyb2xsZXIoMCk7CisgICAgICAg ICAgICBtX3BhZ2UgPSAwOworICAgICAgICB9CisgICAgfQogfQogCiB2b2lkIEluc3BlY3RvckNv bnRyb2xsZXI6OnNob3dXaW5kb3coKQo=