31997 2009-11-30 13:30:36 -0800 LayoutTests/transitions/change-values-during-transition.html is flaky 2009-12-02 13:36:43 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jparent jparent abarth cmarrin eric oldest_to_newest 167402 0 jparent 2009-11-30 13:30:36 -0800 This test fails ~10% of the time for the Chromium ports. See http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=LayoutTests%2Ftransitions%2Fchange-values-during-transition.html&showExpectations=true for flakiness graphs. Running locally for Windows, I see this failing as much as 25% of the time in DRT. The failures look legit, I believe the test is wrong. On a setTimeout of 600ms, it checks to see that the animation is at x position 50 (+/- 10). For a 1 sec duration animation that is moving 100px, it should be at position 50 at 500ms, not 600ms. I'll fix this and do some other assorted cleanups to the test. Because of the heavy usage of setTimeouts, I expect it will likely stay flaky, but hopefully much less so. 167428 1 44042 jparent 2009-11-30 14:37:37 -0800 Created attachment 44042 Change check for 50% done to 500ms, not 600ms. Other assorted cleanups. 167429 2 abarth 2009-11-30 14:38:52 -0800 style-queue ran check-webkit-style on attachment 44042 without any errors. 167664 3 44042 darin 2009-12-01 10:23:10 -0800 Comment on attachment 44042 Change check for 50% done to 500ms, not 600ms. Other assorted cleanups. I wish there was a way to isolate timing-dependent tests separately from the vast majority of tests that can run at any speed. I'd prefer to not have tests that pass or fail based on the speed or load of the computer, but if we do knowingly have them it would be *so* much better if they were identified somehow. My comments have little to do with this patch, but rather with the original test. I think it's unfortunate that our function to tell us if two values are close enough is called "isEqual" -- I would call it "isCloseEnough". > + function getXPosition() { > + var t = window.getComputedStyle(document.getElementById('box')).webkitTransform; > + t = t.split("("); > + t = t[1].split(","); > + return t[4]; > + } The brace style is to put the function opening brace on a separate line. > + document.getElementById('result').innerHTML = result; Should use innerText or textContent, since this is not HTML. r=me 168145 4 jparent 2009-12-02 13:36:43 -0800 All comments addressed and landed in http://trac.webkit.org/changeset/51613. I agree on the idea of isolating timing-dependent tests. I have a few ideas, will send mail to webkit-dev about it. 44042 2009-11-30 14:37:37 -0800 2009-12-01 10:23:10 -0800 Change check for 50% done to 500ms, not 600ms. Other assorted cleanups. changeValues.txt text/plain 3914 jparent SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUxNTA3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDktMTEtMzAgIEp1bGllIFBhcmVudCAgPGpw YXJlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE1ha2UgY2hhbmdlLXZhbHVlcy1kdXJpbmctdHJhbnNpdGlvbiBsZXNzIGZs YWt5LiAgVHJhbnNpdGlvbiBpcyAxIHNlYyBkdXJhdGlvbiwKKyAgICAgICAgdHJhbnNsYXRpbmcg MTAwcHgsIHN0YXJ0aW5nIGF0IDAsIHNvIGl0IHNob3VsZCBiZSBhdCA1MHB4IGF0IDUwMG1zLCBu b3QgNjAwbXMuCisgICAgICAgICAgICAgICAgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMTk5NworCisgICAgICAgICogdHJhbnNpdGlvbnMvY2hhbmdl LXZhbHVlcy1kdXJpbmctdHJhbnNpdGlvbi5odG1sOgorICAgICAgICBpc0VxdWFsOiBSZW1vdmUg dW5uZWNlc3NhcnkgY29kZSAtIHRvbGVyYW5jZSBhbHdheXMgcGFzc2VkIGluIGFuZCBhbHdheXMg ZGVmYXVsdCB2YWx1ZS4KKyAgICAgICAgZ2V0WFBvc2l0aW9uOiBFeHRyYWN0IGludG8gYSBmdW5j dGlvbiwgc2luY2UgaXQgaXMgZHVwbGljYXRlZCB0d2ljZS4KKyAgICAgICAgY2hlY2syOiBTdGls bCBydW4gc2Vjb25kIGNoZWNrIGlmIHRoZSBmaXJzdCBmYWlscywganVzdCBnaXZlIG1vcmUgZGVi dWdnaW5nIG91dHB1dC4KKyAgICAgICAgc3RhcnQ6IFJlbW92ZSBmaW5hbCBzZXRUaW1lb3V0IC0g bm90aGluZyBjaGFuZ2VzIGJldHdlZW4gdGhlIGVuZCBvZiBjaGVjazIgYW5kIGhlcmUsCisgICAg ICAgICAgICBzbyB0aGlzIGlzIGp1c3QgbWFraW5nIHRoZSB0ZXN0IHRha2UgMTAwbXMgbG9uZ2Vy LgorCiAyMDA5LTExLTMwICBKb3NlcGggUGVjb3Jhcm8gIDxqb2VwZWNrQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KSW5kZXg6IExheW91dFRlc3RzL3Ry YW5zaXRpb25zL2NoYW5nZS12YWx1ZXMtZHVyaW5nLXRyYW5zaXRpb24uaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy90cmFuc2l0aW9ucy9jaGFuZ2UtdmFsdWVzLWR1cmluZy10cmFuc2l0 aW9uLmh0bWwJKHJldmlzaW9uIDUxNTAxKQorKysgTGF5b3V0VGVzdHMvdHJhbnNpdGlvbnMvY2hh bmdlLXZhbHVlcy1kdXJpbmctdHJhbnNpdGlvbi5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0yMSwx NSArMjEsMTMgQEAKICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsK ICAgICB9CiAgICAgCi0gICAgcmVzdWx0ID0gIlBBU1MiOworICAgIHZhciByZXN1bHQgPSAiUEFT UyI7CiAgICAgY29uc3QgZGVmYXVsdFRvbGVyYW5jZSA9IDEwOwogICAgIAotICAgIGZ1bmN0aW9u IGlzRXF1YWwoYWN0dWFsLCBkZXNpcmVkLCB0b2xlcmFuY2UpCisgICAgZnVuY3Rpb24gaXNFcXVh bChhY3R1YWwsIGRlc2lyZWQpCiAgICAgewotICAgICAgICBpZiAodG9sZXJhbmNlID09IHVuZGVm aW5lZCB8fCB0b2xlcmFuY2UgPT0gMCkKLSAgICAgICAgICAgIHRvbGVyYW5jZSA9IGRlZmF1bHRU b2xlcmFuY2U7CiAgICAgICAgIHZhciBkaWZmID0gTWF0aC5hYnMoYWN0dWFsIC0gZGVzaXJlZCk7 Ci0gICAgICAgIHJldHVybiBkaWZmIDwgdG9sZXJhbmNlOworICAgICAgICByZXR1cm4gZGlmZiA8 IGRlZmF1bHRUb2xlcmFuY2U7CiAgICAgfQogICAgIAogICAgIGZ1bmN0aW9uIGNoYW5nZVZhbHVl cygpCkBAIC0zOCwyNSArMzYsMjkgQEAKICAgICAgICAgYm94LnN0eWxlLndlYmtpdFRyYW5zaXRp b25EdXJhdGlvbiA9ICIwLjFzIjsKICAgICB9CiAgICAgCisgICAgZnVuY3Rpb24gZ2V0WFBvc2l0 aW9uKCkgeworICAgICAgICB2YXIgdCA9IHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdib3gnKSkud2Via2l0VHJhbnNmb3JtOworICAgICAgICB0ID0gdC5z cGxpdCgiKCIpOworICAgICAgICB0ID0gdFsxXS5zcGxpdCgiLCIpOworICAgICAgICByZXR1cm4g dFs0XTsKKyAgICB9CisgICAgCiAgICAgZnVuY3Rpb24gY2hlY2sxKCkKICAgICB7Ci0gICAgICAg IHZhciB0ID0gd2luZG93LmdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J2JveCcpKS53ZWJraXRUcmFuc2Zvcm07Ci0gICAgICAgIHZhciB0ID0gdC5zcGxpdCgiKCIpOwot ICAgICAgICB2YXIgdCA9IHRbMV0uc3BsaXQoIiwiKTsKLSAgICAgICAgaWYgKCFpc0VxdWFsKHRb NF0sIDUwLCBkZWZhdWx0VG9sZXJhbmNlKSkKLSAgICAgICAgICAgIHJlc3VsdCA9ICJGQUlMKHdh czoiK3RbNF0rIiwgcy9iOjUwKSI7CisgICAgICAgIHZhciB4UG9zID0gZ2V0WFBvc2l0aW9uKCk7 CisgICAgICAgIGlmICghaXNFcXVhbCh4UG9zLCA1MCkpCisgICAgICAgICAgICByZXN1bHQgPSAi RkFJTCh3YXM6Iit4UG9zKyIsIHMvYjo1MCkiOwogICAgIH0KIAogICAgIGZ1bmN0aW9uIGNoZWNr MigpCiAgICAgewotICAgICAgICBpZiAocmVzdWx0ICE9ICJQQVNTIikKLSAgICAgICAgICAgIHJl dHVybjsKKyAgICAgICAgdmFyIHhQb3MgPSBnZXRYUG9zaXRpb24oKTsKKyAgICAgICAgaWYgKCFp c0VxdWFsKHhQb3MsIDApKQorICAgICAgICAgICAgcmVzdWx0ICs9ICJGQUlMKHdhczoiK3hQb3Mr Iiwgcy9iOjApIjsKICAgICAgICAgICAgIAotICAgICAgICB2YXIgdCA9IHdpbmRvdy5nZXRDb21w dXRlZFN0eWxlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdib3gnKSkud2Via2l0VHJhbnNmb3Jt OwotICAgICAgICB2YXIgdCA9IHQuc3BsaXQoIigiKTsKLSAgICAgICAgdmFyIHQgPSB0WzFdLnNw bGl0KCIsIik7Ci0gICAgICAgIGlmICghaXNFcXVhbCh0WzRdLCAwLCBkZWZhdWx0VG9sZXJhbmNl KSkKLSAgICAgICAgICAgIHJlc3VsdCA9ICJGQUlMKHdhczoiK3RbNF0rIiwgcy9iOjApIjsKKyAg ICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Jlc3VsdCcpLmlubmVySFRNTCA9IHJlc3Vs dDsKKyAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAg IGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKICAgICB9CiAgICAgCiAgICAgZnVu Y3Rpb24gZ29CYWNrKCkKQEAgLTY5LDE1ICs3MSw5IEBACiAgICAgewogICAgICAgICB2YXIgYm94 ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2JveCcpOwogICAgICAgICBzZXRUaW1lb3V0KCJj aGFuZ2VWYWx1ZXMoKSIsIDEwMCk7Ci0gICAgICAgIHNldFRpbWVvdXQoImNoZWNrMSgpIiwgNjAw KTsKKyAgICAgICAgc2V0VGltZW91dCgiY2hlY2sxKCkiLCA1MDApOwogICAgICAgICBzZXRUaW1l b3V0KCJjaGVjazIoKSIsIDEzMDApOwogICAgICAgICBib3guc3R5bGUud2Via2l0VHJhbnNmb3Jt ID0gJ3RyYW5zbGF0ZVgoMTAwcHgpJzsKLSAgICAgICAgCi0gICAgICAgIHdpbmRvdy5zZXRUaW1l b3V0KGZ1bmN0aW9uKCkgewotICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Jl c3VsdCcpLmlubmVySFRNTCA9IHJlc3VsdDsKLSAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0 VGVzdENvbnRyb2xsZXIpCi0gICAgICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90 aWZ5RG9uZSgpOwotICAgICAgICB9LCAxNDAwKTsKICAgICB9CiAgICAgCiAgICAgd2luZG93LmFk ZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBzdGFydCwgZmFsc2UpOwo=